Would like input on a patch from other devs.

[Joshua A. Andler-2]

Hey All,

So, Adib made a patch to address one of the issues that has annoyed many
users... saving over a non-writable bitmap type (such as jpg) that they
had opened. The patch simply checks to see if we can write the filetype,
if not, throws an error message and then proceeds to open a Save As
dialog.

The problem is that the error message is unclear as it is a standard
error message that we have and makes no sense in the context unless you
know how our files are handled internally. The message is "No Inkscape
extension found to save document (/path/to/file.jpg). This may have been
caused by an unknown filename extension."

So, the question is, would people be okay with us shipping with the
user-unfriendly error message in favor of saving people's data? Yes we
could create a custom message for it, but I really don't want to break
the string freeze again. After 0.47 is out, we could then make a 0.47.1
branch and have the proper error message that explains what went wrong
(obviously adding to trunk as well).

Please share your thoughts.

Cheers,
Josh


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Inkscape-devel mailing list
Inkscape-devel@...
https://lists.sourceforge.net/lists/listinfo/inkscape-devel

[Alvin Penner]

sounds good to me, better than the alternative!

Alvin

[Nicolas Dufour-5]

> De : Joshua A. Andler <scislac@...>
> The patch simply checks to see if we can write the filetype,
> if not, throws an error message and then proceeds to open a Save As
> dialog.

Do we really need this error message? Opening the Save As dialog sounds good enough to me.

> So, the question is, would people be okay with us shipping with the
> user-unfriendly error message in favor of saving people's data? Yes we
> could create a custom message for it, but I really don't want to break
> the string freeze again. After 0.47 is out, we could then make a 0.47.1
> branch and have the proper error message that explains what went wrong
> (obviously adding to trunk as well).

I'd remove the error message in 0..47, and add a proper one (if it is really necessary) in 0.47.1.

Regards,
--
Nicolas



     


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Inkscape-devel mailing list
Inkscape-devel@...
https://lists.sourceforge.net/lists/listinfo/inkscape-devel

[Joshua A. Andler-2]

On Mon, 2009-10-19 at 06:18 +0000, Nicolas Dufour wrote:
>
> > De : Joshua A. Andler <scislac@...>
> > The patch simply checks to see if we can write the filetype,
> > if not, throws an error message and then proceeds to open a Save As
> > dialog.
>
> Do we really need this error message? Opening the Save As dialog sounds good enough to me.

We do need the error... it is a form of feedback, even if
non-decipherable by a non-techie user. Just bringing up a Save As dialog
with no explanation would be more confusing... and what if they manually
type in a jpg extension w/ no feedback?

Just throwing it out there.

Cheers,
Josh


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Inkscape-devel mailing list
Inkscape-devel@...
https://lists.sourceforge.net/lists/listinfo/inkscape-devel