XBL constructor order

View: New views
7 Messages — Rating Filter:   Alert me  

XBL constructor order

by Boris Zbarsky :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Bug 526178 [1] was filed yesterday about the fact that between 3.5 and
3.6b1 XBL constructor behavior changed such that the constructor of an
ancestor is fired after the constructors of the descendants, not before.
  The claim is that this breaks various existing code.  The change was
inadvertent and was made back in March.  The new behavior is in fact
inconsistent as to whether ancestor or descendant gets the constructor
firing first in general (e.g. when display:inline is involved), but for
XUL the descendant's constructor is fired first.

It's pretty simple to restore the 3.5 behavior, but that is of course a
somewhat breaking change from b1...

Where do we go from here, for both m-c and 3.6?

-Boris

P.S.  Please follow up to mozilla.dev.tech.xbl

P.P.S. Someone please write some exhaustive XBL tests?  :(

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=526178
_______________________________________________
dev-planning mailing list
dev-planning@...
https://lists.mozilla.org/listinfo/dev-planning

Re: XBL constructor order

by Boris Zbarsky :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On 11/3/09 12:46 PM, Boris Zbarsky wrote:
> Where do we go from here, for both m-c and 3.6?

Current plan is to restore the 3.5 behavior (including for display:none
nodes, which is a bit of a hassle....)

-Boris
_______________________________________________
dev-planning mailing list
dev-planning@...
https://lists.mozilla.org/listinfo/dev-planning

Re: XBL constructor order

by Mike Beltzner :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On 2009-11-03, at 3:09 PM, Boris Zbarsky wrote:

> On 11/3/09 12:46 PM, Boris Zbarsky wrote:
>> Where do we go from here, for both m-c and 3.6?
>
> Current plan is to restore the 3.5 behavior (including for  
> display:none nodes, which is a bit of a hassle....)

I think that's the right plan; I also think we should get it done  
before the next beta refresh.

cheers,
mike
_______________________________________________
dev-planning mailing list
dev-planning@...
https://lists.mozilla.org/listinfo/dev-planning

Parent Message unknown Re: XBL constructor order

by Boris Zbarsky :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On 11/3/09 6:46 PM, Mike Beltzner wrote:
> I think that's the right plan; I also think we should get it done before
> the next beta refresh.

I was thinking in "patch by tomorrow" terms; then review and such.  Next
beta refresh is the 18th, right?

-Boris

_______________________________________________
dev-planning mailing list
dev-planning@...
https://lists.mozilla.org/listinfo/dev-planning

Re: XBL constructor order

by Mike Beltzner :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On 2009-11-03, at 4:58 PM, Boris Zbarsky wrote:

> On 11/3/09 6:46 PM, Mike Beltzner wrote:
>> I think that's the right plan; I also think we should get it done  
>> before
>> the next beta refresh.
>
> I was thinking in "patch by tomorrow" terms; then review and such.  
> Next beta refresh is the 18th, right?

Tomorrow is great. Next beta refresh may be this Friday.

cheers,
mike
_______________________________________________
dev-planning mailing list
dev-planning@...
https://lists.mozilla.org/listinfo/dev-planning

Parent Message unknown Re: XBL constructor order

by Peter Weilbacher :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On 04/11/09 03:14, Mike Beltzner wrote:

> On 2009-11-03, at 4:58 PM, Boris Zbarsky wrote:
>
>> On 11/3/09 6:46 PM, Mike Beltzner wrote:
>>> I think that's the right plan; I also think we should get it done before
>>> the next beta refresh.
>>
>> I was thinking in "patch by tomorrow" terms; then review and such.
>> Next beta refresh is the 18th, right?
>
> Tomorrow is great. Next beta refresh may be this Friday.

So there will be another beta? https://wiki.mozilla.org/Platform/2009-11-03
didn't say anything about that...
    Peter.
_______________________________________________
dev-planning mailing list
dev-planning@...
https://lists.mozilla.org/listinfo/dev-planning

Re: XBL constructor order

by Peter Weilbacher :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On 04/11/09 09:26, Peter Weilbacher wrote:
> So there will be another beta? https://wiki.mozilla.org/Platform/2009-11-03
> didn't say anything about that...

Ah, wait. I think I just didn't understand
    will refresh frequently via the Firefox 3.6 beta update channel,
    each update will be versioned "3.6b#" and presented as a "revision"
correctly.
    P.
_______________________________________________
dev-planning mailing list
dev-planning@...
https://lists.mozilla.org/listinfo/dev-planning