XSL refactoring

[abompard]

Dr John Gow,

Following patch 2827143 [1], I've fixed a "spec conformance bug" in the *-
to-airsync.xsl files, and thought the XSL files are becoming a little
"hairy".

Mark told me you're in charge of sync-engine, so I'm asking you directly :
if you like, I can refactor the stylesheets with templates and variables. I
think that would make sense since many tags are near-identical.

We could avoid regression bugs with the unit tests, although they don't
cover every possible transformation at the moment.

Do you have something planned in this general direction ? Are you interested
in the refactoring ?

Thanks

Aurélien

[1]
https://sourceforge.net/tracker/?func=detail&atid=399603&aid=2827143&group_id=30550
--
http://aurelien.bompard.org  ~~~~  Jabber : abompard@...
Recursion: (n.)  See "Recursion".

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
SynCE-Devel mailing list
SynCE-Devel@...
https://lists.sourceforge.net/lists/listinfo/synce-devel

[Mark Ellis]

On Thu, 2009-09-03 at 09:07 +0200, Aurelien Bompard wrote:

> Dr John Gow,
>
> Following patch 2827143 [1], I've fixed a "spec conformance bug" in the *-
> to-airsync.xsl files, and thought the XSL files are becoming a little
> "hairy".
>
> Mark told me you're in charge of sync-engine, so I'm asking you directly :
> if you like, I can refactor the stylesheets with templates and variables. I
> think that would make sense since many tags are near-identical.
>
> We could avoid regression bugs with the unit tests, although they don't
> cover every possible transformation at the moment.
>
> Do you have something planned in this general direction ? Are you interested
> in the refactoring ?
>
> Thanks
>
> Aurélien
>
> [1]
> https://sourceforge.net/tracker/?func=detail&atid=399603&aid=2827143&group_id=30550

Aurelien, in the absence of any objections, I would say please go ahead,
your help will be most welcome :)

Mark



------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
SynCE-Devel mailing list
SynCE-Devel@...
https://lists.sourceforge.net/lists/listinfo/synce-devel

[David Eriksson]

On Wed, 2009-09-16 at 19:36 +0100, Mark Ellis wrote:

> On Thu, 2009-09-03 at 09:07 +0200, Aurelien Bompard wrote:
> > Dr John Gow,
> >
> > Following patch 2827143 [1], I've fixed a "spec conformance bug" in the *-
> > to-airsync.xsl files, and thought the XSL files are becoming a little
> > "hairy".
> >
> > Mark told me you're in charge of sync-engine, so I'm asking you directly :
> > if you like, I can refactor the stylesheets with templates and variables. I
> > think that would make sense since many tags are near-identical.
> >
> > We could avoid regression bugs with the unit tests, although they don't
> > cover every possible transformation at the moment.
> >
> > Do you have something planned in this general direction ? Are you interested
> > in the refactoring ?
> >
> > Thanks
> >
> > Aurélien
> >
> > [1]
> > https://sourceforge.net/tracker/?func=detail&atid=399603&aid=2827143&group_id=30550
>
> Aurelien, in the absence of any objections, I would say please go ahead,
> your help will be most welcome :)

+1


Cheers,

David Eriksson, http://www.divideandconquer.se/



------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
SynCE-Devel mailing list
SynCE-Devel@...
https://lists.sourceforge.net/lists/listinfo/synce-devel

[abompard]

> > Aurelien, in the absence of any objections, I would say please go
> > ahead, your help will be most welcome :)
>
> +1

Actually, John replied to me privately, he's fine with the idea. I've sent
him the first part of my work, which apparently seem to look good :)

I'll remember to keep the mailing-list in CC now.

Thanks

Aurélien
--
http://aurelien.bompard.org  ~~~~  Jabber : abompard@...
"When the winds of change are blowing, some people are building
shelters and others are building windmills."

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
SynCE-Devel mailing list
SynCE-Devel@...
https://lists.sourceforge.net/lists/listinfo/synce-devel

[abompard]

> I like!

Great !

> Do you have commit rights on SVN or do you want me to commit it?

No, I don't have the commit rights. Until now I've sent 4 patches to
SynCE[1] and Mark committed them himself. If you could commit this one
that'd be great.
[1]
http://sourceforge.net/tracker/?limit=10&func=&group_id=30550&atid=399603&assignee=&status=&category=&artgroup=&keyword=&submitter=&artifact_id=&assignee=&status=&category=&artgroup=&submitter=abompard&keyword=&artifact_id=&submit=Filter

> Don't forget to update the changelog :)

Oh, that's right. Last times Mark updated it himself, but that's not a
reason to keep being lazy :)

> If you are happy to extend this to the event and tasks, that would be
> great.

OK, I'll do it. Thanks for your support.
I'm adding the list as CC, if you don't mind, to keep the rest of the team
posted.


Aurélien
--
http://aurelien.bompard.org  ~~~~  Jabber : abompard@...
"Anyone who believes exponential growth can go on forever in a finite world
is either a madman or an economist." -- Kenneth Boulding, economist


------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
SynCE-Devel mailing list
SynCE-Devel@...
https://lists.sourceforge.net/lists/listinfo/synce-devel

[Mark Ellis]

On Thu, 2009-09-17 at 07:40 +0200, Aurelien Bompard wrote:
> > I like!
>
> Great !
>
> > Do you have commit rights on SVN or do you want me to commit it?
>

I've just given you commit access, have fun ...

> No, I don't have the commit rights. Until now I've sent 4 patches to
> SynCE[1] and Mark committed them himself. If you could commit this one
> that'd be great.
> [1]
> http://sourceforge.net/tracker/?limit=10&func=&group_id=30550&atid=399603&assignee=&status=&category=&artgroup=&keyword=&submitter=&artifact_id=&assignee=&status=&category=&artgroup=&submitter=abompard&keyword=&artifact_id=&submit=Filter
>
> > Don't forget to update the changelog :)
>
> Oh, that's right. Last times Mark updated it himself, but that's not a
> reason to keep being lazy :)
>
> > If you are happy to extend this to the event and tasks, that would be
> > great.
>
> OK, I'll do it. Thanks for your support.
> I'm adding the list as CC, if you don't mind, to keep the rest of the team
> posted.
>
>
> Aurélien

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
SynCE-Devel mailing list
SynCE-Devel@...
https://lists.sourceforge.net/lists/listinfo/synce-devel

[abompard]

> I've just given you commit access, have fun ...

Wow, thank you Mark !
Any instructions available to keep me from making beginner's mistakes ? I
know SVN, it's just if you have SynCE-specific policies, things like that.

Aurélien
--
http://aurelien.bompard.org  ~~~~  Jabber : abompard@...
"Millions long for immortality who do not know what to do with themselves
on a rainy Sunday afternoon." -- Susan Ertz


------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
SynCE-Devel mailing list
SynCE-Devel@...
https://lists.sourceforge.net/lists/listinfo/synce-devel

[Mark Ellis]

On Thu, 2009-09-17 at 08:17 +0200, Aurelien Bompard wrote:
> > I've just given you commit access, have fun ...
>
> Wow, thank you Mark !
> Any instructions available to keep me from making beginner's mistakes ? I
> know SVN, it's just if you have SynCE-specific policies, things like that.
>
> Aurélien

Nothing specific, just the normal kind of thing.



------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
SynCE-Devel mailing list
SynCE-Devel@...
https://lists.sourceforge.net/lists/listinfo/synce-devel