Yahoo issues

[John Bailey-2]

Well, as most of us are aware, there have been a bunch of reports of a few
issues with the new Yahoo code:

  * Doesn't compile with ancient glib (2.4.x or older)
  * Buddies never go offline
  * Crash for some users under certain circumstances (easiest to reproduce with
a pager server of cn.scs.msg.yahoo.com although I can't reproduce it at all)
  * Buddy icons not fetching properly
  * Possibly others I'm forgetting at the moment

We have already fixed the first two issues.  The third can probably be fixed
relatively easily.  I think the fourth might be related to the URL fetching
stuff I did so that the account's proxy settings take effect for URL fetch requests.

If we can get all of these problems fixed, should we release a 2.5.8 relatively
soonish just to get the fixes out the door?  Or should we instead just rely on
packagers (including Richard and Stu) to update the 2.5.7 builds with the
relevant patches?  Personally, as much as I hate to throw another release out
before 2.6.0, I'm leaning toward releasing 2.5.8 since it will additionally
benefit Adium.

Thoughts?

John



_______________________________________________
Devel mailing list
Devel@...
http://pidgin.im/cgi-bin/mailman/listinfo/devel

[Mark Doliner]

On Wed, Jun 24, 2009 at 8:12 PM, John Bailey<rekkanoryo@...> wrote:

> Well, as most of us are aware, there have been a bunch of reports of a few
> issues with the new Yahoo code:
>
>  * Doesn't compile with ancient glib (2.4.x or older)
>  * Buddies never go offline
>  * Crash for some users under certain circumstances (easiest to reproduce with
> a pager server of cn.scs.msg.yahoo.com although I can't reproduce it at all)
>  * Buddy icons not fetching properly
>  * Possibly others I'm forgetting at the moment
>
> We have already fixed the first two issues.  The third can probably be fixed
> relatively easily.  I think the fourth might be related to the URL fetching
> stuff I did so that the account's proxy settings take effect for URL fetch requests.
>
> If we can get all of these problems fixed, should we release a 2.5.8 relatively
> soonish just to get the fixes out the door?  Or should we instead just rely on
> packagers (including Richard and Stu) to update the 2.5.7 builds with the
> relevant patches?  Personally, as much as I hate to throw another release out
> before 2.6.0, I'm leaning toward releasing 2.5.8 since it will additionally
> benefit Adium.
>
> Thoughts?

Thanks for staying on top of this, you da man!  My vote would be for
2.5.8, so that we don't put more pressure on 2.6.0.  But I think both
options are fine.

-Mark

_______________________________________________
Devel mailing list
Devel@...
http://pidgin.im/cgi-bin/mailman/listinfo/devel

[Sulabh Mahajan]

 * Crash for some users under certain circumstances (easiest to reproduce with
a pager server of cn.scs.msg.yahoo.com although I can't reproduce it at all)

I have commited the code, where we exit yahoo_process_picture(), in case who is NULL. This should eventually prevent the call to g_utf8_normalize(), which causes the crash.

Note: I was unable to reproduce this crash as well. Last checked cn.scs.msg.yahoo.com is now working like other yahoo servers.

I am closing the ticket #9426 with this.

* Another issue: File transfers don't work. They just don't start. Ticket #9478
(I am looking into this right now)

Sulabh

_______________________________________________
Devel mailing list
Devel@...
http://pidgin.im/cgi-bin/mailman/listinfo/devel

[John Bailey-2]

John Bailey wrote:
>   * Buddy icons not fetching properly

Of all the items I listed, this is the only item currently outstanding.  I've
tried to figure this out already and it's not being particularly cooperative.
If someone feels like figuring this out, I'm certainly not going to complain.  I
can reproduce this in both the soon-to-be 2.5.8 and 2.6.0devel.

John



_______________________________________________
Devel mailing list
Devel@...
http://pidgin.im/cgi-bin/mailman/listinfo/devel

[Sadrul Habib Chowdhury]

* John Bailey had this to say on [26 Jun 2009, 20:06:28 -0400]:
> John Bailey wrote:
> >   * Buddy icons not fetching properly
>
> Of all the items I listed, this is the only item currently outstanding.  I've
> tried to figure this out already and it's not being particularly cooperative.
> If someone feels like figuring this out, I'm certainly not going to complain.  I
> can reproduce this in both the soon-to-be 2.5.8 and 2.6.0devel.
>

f7d214529b031e5f31f560c07fc47d445cf87c92 seems to fix the problem for me.
Can someone confirm/refute?

Sadrul

_______________________________________________
Devel mailing list
Devel@...
http://pidgin.im/cgi-bin/mailman/listinfo/devel

[John Bailey-2]

Sadrul Habib Chowdhury wrote:
> * John Bailey had this to say on [26 Jun 2009, 20:06:28 -0400]:
>> John Bailey wrote:
>>>   * Buddy icons not fetching properly
<snip>
> f7d214529b031e5f31f560c07fc47d445cf87c92 seems to fix the problem for me.
> Can someone confirm/refute?

This revision and 6aea73a291e92c493bf5151b0671a748205c545e seem to fix all the
new Yahoo buddy icon problems.

Unless anyone else has something that needs to go into 2.5.8, I'm declaring it
releasable.  Someone will need to build tarballs.  (Ideally someone who will not
reproduce the nls issues that apparently cropped up in the 2.5.7 tarball?)

John



_______________________________________________
Devel mailing list
Devel@...
http://pidgin.im/cgi-bin/mailman/listinfo/devel

[John Bailey-2]

John Bailey wrote:
> Unless anyone else has something that needs to go into 2.5.8, I'm declaring it
> releasable.  Someone will need to build tarballs.  (Ideally someone who will not
> reproduce the nls issues that apparently cropped up in the 2.5.7 tarball?)

Pidgin 2.5.8 is tagged.  We just need someone other than myself or Mark to
generate the tarballs, preferably any developer who is NOT using intltool
0.40.6.  Mark and I both appear to be using that version of intltool, and
tarballs we generate end up with empty i18n-related files.  This will cause
problems for users.

John



_______________________________________________
Devel mailing list
Devel@...
http://pidgin.im/cgi-bin/mailman/listinfo/devel