about DataPilot

[Kohei Yoshida-2]

On Tue, 2009-08-18 at 22:41 -0400, Kohei Yoshida wrote:

> Hello Xu Ming,
>
> On Tue, 2009-08-18 at 15:06 +0800, Xu Ming Wang wrote:
> > Find a critical issue:
> > The field items list in Hide/Show items or Display value options use
> > the source data's original strings.
> > But some items' string maybe become same if they are float values or
> > date values and use some special formats.
> > Then we can not identify them. I think need use the field item index
> > to identify the field items and need redefine the ODF format about
> > this.
> > There is the same problem in fields' name.
> >
> > Attach a sample file:
> > (See attached file: issue.ods)
>
> Can you send me the file directly?  The mailing list has stripped your
> attachment, so I don't see the file you attached.

I got the attached file.  Let me take a look at that, and see what we
should do.  I'll get back to you soon.

Kohei

--
Kohei Yoshida - OpenOffice.org Engineer - Novell, Inc.
<kyoshida@...>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Kohei Yoshida-2]

On Wed, 2009-08-19 at 11:04 -0400, Kohei Yoshida wrote:

> On Tue, 2009-08-18 at 22:41 -0400, Kohei Yoshida wrote:
> > Hello Xu Ming,
> >
> > On Tue, 2009-08-18 at 15:06 +0800, Xu Ming Wang wrote:
> > > Find a critical issue:
> > > The field items list in Hide/Show items or Display value options use
> > > the source data's original strings.
> > > But some items' string maybe become same if they are float values or
> > > date values and use some special formats.
> > > Then we can not identify them. I think need use the field item index
> > > to identify the field items and need redefine the ODF format about
> > > this.
> > > There is the same problem in fields' name.
> > >
> > > Attach a sample file:
> > > (See attached file: issue.ods)
> >
> > Can you send me the file directly?  The mailing list has stripped your
> > attachment, so I don't see the file you attached.
>
> I got the attached file.  Let me take a look at that, and see what we
> should do.  I'll get back to you soon.

Just filed a new issue for this:
http://qa.openoffice.org/issues/show_bug.cgi?id=104418

Kohei

--
Kohei Yoshida - OpenOffice.org Engineer - Novell, Inc.
<kyoshida@...>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Kohei Yoshida-2]

On Tue, 2009-08-18 at 15:06 +0800, Xu Ming Wang wrote:
> Find a critical issue:
> The field items list in Hide/Show items or Display value options use
> the source data's original strings.
> But some items' string maybe become same if they are float values or
> date values and use some special formats.
> Then we can not identify them. I think need use the field item index
> to identify the field items and need redefine the ODF format about
> this.
> There is the same problem in fields' name.

Ok.  So this problem is an existing problem, not related to the new
field popup window.  I somehow got that wrong impression...

And you're right; the problem is how this information is stored in the
file, so we need to fix the file format itself before we fix this in the
application code.

We can probably add another attribute to table:data-pilot-member
element, and call it, say, table:index (or something) to store the
position of the field member.  We would still need to keep the existing
"table:name" attribute for backward compatibility.

Let me think this through a bit.  Meanwhile, if you have any more ideas
on this, please share.

Kohei

--
Kohei Yoshida - OpenOffice.org Engineer - Novell, Inc.
<kyoshida@...>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Xu Ming Wang]

I think keep the member's name maybe better, we perhaps need them when refresh source data. This problem may impact Field reference-- it uses field item's name as base item now.


Sincerely,
Xu Ming Wang


Lotus Symphony
China Software Development Laboratory,Beijing
Phone: [phone]
E-mail : wangxum@...

Kohei Yoshida ---2009-08-22 05:54:30---On Tue, 2009-08-18 at 15:06 +0800, Xu Ming Wang wrote:

Kohei Yoshida <kyoshida@...>

2009-08-22 05:51

Please respond to
dev@...

To	dev@...
cc
Subject	Re: [sc-dev] about DataPilot

On Tue, 2009-08-18 at 15:06 +0800, Xu Ming Wang wrote:
> Find a critical issue:
> The field items list in Hide/Show items or Display value options use
> the source data's original strings.
> But some items' string maybe become same if they are float values or
> date values and use some special formats.
> Then we can not identify them. I think need use the field item index
> to identify the field items and need redefine the ODF format about
> this.
> There is the same problem in fields' name.

Ok.  So this problem is an existing problem, not related to the new
field popup window.  I somehow got that wrong impression...

And you're right; the problem is how this information is stored in the
file, so we need to fix the file format itself before we fix this in the
application code.

We can probably add another attribute to table:data-pilot-member
element, and call it, say, table:index (or something) to store the
position of the field member.  We would still need to keep the existing
"table:name" attribute for backward compatibility.

Let me think this through a bit.  Meanwhile, if you have any more ideas
on this, please share.

Kohei

--
Kohei Yoshida - OpenOffice.org Engineer - Novell, Inc.
<kyoshida@...>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Kohei Yoshida-2]

On Tue, 2009-08-25 at 11:23 +0800, Xu Ming Wang wrote:
> I think keep the member's name maybe better, we perhaps need them when
> refresh source data. This problem may impact Field reference-- it uses
> field item's name as base item now.

Yup.  I think, ultimately, we need to switch to using numerical indexes
for all field and field member references in ods file format instead of
using their textural names.  That would resolve issues with fields with
identical names as well as the issue you just raised with field names
with fractional numbers.

I think the next step is to come up with a new XML structure that
achieves this while maintaining a reasonable level of backward
compatibility.  Let's work on that before going any further with this.

Kohei

--
Kohei Yoshida - OpenOffice.org Engineer - Novell, Inc.
<kyoshida@...>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...