|

»

phpmyadmin-devel

about long lines

View: New views

4 Messages — Rating Filter: Alert me

	about long lines by Marc Delisle-2 :: Rate this Message: \| View Threaded \| Show Only this Message Chanaka, about your question on long lines, I agree with you that this could be put on two lines. Suggestion: if ((PMA_strlen($wktval) > $GLOBALS['cfg']['LimitChars']) && ($_SESSION['tmp_user_values']['display_text'] == self::DISPLAY_PARTIAL_TEXT) ) { -- Marc Delisle http://infomarc.info ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@... https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel signature.asc (916 bytes) Download Attachment
	Re: about long lines by Chanaka Dharmarathna :: Rate this Message: \| View Threaded \| Show Only this Message On Tue, Jun 12, 2012 at 6:18 PM, Marc Delisle <marc@...> wrote: Chanaka, about your question on long lines, I agree with you that this could be put on two lines. Suggestion: if ((PMA_strlen($wktval) > $GLOBALS['cfg']['LimitChars']) && ($_SESSION['tmp_user_values']['display_text'] == self::DISPLAY_PARTIAL_TEXT) ) { -- Marc Delisle http://infomarc.info ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@... https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel Hi Marc, Thanks for your suggestion. I check whether it works or not before also. But code sniffer gives following errors, \| ERROR \| Multi-line IF statement not indented correctly; expected 20 spaces but found 24 \| ERROR \| Each line in a multi-line IF statement must begin with a boolean operator Sorry if I'm doing any wrong. Can you please tell any guesses why I'm getting these errors ? Regards ! -- ____________________________________ Chanaka Indrajith Bsc.Computer Engineering Undergraduate Faculty of Engineering University of Peradeniya Sri Lanka ____________________________________ ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@... https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
	Re: about long lines by Marc Delisle-2 :: Rate this Message: \| View Threaded \| Show Only this Message Le 2012-06-12 13:29, Chanaka Dharmarathna a écrit : > On Tue, Jun 12, 2012 at 6:18 PM, Marc Delisle <marc@...> wrote: > >> Chanaka, >> >> about your question on long lines, I agree with you that this could be >> put on two lines. Suggestion: >> >> if ((PMA_strlen($wktval) > $GLOBALS['cfg']['LimitChars']) >> && ($_SESSION['tmp_user_values']['display_text'] == >> self::DISPLAY_PARTIAL_TEXT) >> ) { >> >> -- >> Marc Delisle >> http://infomarc.info >> >> > Hi Marc, > > Thanks for your suggestion. > I check whether it works or not before also. > > But code sniffer gives following errors, > \| ERROR \| Multi-line IF statement not indented correctly; expected 20 > spaces but found 24 The code sniffer does not like the additional indenting of "self", so align it under "&&". > \| ERROR \| Each line in a multi-line IF statement must begin with a > boolean operator Maybe move the "==" under the "&&". > > Sorry if I'm doing any wrong. Can you please tell any guesses why I'm > getting these errors ? > > Regards ! -- Marc Delisle http://infomarc.info ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@... https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel signature.asc (916 bytes) Download Attachment
	Re: about long lines by Chanaka Dharmarathna :: Rate this Message: \| View Threaded \| Show Only this Message On Wed, Jun 13, 2012 at 8:04 PM, Marc Delisle <marc@...> wrote: Le 2012-06-12 13:29, Chanaka Dharmarathna a écrit : > On Tue, Jun 12, 2012 at 6:18 PM, Marc Delisle <marc@...> wrote: > >> Chanaka, >> >> about your question on long lines, I agree with you that this could be >> put on two lines. Suggestion: >> >> if ((PMA_strlen($wktval) > $GLOBALS['cfg']['LimitChars']) >> && ($_SESSION['tmp_user_values']['display_text'] == >> self::DISPLAY_PARTIAL_TEXT) >> ) { >> >> -- >> Marc Delisle >> http://infomarc.info >> >> > Hi Marc, > > Thanks for your suggestion. > I check whether it works or not before also. > > But code sniffer gives following errors, > \| ERROR \| Multi-line IF statement not indented correctly; expected 20 > spaces but found 24 The code sniffer does not like the additional indenting of "self", so align it under "&&". > \| ERROR \| Each line in a multi-line IF statement must begin with a > boolean operator Maybe move the "==" under the "&&". > > Sorry if I'm doing any wrong. Can you please tell any guesses why I'm > getting these errors ? > > Regards ! -- Marc Delisle http://infomarc.info ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@... https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel Hi Marc, Yes your first suggestion works fine. But second one is not working for me. I thought that code sniffer doesn't support multi line comparisons. Since you again suggest me same way I may wrong. But I couldn't find any way to use comparisons in two lines without errors. Regards ! -- ____________________________________ Chanaka Indrajith Bsc.Computer Engineering Undergraduate Faculty of Engineering University of Peradeniya Sri Lanka ____________________________________ ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@... https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel