accurev provider

[Grant Gardner-3]

Hi all,

I've been working on extending the AccuRev provider implementation to be
fully compatible with the maven release plugin.
(ie update, status, checkin, tag, checkout, add)

I think I'm pretty close with the necessary commands implemented and the
tck tests passing against an AccuRev evaluation install.

Assuming someone here is interested I'll have a bunch of questions about
how I might go about contributing this code.

Cheers,
     Grant.

[Jason van Zyl-5]

If you got code then you need to accompany it with complete tests or  
we're likely not to look at it.

On 12-Jan-09, at 4:51 AM, ggardner wrote:

>
> Hi all,
>
> I've been working on extending the AccuRev provider implementation  
> to be
> fully compatible with the maven release plugin.
> (ie update, status, checkin, tag, checkout, add)
>
> I think I'm pretty close with the necessary commands implemented and  
> the
> tck tests passing against an AccuRev evaluation install.
>
> Assuming someone here is interested I'll have a bunch of questions  
> about
> how I might go about contributing this code.
>
> Cheers,
>     Grant.
>
>
>

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
jason at sonatype dot com
----------------------------------------------------------

What matters is not ideas, but the people who have them. Good people  
can fix bad ideas, but good ideas can't save bad people.

  -- Paul Graham

[Grant Gardner-3]

Thanks, I wanted an excuse to try out a coverage tool. 6 more lines in the
pom and Cobertura tells me 90% coverage.

Though one immediate question is whether it is acceptable for one provider
to require JDK 1.5. If not I'll have to remove JDK 1.5 dependancies
(generics, JMock, JUnit4) that were useful for putting it all together in a
TDD fashion.

Grant.

On Mon, 12 Jan 2009 12:21:15 -0800, Jason van Zyl <jvanzyl@...>
wrote:

> If you got code then you need to accompany it with complete tests or
> we're likely not to look at it.
>
> On 12-Jan-09, at 4:51 AM, ggardner wrote:
>
>>
>> Hi all,
>>
>> I've been working on extending the AccuRev provider implementation
>> to be
>> fully compatible with the maven release plugin.
>> (ie update, status, checkin, tag, checkout, add)
>>
>> I think I'm pretty close with the necessary commands implemented and
>> the
>> tck tests passing against an AccuRev evaluation install.
>>
>> Assuming someone here is interested I'll have a bunch of questions
>> about
>> how I might go about contributing this code.
>>
>> Cheers,
>>     Grant.
>>
>>
>>
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder,  Apache Maven
> jason at sonatype dot com
> ----------------------------------------------------------
>
> What matters is not ideas, but the people who have them. Good people
> can fix bad ideas, but good ideas can't save bad people.
>
>   -- Paul Graham

[struberg]

slightly OT: the JDK1.5 question also applies to the native Java implementation of maven-scm-providers-git.

This is now even more interesting as Shawn changed the license of egit from LGPL to BSD a while ago. This means we have no license problems anymore.

Grant, I've not yet looked at the accurev code, but how does it invoke the SCM? Via API or via command line?

LieGrue,
strub


--- ggardner <gdgardner@...> schrieb am Di, 13.1.2009:

> Von: ggardner <gdgardner@...>
> Betreff: Re: accurev provider
> An: scm-dev@...
> Datum: Dienstag, 13. Januar 2009, 11:14
> Thanks, I wanted an excuse to try out a coverage tool. 6
> more lines in the
> pom and Cobertura tells me 90% coverage.
>
> Though one immediate question is whether it is acceptable
> for one provider
> to require JDK 1.5. If not I'll have to remove JDK 1.5
> dependancies
> (generics, JMock, JUnit4) that were useful for putting it
> all together in a
> TDD fashion.
>
> Grant.
>
> On Mon, 12 Jan 2009 12:21:15 -0800, Jason van Zyl
> <jvanzyl@...>
> wrote:
> > If you got code then you need to accompany it with
> complete tests or
> > we're likely not to look at it.
> >
> > On 12-Jan-09, at 4:51 AM, ggardner wrote:
> >
> >>
> >> Hi all,
> >>
> >> I've been working on extending the AccuRev
> provider implementation
> >> to be
> >> fully compatible with the maven release plugin.
> >> (ie update, status, checkin, tag, checkout, add)
> >>
> >> I think I'm pretty close with the necessary
> commands implemented and
> >> the
> >> tck tests passing against an AccuRev evaluation
> install.
> >>
> >> Assuming someone here is interested I'll have
> a bunch of questions
> >> about
> >> how I might go about contributing this code.
> >>
> >> Cheers,
> >>     Grant.
> >>
> >>
> >>
> >
> > Thanks,
> >
> > Jason
> >
> >
> ----------------------------------------------------------
> > Jason van Zyl
> > Founder,  Apache Maven
> > jason at sonatype dot com
> >
> ----------------------------------------------------------
> >
> > What matters is not ideas, but the people who have
> them. Good people
> > can fix bad ideas, but good ideas can't save bad
> people.
> >
> >   -- Paul Graham

[Ivan Luzyanin]

Via the command line.

struberg wrote:

slightly OT: the JDK1.5 question also applies to the native Java implementation of maven-scm-providers-git.

This is now even more interesting as Shawn changed the license of egit from LGPL to BSD a while ago. This means we have no license problems anymore.

Grant, I've not yet looked at the accurev code, but how does it invoke the SCM? Via API or via command line?

LieGrue,
strub


--- ggardner <[e-mail]> schrieb am Di, 13.1.2009:

> Von: ggardner <[e-mail]>
> Betreff: Re: accurev provider
> An: [e-mail]
> Datum: Dienstag, 13. Januar 2009, 11:14
> Thanks, I wanted an excuse to try out a coverage tool. 6
> more lines in the
> pom and Cobertura tells me 90% coverage.
>
> Though one immediate question is whether it is acceptable
> for one provider
> to require JDK 1.5. If not I'll have to remove JDK 1.5
> dependancies
> (generics, JMock, JUnit4) that were useful for putting it
> all together in a
> TDD fashion.
>
> Grant.
>
> On Mon, 12 Jan 2009 12:21:15 -0800, Jason van Zyl
> <[e-mail]>
> wrote:
> > If you got code then you need to accompany it with
> complete tests or
> > we're likely not to look at it.
> >
> > On 12-Jan-09, at 4:51 AM, ggardner wrote:
> >
> >>
> >> Hi all,
> >>
> >> I've been working on extending the AccuRev
> provider implementation
> >> to be
> >> fully compatible with the maven release plugin.
> >> (ie update, status, checkin, tag, checkout, add)
> >>
> >> I think I'm pretty close with the necessary
> commands implemented and
> >> the
> >> tck tests passing against an AccuRev evaluation
> install.
> >>
> >> Assuming someone here is interested I'll have
> a bunch of questions
> >> about
> >> how I might go about contributing this code.
> >>
> >> Cheers,
> >>     Grant.
> >>
> >>
> >>
> >
> > Thanks,
> >
> > Jason
> >
> >
> ----------------------------------------------------------
> > Jason van Zyl
> > Founder,  Apache Maven
> > jason at sonatype dot com
> >
> ----------------------------------------------------------
> >
> > What matters is not ideas, but the people who have
> them. Good people
> > can fix bad ideas, but good ideas can't save bad
> people.
> >
> >   -- Paul Graham

[struberg]

> Via the command line.

fine, just 2 make sure that we don't get license troubles.

LieGrue,
strub


--- Ivan Luzyanin <ivanobulo@...> schrieb am Di, 13.1.2009:

> Von: Ivan Luzyanin <ivanobulo@...>
> Betreff: Re: accurev provider
> An: scm-dev@...
> Datum: Dienstag, 13. Januar 2009, 12:04
> Via the command line.
>
>
> struberg wrote:
> >
> > slightly OT: the JDK1.5 question also applies to the
> native Java
> > implementation of maven-scm-providers-git.
> >
> > This is now even more interesting as Shawn changed the
> license of egit
> > from LGPL to BSD a while ago. This means we have no
> license problems
> > anymore.
> >
> > Grant, I've not yet looked at the accurev code,
> but how does it invoke the
> > SCM? Via API or via command line?
> >
> > LieGrue,
> > strub
> >
> >
> > --- ggardner <gdgardner@...> schrieb
> am Di, 13.1.2009:
> >
> >> Von: ggardner <gdgardner@...>
> >> Betreff: Re: accurev provider
> >> An: scm-dev@...
> >> Datum: Dienstag, 13. Januar 2009, 11:14
> >> Thanks, I wanted an excuse to try out a coverage
> tool. 6
> >> more lines in the
> >> pom and Cobertura tells me 90% coverage.
> >>
> >> Though one immediate question is whether it is
> acceptable
> >> for one provider
> >> to require JDK 1.5. If not I'll have to remove
> JDK 1.5
> >> dependancies
> >> (generics, JMock, JUnit4) that were useful for
> putting it
> >> all together in a
> >> TDD fashion.
> >>
> >> Grant.
> >>
> >> On Mon, 12 Jan 2009 12:21:15 -0800, Jason van Zyl
> >> <jvanzyl@...>
> >> wrote:
> >> > If you got code then you need to accompany it
> with
> >> complete tests or
> >> > we're likely not to look at it.
> >> >
> >> > On 12-Jan-09, at 4:51 AM, ggardner wrote:
> >> >
> >> >>
> >> >> Hi all,
> >> >>
> >> >> I've been working on extending the
> AccuRev
> >> provider implementation
> >> >> to be
> >> >> fully compatible with the maven release
> plugin.
> >> >> (ie update, status, checkin, tag,
> checkout, add)
> >> >>
> >> >> I think I'm pretty close with the
> necessary
> >> commands implemented and
> >> >> the
> >> >> tck tests passing against an AccuRev
> evaluation
> >> install.
> >> >>
> >> >> Assuming someone here is interested
> I'll have
> >> a bunch of questions
> >> >> about
> >> >> how I might go about contributing this
> code.
> >> >>
> >> >> Cheers,
> >> >>     Grant.
> >> >>
> >> >>
> >> >>
> >> >
> >> > Thanks,
> >> >
> >> > Jason
> >> >
> >> >
> >>
> ----------------------------------------------------------
> >> > Jason van Zyl
> >> > Founder,  Apache Maven
> >> > jason at sonatype dot com
> >> >
> >>
> ----------------------------------------------------------
> >> >
> >> > What matters is not ideas, but the people who
> have
> >> them. Good people
> >> > can fix bad ideas, but good ideas can't
> save bad
> >> people.
> >> >
> >> >   -- Paul Graham
> >
> >
> >
> >
> >
>
> --
> View this message in context:
> http://www.nabble.com/accurev-provider-tp21413963p21433339.html
> Sent from the Maven - SCM mailing list archive at
> Nabble.com.

[Grant Gardner-2]

Hi, I've got my AccuRev provider to a point where both the release plugin
and Continuum are working (for me).

Includes unit tests and tck tests for all the implemented commands.

How do I go about contributing the code?.

Grant.

[brettporter]

1) Create a JIRA ticket under SCM
2) you might like to submit a CLA - you can do it regardless, and if  
the work is accepted such a large chunk would probably require it (see http://www.apache.org/licenses/ 
  and specifically http://www.apache.org/licenses/icla.txt)

Thanks!

- Brett

On 07/03/2009, at 12:50 PM, Grant Gardner wrote:

>
>
> Hi, I've got my AccuRev provider to a point where both the release  
> plugin
> and Continuum are working (for me).
>
> Includes unit tests and tck tests for all the implemented commands.
>
> How do I go about contributing the code?.
>
> Grant.
>
>

--
Brett Porter
brett@...
http://blogs.exist.com/bporter/

[Grant Gardner-3]

I've created the jira with attached code. Let me know if there's anything
else I need to do.
http://jira.codehaus.org/browse/SCM-445

Will do the CLA when I find myself conveniently located near a fax or
scanner.

On Mon, 9 Mar 2009 05:02:15 +1100, Brett Porter <brett@...> wrote:

> 1) Create a JIRA ticket under SCM
> 2) you might like to submit a CLA - you can do it regardless, and if
> the work is accepted such a large chunk would probably require it (see
> http://www.apache.org/licenses/
>   and specifically http://www.apache.org/licenses/icla.txt)
>
> Thanks!
>
> - Brett
>
> On 07/03/2009, at 12:50 PM, Grant Gardner wrote:
>
>>
>>
>> Hi, I've got my AccuRev provider to a point where both the release
>> plugin
>> and Continuum are working (for me).
>>
>> Includes unit tests and tck tests for all the implemented commands.
>>
>> How do I go about contributing the code?.
>>
>> Grant.
>>
>>
>
> --
> Brett Porter
> brett@...
> http://blogs.exist.com/bporter/

[brettporter]

Do the authors of the original provider, or other users here, have an  
opinion on this? I like that it is more complete (functionally, and in  
docs and tests), however am not an accurev user myself.

What effect does the URL syntax change have?

Also Grant, I haven't seen the CLA yet?

- Brett

On 17/03/2009, at 11:58 PM, Grant Gardner wrote:

>
>
> I've created the jira with attached code. Let me know if there's  
> anything
> else I need to do.
> http://jira.codehaus.org/browse/SCM-445
>
> Will do the CLA when I find myself conveniently located near a fax or
> scanner.
>
> On Mon, 9 Mar 2009 05:02:15 +1100, Brett Porter <brett@...>  
> wrote:
>> 1) Create a JIRA ticket under SCM
>> 2) you might like to submit a CLA - you can do it regardless, and if
>> the work is accepted such a large chunk would probably require it  
>> (see
>> http://www.apache.org/licenses/
>>  and specifically http://www.apache.org/licenses/icla.txt)
>>
>> Thanks!
>>
>> - Brett
>>
>> On 07/03/2009, at 12:50 PM, Grant Gardner wrote:
>>
>>>
>>>
>>> Hi, I've got my AccuRev provider to a point where both the release
>>> plugin
>>> and Continuum are working (for me).
>>>
>>> Includes unit tests and tck tests for all the implemented commands.
>>>
>>> How do I go about contributing the code?.
>>>
>>> Grant.
>>>
>>>
>>
>> --
>> Brett Porter
>> brett@...
>> http://blogs.exist.com/bporter/

[Grant Gardner-3]

I faxed in the CLA today. Also uploaded a new version to the JIRA that
fixes a few bugs under Windows.

Grant.


On Wed, 1 Apr 2009 01:56:19 +1100, Brett Porter <brett@...> wrote:

> Do the authors of the original provider, or other users here, have an
> opinion on this? I like that it is more complete (functionally, and in
> docs and tests), however am not an accurev user myself.
>
> What effect does the URL syntax change have?
>
> Also Grant, I haven't seen the CLA yet?
>
> - Brett
>
> On 17/03/2009, at 11:58 PM, Grant Gardner wrote:
>
>>
>>
>> I've created the jira with attached code. Let me know if there's
>> anything
>> else I need to do.
>> http://jira.codehaus.org/browse/SCM-445
>>
>> Will do the CLA when I find myself conveniently located near a fax or
>> scanner.
>>

[Rodriguez, Pedro]

The plugin version submitted by Grant (JIRA SCM-445) is already more
completed than the current available version.

I'm currently using the release plugin with it and it works!

The url change was required to implement the additional accurev
commands. No sure about compatibility with previous version (if this is
what you meant by "effect of the new URL syntax").  

In fact, I was only able to use the plugin release with Accurev after
Grant contribution.

Pedro



-------- Original Message --------

Subject: Re: accurev provider

Date: Wed, 1 Apr 2009 01:56:19 +1100

From: Brett Porter <brett@...>

To: scm-dev@...



Do the authors of the original provider, or other users here, have an

opinion on this? I like that it is more complete (functionally, and in

docs and tests), however am not an accurev user myself.



What effect does the URL syntax change have?



Also Grant, I haven't seen the CLA yet?



- Brett