alsaplayer and jack2

View: New views
9 Messages — Rating Filter:   Alert me  

alsaplayer and jack2

by Fons Adriaensen-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hello all,

AFAICS, alsaplayer fails with jack2, printing some
cryptic error messages about the sample rate being
0 instead of 44100. The same alsaplayer works well
with jack 0.116.2.

I noticed this before, using earlier versions of
alsaplayer and jack2, but up to now I just assumed
that alsaplayer was to blame (its jack support has
been erratic). But the pattern seems to repeat.

Anyone else noticed this ?

Ciao,

--
FA

_______________________________________________
Jack-Devel mailing list
Jack-Devel@...
http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org

Re: alsaplayer and jack2

by James Warden :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi Fons,

Looks like the same symptom I saw in oss2jack. It had to do with the samplerate callback.

jack1 and jack2 differ in how they treat it.

In oss2jack, the code used to be:


         jack_set_sample_rate_callback(info->client, jack_srate, info);

jack_srate being the callback func, and info the client data.
Jack1 would actually do something explicit about it.

But not jack2.

I had a short message echange with Stephane Letz, and I ended up adding a one liner in oss2jack:

+        /* initialize current sample rate for jack2 at startup */
+        (void)jack_srate(jack_get_sample_rate(info->client), info);


My bet is that alsaplayer is suffering from the same diff between jack1 and jack2.

J.
--- On Mon, 10/26/09, fons@... <fons@...> wrote:

> From: fons@... <fons@...>
> Subject: [Jack-Devel] alsaplayer and jack2
> To: "Jack Developers" <jack-devel@...>
> Date: Monday, October 26, 2009, 5:18 PM
> Hello all,
>
> AFAICS, alsaplayer fails with jack2, printing some
> cryptic error messages about the sample rate being
> 0 instead of 44100. The same alsaplayer works well
> with jack 0.116.2.
>
> I noticed this before, using earlier versions of
> alsaplayer and jack2, but up to now I just assumed
> that alsaplayer was to blame (its jack support has
> been erratic). But the pattern seems to repeat.
>
> Anyone else noticed this ?
>
> Ciao,
>
> --
> FA
>
> _______________________________________________
> Jack-Devel mailing list
> Jack-Devel@...
> http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org
>


     
_______________________________________________
Jack-Devel mailing list
Jack-Devel@...
http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org

Re: alsaplayer and jack2

by James Warden :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

specifically,

what jack1 does is :

[code]
       /* Now invoke it */

        callback (client->engine->current_time.frame_rate, arg);
[/code]

in jack_set_sample_rate_callback (jack_client_t *client,
                               JackSampleRateCallback callback, void *arg)

Jack2 does not do this.

--- On Mon, 10/26/09, James Warden <warjamy@...> wrote:

> From: James Warden <warjamy@...>
> Subject: Re: [Jack-Devel] alsaplayer and jack2
> To: "Jack Developers" <jack-devel@...>, fons@...
> Date: Monday, October 26, 2009, 5:39 PM
> Hi Fons,
>
> Looks like the same symptom I saw in oss2jack. It had to do
> with the samplerate callback.
>
> jack1 and jack2 differ in how they treat it.
>
> In oss2jack, the code used to be:
>
>
>      
>    jack_set_sample_rate_callback(info->client,
> jack_srate, info);
>
> jack_srate being the callback func, and info the client
> data.
> Jack1 would actually do something explicit about it.
>
> But not jack2.
>
> I had a short message echange with Stephane Letz, and I
> ended up adding a one liner in oss2jack:
>
> +        /* initialize current sample
> rate for jack2 at startup */
> +       
> (void)jack_srate(jack_get_sample_rate(info->client),
> info);
>
>
> My bet is that alsaplayer is suffering from the same diff
> between jack1 and jack2.
>
> J.
> --- On Mon, 10/26/09, fons@...
> <fons@...>
> wrote:
>
> > From: fons@...
> <fons@...>
> > Subject: [Jack-Devel] alsaplayer and jack2
> > To: "Jack Developers" <jack-devel@...>
> > Date: Monday, October 26, 2009, 5:18 PM
> > Hello all,
> >
> > AFAICS, alsaplayer fails with jack2, printing some
> > cryptic error messages about the sample rate being
> > 0 instead of 44100. The same alsaplayer works well
> > with jack 0.116.2.
> >
> > I noticed this before, using earlier versions of
> > alsaplayer and jack2, but up to now I just assumed
> > that alsaplayer was to blame (its jack support has
> > been erratic). But the pattern seems to repeat.
> >
> > Anyone else noticed this ?
> >
> > Ciao,
> >
> > --
> > FA
> >
> > _______________________________________________
> > Jack-Devel mailing list
> > Jack-Devel@...
> > http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org
> >
>
>
>      
> _______________________________________________
> Jack-Devel mailing list
> Jack-Devel@...
> http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org
>


     
_______________________________________________
Jack-Devel mailing list
Jack-Devel@...
http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org

Re: alsaplayer and jack2

by Stéphane Letz :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


Le 26 oct. 2009 à 22:42, James Warden a écrit :

> specifically,
>
> what jack1 does is :
>
> [code]
>       /* Now invoke it */
>
>        callback (client->engine->current_time.frame_rate, arg);
> [/code]
>
> in jack_set_sample_rate_callback (jack_client_t *client,
>                               JackSampleRateCallback callback, void  
> *arg)
>
> Jack2 does not do this.


Never really looked as what JACK1 was doing... (since i was assuming  
that jack_set_sample_rate_callback was "deprecated")

Now fixed in JACK2 SVN rev 2677.

Stéphane
_______________________________________________
Jack-Devel mailing list
Jack-Devel@...
http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org

Re: alsaplayer and jack2

by James Warden :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

hehe, when we talked about it some months ago, you preferred not modifying jack2 but instead letting clients call jack_get_sample_rate() ;)

alsaplayer now works with your update :)

J.


--- On Mon, 10/26/09, Stéphane Letz <letz@...> wrote:

> From: Stéphane Letz <letz@...>
> Subject: Re: [Jack-Devel] alsaplayer and jack2
> To: "James Warden" <warjamy@...>
> Cc: "Jack Developers" <jack-devel@...>, fons@...
> Date: Monday, October 26, 2009, 5:56 PM
>
> Le 26 oct. 2009 à 22:42, James Warden a écrit :
>
> > specifically,
> >
> > what jack1 does is :
> >
> > [code]
> >       /* Now invoke it */
> >
> >        callback
> (client->engine->current_time.frame_rate, arg);
> > [/code]
> >
> > in jack_set_sample_rate_callback (jack_client_t
> *client,
> >               
>            
>    JackSampleRateCallback callback, void
> *arg)
> >
> > Jack2 does not do this.
>
>
> Never really looked as what JACK1 was doing... (since i was
> assuming that jack_set_sample_rate_callback was
> "deprecated")
>
> Now fixed in JACK2 SVN rev 2677.
>
> Stéphane


     
_______________________________________________
Jack-Devel mailing list
Jack-Devel@...
http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org

Re: alsaplayer and jack2

by Stéphane Letz :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


Le 26 oct. 2009 à 23:07, James Warden a écrit :

> hehe, when we talked about it some months ago, you preferred not  
> modifying jack2 but instead letting clients call jack_get_sample_rate
> () ;
>
> alsaplayer now works with your update :)
>
> J.
>

Well, I did not looked as JACK1 code at that time... ((-:

The "fix" seems reasonable..

Stéphane
_______________________________________________
Jack-Devel mailing list
Jack-Devel@...
http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org

Re: alsaplayer and jack2

by Fons Adriaensen-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Mon, Oct 26, 2009 at 03:07:29PM -0700, James Warden wrote:

> hehe, when we talked about it some months ago, you preferred
> not modifying jack2 but instead letting clients call
> jack_get_sample_rate() ;)
>
> alsaplayer now works with your update :)

> --- On Mon, 10/26/09, Stéphane Letz <letz@...> wrote:
>  
> > Never really looked as what JACK1 was doing... (since i was
> > assuming that jack_set_sample_rate_callback was
> > "deprecated")

Which means it should still work... Apparently then
alsaplayer relies on getting the initial sample_rate
callback. I hope they'll fix this (after having fixed
the absolutely indecent resampling quality).

Many thanks,

--
FA


_______________________________________________
Jack-Devel mailing list
Jack-Devel@...
http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org

jackrouter source?

by Joakim Hernberg :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hello,

I'm working on the wineasio code and was wondering if the jackrouter code is
available somewhere?  Was hoping to compare notes, and possibly see if it can
be used in wine.

Best wishes,

   Joakim

_______________________________________________
Jack-Devel mailing list
Jack-Devel@...
http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org

Re: jackrouter source?

by Stéphane Letz :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


Le 27 oct. 2009 à 13:39, Joakim Hernberg a écrit :

> Hello,
>
> I'm working on the wineasio code and was wondering if the jackrouter  
> code is
> available somewhere?  Was hoping to compare notes, and possibly see  
> if it can
> be used in wine.
>
> Best wishes,
>
>   Joakim


Here :

http://sourceforge.net/projects/jackosx/develop

http://jackosx.cvs.sourceforge.net/jackosx/

Stéphane
_______________________________________________
Jack-Devel mailing list
Jack-Devel@...
http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org