blur & masks

Hi,

Dmitry asked me to look at why the blur filter doesn't work with masks,
and I think I've at least got a lead: it looks like none of the
convolution-based filters work with masks. Saving the src and dst
paint devices in the process() method shows that dst _is_ blurred --
but there is something else going on.

In any case, I'm still working on it :-)

Boudewijn

_______________________________________________
kimageshop mailing list
kimageshop@...
https://mail.kde.org/mailman/listinfo/kimageshop

[Cyrille Berger]

On Wednesday 30 September 2009, Boudewijn Rempt wrote:
> Hi,
>
> Dmitry asked me to look at why the blur filter doesn't work with masks,
> and I think I've at least got a lead: it looks like none of the
> convolution-based filters work with masks. Saving the src and dst
> paint devices in the process() method shows that dst _is_ blurred --
> but there is something else going on.
the blur filter absolutely need a KisTransaction to be created prior to
applying the filter, is it the case ? (that said, without the kistransaction
you would get garbage in the output, not nothing)

--
Cyrille Berger
_______________________________________________
kimageshop mailing list
kimageshop@...
https://mail.kde.org/mailman/listinfo/kimageshop

On Wednesday 30 September 2009, Cyrille Berger wrote:

> On Wednesday 30 September 2009, Boudewijn Rempt wrote:
> > Hi,
> >
> > Dmitry asked me to look at why the blur filter doesn't work with masks,
> > and I think I've at least got a lead: it looks like none of the
> > convolution-based filters work with masks. Saving the src and dst
> > paint devices in the process() method shows that dst _is_ blurred --
> > but there is something else going on.
>
> the blur filter absolutely need a KisTransaction to be created prior to
> applying the filter, is it the case ? (that said, without the
>  kistransaction you would get garbage in the output, not nothing)

Good point, I'll check that.

--
Boudewijn Rempt | http://www.valdyas.org
_______________________________________________
kimageshop mailing list
kimageshop@...
https://mail.kde.org/mailman/listinfo/kimageshop

On Wed, Sep 30, 2009 at 11:17 PM, Boudewijn Rempt <boud@...> wrote:

On Wednesday 30 September 2009, Cyrille Berger wrote:
> On Wednesday 30 September 2009, Boudewijn Rempt wrote:
> > Hi,
> >
> > Dmitry asked me to look at why the blur filter doesn't work with masks,
> > and I think I've at least got a lead: it looks like none of the
> > convolution-based filters work with masks. Saving the src and dst
> > paint devices in the process() method shows that dst _is_ blurred --
> > but there is something else going on.
>
> the blur filter absolutely need a KisTransaction to be created prior to
> applying the filter, is it the case ? (that said, without the
>  kistransaction you would get garbage in the output, not nothing)

Good point, I'll check that.

It should be placed in KisFilterMask::decorateRect(). Maybe, there are two transactions created at once? In KisMask::apply and in KisFilterMask::decorateRect? I don't have code to check atm.

--
Dmitry Kazakov

_______________________________________________
kimageshop mailing list
kimageshop@...
https://mail.kde.org/mailman/listinfo/kimageshop