buildmap_osm : invalid layer 0 in line #1

[Marco atzeri-3]

Dear all,
I was trying to convert the full
http://download.geofabrik.de/osm/europe/italy.osm.bz2

on fedora10 x86_64 using  1.2.1

put the fault message is puzzling:

$./buildmap_osm -i iso-it.osm -o iso-it.rdm
-- Pass 1 : 11630955 lines read (481 seconds)
## invalid layer 0 in line #1

For what I can see, there is a large use of layer 0
in the openstreet maps

 grep  layer iso-it.osm |sort -u |less
    <tag k="layer" v="0"/>
    <tag k="layer" v="0;1"/>
    <tag k="layer" v="- 1"/>
    <tag k="layer" v="-1"/>
    <tag k="layer" v="+1"/>
    <tag k="layer" v="1"/>
    <tag k="layer" v="-2"/>
    <tag k="layer" v="2"/>
    <tag k="layer" v="-3"/>
    <tag k="layer" v="3"/>
    <tag k="layer" v="-4"/>
    <tag k="layer" v="4"/>
    <tag k="layer" v="-5"/>
    <tag k="layer" v="5"/>
    <tag k="layer" v="asteracee"/>
    <tag k="layer" v="camomille"/>
    <tag k="layer" v="Data Layer"/>
    <tag k="layer" v="digiura"/>
    <tag k="layer" v="f. carcano"/>
    <tag k="layer" v="firenze"/>
    <tag k="layer" v="Nora"/>
    <tag k="layer" v="ss93"/>
    <tag k="layer" v="Tangenziale nord Potenza"/>
    <tag k="layer" v="unnamed"/>
    <tag k="layer" v="unnamed2"/>
    <tag k="layer" v="unnamed4"/>
    <tag k="layer" v="via_de_coubertin"/>
    <tag k="layer" v="via Ippodromo"/>
    <tag k="openGeoDB:layer" v="5"/>
    <tag k="openGeoDB:layer" v="6"/>
    <tag k="openGeoDB:layer" v="7"/>

$grep  " <tag k=\"layer\" v=\"0\"/>" iso-it.osm | wc -l
2166

any suggestion ?

Thanks
Marco




     

------------------------------------------------------------------------------
Stay on top of everything new and different, both inside and
around Java (TM) technology - register by April 22, and save
$200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco.
300 plus technical and hands-on sessions. Register today.
Use priority code J9JMT32. http://p.sf.net/sfu/p
_______________________________________________
Roadmap-general mailing list
Roadmap-general@...
https://lists.sourceforge.net/lists/listinfo/roadmap-general

[Danny Backx]

On Sun, 2009-04-19 at 06:28 +0000, Marco Atzeri wrote:

> I was trying to convert the full
> http://download.geofabrik.de/osm/europe/italy.osm.bz2
>
> on fedora10 x86_64 using  1.2.1
>
> put the fault message is puzzling:
>
> $./buildmap_osm -i iso-it.osm -o iso-it.rdm
> -- Pass 1 : 11630955 lines read (481 seconds)
> ## invalid layer 0 in line #1
>
> For what I can see, there is a large use of layer 0
> in the openstreet maps
>
>  grep  layer iso-it.osm |sort -u |less
>     <tag k="layer" v="0"/>

buildmap_osm doesn't use this information, the cause is elsewhere.

When I run that test, it fails on this input :
  <way id="1385461" timestamp="2006-05-25T17:40:23Z" user="Roberto Piola">
    <nd ref="5888666"/>
    <nd ref="5888671"/>
    <tag k="name" v="Biella-Piani del Cucco"/>
    <tag k="class" v="pathway"/>
  </way>

Adding "pathway" to the list of classes recognized is a bit awkward, usually
another kind of tag, like
 <tag k="highway" v="residential"/>
is used instead of the "class".

Two things I note in this :
1. the error message is not informative enough, it should print the
   OSM node number or something. But that would require interface changes
   that I'm not comfortable with.

   Paul, how about a return -1 in this function, and catching the error at
   a higher level ?

2. buildmap shouldn't fail on this (or : my opinion is that applications
   should not fail in such conditions), it should fall back to some default
   layer.

But obviously if you do fix #2 then #1 becomes invalid :-)

I've just applied fix #2 to CVS, you can update and try again...

        Danny

--
Danny Backx ; danny.backx - at - scarlet.be ; http://danny.backx.info


------------------------------------------------------------------------------
Stay on top of everything new and different, both inside and
around Java (TM) technology - register by April 22, and save
$200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco.
300 plus technical and hands-on sessions. Register today.
Use priority code J9JMT32. http://p.sf.net/sfu/p
_______________________________________________
Roadmap-general mailing list
Roadmap-general@...
https://lists.sourceforge.net/lists/listinfo/roadmap-general