commit 1dfc6b1f6ed81c2b58b5beca09d7f7ab903c8ad8

[John Darrington-3]

        hmap-test: Disable tests that GCC 4.3 miscompiles.
        Commit ac58b3c51 "Avoid bug in GCC 4.3 in hmap-test." attempted to work around a bug in GCC 4.3 that was causing test failures in hmap-test. Unfortunately, the problem has started resurfacing again, probably due to changes elsewhere, so this commit simply disables the tests in question when PSPP is built with GCC 4.3.


Instead of simply ignoring this test, I suggest that it returns 77 if the offending
compiler version is detected.  That way, there will be a warning that the test was not run.

J'

--
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.




_______________________________________________
pspp-dev mailing list
pspp-dev@...
http://lists.gnu.org/mailman/listinfo/pspp-dev

[Ben Pfaff]

John Darrington <john@...> writes:

> hmap-test: Disable tests that GCC 4.3 miscompiles.
> Commit ac58b3c51 "Avoid bug in GCC 4.3 in hmap-test." attempted to work around a bug in GCC 4.3 that was causing test failures in hmap-test. Unfortunately, the problem has started resurfacing again, probably due to changes elsewhere, so this commit simply disables the tests in question when PSPP is built with GCC 4.3.
>
>
> Instead of simply ignoring this test, I suggest that it returns 77 if the offending
> compiler version is detected.  That way, there will be a warning that the test was not run.

You are right, that is better.  I pushed this change.
--
"To the engineer, the world is a toy box full of sub-optimized and
 feature-poor toys."
--Scott Adams


_______________________________________________
pspp-dev mailing list
pspp-dev@...
http://lists.gnu.org/mailman/listinfo/pspp-dev