compiling failure soundtracker-v0.6.8 without package libsndfile

Hello Michael,
Hello Trackers,

I had some spare time this night,
so I downloaded the soundtracker-0.6.8  and compiled it again .

I had not installed the libsndfile package at first.
So I ran in an compilation error,


2006-11-03  Frank Haferkorn <WillyFoobar@...>

        * app/drivers/file-output.c:
          line 410: removed an  gcc error
        when compiling without sndfile package as
        "*snd*file_driver" is not available at that precompiler options
        and should be modified to "file_driver".
        The modified function is is:

file_get_play_rate (void *d)
{
    file_driver * const dp = d;
    return dp->p_mixfreq;
}

that error above doesnt appear when libsndfile is present:
I appendend these changes:
hafi@duffy:~soundtracker-0.6.8> pkg-config --modversion sndfile
1.0.17


I also found a redefine of an existing "DEFINE"

        * app/drivers/jack-output.c:
                the change suggested by "Erik de Castro Lopo"
                #define INT16_MAX 32767.0f
                collided with
                 define INT16_MAX              (32767)
                of included file
                /usr/include/stdint.h
        In order to fix that mixedup with the global define
        in lines 62 and 66 need to be modified to e.g. "INT16_MAX_float"



Then there were no more warnings at all.

When I install the package libsndfile
I surprinsingly received lots (new) gcc-compiler warnings about
        broken fixed aliases and
        illegal signedness.


...............More on that in a following mail.




-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Soundtracker-discuss mailing list
Soundtracker-discuss@...
https://lists.sourceforge.net/lists/listinfo/soundtracker-discuss

[Yury Aliaev]

Helo, Willy!

>
> I had some spare time this night,
> so I downloaded the soundtracker-0.6.8  and compiled it again .
>
> I had not installed the libsndfile package at first.
> So I ran in an compilation error,
>
>
> 2006-11-03  Frank Haferkorn <WillyFoobar@...>
>
>         * app/drivers/file-output.c:
>           line 410: removed an  gcc error
> when compiling without sndfile package as
> "*snd*file_driver" is not available at that precompiler options
> and should be modified to "file_driver".
> The modified function is is:
>
> file_get_play_rate (void *d)
> {
>     file_driver * const dp = d;
>     return dp->p_mixfreq;
> }
>
> that error above doesnt appear when libsndfile is present:
> I appendend these changes:
> hafi@duffy:~soundtracker-0.6.8> pkg-config --modversion sndfile
> 1.0.17
>
>
> I also found a redefine of an existing "DEFINE"
>
>         * app/drivers/jack-output.c:
>        the change suggested by "Erik de Castro Lopo"
>                 #define INT16_MAX 32767.0f
>        collided with
>                  define INT16_MAX              (32767)
>        of included file
>                 /usr/include/stdint.h
> In order to fix that mixedup with the global define
>         in lines 62 and 66 need to be modified to e.g. "INT16_MAX_float"
>
>

Could you issue your fixes as a patch and send it to the list, please?

WBR,
Yury.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Soundtracker-discuss mailing list
Soundtracker-discuss@...
https://lists.sourceforge.net/lists/listinfo/soundtracker-discuss

Hello Yury,
Hello Tracker Team,

Here is the result of the command
        diff -r soundtracker-0.6.8 soundtracker-0.6.8-willyfoobar
attached as a file to this mail.

I am not sure, whether attaching works inside the discussion forum.
so please mail me, wheter this is not enough.

Yours,
        Willy


> Could you issue your fixes as a patch and send it to the list, please?
>
> WBR,
> Yury.

[soundtracker-0.6.8.diff]

---

diff -r soundtracker-0.6.8/app/clavier.c soundtracker-0.6.8-willyfoobar/app/clavier.c
22a23
> #include <gtk/gtkobject.h> //patch by F.Haferkorn 2006-06-29
Nur in soundtracker-0.6.8-willyfoobar/app: .deps.
Nur in soundtracker-0.6.8-willyfoobar/app/drivers: .deps.
diff -r soundtracker-0.6.8/app/drivers/file-output.c soundtracker-0.6.8-willyfoobar/app/drivers/file-output.c
406a407,408
>
>
410c412
<     sndfile_driver * const dp = d;
---
>     file_driver * const dp = d;
diff -r soundtracker-0.6.8/app/drivers/jack-output.c soundtracker-0.6.8-willyfoobar/app/drivers/jack-output.c
62c62
< #define INT16_MAX 32767.0f
---
> #define INT16_MAX_float 32767.0f
66c66
< return inval * (1.0 / (INT16_MAX + 1));
---
> return inval * (1.0 / (INT16_MAX_float + 1));
Nur in soundtracker-0.6.8-willyfoobar/app/drivers: Makefile.
Nur in soundtracker-0.6.8-willyfoobar/app: Makefile.
Nur in soundtracker-0.6.8-willyfoobar/app/mixers: .deps.
Nur in soundtracker-0.6.8-willyfoobar/app/mixers: Makefile.
diff -r soundtracker-0.6.8/ChangeLog soundtracker-0.6.8-willyfoobar/ChangeLog
0a1,14

> 2006-11-03  Frank Haferkorn <WillyFoobar@...>
>
> * app/drivers/file-output.c:
>  line 410: removed an  gcc error when compiling without sndfile package
>
> * app/drivers/jack-output.c:
> the change suggested by "Erik de Castro Lopo"
> #define INT16_MAX 32767.0f
> collided with
> define INT16_MAX              (32767)
> of included file
> /usr/include/stdint.h
> lines 62 and 66 were modified to "INT16_MAX_float"
>

Nur in soundtracker-0.6.8-willyfoobar/: .ChangeLog.swp.
Nur in soundtracker-0.6.8-willyfoobar/: config.h.
Nur in soundtracker-0.6.8-willyfoobar/: config.log.
Nur in soundtracker-0.6.8-willyfoobar/: config.status.
Nur in soundtracker-0.6.8/doc: hacking.html.
Nur in soundtracker-0.6.8-willyfoobar/doc: .hacking.texi.swp.
Nur in soundtracker-0.6.8/doc: hacking.txt.
Nur in soundtracker-0.6.8-willyfoobar/doc: Makefile.
Nur in soundtracker-0.6.8-willyfoobar/: .INSTALL.swp.
Nur in soundtracker-0.6.8-willyfoobar/: Makefile.
Nur in soundtracker-0.6.8-willyfoobar/po: Makefile.
Nur in soundtracker-0.6.8-willyfoobar/po: Makefile.in.
Nur in soundtracker-0.6.8-willyfoobar/po: POTFILES.
Nur in soundtracker-0.6.8-willyfoobar/: stamp-h1.

---

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Soundtracker-discuss mailing list
Soundtracker-discuss@...
https://lists.sourceforge.net/lists/listinfo/soundtracker-discuss