couple of changes to ruby stomp client

[andrewk]

Hey folks,

So I am finally getting ready to check in a few changes to the ruby stomp gem -

1) cleaning up the receive and _receive methods, fixing a small bug in multiple lose/reconnect logic in reliable mode

2) an enhancement to be able to pass in a 'client-id' header for the CONNECT message - this is necessary to support durable topic subscriptions when using the activemq/stompconnect impls and their jms-like extensions.

While I am in the code, anything else missing/broken I don't know about for the ruby stomp client?

Thanks,

Andrew Kuklewicz
http://beginsinwonder.com

[Charlie Sadler]

Yes, please. Dashes are illegal characters for JMS Property names. Please see the "ruby client stompconnect weblogic 9.2 issue thread". The needed adjustment could be made to the ruby stomp gem or stompconnect. Thanks.

andrewk wrote:

Hey folks,

So I am finally getting ready to check in a few changes to the ruby stomp gem -

1) cleaning up the receive and _receive methods, fixing a small bug in multiple lose/reconnect logic in reliable mode

2) an enhancement to be able to pass in a 'client-id' header for the CONNECT message - this is necessary to support durable topic subscriptions when using the activemq/stompconnect impls and their jms-like extensions.

While I am in the code, anything else missing/broken I don't know about for the ruby stomp client?

Thanks,

Andrew Kuklewicz
http://beginsinwonder.com

[andrewk]

Hey Charlie,

I haven't forgotten you or this bug :) How are things going?  Have things been working since you patches up StompConnect for this?

I think this bug may need to be a StompConnect fix, as this character limitation is for JMS, and the ruby stomp gem has no clue it is writing to anything but stomp - stomp could care less about dashes.  What I will look at is making sure the gem doesn't force you to send dashed header names anywhere (I think it is always adding content-length, for example).

-Andrew


Yes, please. Dashes are illegal characters for JMS Property names. Please see the "ruby client stompconnect weblogic 9.2 issue thread". The needed adjustment could be made to the ruby stomp gem or stompconnect. Thanks.

andrewk wrote:

Hey folks,

So I am finally getting ready to check in a few changes to the ruby stomp gem -

1) cleaning up the receive and _receive methods, fixing a small bug in multiple lose/reconnect logic in reliable mode

2) an enhancement to be able to pass in a 'client-id' header for the CONNECT message - this is necessary to support durable topic subscriptions when using the activemq/stompconnect impls and their jms-like extensions.

While I am in the code, anything else missing/broken I don't know about for the ruby stomp client?

Thanks,

Andrew Kuklewicz
http://beginsinwonder.com

[Charlie Sadler]

Hi Andrew,

Things are going well with the local patches I made to StompConnect.

I agree StompConnect is responsible for translating relevant stomp
headers and the stomp gem should not worry about dashes. I think
currently the only header coming from the stomp gem which is an issue
for StompConnect is the content-type header (not the content-length
header). A couple of questions:

1) How do I get my patches into the distribution so other people
(Sylvain Perez) might benefit?

2) Would you like me to help out with the StompConnect changes to
leverage the new client-id header coming from the gem?

Thanks, Charlie

-----Original Message-----
From: andrewk [mailto:andrew@...]
Sent: Wednesday, May 09, 2007 6:32 PM
To: dev@...
Subject: Re: [stomp-dev] couple of changes to ruby stomp client


Hey Charlie,

I haven't forgotten you or this bug :) How are things going?  Have
things
been working since you patches up StompConnect for this?

I think this bug may need to be a StompConnect fix, as this character
limitation is for JMS, and the ruby stomp gem has no clue it is writing
to
anything but stomp - stomp could care less about dashes.  What I will
look
at is making sure the gem doesn't force you to send dashed header names
anywhere (I think it is always adding content-length, for example).

-Andrew


Charlie Sadler wrote:
>
> Yes, please. Dashes are illegal characters for JMS Property names.
Please
> see the "ruby client stompconnect weblogic 9.2 issue thread". The
needed
> adjustment could be made to the ruby stomp gem or stompconnect.
Thanks.
>
>
> andrewk wrote:
>>
>> Hey folks,
>>
>> So I am finally getting ready to check in a few changes to the ruby
stomp
>> gem -
>>
>> 1) cleaning up the receive and _receive methods, fixing a small bug
in
>> multiple lose/reconnect logic in reliable mode
>>
>> 2) an enhancement to be able to pass in a 'client-id' header for the
>> CONNECT message - this is necessary to support durable topic
>> subscriptions when using the activemq/stompconnect impls and their
>> jms-like extensions.
>>
>> While I am in the code, anything else missing/broken I don't know
about
>> for the ruby stomp client?
>>
>> Thanks,
>>
>> Andrew Kuklewicz
>> http://beginsinwonder.com
>>
>
>

--
View this message in context:
http://www.nabble.com/couple-of-changes-to-ruby-stomp-client-tf3717839.h
tml#a10404115
Sent from the stomp - dev mailing list archive at Nabble.com.


---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email


---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email