crash in settings in svn version

[Jean-Luc Coulon (f5ibh)-2]

Hi,

100% reproductble:

Settings -> Toolbars -> Toolbar style

crash

attached the bt


regards


J-L

[Thread debugging using libthread_db enabled]
0x00007f08bea4e28f in waitpid () from /lib/libpthread.so.0
#0  0x00007f08bea4e28f in waitpid () from /lib/libpthread.so.0
#1  0x00007f08b92ce169 in g_spawn_sync () from /lib/libglib-2.0.so.0
#2  0x00007f08b92ce468 in g_spawn_command_line_sync ()
   from /lib/libglib-2.0.so.0
#3  0x00007f08b184edb0 in ?? ()
   from /usr/lib/gtk-2.0/modules/libgnomebreakpad.so
#4  <signal handler called>
#5  tm_remove_underscore (toolbar=0x249aa20, event=0x0, info=0x290e300)
    at toolbar-factory.c:639
#6  tm_do_popup_menu (toolbar=0x249aa20, event=0x0, info=0x290e300)
    at toolbar-factory.c:730
#7  0x00007f08bb8bebdb in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#8  0x00007f08b97314bd in g_closure_invoke ()
   from /usr/lib/libgobject-2.0.so.0
#9  0x00007f08b9744c8b in ?? () from /usr/lib/libgobject-2.0.so.0
#10 0x00007f08b9745ec8 in g_signal_emit_valist ()
   from /usr/lib/libgobject-2.0.so.0
#11 0x00007f08b974636a in g_signal_emit_by_name ()
   from /usr/lib/libgobject-2.0.so.0
#12 0x000000000047a139 in style_button_cb (widget=<value optimized out>,
    page=<value optimized out>) at toolbar-prefs.c:337
#13 0x00007f08b97314bd in g_closure_invoke ()
   from /usr/lib/libgobject-2.0.so.0
#14 0x00007f08b9744c8b in ?? () from /usr/lib/libgobject-2.0.so.0
#15 0x00007f08b9746032 in g_signal_emit_valist ()
   from /usr/lib/libgobject-2.0.so.0
#16 0x00007f08b9746503 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#17 0x00007f08bb810a85 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#18 0x00007f08b97314bd in g_closure_invoke ()
   from /usr/lib/libgobject-2.0.so.0
#19 0x00007f08b974459c in ?? () from /usr/lib/libgobject-2.0.so.0
#20 0x00007f08b9746032 in g_signal_emit_valist ()
   from /usr/lib/libgobject-2.0.so.0
#21 0x00007f08b9746503 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#22 0x00007f08bb80f74d in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#23 0x00007f08bb8bff78 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#24 0x00007f08b97314bd in g_closure_invoke ()
   from /usr/lib/libgobject-2.0.so.0
#25 0x00007f08b9744979 in ?? () from /usr/lib/libgobject-2.0.so.0
#26 0x00007f08b9745ec8 in g_signal_emit_valist ()
   from /usr/lib/libgobject-2.0.so.0
#27 0x00007f08b9746503 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#28 0x00007f08bb9c8eae in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#29 0x00007f08bb8b8623 in gtk_propagate_event ()
   from /usr/lib/libgtk-x11-2.0.so.0
#30 0x00007f08bb8b96fb in gtk_main_do_event ()
   from /usr/lib/libgtk-x11-2.0.so.0
#31 0x00007f08bb0e504c in ?? () from /usr/lib/libgdk-x11-2.0.so.0
#32 0x00007f08b929712a in g_main_context_dispatch ()
   from /lib/libglib-2.0.so.0
#33 0x00007f08b929a988 in ?? () from /lib/libglib-2.0.so.0
#34 0x00007f08b929ae5d in g_main_loop_run () from /lib/libglib-2.0.so.0
#35 0x00007f08bb8b9af7 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
#36 0x000000000045c47a in main (argc=<value optimized out>,
    argv=0x7fffa319c7d8) at main.c:1155

Thread 1 (Thread 0x7f08c17197f0 (LWP 20539)):
#0  0x00007f08bea4e28f in waitpid () from /lib/libpthread.so.0
No symbol table info available.
#1  0x00007f08b92ce169 in g_spawn_sync () from /lib/libglib-2.0.so.0
No symbol table info available.
#2  0x00007f08b92ce468 in g_spawn_command_line_sync ()
   from /lib/libglib-2.0.so.0
No symbol table info available.
#3  0x00007f08b184edb0 in ?? ()
   from /usr/lib/gtk-2.0/modules/libgnomebreakpad.so
No symbol table info available.
#4  <signal handler called>
No symbol table info available.
#5  tm_remove_underscore (toolbar=0x249aa20, event=0x0, info=0x290e300)
    at toolbar-factory.c:639
No locals.
#6  tm_do_popup_menu (toolbar=0x249aa20, event=0x0, info=0x290e300)
    at toolbar-factory.c:730
        option_text = 0x0
        item = <value optimized out>
        menu = <value optimized out>
        event_time = <value optimized out>
        group = 0x2915310
        default_style = GTK_TOOLBAR_BOTH_HORIZ
#7  0x00007f08bb8bebdb in ?? () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#8  0x00007f08b97314bd in g_closure_invoke ()
   from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#9  0x00007f08b9744c8b in ?? () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#10 0x00007f08b9745ec8 in g_signal_emit_valist ()
   from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#11 0x00007f08b974636a in g_signal_emit_by_name ()
   from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#12 0x000000000047a139 in style_button_cb (widget=<value optimized out>,
    page=<value optimized out>) at toolbar-prefs.c:337
        handled = 0
#13 0x00007f08b97314bd in g_closure_invoke ()
   from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#14 0x00007f08b9744c8b in ?? () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#15 0x00007f08b9746032 in g_signal_emit_valist ()
   from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#16 0x00007f08b9746503 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#17 0x00007f08bb810a85 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#18 0x00007f08b97314bd in g_closure_invoke ()
   from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#19 0x00007f08b974459c in ?? () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#20 0x00007f08b9746032 in g_signal_emit_valist ()
   from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#21 0x00007f08b9746503 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#22 0x00007f08bb80f74d in ?? () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#23 0x00007f08bb8bff78 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#24 0x00007f08b97314bd in g_closure_invoke ()
   from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#25 0x00007f08b9744979 in ?? () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#26 0x00007f08b9745ec8 in g_signal_emit_valist ()
   from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#27 0x00007f08b9746503 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#28 0x00007f08bb9c8eae in ?? () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#29 0x00007f08bb8b8623 in gtk_propagate_event ()
   from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#30 0x00007f08bb8b96fb in gtk_main_do_event ()
   from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#31 0x00007f08bb0e504c in ?? () from /usr/lib/libgdk-x11-2.0.so.0
No symbol table info available.
#32 0x00007f08b929712a in g_main_context_dispatch ()
   from /lib/libglib-2.0.so.0
No symbol table info available.
#33 0x00007f08b929a988 in ?? () from /lib/libglib-2.0.so.0
No symbol table info available.
#34 0x00007f08b929ae5d in g_main_loop_run () from /lib/libglib-2.0.so.0
No symbol table info available.
#35 0x00007f08bb8b9af7 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#36 0x000000000045c47a in main (argc=<value optimized out>,
    argv=0x7fffa319c7d8) at main.c:1155
        window = 0x2585130
        client = 0x22d0030
        default_icon = <value optimized out>
        app = 0x236e320
The program is running.  Quit anyway (and detach it)? (y or n) [answered Y; input not from terminal]




_______________________________________________
balsa-list mailing list
balsa-list@...
http://mail.gnome.org/mailman/listinfo/balsa-list

[Peter Bloomfield]

Hi Jean-Luc!

On 09/30/2009 08:17:01 AM Wed, Jean-Luc Coulon (f5ibh) wrote:
> Hi,
>
> 100% reproductble:
>
> Settings -> Toolbars -> Toolbar style
>
> crash
>
> attached the bt

Ouch!  Fixed in git.

Peter


_______________________________________________
balsa-list mailing list
balsa-list@...
http://mail.gnome.org/mailman/listinfo/balsa-list

[Peter Bloomfield]

Hi Jean-Luc:

On 09/30/2009 08:17:01 AM Wed, Jean-Luc Coulon (f5ibh) wrote:
> Hi,
>
> 100% reproductble:
>
> Settings -> Toolbars -> Toolbar style
>
> crash

...so the crash occurs when the default toolbar style is "Text Beside  
Icons"...which reminds me, we set the text beside *all* icons.  Some apps  
advertise "Priority Text Beside Icons", but Balsa has never identified  
"Priority" text, and as a result this option is pretty much unusable--the  
toolbar becomes over-wide.  It's not too hard to implement--question is,  
which buttons should show their text, and which are unambiguous without  
it?  The "print" and "exit" buttons are clear, and "spell-check" is  
universal, but which others could we safely leave unlabeled?

Vote early and often!

Peter


_______________________________________________
balsa-list mailing list
balsa-list@...
http://mail.gnome.org/mailman/listinfo/balsa-list

[Jack Ostroff]

On 2009.10.19 19:39, Peter Bloomfield wrote:

> On 09/30/2009 08:17:01 AM Wed, Jean-Luc Coulon (f5ibh) wrote:
>> 100% reproductble:
>>
>> Settings -> Toolbars -> Toolbar style
>>
>> crash
>
> ...so the crash occurs when the default toolbar style is "Text Beside  
> Icons"...which reminds me, we set the text beside *all* icons.  Some  
> apps advertise "Priority Text Beside Icons", but Balsa has never  
> identified "Priority" text, and as a result this option is pretty  
> much unusable--the toolbar becomes over-wide.  It's not too hard to  
> implement--question is, which buttons should show their text, and  
> which are unambiguous without it?  The "print" and "exit" buttons are  
> clear, and "spell-check" is universal, but which others could we  
> safely leave unlabeled?

Trash is pretty universal.  I think Reply, ReplyAll, and Forward are  
also, but I just noticed "Next Unread" is also an envelope with an  
arrow, so maybe only a half vote here.

Jack
_______________________________________________
balsa-list mailing list
balsa-list@...
http://mail.gnome.org/mailman/listinfo/balsa-list

[Peter Bloomfield]

On 10/19/2009 07:57:29 PM Mon, Jack wrote:

> On 2009.10.19 19:39, Peter Bloomfield wrote:
>> On 09/30/2009 08:17:01 AM Wed, Jean-Luc Coulon (f5ibh) wrote:
>>> 100% reproductble:
>>>
>>> Settings -> Toolbars -> Toolbar style
>>>
>>> crash
>>
>> ...so the crash occurs when the default toolbar style is "Text Beside  
>> Icons"...which reminds me, we set the text beside *all* icons.  Some  
>> apps advertise "Priority Text Beside Icons", but Balsa has never  
>> identified "Priority" text, and as a result this option is pretty much  
>> unusable--the toolbar becomes over-wide.  It's not too hard to  
>> implement--question is, which buttons should show their text, and which  
>> are unambiguous without it?  The "print" and "exit" buttons are clear,  
>> and "spell-check" is universal, but which others could we safely leave  
>> unlabeled?
>
> Trash is pretty universal.  I think Reply, ReplyAll, and Forward are  
> also, but I just noticed "Next Unread" is also an envelope with an  
> arrow, so maybe only a half vote here.

OK, so here's a (perhaps aggressive) proposal:

No text:

     {GTK_STOCK_QUIT, N_("Quit"), FALSE},
     {BALSA_PIXMAP_RECEIVE, N_("Check"), FALSE},
     {BALSA_PIXMAP_COMPOSE, N_("Compose"), FALSE},
     {BALSA_PIXMAP_REPLY, N_("Reply"), FALSE},
     {BALSA_PIXMAP_REPLY_ALL, N_("Reply\nto all"), FALSE},
     {BALSA_PIXMAP_NEXT_UNREAD, N_("Next\nunread"), FALSE},
     {GTK_STOCK_DELETE, N_("Trash /\nDelete"), FALSE},
     {GTK_STOCK_PRINT, N_("Print"), FALSE},
     {BALSA_PIXMAP_ATTACHMENT, N_("Attach"), FALSE},
     {GTK_STOCK_SAVE, N_("Save"), FALSE},
     {BALSA_PIXMAP_IDENTITY, N_("Identity"), FALSE},
     {GTK_STOCK_SPELL_CHECK, N_("Spelling"), FALSE},
     {GTK_STOCK_CLOSE, N_("Close"), FALSE},
     {GTK_STOCK_UNDO, N_("Undo"), FALSE},
     {GTK_STOCK_REDO, N_("Redo"), FALSE},
     {GTK_STOCK_EDIT, N_("Edit"), FALSE},

With text:

     {BALSA_PIXMAP_CONTINUE, N_("Continue"), TRUE},
     {BALSA_PIXMAP_REPLY_GROUP, N_("Reply\nto group"), TRUE},
     {BALSA_PIXMAP_FORWARD, N_("Forward"), TRUE},
     {BALSA_PIXMAP_PREVIOUS, N_("Previous"), TRUE},
     {BALSA_PIXMAP_NEXT, N_("Next"), TRUE},
     {BALSA_PIXMAP_NEXT_FLAGGED, N_("Next\nflagged"), TRUE},
     {BALSA_PIXMAP_PREVIOUS_PART, N_("Previous\npart"), TRUE},
     {BALSA_PIXMAP_NEXT_PART, N_("Next\npart"), TRUE},
     {BALSA_PIXMAP_POSTPONE, N_("Postpone"), TRUE},
     {BALSA_PIXMAP_REQUEST_MDN, N_("Request\nMDN"), TRUE},
     {BALSA_PIXMAP_SEND, N_("Send"), TRUE},
     {BALSA_PIXMAP_SEND_RECEIVE, N_("Exchange"), TRUE},
     {BALSA_PIXMAP_MARKED_NEW, N_("Toggle\nnew"), TRUE},
     {BALSA_PIXMAP_MARK_ALL, N_("Mark all"), TRUE},
     {BALSA_PIXMAP_SHOW_HEADERS, N_("All\nheaders"), TRUE},
     {GTK_STOCK_CANCEL, N_("Reset\nFilter"), TRUE},
     {BALSA_PIXMAP_SHOW_PREVIEW, N_("Msg Preview"), TRUE},
#ifdef HAVE_GPGME
     {BALSA_PIXMAP_GPG_SIGN, N_("Sign"), TRUE},
     {BALSA_PIXMAP_GPG_ENCRYPT, N_("Encrypt"), TRUE},
#endif
     {GTK_STOCK_CLEAR, N_("Expunge"), TRUE},
     {GTK_STOCK_REMOVE, N_("Empty\nTrash"), TRUE},

Comments?

Peter


_______________________________________________
balsa-list mailing list
balsa-list@...
http://mail.gnome.org/mailman/listinfo/balsa-list