crypt32(10/13): Don't delete a context when removing it from a list

View: New views
1 Messages — Rating Filter:   Alert me  

crypt32(10/13): Don't delete a context when removing it from a list

by Juan Lang-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

This temporarily "fixes" the todo_wine added in patch 2 of this series
by leaking memory.  The free is moved to the caller in the next patch,
then fixed altogether in the subsequent patch.
--Juan

[0010-Don-t-delete-a-context-when-removing-it-from-a-list.patch]

From 41377057408c54e19e0445fc6dfd6f24eb83ef0a Mon Sep 17 00:00:00 2001
From: Juan Lang <juan.lang@...>
Date: Fri, 30 Oct 2009 18:19:39 -0700
Subject: [PATCH] Don't delete a context when removing it from a list

---
 dlls/crypt32/context.c     |    1 -
 dlls/crypt32/tests/store.c |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/dlls/crypt32/context.c b/dlls/crypt32/context.c
index e0c1932..73e1e0e 100644
--- a/dlls/crypt32/context.c
+++ b/dlls/crypt32/context.c
@@ -321,7 +321,6 @@ void ContextList_Delete(struct ContextList *list, void *context)
     list_remove(entry);
     LeaveCriticalSection(&list->cs);
     list_init(entry);
-    list->contextInterface->free(context);
 }
 
 static void ContextList_Empty(struct ContextList *list)
diff --git a/dlls/crypt32/tests/store.c b/dlls/crypt32/tests/store.c
index 1f6609c..419d2dd 100644
--- a/dlls/crypt32/tests/store.c
+++ b/dlls/crypt32/tests/store.c
@@ -237,7 +237,6 @@ static void testMemStore(void)
          GetLastError());
         /* try deleting a copy */
         ret = CertDeleteCertificateFromStore(copy);
-        todo_wine
         ok(ret, "CertDeleteCertificateFromStore failed: %08x\n",
          GetLastError());
         /* check that the store is empty */
--
1.6.0.6