cygwin patches for 1.05
|
View:
New views
5 Messages
—
Rating Filter:
Alert me
|
 |
cygwin patches for 1.05
by Reini Urban
::
Rate this Message:
Attached is simple patch which fixes two issues:
* GUI.rc is readonly in the downloaded archive, and therefore build_tools/updateRC.pl fails to write it. * gcc-3.4 issues a warning if -Wdeclaration-after-statement is used with .cpp files (c++ mode). And I also waiting for my big CustomDraw patch. -- Reini Urban http://phpwiki.org/ http://murbreak.at/ http://helsinki.at/ http://spacemovie.mur.at/ difforig Win32-GUI-1.05 * GUI.rc is readonly in the downloaded archive, and therefore build_tools/updateRC.pl fails to write it. * gcc-3.4 issues a warning if -Wdeclaration-after-statement is used with cpp files (c++ mode). 2007-07-28 Reini Urban <rurban@...> diff -ub Win32-GUI-1.05/Makefile.PL.orig --- Win32-GUI-1.05/Makefile.PL.orig 2006-11-02 20:36:58.000000000 +0000 +++ Win32-GUI-1.05/Makefile.PL 2007-07-28 20:48:08.812500000 +0000 @@ -279,6 +279,12 @@ return $inherited; } +sub cflags { + my $inherited = shift->SUPER::cflags(@_); + $inherited =~ s/-Wdeclaration-after-statement//mg; + return $inherited; +} + # Remove the Test-More dependency from the PPD file, as it is not # a requirement for a binary distribution sub ppd { diff -ub Win32-GUI-1.05/build_tools/updateRC.pl.orig --- Win32-GUI-1.05/build_tools/updateRC.pl.orig 2005-08-03 21:45:58.000000000 +0000 +++ Win32-GUI-1.05/build_tools/updateRC.pl 2007-07-28 20:55:31.812500000 +0000 @@ -60,7 +60,11 @@ close($in); # write out the new rcfile -open(my $out, ">$rcfile") or die "Failed to open $rcfile for writing"; +my $out; +if (!open($out, ">$rcfile")) { + chmod 0644, $rcfile; + open($out, ">$rcfile") or die "Failed to open $rcfile for writing"; +} print $out $outtext; close($out); ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Perl-Win32-GUI-Hackers mailing list Perl-Win32-GUI-Hackers@... https://lists.sourceforge.net/lists/listinfo/perl-win32-gui-hackers http://perl-win32-gui.sourceforge.net/ |
|
|
Re: cygwin patches for 1.05
by Robert May-5
::
Rate this Message:
On 28/07/07, Reini Urban <rurban@...> wrote:
> Attached is simple patch which fixes two issues: > > * GUI.rc is readonly in the downloaded archive, and therefore > build_tools/updateRC.pl fails to write it. Thanks. Applied with additional tweaks to updateRC.pl and Makefile, so that GUI.rc does not get re-written if it does not change. > * gcc-3.4 issues a warning if -Wdeclaration-after-statement is used > with .cpp files (c++ mode). Thanks, applied. I assume it is a later version of MakeMaker than I have (6.17) that adds the -Wdeclaration-after-statement flag, as I don't see any warnings when building under cygwin with gcc 3.4.4. > And I also waiting for my big CustomDraw patch. I haven't forgotten it, just don't have enough tuits. There's more than just the CustomDraw stuff that I'm sitting on from you (including a promise to change the way the samples get copied so that make doesn't spew lots of warnings) Changes are in my local copy, and will make it to CVS shortly. Regards, Rob. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Perl-Win32-GUI-Hackers mailing list Perl-Win32-GUI-Hackers@... https://lists.sourceforge.net/lists/listinfo/perl-win32-gui-hackers http://perl-win32-gui.sourceforge.net/ |
|
|
Re: cygwin patches for 1.05
by Reini Urban
::
Rate this Message:
Robert May schrieb:
> On 28/07/07, Reini Urban <rurban@...> wrote: >> Attached is simple patch which fixes two issues: >> >> * GUI.rc is readonly in the downloaded archive, and therefore >> build_tools/updateRC.pl fails to write it. > > Thanks. Applied with additional tweaks to updateRC.pl and Makefile, > so that GUI.rc does not get re-written if it does not change. > >> * gcc-3.4 issues a warning if -Wdeclaration-after-statement is used >> with .cpp files (c++ mode). > > Thanks, applied. I assume it is a later version of MakeMaker than I > have (6.17) that adds the -Wdeclaration-after-statement flag, as I > don't see any warnings when building under cygwin with gcc 3.4.4. > >> And I also waiting for my big CustomDraw patch. > > I haven't forgotten it, just don't have enough tuits. There's more > than just the CustomDraw stuff that I'm sitting on from you (including > a promise to change the way the samples get copied so that make > doesn't spew lots of warnings) Ah yes almost forgot that. Just tried a new cvs up and make ended again at copying the samples. > Changes are in my local copy, and will make it to CVS shortly. Thanks. I use it daily. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Perl-Win32-GUI-Hackers mailing list Perl-Win32-GUI-Hackers@... https://lists.sourceforge.net/lists/listinfo/perl-win32-gui-hackers http://perl-win32-gui.sourceforge.net/ |
|
|
Re: cygwin patches for 1.05
by Robert May-5
::
Rate this Message:
On 30/07/07, Robert May <robertemay@...> wrote:
> > Changes are in my local copy, and will make it to CVS shortly. Quicker than I expected! In CVS now. Regards, Rob. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Perl-Win32-GUI-Hackers mailing list Perl-Win32-GUI-Hackers@... https://lists.sourceforge.net/lists/listinfo/perl-win32-gui-hackers http://perl-win32-gui.sourceforge.net/ |
|
|
Re: cygwin patches for 1.05
by Reini Urban
::
Rate this Message:
Reini Urban schrieb:
> Robert May schrieb: >> I haven't forgotten it, just don't have enough tuits. There's more >> than just the CustomDraw stuff that I'm sitting on from you (including >> a promise to change the way the samples get copied so that make >> doesn't spew lots of warnings) > > Ah yes almost forgot that. Just tried a new cvs up and make ended again > at copying the samples. My patch fixed that, for CVS only: $ cvs up $ make ... Creating per package POD for Win32::GUI v1.05_02 on 31 Jul 2007 /bin/perl.exe "-MExtUtils::Command" -e mkpath blib/lib/Win32/GUI/demos cp samples/* blib/lib/Win32/GUI/demos cp: omitting directory `samples/CVS' make: [demos] Error 1 (ignored) ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Perl-Win32-GUI-Hackers mailing list Perl-Win32-GUI-Hackers@... https://lists.sourceforge.net/lists/listinfo/perl-win32-gui-hackers http://perl-win32-gui.sourceforge.net/ |
| Free embeddable forum powered by Nabble | Forum Help |
