dbus no_x11

[Vladimir Kirillov-2]

Hello ports@!

This diff is to detach dependency of X for dbus.
(my #1-goal is to be able install avahi on X-less router
later)

Index: Makefile
===================================================================
RCS file: /cvs/ports/x11/dbus/Makefile,v
retrieving revision 1.31
diff -N -u -p Makefile
--- Makefile    10 Oct 2009 14:30:47 -0000      1.31
+++ Makefile    2 Nov 2009 22:35:52 -0000
@@ -17,14 +17,16 @@ PERMIT_DISTFILES_FTP=       Yes
 PERMIT_PACKAGE_CDROM=  Yes
 PERMIT_PACKAGE_FTP=    Yes
 
-WANTLIB=       ICE X11 Xau Xdmcp SM c expat pthread pthread-stubs xcb
+FLAVORS=       no_x11
+FLAVOR?=      
 
+WANTLIB=       c expat pthread
+
 MASTER_SITES=  ${HOMEPAGE}/releases/dbus/
 
 SEPARATE_BUILD=        simple
 
 USE_LIBTOOL=   Yes
-USE_X11=       Yes
 
 CONFIGURE_STYLE= gnu
 CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" \
@@ -41,6 +43,13 @@ CONFIGURE_ARGS=      --localstatedir=/var \
 #CONFIGURE_ARGS+=      --enable-verbose-mode
 
 FAKE_FLAGS=    sysconfdir=${TRUEPREFIX}/share/examples/dbus
+
+.if ${FLAVOR:L:Mno_x11}
+CONFIGURE_ARGS+= --without-x
+.else
+WANTLIB+=      ICE X11 Xau Xdmcp SM pthread-stubs xcb
+USE_X11=       Yes
+.endif
 
 pre-configure:
        @${SUBST_CMD} ${WRKSRC}/bus/dbus-daemon.1 ${WRKSRC}/tools/dbus-uuidgen.1

[Antoine Jacoutot-7]

On Tue, 3 Nov 2009, Vladimir Kirillov wrote:

> Hello ports@!
>
> This diff is to detach dependency of X for dbus.
> (my #1-goal is to be able install avahi on X-less router
> later)

IMHO, buy a bigger disk^memory card, untar xbase and be done with it.

--
Antoine

[Sergey Prysiazhnyi]

On Tue, Nov 03, 2009 at 07:18:54AM +0100, Antoine Jacoutot wrote:
> On Tue, 3 Nov 2009, Vladimir Kirillov wrote:
>
> > Hello ports@!
> >
> > This diff is to detach dependency of X for dbus.
> > (my #1-goal is to be able install avahi on X-less router
> > later)
>
> IMHO, buy a bigger disk^memory card, untar xbase and be done with it.

Yes, but if we are talking about small embedded solution like
http://www.pcengines.ch/alix.htm , http://www.andahammer.com/mini244/ , etc with
only 1-4GB CF and other services run on it those need disk space?

IMHO, really make sense.

[Antoine Jacoutot-7]

On Tue, 3 Nov 2009, Sergey Prysiazhnyi wrote:

> On Tue, Nov 03, 2009 at 07:18:54AM +0100, Antoine Jacoutot wrote:
> > On Tue, 3 Nov 2009, Vladimir Kirillov wrote:
> >
> > > Hello ports@!
> > >
> > > This diff is to detach dependency of X for dbus.
> > > (my #1-goal is to be able install avahi on X-less router
> > > later)
> >
> > IMHO, buy a bigger disk^memory card, untar xbase and be done with it.
>
> Yes, but if we are talking about small embedded solution like
> http://www.pcengines.ch/alix.htm , http://www.andahammer.com/mini244/ , etc with
> only 1-4GB CF and other services run on it those need disk space?
>
> IMHO, really make sense.

I really don't like this. FLAVORS add to maintainership pain and require
the package to be built as much as enabled FLAVORS on bulks.
I don't see how OpenBSD+xsets+dbus+avahi would not fit on a 1Gb space.

If you want a specific solution, I'd say compile your own stuff.
Of course, this is only my opinion, other devs may think differently...

--
Antoine

[Antoine Jacoutot-7]

On Tue, 3 Nov 2009, Antoine Jacoutot wrote:
> I really don't like this. FLAVORS add to maintainership pain and require
> the package to be built as much as enabled FLAVORS on bulks.

Oh and I forgot to say that flavors that are not enabled are usually
poorly tested (if ever for some...).

--
Antoine

[Landry Breuil-6]

On Tue, Nov 03, 2009 at 03:00:41PM +0100, Antoine Jacoutot wrote:

> On Tue, 3 Nov 2009, Sergey Prysiazhnyi wrote:
>
> > On Tue, Nov 03, 2009 at 07:18:54AM +0100, Antoine Jacoutot wrote:
> > > On Tue, 3 Nov 2009, Vladimir Kirillov wrote:
> > >
> > > > Hello ports@!
> > > >
> > > > This diff is to detach dependency of X for dbus.
> > > > (my #1-goal is to be able install avahi on X-less router
> > > > later)
> > >
> > > IMHO, buy a bigger disk^memory card, untar xbase and be done with it.
> >
> > Yes, but if we are talking about small embedded solution like
> > http://www.pcengines.ch/alix.htm , http://www.andahammer.com/mini244/ , etc with
> > only 1-4GB CF and other services run on it those need disk space?
> >
> > IMHO, really make sense.
>
> I really don't like this. FLAVORS add to maintainership pain and require
> the package to be built as much as enabled FLAVORS on bulks.
> I don't see how OpenBSD+xsets+dbus+avahi would not fit on a 1Gb space.
>
> If you want a specific solution, I'd say compile your own stuff.
> Of course, this is only my opinion, other devs may think differently...

I'm with antoine here. We already have a flavor mess for avahi, don't
add some mess to dbus. Just use plain dbus package and untar only the
X libs needed for DBUS from xbase.tgz.

Landry

[Stuart Henderson]

On 2009/11/03 15:00, Antoine Jacoutot wrote:

> On Tue, 3 Nov 2009, Sergey Prysiazhnyi wrote:
>
> > On Tue, Nov 03, 2009 at 07:18:54AM +0100, Antoine Jacoutot wrote:
> > > On Tue, 3 Nov 2009, Vladimir Kirillov wrote:
> > >
> > > > Hello ports@!
> > > >
> > > > This diff is to detach dependency of X for dbus.
> > > > (my #1-goal is to be able install avahi on X-less router
> > > > later)
> > >
> > > IMHO, buy a bigger disk^memory card, untar xbase and be done with it.
> >
> > Yes, but if we are talking about small embedded solution like
> > http://www.pcengines.ch/alix.htm , http://www.andahammer.com/mini244/ , etc with
> > only 1-4GB CF and other services run on it those need disk space?
> >
> > IMHO, really make sense.
>
> I really don't like this. FLAVORS add to maintainership pain and require
> the package to be built as much as enabled FLAVORS on bulks.
> I don't see how OpenBSD+xsets+dbus+avahi would not fit on a 1Gb space.
>
> If you want a specific solution, I'd say compile your own stuff.
> Of course, this is only my opinion, other devs may think differently...

I do see that it might be useful, but given the huge set of
packages which depend on dbus and/or avahi, there is no way
we can properly get things tested against no_x11 flavours,
so for quality control purposes I agree with you, this
shouldn't go in the tree.

And really, if you're building enough systems that the price
difference of larger storage is an issue, you should be able
to handle a few custom changes to ports here and there.