does 1.3.9 not find ANY bugs?

[captainmidnight]

I last used 1.3.8 several months ago on my personal code library, and it found several bugs (as well as many more non-bugs, but thats the nature of these things).

I have made a lot of changes to my code library since then, so this morning I wanted to reanalyse.  First thing that I did was download 1.3.9 since it ought to be better.  When I ran it (from a .bat script file), it spent the usual minute or so analysing my code, and then it reported ZERO bugs!

Puzzled, I reinstalled 1.3.8 and reran my .bat file, and sure enough, 68 "bugs" were flagged.  (Probably most of them are not true bugs, but we'll see when I analyse them in more detail later.)

Does anyone have any idea what happened here?  Is 1.3.9 really just that good at not flagging bogus bugs?  Or (probably more likely) is there a usage error on my part, like some new kind of option that I have not configured?

Below is the relevant part of my .bat file (notice that I AM using -effort:max):

set findBugsDir=C:\Program Files\Java\findbugs-1.3.9\bin

set effort=-effort:max

set project=-project [code path relevant only to me]

set properties=-property "findbugs.assertionmethods=bb.util.Check.notNull"
set properties=%properties%  -property "findbugs.de.comment=true"
set properties=%properties%  -property "findbugs.maskedfields.locals=true"

cmd /c  "cd  /d  %findBugsDir%  &&  findbugs.bat  %effort%  %project%  %properties%"


I searched this list's archives before posting, and did not seem to see anything.



     
_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss

[captainmidnight]

One more thing: when the FindBugs 1.3.9 GUI came up, I looked under the
View menu, and verified that all the settings were for maximum
viewability.

In particular, the following choices were selected: All bug ranks, All issues, No matter when first seen.  I never changed these choices in the first place (I think that they
are the defaults).


     
_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss

[John Penix]

Hi Brent,

Put a bug in your code and see if it finds it.

John

On Wed, Nov 4, 2009 at 10:02 AM, Brent <yhbrent@...> wrote:

> One more thing: when the FindBugs 1.3.9 GUI came up, I looked under the
> View menu, and verified that all the settings were for maximum
> viewability.
>
> In particular, the following choices were selected: All bug ranks, All issues, No matter when first seen.  I never changed these choices in the first place (I think that they
> are the defaults).
>
>
>
> _______________________________________________
> Findbugs-discuss mailing list
> Findbugs-discuss@...
> https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss
>

_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss

[captainmidnight]

John:


> Put a bug in your code and see if it finds it.

OK.  I picked a random class and added this:
   
static {
    Object obj = null;
    System.out.println( obj.toString() );
}

It compiles with no warning.

Running 1.3.8 yields, as expected, this bug:
    Null pointer dereference

Running 1.3.9 yields, again, no bugs.

I cannot believe that 1.3.9 would have removed this bug pattern, so there obviously has to be something wrong in my configuration of 1.3.9.  I just can't see it.

All I did was download 1.3.9, unzip it, and then update my .bat script file to run with its findbugs.bat script file instead of 1.3.8's.  No other configuration changes.


NOTE: to the find bugs developers: it would be nice if you could copy text from the 2 bottom TextAreas in the gui.


     
_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss

[Bill Pugh]

Brent,
   Yeah, sounds like some sort of problem. No changes that big between  
1.3.8 and 1.3.9.

   Is your code open or closed source?

   Can you try analyzing it on the command line or in ant, and  
generating xml? The XML will contain a bunch of diagnostic information.
Alternatively, you can do "Save as..." from the GUI, select "Findbugs  
analysis file", and that will save the XML.

   If nothing else, look for the following entries in the XML:

      <Errors ...>

and

    <FindBugsSummary...>

FindBugs summary shouldn't contain any confidential data, and the  
<Errors> start tag shouldn't contain any either (the nested elements
inside the <Errors> tag might list class names.

Can you send those to me?


Bill

On Nov 4, 2009, at 4:11 PM, Brent wrote:

> John:
>
>
>> Put a bug in your code and see if it finds it.
>
> OK.  I picked a random class and added this:
>
> static {
>    Object obj = null;
>    System.out.println( obj.toString() );
> }
>
> It compiles with no warning.
>
> Running 1.3.8 yields, as expected, this bug:
>    Null pointer dereference
>
> Running 1.3.9 yields, again, no bugs.
>
> I cannot believe that 1.3.9 would have removed this bug pattern, so  
> there obviously has to be something wrong in my configuration of  
> 1.3.9.  I just can't see it.
>
> All I did was download 1.3.9, unzip it, and then update my .bat  
> script file to run with its findbugs.bat script file instead of  
> 1.3.8's.  No other configuration changes.
>
>
> NOTE: to the find bugs developers: it would be nice if you could  
> copy text from the 2 bottom TextAreas in the gui.
>
>
>
> _______________________________________________
> Findbugs-discuss mailing list
> Findbugs-discuss@...
> https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss

_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss

[captainmidnight]

Since I suspect that 1.3.9's not reporting any bugs is probably due to a misconfiguration on my part, I did a diff between the findbugs.bat files in 1.3.8 and 1.3.9.

1.3.9's version has a LOT more stuff inside.  Tons of options like
    -addMessages
    -computeBugHistory
etc.

As near as I can tell, these are all undocumented in the current manual
    http://findbugs.sourceforge.net/manual/running.html
especially
    http://findbugs.sourceforge.net/manual/running.html#d0e511
and
    http://findbugs.sourceforge.net/manual/running.html#commandLineOptions

Guessing, I tried adding a few of those options to my .bat file, but they all seemed to make FB abort.

Does anyone know if I am not seeing bugs being reported because I need to update the options that I use with findbugs.bat?



     
_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss