egl_dri2: Checking for xcb/dri2.h and xcb/xfixes.h

[Sedat Dilek]

Hi,

I was trying to build a mesa snapshot from GIT master and egl_dri2
seems to be broken on first sight (see below for build.log).

As egl_dri2 is build by-default, you can "workaround" the problem by
setting explicitly --disable-egl to configure-line.

Alternatively, for example Debian-systems (tested on sid 32-bit) please install:

# apt-get install libxcb-xfixes0-dev libxcb-dri2-0-dev

Shouldn't there be a more rough depend-checking on XCB_DRI2
(libxcb-1.6) in configure.ac?
With "rough" I mean to stop immediately the build, so someone can
check for the missing packages.


Kind Regards,
- Sedat -


[build.log]
...
checking for XCB_DRI2... no
        Use XCB:         no
...
make[4]: Entering directory `/home/sd/src/mesa/mesa/src/egl/drivers/dri2'
ccache gcc -c -I../../../../include -I../../../../src/egl/main
-I../../../../src/mapi -DDEFAULT_DRIVER_DIR=\"/usr/lib/dri\"
-I/usr/include/libdrm   -g -O2 -Wall -Wmissing-prototypes -std=c99
-ffast-math -fvisibility=hidden -fno-strict-aliasing -g  -fPIC
-DUSE_X86_ASM -DUSE_MMX_ASM -DUSE_3DNOW_ASM -DUSE_SSE_ASM
-D_GNU_SOURCE -DPTHREADS -DDEBUG -DHAVE_POSIX_MEMALIGN -DGLX_USE_TLS
-DPTHREADS -DUSE_EXTERNAL_DXTN_LIB=1 -DIN_DRI_DRIVER
-DGLX_DIRECT_RENDERING -DGLX_INDIRECT_RENDERING -DHAVE_ALIAS
-DHAVE_LIBUDEV  egl_dri2.c -o egl_dri2.o
egl_dri2.c:40:22: error: xcb/dri2.h: No such file or directory
egl_dri2.c:41:24: error: xcb/xfixes.h: No such file or directory
egl_dri2.c:104: error: expected specifier-qualifier-list before
'xcb_xfixes_region_t'
egl_dri2.c:292: error: expected declaration specifiers or '...' before
'xcb_dri2_dri2_buffer_t'
egl_dri2.c: In function 'dri2_process_buffers':
egl_dri2.c:300: error: 'struct dri2_egl_surface' has no member named
'have_fake_front'
egl_dri2.c:305: error: 'buffers' undeclared (first use in this function)
egl_dri2.c:305: error: (Each undeclared identifier is reported only once
egl_dri2.c:305: error: for each function it appears in.)
egl_dri2.c:317: error: 'struct dri2_egl_surface' has no member named
'have_fake_front'
egl_dri2.c:320: error: 'struct dri2_egl_surface' has no member named 'region'
egl_dri2.c:321: warning: implicit declaration of function
'xcb_xfixes_destroy_region'
egl_dri2.c:321: error: 'struct dri2_egl_surface' has no member named 'region'
egl_dri2.c:327: error: 'struct dri2_egl_surface' has no member named 'region'
egl_dri2.c:328: warning: implicit declaration of function
'xcb_xfixes_create_region'
egl_dri2.c:328: error: 'struct dri2_egl_surface' has no member named 'region'
egl_dri2.c: In function 'dri2_get_buffers':
egl_dri2.c:340: error: 'xcb_dri2_dri2_buffer_t' undeclared (first use
in this function)
egl_dri2.c:340: error: 'buffers' undeclared (first use in this function)
egl_dri2.c:341: error: 'xcb_dri2_get_buffers_reply_t' undeclared
(first use in this function)
egl_dri2.c:341: error: 'reply' undeclared (first use in this function)
egl_dri2.c:342: error: 'xcb_dri2_get_buffers_cookie_t' undeclared
(first use in this function)
egl_dri2.c:342: error: expected ';' before 'cookie'
egl_dri2.c:344: error: 'cookie' undeclared (first use in this function)
egl_dri2.c:344: warning: implicit declaration of function
'xcb_dri2_get_buffers_unchecked'
egl_dri2.c:347: warning: implicit declaration of function
'xcb_dri2_get_buffers_reply'
egl_dri2.c:348: warning: implicit declaration of function
'xcb_dri2_get_buffers_buffers'
egl_dri2.c:355: error: too many arguments to function 'dri2_process_buffers'
egl_dri2.c: In function 'dri2_get_buffers_with_format':
egl_dri2.c:407: error: 'xcb_dri2_dri2_buffer_t' undeclared (first use
in this function)
egl_dri2.c:407: error: 'buffers' undeclared (first use in this function)
egl_dri2.c:408: error: 'xcb_dri2_get_buffers_with_format_reply_t'
undeclared (first use in this function)
egl_dri2.c:408: error: 'reply' undeclared (first use in this function)
egl_dri2.c:409: error: 'xcb_dri2_get_buffers_with_format_cookie_t'
undeclared (first use in this function)
egl_dri2.c:409: error: expected ';' before 'cookie'
egl_dri2.c:410: error: 'xcb_dri2_attach_format_t' undeclared (first
use in this function)
egl_dri2.c:410: error: 'format_attachments' undeclared (first use in
this function)
egl_dri2.c:412: error: expected expression before ')' token
egl_dri2.c:413: error: 'cookie' undeclared (first use in this function)
egl_dri2.c:413: warning: implicit declaration of function
'xcb_dri2_get_buffers_with_format_unchecked'
egl_dri2.c:418: warning: implicit declaration of function
'xcb_dri2_get_buffers_with_format_reply'
egl_dri2.c:423: warning: implicit declaration of function
'xcb_dri2_get_buffers_with_format_buffers'
egl_dri2.c:427: error: too many arguments to function 'dri2_process_buffers'
egl_dri2.c: In function 'dri2_connect':
egl_dri2.c:506: error: 'xcb_xfixes_query_version_reply_t' undeclared
(first use in this function)
egl_dri2.c:506: error: 'xfixes_query' undeclared (first use in this function)
egl_dri2.c:507: error: 'xcb_xfixes_query_version_cookie_t' undeclared
(first use in this function)
egl_dri2.c:507: error: expected ';' before 'xfixes_query_cookie'
egl_dri2.c:508: error: 'xcb_dri2_query_version_reply_t' undeclared
(first use in this function)
egl_dri2.c:508: error: 'dri2_query' undeclared (first use in this function)
egl_dri2.c:509: error: 'xcb_dri2_query_version_cookie_t' undeclared
(first use in this function)
egl_dri2.c:509: error: expected ';' before 'dri2_query_cookie'
egl_dri2.c:510: error: 'xcb_dri2_connect_reply_t' undeclared (first
use in this function)
egl_dri2.c:510: error: 'connect' undeclared (first use in this function)
egl_dri2.c:511: error: 'xcb_dri2_connect_cookie_t' undeclared (first
use in this function)
egl_dri2.c:511: error: expected ';' before 'connect_cookie'
egl_dri2.c:515: error: 'xcb_xfixes_id' undeclared (first use in this function)
egl_dri2.c:516: error: 'xcb_dri2_id' undeclared (first use in this function)
egl_dri2.c:518: error: 'xfixes_query_cookie' undeclared (first use in
this function)
egl_dri2.c:518: warning: implicit declaration of function
'xcb_xfixes_query_version'
egl_dri2.c:519: error: 'XCB_XFIXES_MAJOR_VERSION' undeclared (first
use in this function)
egl_dri2.c:520: error: 'XCB_XFIXES_MINOR_VERSION' undeclared (first
use in this function)
egl_dri2.c:522: error: 'dri2_query_cookie' undeclared (first use in
this function)
egl_dri2.c:522: warning: implicit declaration of function
'xcb_dri2_query_version'
egl_dri2.c:523: error: 'XCB_DRI2_MAJOR_VERSION' undeclared (first use
in this function)
egl_dri2.c:524: error: 'XCB_DRI2_MINOR_VERSION' undeclared (first use
in this function)
egl_dri2.c:527: error: 'connect_cookie' undeclared (first use in this function)
egl_dri2.c:527: warning: implicit declaration of function
'xcb_dri2_connect_unchecked'
egl_dri2.c:529: error: 'XCB_DRI2_DRIVER_TYPE_DRI' undeclared (first
use in this function)
egl_dri2.c:532: warning: implicit declaration of function
'xcb_xfixes_query_version_reply'
egl_dri2.c:543: warning: implicit declaration of function
'xcb_dri2_query_version_reply'
egl_dri2.c:553: warning: implicit declaration of function
'xcb_dri2_connect_reply'
egl_dri2.c:561: warning: implicit declaration of function
'xcb_dri2_connect_device_name'
egl_dri2.c:562: warning: implicit declaration of function
'xcb_dri2_connect_device_name_length'
egl_dri2.c:565: warning: implicit declaration of function
'xcb_dri2_connect_driver_name'
egl_dri2.c:566: warning: implicit declaration of function
'xcb_dri2_connect_driver_name_length'
egl_dri2.c: In function 'dri2_authenticate':
egl_dri2.c:582: error: 'xcb_dri2_authenticate_reply_t' undeclared
(first use in this function)
egl_dri2.c:582: error: 'authenticate' undeclared (first use in this function)
egl_dri2.c:583: error: 'xcb_dri2_authenticate_cookie_t' undeclared
(first use in this function)
egl_dri2.c:583: error: expected ';' before 'authenticate_cookie'
egl_dri2.c:593: error: 'authenticate_cookie' undeclared (first use in
this function)
egl_dri2.c:594: warning: implicit declaration of function
'xcb_dri2_authenticate_unchecked'
egl_dri2.c:596: warning: implicit declaration of function
'xcb_dri2_authenticate_reply'
egl_dri2.c: In function 'dri2_destroy_surface':
egl_dri2.c:1117: warning: implicit declaration of function
'xcb_dri2_destroy_drawable'
egl_dri2.c: In function 'dri2_create_surface':
egl_dri2.c:1196: error: 'struct dri2_egl_surface' has no member named 'region'
egl_dri2.c:1216: warning: implicit declaration of function
'xcb_dri2_create_drawable'
egl_dri2.c: At top level:
egl_dri2.c:1276: error: expected declaration specifiers or '...'
before 'xcb_xfixes_region_t'
egl_dri2.c: In function 'dri2_copy_region':
egl_dri2.c:1282: error: 'xcb_dri2_copy_region_cookie_t' undeclared
(first use in this function)
egl_dri2.c:1282: error: expected ';' before 'cookie'
egl_dri2.c:1303: error: 'struct dri2_egl_surface' has no member named
'have_fake_front'
egl_dri2.c:1306: error: 'cookie' undeclared (first use in this function)
egl_dri2.c:1306: warning: implicit declaration of function
'xcb_dri2_copy_region_unchecked'
egl_dri2.c:1308: error: 'region' undeclared (first use in this function)
egl_dri2.c:1309: error: 'XCB_DRI2_ATTACHMENT_BUFFER_FRONT_LEFT'
undeclared (first use in this function)
egl_dri2.c:1310: error: 'XCB_DRI2_ATTACHMENT_BUFFER_FAKE_FRONT_LEFT'
undeclared (first use in this function)
egl_dri2.c:1311: warning: implicit declaration of function
'xcb_dri2_copy_region_reply'
egl_dri2.c: In function 'dri2_swap_buffers':
#!/bin/bash
egl_dri2.c:1321: error: 'struct dri2_egl_surface' has no member named 'region'
egl_dri2.c:1321: error: too many arguments to function 'dri2_copy_region'
egl_dri2.c: In function 'dri2_swap_buffers_region':
egl_dri2.c:1331: error: 'xcb_xfixes_region_t' undeclared (first use in
this function)
egl_dri2.c:1331: error: expected ';' before 'region'
egl_dri2.c:1336: error: 'struct dri2_egl_surface' has no member named 'region'
egl_dri2.c:1336: error: too many arguments to function 'dri2_copy_region'
egl_dri2.c:1346: error: 'region' undeclared (first use in this function)
egl_dri2.c:1348: error: too many arguments to function 'dri2_copy_region'
egl_dri2.c: In function 'dri2_create_image_khr_pixmap':
egl_dri2.c:1479: error: 'xcb_dri2_get_buffers_cookie_t' undeclared
(first use in this function)
egl_dri2.c:1479: error: expected ';' before 'buffers_cookie'
egl_dri2.c:1480: error: 'xcb_dri2_get_buffers_reply_t' undeclared
(first use in this function)
egl_dri2.c:1480: error: 'buffers_reply' undeclared (first use in this function)
egl_dri2.c:1481: error: 'xcb_dri2_dri2_buffer_t' undeclared (first use
in this function)
egl_dri2.c:1481: error: 'buffers' undeclared (first use in this function)
egl_dri2.c:1489: error: 'XCB_DRI2_ATTACHMENT_BUFFER_FRONT_LEFT'
undeclared (first use in this function)
egl_dri2.c:1490: error: 'buffers_cookie' undeclared (first use in this function)
make[4]: *** [egl_dri2.o] Error 1
make[4]: Leaving directory `/home/sd/src/mesa/mesa/src/egl/drivers/dri2'
make[3]: *** [subdirs] Error 1
make[3]: Leaving directory `/home/sd/src/mesa/mesa/src/egl/drivers'
make[2]: *** [subdirs] Error 1
make[2]: Leaving directory `/home/sd/src/mesa/mesa/src/egl'
make[1]: *** [subdirs] Error 1
make[1]: Leaving directory `/home/sd/src/mesa/mesa/src'
make: *** [default] Error 1

real 2m25.097s
user 3m46.417s
sys 0m18.615s
[1]+  Exit 2                  ./build_mesa-with-gallium-radeon.sh >
build.log 2>&1

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@...
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

[Sedat Dilek]

On Tue, Jul 13, 2010 at 5:25 PM, Sedat Dilek <sedat.dilek@...> wrote:
[...]
> Shouldn't there be a more rough depend-checking on XCB_DRI2
> (libxcb-1.6) in configure.ac?
> With "rough" I mean to stop immediately the build, so someone can
> check for the missing packages.
>

Looking at [1] feom

Commit 2168b87b51e70e8ad914e547c6c922fc33af3a89
"egl_dri2: Support _EGL_PLATFORM_DRM"

[configure.ac]
...
 # build egl_dri2 when xcb-dri2 is available
- PKG_CHECK_MODULES([EGL_DRI2], [x11-xcb xcb-dri2 xcb-xfixes libdrm],
+ PKG_CHECK_MODULES([XCB_DRI2], [x11-xcb xcb-dri2 xcb-xfixes],
[have_xcb_dri2=yes],[have_xcb_dri2=no])
+ PKG_CHECK_MODULES([LIBUDEV], [libudev > 150],
+ [have_libudev=yes],[have_libudev=no])
+
if test "$have_xcb_dri2" = yes; then
- EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS dri2"
+ EGL_DRIVER_DRI2=dri2
+ DEFINES="$DEFINES -DHAVE_XCB_DRI2"
+ fi
+
+ if test "$have_libudev" = yes; then
+ EGL_DRIVER_DRI2=dri2
+ DEFINES="$DEFINES -DHAVE_LIBUDEV"
fi
+
+ EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS $EGL_DRIVER_DRI2"
...

So if $have_xcb_dri2 is false, but $have_libudev true,
$EGL_DRIVER_DRI2 is set to "dri2" and the compilation of egl_dri2 will
be broken.

What about...?

- EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS $EGL_DRIVER_DRI2"
+ if test "$have_xcb_dri2" = no; then
+  EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS"
+ else
+   EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS $EGL_DRIVER_DRI2"
+ fi

- Sedat -

[1]
http://cgit.freedesktop.org/mesa/mesa/diff/configure.ac?id=2168b87b51e70e8ad914e547c6c922fc33af3a89

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@...
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

[Chia-I Wu-2]

On Wed, Jul 14, 2010 at 1:53 AM, Sedat Dilek <sedat.dilek@...> wrote:

> On Tue, Jul 13, 2010 at 5:25 PM, Sedat Dilek <sedat.dilek@...> wrote:
> [...]
>> Shouldn't there be a more rough depend-checking on XCB_DRI2
>> (libxcb-1.6) in configure.ac?
>> With "rough" I mean to stop immediately the build, so someone can
>> check for the missing packages.
>>
>
> Looking at [1] feom
>
> Commit 2168b87b51e70e8ad914e547c6c922fc33af3a89
> "egl_dri2: Support _EGL_PLATFORM_DRM"
>
> [configure.ac]
> ...
>  # build egl_dri2 when xcb-dri2 is available
> - PKG_CHECK_MODULES([EGL_DRI2], [x11-xcb xcb-dri2 xcb-xfixes libdrm],
> + PKG_CHECK_MODULES([XCB_DRI2], [x11-xcb xcb-dri2 xcb-xfixes],
> [have_xcb_dri2=yes],[have_xcb_dri2=no])
> + PKG_CHECK_MODULES([LIBUDEV], [libudev > 150],
> + [have_libudev=yes],[have_libudev=no])
> +
> if test "$have_xcb_dri2" = yes; then
> - EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS dri2"
> + EGL_DRIVER_DRI2=dri2
> + DEFINES="$DEFINES -DHAVE_XCB_DRI2"
> + fi
> +
> + if test "$have_libudev" = yes; then
> + EGL_DRIVER_DRI2=dri2
> + DEFINES="$DEFINES -DHAVE_LIBUDEV"
> fi
> +
> + EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS $EGL_DRIVER_DRI2"
> ...
>
> So if $have_xcb_dri2 is false, but $have_libudev true,
> $EGL_DRIVER_DRI2 is set to "dri2" and the compilation of egl_dri2 will
> be broken.
>
> What about...?
>
> - EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS $EGL_DRIVER_DRI2"
> + if test "$have_xcb_dri2" = no; then
> +  EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS"
> + else
> +   EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS $EGL_DRIVER_DRI2"
> + fi
>
> - Sedat -
>
> [1]
> http://cgit.freedesktop.org/mesa/mesa/diff/configure.ac?id=2168b87b51e70e8ad914e547c6c922fc33af3a89

I will commit a fix so that egl_dri2 is built only when xcb-dri2 is available.
I believe Krisitian wants to make xcb-dri2 optional, but it does not seem to be
the case right now.


--
olv@...

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@...
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

[Sedat Dilek]

On Fri, Jul 16, 2010 at 1:43 PM, Chia-I Wu <olvaffe@...> wrote:

> On Wed, Jul 14, 2010 at 1:53 AM, Sedat Dilek <sedat.dilek@...> wrote:
>> On Tue, Jul 13, 2010 at 5:25 PM, Sedat Dilek <sedat.dilek@...> wrote:
>> [...]
>>> Shouldn't there be a more rough depend-checking on XCB_DRI2
>>> (libxcb-1.6) in configure.ac?
>>> With "rough" I mean to stop immediately the build, so someone can
>>> check for the missing packages.
>>>
>>
>> Looking at [1] feom
>>
>> Commit 2168b87b51e70e8ad914e547c6c922fc33af3a89
>> "egl_dri2: Support _EGL_PLATFORM_DRM"
>>
>> [configure.ac]
>> ...
>>  # build egl_dri2 when xcb-dri2 is available
>> - PKG_CHECK_MODULES([EGL_DRI2], [x11-xcb xcb-dri2 xcb-xfixes libdrm],
>> + PKG_CHECK_MODULES([XCB_DRI2], [x11-xcb xcb-dri2 xcb-xfixes],
>> [have_xcb_dri2=yes],[have_xcb_dri2=no])
>> + PKG_CHECK_MODULES([LIBUDEV], [libudev > 150],
>> + [have_libudev=yes],[have_libudev=no])
>> +
>> if test "$have_xcb_dri2" = yes; then
>> - EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS dri2"
>> + EGL_DRIVER_DRI2=dri2
>> + DEFINES="$DEFINES -DHAVE_XCB_DRI2"
>> + fi
>> +
>> + if test "$have_libudev" = yes; then
>> + EGL_DRIVER_DRI2=dri2
>> + DEFINES="$DEFINES -DHAVE_LIBUDEV"
>> fi
>> +
>> + EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS $EGL_DRIVER_DRI2"
>> ...
>>
>> So if $have_xcb_dri2 is false, but $have_libudev true,
>> $EGL_DRIVER_DRI2 is set to "dri2" and the compilation of egl_dri2 will
>> be broken.
>>
>> What about...?
>>
>> - EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS $EGL_DRIVER_DRI2"
>> + if test "$have_xcb_dri2" = no; then
>> +  EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS"
>> + else
>> +   EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS $EGL_DRIVER_DRI2"
>> + fi
>>
>> - Sedat -
>>
>> [1]
>> http://cgit.freedesktop.org/mesa/mesa/diff/configure.ac?id=2168b87b51e70e8ad914e547c6c922fc33af3a89
> I will commit a fix so that egl_dri2 is built only when xcb-dri2 is available.
> I believe Krisitian wants to make xcb-dri2 optional, but it does not seem to be
> the case right now.
>
>
> --
> olv@...
>

Sounds good to me, thanks for your attention.

- Sedat -

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@...
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

[Kristian Høgsberg]

On Fri, Jul 16, 2010 at 7:59 AM, Sedat Dilek <sedat.dilek@...> wrote:

> On Fri, Jul 16, 2010 at 1:43 PM, Chia-I Wu <olvaffe@...> wrote:
>> On Wed, Jul 14, 2010 at 1:53 AM, Sedat Dilek <sedat.dilek@...> wrote:
>>> On Tue, Jul 13, 2010 at 5:25 PM, Sedat Dilek <sedat.dilek@...> wrote:
>>> [...]
>>>> Shouldn't there be a more rough depend-checking on XCB_DRI2
>>>> (libxcb-1.6) in configure.ac?
>>>> With "rough" I mean to stop immediately the build, so someone can
>>>> check for the missing packages.
>>>>
>>>
>>> Looking at [1] feom
>>>
>>> Commit 2168b87b51e70e8ad914e547c6c922fc33af3a89
>>> "egl_dri2: Support _EGL_PLATFORM_DRM"
>>>
>>> [configure.ac]
>>> ...
>>>  # build egl_dri2 when xcb-dri2 is available
>>> - PKG_CHECK_MODULES([EGL_DRI2], [x11-xcb xcb-dri2 xcb-xfixes libdrm],
>>> + PKG_CHECK_MODULES([XCB_DRI2], [x11-xcb xcb-dri2 xcb-xfixes],
>>> [have_xcb_dri2=yes],[have_xcb_dri2=no])
>>> + PKG_CHECK_MODULES([LIBUDEV], [libudev > 150],
>>> + [have_libudev=yes],[have_libudev=no])
>>> +
>>> if test "$have_xcb_dri2" = yes; then
>>> - EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS dri2"
>>> + EGL_DRIVER_DRI2=dri2
>>> + DEFINES="$DEFINES -DHAVE_XCB_DRI2"
>>> + fi
>>> +
>>> + if test "$have_libudev" = yes; then
>>> + EGL_DRIVER_DRI2=dri2
>>> + DEFINES="$DEFINES -DHAVE_LIBUDEV"
>>> fi
>>> +
>>> + EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS $EGL_DRIVER_DRI2"
>>> ...
>>>
>>> So if $have_xcb_dri2 is false, but $have_libudev true,
>>> $EGL_DRIVER_DRI2 is set to "dri2" and the compilation of egl_dri2 will
>>> be broken.
>>>
>>> What about...?
>>>
>>> - EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS $EGL_DRIVER_DRI2"
>>> + if test "$have_xcb_dri2" = no; then
>>> +  EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS"
>>> + else
>>> +   EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS $EGL_DRIVER_DRI2"
>>> + fi
>>>
>>> - Sedat -
>>>
>>> [1]
>>> http://cgit.freedesktop.org/mesa/mesa/diff/configure.ac?id=2168b87b51e70e8ad914e547c6c922fc33af3a89
>> I will commit a fix so that egl_dri2 is built only when xcb-dri2 is available.
>> I believe Krisitian wants to make xcb-dri2 optional, but it does not seem to be
>> the case right now.
>>
>>
>> --
>> olv@...
>>
>
> Sounds good to me, thanks for your attention.

Yup, sounds fine, thanks Chia-I.

Kristian

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@...
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev