emms-streams: adding streams with utf-8 chars does not work correctly

[Arnaud Fontaine-3]

Hello,

I received  this bug[0] (quite a  while ago I must  admit but completely
forgot about it,  really sorry about that) and I'm  able to reproduce it
with  emms 3.0, any  idea or  patch to  fix this  issue? Thanks  much in
advance for your reply.

Regards,
Arnaud Fontaine

[0] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=470251


_______________________________________________
Emms-help mailing list
Emms-help@...
http://lists.gnu.org/mailman/listinfo/emms-help

[Yoni Rabkin-2]

> [0] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=470251

This goes away if we change `insert-file-contents-literally' to
`insert-file-contents' in line 326 of "emms-streams.el".

Any reason not to install this change?

--
   "Cut your own wood and it will warm you twice"



_______________________________________________
Emms-help mailing list
Emms-help@...
http://lists.gnu.org/mailman/listinfo/emms-help

[Michael Olson-2]

On Tue, Aug 4, 2009 at 10:03 AM, Yoni Rabkin<yoni@...> wrote:
> Here is what emms-playlist-mode uses. I think it's good in this regard:
>
> ...
>  (let* ((s)
>         (buffer (find-file-noselect filename))
>         (name   (buffer-name buffer)))
>    (with-current-buffer buffer
>      (setq s (read (buffer-string))))
>    (kill-buffer buffer)

That also does major mode detection (and a whole host of other revert
magic).  I've already got the fix installed, and changed some other
instances to use it, just need to test it 8hrs from now.

Sorry for not replying to all, still getting used to new email client.

--
Michael Olson  ||  http://mwolson.org/
Projects: Emacs, Muse, ERC, EMMS


_______________________________________________
Emms-help mailing list
Emms-help@...
http://lists.gnu.org/mailman/listinfo/emms-help

[Michael Olson-2]

On Tue, Aug 4, 2009 at 11:01 AM, Michael Olson<mwolson@...> wrote:
> That also does major mode detection (and a whole host of other revert
> magic).  I've already got the fix installed, and changed some other
> instances to use it, just need to test it 8hrs from now.

I've checked in the fix.  It would be also nice to have that use of
find-file-noselect in emms-playlist-mode changed to use the new
emms-insert-file-contents function, but it's not that high priority.

--
Michael Olson  ||  http://mwolson.org/
Projects: Emacs, Muse, ERC, EMMS


_______________________________________________
Emms-help mailing list
Emms-help@...
http://lists.gnu.org/mailman/listinfo/emms-help

[Arnaud Fontaine-3]

>>>>> Yoni Rabkin <yoni@...> writes:

Hi,

    > This  goes away  if we change  `insert-file-contents-literally' to
    > `insert-file-contents' in line 326 of "emms-streams.el".

    > Any reason not to install this change?

I   have  just   noticed  that   you  have   committed  a   fix  (commit
3e001aacb45633583282001d49634e080deaf8d7). Thank you very much! BTW when
have you planned to release a new version (just wondering)?

Cheers,
Arnaud Fontaine


_______________________________________________
Emms-help mailing list
Emms-help@...
http://lists.gnu.org/mailman/listinfo/emms-help

[Michael Olson-2]

On Fri, Sep 18, 2009 at 3:54 AM, Arnaud Fontaine <arnau@...> wrote:
> I   have  just   noticed  that   you  have   committed  a   fix  (commit
> 3e001aacb45633583282001d49634e080deaf8d7). Thank you very much! BTW when
> have you planned to release a new version (just wondering)?

No idea.

--
Michael Olson  ||  http://mwolson.org/
Projects: Emacs, Muse, ERC, EMMS


_______________________________________________
Emms-help mailing list
Emms-help@...
http://lists.gnu.org/mailman/listinfo/emms-help