fix for bug 217879

View: New views
20 Messages — Rating Filter:   Alert me  
< Prev | 1 - 2 - 3 - 4 - 5 - 6 - 7 | Next >

Re: fix for bug 218084

by Guy Pelletier :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

The patch has been submitted.

Reviewed by: Tom Ware

No new tests were added. However, the existing xml extended advanced model
was modified to include an eclipselink-orm.xml file with the extended
mappings for that model. Hence reverting the
advanced-extended-entity-mappings.xml for that model back to its original
JPA format.

All tests (JPA and extended) should continue to pass without any errors.

Cheers,
Guy

----- Original Message -----
From: "Guy Pelletier" <guy.pelletier@...>
To: "Dev mailing list for Eclipse Persistence Services"
<eclipselink-dev@...>
Sent: Tuesday, May 20, 2008 1:30 PM
Subject: [eclipselink-dev] fix for bug 218084


>A patch file for bug 218084 is now available for review.
>
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=218084
>
> Description: Implement metadata merging functionality between mapping
> files
>
> Please review and provide any feedback.
>
> Cheers,
> Guy
>
> _______________________________________________
> eclipselink-dev mailing list
> eclipselink-dev@...
> https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
>

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

Bug 211330 - Add attributes-complete support to the EclipseLink-ORM.XML Schema

by Guy Pelletier :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Two suggestions to address the following bug have been documented.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=211330

Please review and provide any feedback.

Cheers,
Guy
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

Re: Bug 211330 - Add attributes-complete support to the EclipseLink-ORM.XML Schema

by Shaun Smith :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi Guy,

   Can you elaborate on the problem? Your initial description is:
Which is a flag to indicate not to auto-generate any unspecified attributes. This is important in XML when the class may continue to evolve.
When  you say "auto-generate" are you talking about DDL generation?  Can you provide an example of the issue?

     Shaun

Guy Pelletier wrote:
Two suggestions to address the following bug have been documented.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=211330

Please review and provide any feedback.

Cheers,
Guy
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

--


Oracle
Shaun Smith | Principal Product Manager, TopLink | +1.905.502.3094
Oracle Fusion Middleware
110 Matheson Boulevard West, Suite 100
Mississauga, Ontario, Canada L5R 3P4


_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

Re: Bug 211330 - Add attributes-complete support to the EclipseLink-ORM.XML Schema

by Guy Pelletier :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Some parts of this message have been removed. Learn more about Nabble's security policy.
Hi Shaun,
 
What we want to do is avoid processing the class for mapping defaults. Current deployment XML users specify their complete set of mappings within the XML file with no notion of EclipseLink inspecting those files for other 'default' mappings. Migrating these users to the new format (and metadata processing) we need to ensure there is a way to preserve this.
 
Currently, specify an xml-mapping-metadata-complete falls a little short of this functionality since it will use those mappings that are in XML and ignore annotations, however, the processing will still inspect the class for default mappings for basics, 1-1's, 1-M's and Variable1-1's.
 
Bug 218082 (conversion tool, current deployment XML -> new Eclipselink orm schema format) also depends on a solution to this bug.
 
Cheers,
Guy
----- Original Message -----
Sent: Wednesday, May 21, 2008 9:32 AM
Subject: Re: [eclipselink-dev] Bug 211330 - Add attributes-complete support to the EclipseLink-ORM.XML Schema

Hi Guy,

   Can you elaborate on the problem? Your initial description is:
Which is a flag to indicate not to auto-generate any unspecified attributes. This is important in XML when the class may continue to evolve.
When  you say "auto-generate" are you talking about DDL generation?  Can you provide an example of the issue?

     Shaun

Guy Pelletier wrote:
Two suggestions to address the following bug have been documented.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=211330

Please review and provide any feedback.

Cheers,
Guy
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

--


Oracle
Shaun Smith | Principal Product Manager, TopLink | +1.905.502.3094
Oracle Fusion Middleware
110 Matheson Boulevard West, Suite 100
Mississauga, Ontario, Canada L5R 3P4


_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

RE: Bug 211330 - Add attributes-complete support to the EclipseLink-ORM.XML Schema

by Michael Keith-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Some parts of this message have been removed. Learn more about Nabble's security policy.
Guy,
 
But xml-mapping-metadata-complete does mean that mapping defaults should be applied, so the current behavior is correct.
If we want to offer a feature that prevents this then we should have a separate option to not apply defaults.
 
-Mike
-----Original Message-----
From: GUY.PELLETIER@...
Sent: Wednesday, May 21, 2008 9:56 AM
To: shaun.smith@...; Dev mailing list for Eclipse Persistence Services
Subject: Re: [eclipselink-dev] Bug 211330 - Add attributes-complete support to the EclipseLink-ORM.XML Schema

Hi Shaun,
 
What we want to do is avoid processing the class for mapping defaults. Current deployment XML users specify their complete set of mappings within the XML file with no notion of EclipseLink inspecting those files for other 'default' mappings. Migrating these users to the new format (and metadata processing) we need to ensure there is a way to preserve this.
 
Currently, specify an xml-mapping-metadata-complete falls a little short of this functionality since it will use those mappings that are in XML and ignore annotations, however, the processing will still inspect the class for default mappings for basics, 1-1's, 1-M's and Variable1-1's.
 
Bug 218082 (conversion tool, current deployment XML -> new Eclipselink orm schema format) also depends on a solution to this bug.
 
Cheers,
Guy
----- Original Message -----
Sent: Wednesday, May 21, 2008 9:32 AM
Subject: Re: [eclipselink-dev] Bug 211330 - Add attributes-complete support to the EclipseLink-ORM.XML Schema

Hi Guy,

   Can you elaborate on the problem? Your initial description is:
Which is a flag to indicate not to auto-generate any unspecified attributes. This is important in XML when the class may continue to evolve.
When  you say "auto-generate" are you talking about DDL generation?  Can you provide an example of the issue?

     Shaun

Guy Pelletier wrote:
Two suggestions to address the following bug have been documented.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=211330

Please review and provide any feedback.

Cheers,
Guy
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

--


Oracle
Shaun Smith | Principal Product Manager, TopLink | +1.905.502.3094
Oracle Fusion Middleware
110 Matheson Boulevard West, Suite 100
Mississauga, Ontario, Canada L5R 3P4


_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

Re: Bug 211330 - Add attributes-complete support to the EclipseLink-ORM.XML Schema

by Guy Pelletier :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Some parts of this message have been removed. Learn more about Nabble's security policy.
Hi Mike,
 
Yes the xml-mapping-metadata-complete behavior is correct. I mentioned it only because questions arose in the past on the usage of this flag to solve this bug. I was simply highlighting why this flag does not solve our needs in this case.
 
Within the bug I presented two possible solutions. The first one, as you mentioned was a separate option/element, and the second one was to expand the existing xml-mapping-metadata-complete element in the EclipseLink orm.xml schema from an empty type to one that requires a type.
 
Cheers,
Guy
----- Original Message -----
Sent: Wednesday, May 21, 2008 1:57 PM
Subject: RE: [eclipselink-dev] Bug 211330 - Add attributes-complete support to the EclipseLink-ORM.XML Schema

Guy,
 
But xml-mapping-metadata-complete does mean that mapping defaults should be applied, so the current behavior is correct.
If we want to offer a feature that prevents this then we should have a separate option to not apply defaults.
 
-Mike
-----Original Message-----
From: GUY.PELLETIER@...
Sent: Wednesday, May 21, 2008 9:56 AM
To: shaun.smith@...; Dev mailing list for Eclipse Persistence Services
Subject: Re: [eclipselink-dev] Bug 211330 - Add attributes-complete support to the EclipseLink-ORM.XML Schema

Hi Shaun,
 
What we want to do is avoid processing the class for mapping defaults. Current deployment XML users specify their complete set of mappings within the XML file with no notion of EclipseLink inspecting those files for other 'default' mappings. Migrating these users to the new format (and metadata processing) we need to ensure there is a way to preserve this.
 
Currently, specify an xml-mapping-metadata-complete falls a little short of this functionality since it will use those mappings that are in XML and ignore annotations, however, the processing will still inspect the class for default mappings for basics, 1-1's, 1-M's and Variable1-1's.
 
Bug 218082 (conversion tool, current deployment XML -> new Eclipselink orm schema format) also depends on a solution to this bug.
 
Cheers,
Guy
----- Original Message -----
Sent: Wednesday, May 21, 2008 9:32 AM
Subject: Re: [eclipselink-dev] Bug 211330 - Add attributes-complete support to the EclipseLink-ORM.XML Schema

Hi Guy,

   Can you elaborate on the problem? Your initial description is:
Which is a flag to indicate not to auto-generate any unspecified attributes. This is important in XML when the class may continue to evolve.
When  you say "auto-generate" are you talking about DDL generation?  Can you provide an example of the issue?

     Shaun

Guy Pelletier wrote:
Two suggestions to address the following bug have been documented.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=211330

Please review and provide any feedback.

Cheers,
Guy
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

--


Oracle
Shaun Smith | Principal Product Manager, TopLink | +1.905.502.3094
Oracle Fusion Middleware
110 Matheson Boulevard West, Suite 100
Mississauga, Ontario, Canada L5R 3P4


_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

RE: Bug 211330 - Add attributes-complete support to the EclipseLink-ORM.XML Schema

by djclarke :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Some parts of this message have been removed. Learn more about Nabble's security policy.
I believe that is what Guy and I discussed. An additional enhancement that would allow a user to configure the XML to trusted exclusively.
 
Doug
-----Original Message-----
From: MICHAEL.KEITH@...
Sent: Wednesday, May 21, 2008 1:57 PM
To: GUY.PELLETIER@...; Dev mailing list for Eclipse Persistence Services; shaun.smith@...
Subject: RE: [eclipselink-dev] Bug 211330 - Add attributes-complete support to the EclipseLink-ORM.XML Schema

Guy,
 
But xml-mapping-metadata-complete does mean that mapping defaults should be applied, so the current behavior is correct.
If we want to offer a feature that prevents this then we should have a separate option to not apply defaults.
 
-Mike
-----Original Message-----
From: GUY.PELLETIER@...
Sent: Wednesday, May 21, 2008 9:56 AM
To: shaun.smith@...; Dev mailing list for Eclipse Persistence Services
Subject: Re: [eclipselink-dev] Bug 211330 - Add attributes-complete support to the EclipseLink-ORM.XML Schema

Hi Shaun,
 
What we want to do is avoid processing the class for mapping defaults. Current deployment XML users specify their complete set of mappings within the XML file with no notion of EclipseLink inspecting those files for other 'default' mappings. Migrating these users to the new format (and metadata processing) we need to ensure there is a way to preserve this.
 
Currently, specify an xml-mapping-metadata-complete falls a little short of this functionality since it will use those mappings that are in XML and ignore annotations, however, the processing will still inspect the class for default mappings for basics, 1-1's, 1-M's and Variable1-1's.
 
Bug 218082 (conversion tool, current deployment XML -> new Eclipselink orm schema format) also depends on a solution to this bug.
 
Cheers,
Guy
----- Original Message -----
Sent: Wednesday, May 21, 2008 9:32 AM
Subject: Re: [eclipselink-dev] Bug 211330 - Add attributes-complete support to the EclipseLink-ORM.XML Schema

Hi Guy,

   Can you elaborate on the problem? Your initial description is:
Which is a flag to indicate not to auto-generate any unspecified attributes. This is important in XML when the class may continue to evolve.
When  you say "auto-generate" are you talking about DDL generation?  Can you provide an example of the issue?

     Shaun

Guy Pelletier wrote:
Two suggestions to address the following bug have been documented.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=211330

Please review and provide any feedback.

Cheers,
Guy
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

--


Oracle
Shaun Smith | Principal Product Manager, TopLink | +1.905.502.3094
Oracle Fusion Middleware
110 Matheson Boulevard West, Suite 100
Mississauga, Ontario, Canada L5R 3P4


_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

fix for bug 233296

by Guy Pelletier :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

A patch file for bug 233296 is now available for review.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=233296

Description: MappedSuperclass Lifecyele Events not called on Non-Public
Methods

Please review and provide any feedback.

 Cheers,
Guy

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

Parent Message unknown Re: fix for bug 233296

by Guy Pelletier :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Fix has been submitted.

Reviewed by: Tom Ware

No new tests were added. However, I changed the access on the pre persist
lifecycle method from the mapped
superclass AbstractBus from public to private (and manually tried protected
and package as well for completeness
sake) to test the fix.

The calling of that pre-persist method is tested in the
org.eclipse.persistence.testing.tests.jpa.inheritance.LifecycleCallbackJunitTest

The FullRegressionTestSuite also passed successfully.

Cheers,
Guy

----- Original Message -----
From: "Guy Pelletier" <guy.pelletier@...>
To: "Dev mailing list for Eclipse Persistence Services"
<eclipselink-dev@...>
Sent: Thursday, May 22, 2008 10:17 AM
Subject: [eclipselink-dev] fix for bug 233296


>A patch file for bug 233296 is now available for review.
>
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=233296
>
> Description: MappedSuperclass Lifecyele Events not called on Non-Public
> Methods
>
> Please review and provide any feedback.
>
> Cheers,
> Guy

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

fix for bug 211330

by Guy Pelletier :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

A patch file for bug 211330 is now available for review.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=211330

Description: Add attributes-complete support to the EclipseLink-ORM.XML
Schema

Please review and provide any feedback.

Cheers,
Guy

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

fix for bug 234028

by Guy Pelletier :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Some parts of this message have been removed. Learn more about Nabble's security policy.
A patch file for bug 234028 is now available for review.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=234028
 
Description: ClassCastException when running static weaving tests
 
Please review and provide any feedback.

Cheers,
Guy

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

fix for bug 229797

by Guy Pelletier :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Some parts of this message have been removed. Learn more about Nabble's security policy.
A patch file for bug 229797 is now available for review.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=229797

Description: Change @Cache's isolated attribute to be shared with a default of true
 
Please review and provide any feedback.

Cheers,
Guy
 

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

fix for bug 230213

by Guy Pelletier :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Some parts of this message have been removed. Learn more about Nabble's security policy.
A patch file for bug 230213 is now available for review.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=230213

Description: ValidationException when mapping to attribute in @SuperClass

Please review and provide any feedback.

Cheers,
Guy
 

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

fix for bug 224416

by Guy Pelletier :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Some parts of this message have been removed. Learn more about Nabble's security policy.
A patch file for bug 224416 is now available for review.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=224416

Description: JPA @PrePersist event called on new entity within EntityManager.merge has no effect

Please review and provide any feedback.

Cheers,
Guy

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

fix for bug 217932

by Peter Krogh :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Some parts of this message have been removed. Learn more about Nabble's security policy.
A patch file for bug 217932   is now available for review.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=217932


Description
: Remove TopLink from setTopLinkAttributeName Method Names
Please review and provide any feedback.

Reviewed by Tom
Names agreed to by Tom, Peter and Shaun 
Peter 

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

Re: fix for bug 224416

by Guy Pelletier :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Some parts of this message have been removed. Learn more about Nabble's security policy.
Changes have been submitted.
 
Reviewed: James Sutherland, Tom Ware
 
New test (testPrePersistAlpineOnMerge) added to InheritedCallbacksJunitTest.java
 
Cheers,
Guy
----- Original Message -----
Sent: Tuesday, June 03, 2008 4:45 PM
Subject: [eclipselink-dev] fix for bug 224416

A patch file for bug 224416 is now available for review.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=224416

Description: JPA @PrePersist event called on new entity within EntityManager.merge has no effect

Please review and provide any feedback.

Cheers,
Guy


_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

fix for bug 235813

by Guy Pelletier :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Some parts of this message have been removed. Learn more about Nabble's security policy.
A patch file for bug 235813 is now available for review.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=235813

Description: Transient attribute from XML causes exception

Please review and provide any feedback.

Cheers,
Guy
 

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

Proposals for bug 228711

by Guy Pelletier :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Some parts of this message have been removed. Learn more about Nabble's security policy.
Several proposals have been tabled to resolve bug 228711 - Simplify the @NamedStoredProcedure annotations
 
 
If you have an opinion, please cast a vote for one of the proposals.
 
Thanks,
Guy

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

RE: Proposals for bug 228711

by Michael Keith-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Some parts of this message have been removed. Learn more about Nabble's security policy.
My opinions are already documented in the bug.
-----Original Message-----
From: GUY.PELLETIER@...
Sent: Thursday, June 05, 2008 10:35 AM
To: Dev mailing list for Eclipse Persistence Services
Subject: [eclipselink-dev] Proposals for bug 228711

Several proposals have been tabled to resolve bug 228711 - Simplify the @NamedStoredProcedure annotations
 
 
If you have an opinion, please cast a vote for one of the proposals.
 
Thanks,
Guy

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

fix for bug 228711

by Guy Pelletier :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Some parts of this message have been removed. Learn more about Nabble's security policy.
A patch file for bug 228711 is now available for review.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=228711

Description: Simplify the @NamedStoredProcedure annotations

Please review and provide any feedback.

Cheers,
Guy
 

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@...
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
< Prev | 1 - 2 - 3 - 4 - 5 - 6 - 7 | Next >