fix for untranslatable footer in dokumentation

View: New views
1 Messages — Rating Filter:   Alert me  

fix for untranslatable footer in dokumentation

by Bugzilla from lueck@hube-lueck.de :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

since about 3 years there is an unsolved bug in the documentation, the footer
is untranslatable, see
e.g.:http://lists.kde.org/?l=kde-doc-english&m=114157866222476&w=2

I have tried to fix this with the attached patch, works here, tested with en
and de.

I had to divide the text into 3 parts, because I did not succeed to escape the
char "<". I tried this patch, but I am not shure, if there are any unwanted
side effects:
--- kdelibs/kdoctools/docbook/xsl/common/l10n.xsl       (Revision 838534)
+++ kdelibs/kdoctools/docbook/xsl/common/l10n.xsl       (Arbeitskopie)
@@ -178,7 +178,7 @@
         </xsl:choose>
       </xsl:message>
 
-      <xsl:value-of
select="($l10n.xml/l:i18n/l:l10n[@language='en']/l:gentext[@key=$key])
[1]/@text"/>
+      <xsl:value-of
select="($l10n.xml/l:i18n/l:l10n[@language='en']/l:gentext[@key=$key])
[1]/@text" disable-output-escaping="yes"/>
Does anyone know what's wrong whith this escaping?

Comments and improvements welcome.

--
Burkhard Lück

[kdelibs-kdoctools-footer-translation]

Index: kdelibs/kdoctools/docbook/xsl/common/en.xml
===================================================================
--- kdelibs/kdoctools/docbook/xsl/common/en.xml (Revision 840157)
+++ kdelibs/kdoctools/docbook/xsl/common/en.xml (Arbeitskopie)
@@ -180,7 +180,9 @@
    <l:gentext key="hyphenation-character" text="-"/>
    <l:gentext key="hyphenation-push-character-count" text="2"/>
    <l:gentext key="hyphenation-remain-character-count" text="2"/>
-
+   <l:gentext key="footer-doc-comment" text="Would you like to make a comment or contribute an update to this page?"/>
+   <l:gentext key="footer-doc-feedback" text="Send feedback to the "/>
+   <l:gentext key="footer-doc-teamname" text="KDE Docs Team"/>
    <l:context name="styles">
       <l:template name="person-name" text="first-last"/>
    </l:context>
Index: kdelibs/kdoctools/docbook/xsl/common/l10n.xsl
===================================================================
--- kdelibs/kdoctools/docbook/xsl/common/l10n.xsl (Revision 840157)
+++ kdelibs/kdoctools/docbook/xsl/common/l10n.xsl (Arbeitskopie)
@@ -292,6 +292,25 @@
   </xsl:call-template>
 </xsl:template>
 
+<xsl:template name="gentext.footer-doc-comment">
+  <xsl:call-template name="gentext">
+    <xsl:with-param name="key" select="'footer-doc-comment'"/>
+  </xsl:call-template>
+</xsl:template>
+
+<xsl:template name="gentext.footer-doc-feedback">
+  <xsl:call-template name="gentext">
+    <xsl:with-param name="key" select="'footer-doc-feedback'"/>
+  </xsl:call-template>
+</xsl:template>
+
+<xsl:template name="gentext.footer-doc-teamname">
+  <xsl:call-template name="gentext">
+    <xsl:with-param name="key" select="'footer-doc-teamname'"/>
+  </xsl:call-template>
+</xsl:template>
+
+
 <!-- ============================================================ -->
 
 <xsl:template name="gentext.template">
Index: kdelibs/kdoctools/docbook/xsl/common/de.xml
===================================================================
--- kdelibs/kdoctools/docbook/xsl/common/de.xml (Revision 840157)
+++ kdelibs/kdoctools/docbook/xsl/common/de.xml (Arbeitskopie)
@@ -180,7 +180,9 @@
    <l:gentext key="hyphenation-character" text="-"/>
    <l:gentext key="hyphenation-push-character-count" text="2"/>
    <l:gentext key="hyphenation-remain-character-count" text="3"/>
-
+   <l:gentext key="footer-doc-comment" text="Möchten Sie Kommentare und Verbesserungen zu dieser Seite beitragen?"/>
+   <l:gentext key="footer-doc-feedback" text="Senden Sie Ihre Vorschläge an das "/>
+   <l:gentext key="footer-doc-teamname" text="KDE Dokumentationsteam"/>
    <l:context name="styles">
       <l:template name="person-name" text="first-last"/>
    </l:context>
Index: kdelibs/kdoctools/customization/kde-navig.xsl
===================================================================
--- kdelibs/kdoctools/customization/kde-navig.xsl (Revision 840157)
+++ kdelibs/kdoctools/customization/kde-navig.xsl (Arbeitskopie)
@@ -205,9 +205,14 @@
         <div class="bannerBottomLeft">
           <img src="{$kde.common}bottom-left.png" style="height: 70px; margin: 0px;" alt=""/>
         </div>
-<div id="comments" style="position:relative; top: 15px; left: 1em; width: 50%; color: #282828;">
- <p>Would you like to make a comment or contribute an update to this page?<br/>
-        Send feedback to the <a href="mailto:kde-docs@..." style="background:transparent; color: #282828; text-decoration: underline;">KDE Docs Team</a></p>
+        <div id="comments" style="position:relative; top: 15px; left: 1em; width: 50%; color: #282828;">
+        <p>
+ <xsl:call-template name="gentext.footer-doc-comment"/>
+ <br/>
+ <xsl:call-template name="gentext.footer-doc-feedback"/>
+ <a href="mailto:kde-docs@..." style="background:transparent; color: #282828; text-decoration: underline;">
+ <xsl:call-template name="gentext.footer-doc-teamname"/>
+ </a></p>
  </div>
 
       </div>


_______________________________________________
kde-docbook mailing list
kde-docbook@...
https://mail.kde.org/mailman/listinfo/kde-docbook