fixes and changes in 2.0.1_RC0.5.15

[Thomas Eckardt/eck]

Hi all,

fixed:

- GeedyWhitelist - a spelling mistake in the CVS version
- some language tags where missing
- Blockreport has shown invalid addresses from DKIM tags


changed:

- better memory handling by predefining the key count for some hashes
- MaillogTail has now enabled and colored file links, if a search string
is used - highlighting is no more automatic switched off if 'files only'
is selected
- database backups are now available in 'mysqlslavemode'


added:

'StoreASSPHeader','Store Assp-Header into Spam Collection', 'Add "X-Assp-"
to the collected spam-mails.' (adapted from V1)

'GreedyWhitelistAdditions','How add Greedy Senders to
Whitelist','0:envelop only|1:all'  'In addition to the setting in
NotGreedyWhitelist , you can define what addresses will be added to
whitelist.

Thomas

DISCLAIMER:
*******************************************************
This email and any files transmitted with it may be confidential, legally
privileged and protected in law and are intended solely for the use of the

individual to whom it is addressed.
This email was multiple times scanned for viruses. There should be no
known virus in this email!
*******************************************************


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Assp-test mailing list
Assp-test@...
https://lists.sourceforge.net/lists/listinfo/assp-test

[K Post]

You forgot to mention in the change log that you fixed the biggy for
me, headers not being parsed even when Not Greedy should have had ASSP
check it (wrong call to onwhitelist).  Thanks for making that change.

Speaking of thanks, thanks for implementing my suggestion to give us
the option of what sender addresses to whitelist.  Still I think there
should be an option for NONE.  In the case of these lists, the
envelope (mail from) is often the uniquie address.  If our users
whitelist the from line from the header, that'll be enough to get the
message through with notgreedy as 0.  But I'd like a
'GreedyWhitelistAdditions' option for none so that the envelope sender
doesn't get added.  I thin kthis makes sense.

And of course thanks for implementing my other nit-picky requests like
fixing DKIM reporting in the block reports and file highlighting when
searching for file names.

You're the best.

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Assp-test mailing list
Assp-test@...
https://lists.sourceforge.net/lists/listinfo/assp-test

[K Post]

Provided I'm understanding the functionality of
GreedyWhitelistAdditions, for clarity, I'd change the description from

['GreedyWhitelistAdditions','How add Greedy Senders to
Whitelist','0:envelop only|1:all',\&listbox,1,'(.*)',undef,
  'In addition to the setting in NotGreedyWhitelist , you can define
what addresses will be added to
whitelist.',undef,undef,'msg008780','msg008781'],

to

['GreedyWhitelistAdditions',Sender Addresses to Add To
Whitelist','0:envelope only|1:all sender
addresses',\&listbox,1,'(.*)',undef,
  'Defines what sender addresses are added to the whitelist if a
message is considered to be from a whitelisted sender.
NotGreedyWhitelist is considered in determining if a message is from a
whitelisted sender.',undef,undef,'msg008780','msg008781'],

Note that I fixed a type-o, envelopE only.

I'd like to see an option 2:None here.  Implementation idea below.


Then change NotGreedyWhitelist to be have the header
Only the compare the envelope-sender to the whitelist (doesn't talk
about adding)

and reword the 3 options (functionality unchanged) to:
check all addresses - consider whitelisted if ANY match
only check the envelope
check all addresses - only consider whitelisted if ALL match,

I think that better describes everything.  NotGreedyWhitelist
determines if the message is considered whitelisted.
GreedyWhitelistAdditions determines what addresses are added to the
whitelist.  I think that the code already does this, it's just
described in an unclear way.

In the code, I see that you consider $GreedyWhitelistAdditions when
deciding if %a gets the sender addresses added.  That's fine.  Several
lines down though, you also consider it when getting the to and cc
addresses out.  I don't think that's right since we're only talking
about SENDER addresses here, not recipient addresses.

I >>think<< the code that is:

 # keep the whitelist up-to-date
        my %a=%senders if $GreedyWhitelistAdditions;
        my $t=time;
        $a{$fm}=1;
        $header=~s/\n\s+/ /g;
        while($header=~/\n(to|cc): (.*)/ig && $GreedyWhitelistAdditions) {
           my $ad=$2;
            while($ad=~/($EmailAdrRe\@$EmailDomainRe)/go) {
                my $s = $1;
                $s = $1 if ($s =~ /^prvs=\d\d\d\d\w{6}=(.*)/);
                $a{lc $s}=1;
            }
        }

should be

 # keep the whitelist up-to-date
        my %a=%senders if $GreedyWhitelistAdditions == 1;  <-- only if
1, not 0 or 2 to implement NONE as an option
        my $t=time;
        $a{$fm}=1 if $GreedyWhitelistAdditions <> 2;  <--- changed if
you implement option 2, NONE
        $header=~s/\n\s+/ /g;
        while($header=~/\n(to|cc): (.*)/ig ) {  <!-- got rid of the
greedywhitelistadditions comparision here
            my $ad=$2;
            while($ad=~/($EmailAdrRe\@$EmailDomainRe)/go) {
                my $s = $1;
                $s = $1 if ($s =~ /^prvs=\d\d\d\d\w{6}=(.*)/);
                $a{lc $s}=1;
            }
        }

Please check my logic though.

Also, might we need to consider whitelisted messages due to SenderBase?

Thanks again.  Looking forward to seeing the block report tomorrow morning.

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Assp-test mailing list
Assp-test@...
https://lists.sourceforge.net/lists/listinfo/assp-test