follow links
|
View:
New views
8 Messages
—
Rating Filter:
Alert me
|
 |
follow links
by Benny Malengier
::
Rate this Message:
Crash in python 2.5 for os.walk with followlinks=True as this is only
present in 2.6 Is there a reason to actually set this to True? I would consider that a risk. Ok to remove? Or should I build in a test for platform.python_version_tuple for this? FYI, the bug: Traceback (most recent call last): File "/home/benny/programs/gramps/trunk/src/gui/grampsgui.py", line 324, in __startgramps Gramps(argparser) File "/home/benny/programs/gramps/trunk/src/gui/grampsgui.py", line 247, in __init__ self.vm = ViewManager(dbstate) File "/home/benny/programs/gramps/trunk/src/gui/viewmanager.py", line 243, in __init__ self.do_reg_plugins() File "/home/benny/programs/gramps/trunk/src/gui/viewmanager.py", line 626, in do_reg_plugins error = CLIManager.do_reg_plugins(self) File "/home/benny/programs/gramps/trunk/src/cli/grampscli.py", line 281, in do_reg_plugins self._pmgr.reg_plugins(const.PLUGINS_DIR) File "/home/benny/programs/gramps/trunk/src/gen/plug/_manager.py", line 109, in reg_plugins for (dirpath, dirnames, filenames) in os.walk(direct, followlinks=True): TypeError: walk() got an unexpected keyword argument 'followlinks Benny ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Gramps-devel mailing list Gramps-devel@... https://lists.sourceforge.net/lists/listinfo/gramps-devel |
|
|
Re: follow links
by Brian Matherly
::
Rate this Message:
> Crash in python 2.5 for os.walk
> with followlinks=True as this is only > present in 2.6 > > Is there a reason to actually set this to True? I would > consider that > a risk. Ok to remove? Or should I build in a test for > platform.python_version_tuple for this? > > FYI, the bug: > > Traceback (most recent call last): > File > "/home/benny/programs/gramps/trunk/src/gui/grampsgui.py", > line > 324, in __startgramps > Gramps(argparser) > File > "/home/benny/programs/gramps/trunk/src/gui/grampsgui.py", > line > 247, in __init__ > self.vm = ViewManager(dbstate) > File > "/home/benny/programs/gramps/trunk/src/gui/viewmanager.py", > line 243, in __init__ > self.do_reg_plugins() > File > "/home/benny/programs/gramps/trunk/src/gui/viewmanager.py", > line 626, in do_reg_plugins > error = CLIManager.do_reg_plugins(self) > File > "/home/benny/programs/gramps/trunk/src/cli/grampscli.py", > line > 281, in do_reg_plugins > self._pmgr.reg_plugins(const.PLUGINS_DIR) > File > "/home/benny/programs/gramps/trunk/src/gen/plug/_manager.py", > line 109, in reg_plugins > for (dirpath, dirnames, filenames) in > os.walk(direct, followlinks=True): > TypeError: walk() got an unexpected keyword argument > 'followlinks Please remove. Do not follow links. ~Brian ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Gramps-devel mailing list Gramps-devel@... https://lists.sourceforge.net/lists/listinfo/gramps-devel |
|
|
Re: follow links
by Doug Blank-2
::
Rate this Message:
On Fri, Nov 6, 2009 at 8:46 AM, Benny Malengier
<benny.malengier@...> wrote: > Crash in python 2.5 for os.walk with followlinks=True as this is only > present in 2.6 > > Is there a reason to actually set this to True? I would consider that > a risk. Ok to remove? Or should I build in a test for > platform.python_version_tuple for this? I didn't realize that it was only 2.6. I added it so that we can: cd ~/.gramps/plugins ln -s .../gramps-addons/contrib And then you can work from your gramps-addons subdirectory, wherever it might be. Can you think of another way of doing this? I guess one could put the gramps-addons SVN directory inside your plugins directory, but that doesn't seem very good. Does the 2.5 os.walk follow links? If so, then we should just test versions, and use followlinks if 2.5, and both will work. -Doug > FYI, the bug: > > Traceback (most recent call last): > File "/home/benny/programs/gramps/trunk/src/gui/grampsgui.py", line > 324, in __startgramps > Gramps(argparser) > File "/home/benny/programs/gramps/trunk/src/gui/grampsgui.py", line > 247, in __init__ > self.vm = ViewManager(dbstate) > File "/home/benny/programs/gramps/trunk/src/gui/viewmanager.py", > line 243, in __init__ > self.do_reg_plugins() > File "/home/benny/programs/gramps/trunk/src/gui/viewmanager.py", > line 626, in do_reg_plugins > error = CLIManager.do_reg_plugins(self) > File "/home/benny/programs/gramps/trunk/src/cli/grampscli.py", line > 281, in do_reg_plugins > self._pmgr.reg_plugins(const.PLUGINS_DIR) > File "/home/benny/programs/gramps/trunk/src/gen/plug/_manager.py", > line 109, in reg_plugins > for (dirpath, dirnames, filenames) in os.walk(direct, followlinks=True): > TypeError: walk() got an unexpected keyword argument 'followlinks > > Benny > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day > trial. Simplify your report design, integration and deployment - and focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > Gramps-devel mailing list > Gramps-devel@... > https://lists.sourceforge.net/lists/listinfo/gramps-devel > ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Gramps-devel mailing list Gramps-devel@... https://lists.sourceforge.net/lists/listinfo/gramps-devel |
|
|
Re: follow links
by Doug Blank-2
::
Rate this Message:
On Fri, Nov 6, 2009 at 9:02 AM, Brian Matherly <brian@...> wrote:
>> Crash in python 2.5 for os.walk >> with followlinks=True as this is only >> present in 2.6 >> >> Is there a reason to actually set this to True? I would >> consider that >> a risk. Ok to remove? Or should I build in a test for >> platform.python_version_tuple for this? >> >> FYI, the bug: >> >> Traceback (most recent call last): >> File >> "/home/benny/programs/gramps/trunk/src/gui/grampsgui.py", >> line >> 324, in __startgramps >> Gramps(argparser) >> File >> "/home/benny/programs/gramps/trunk/src/gui/grampsgui.py", >> line >> 247, in __init__ >> self.vm = ViewManager(dbstate) >> File >> "/home/benny/programs/gramps/trunk/src/gui/viewmanager.py", >> line 243, in __init__ >> self.do_reg_plugins() >> File >> "/home/benny/programs/gramps/trunk/src/gui/viewmanager.py", >> line 626, in do_reg_plugins >> error = CLIManager.do_reg_plugins(self) >> File >> "/home/benny/programs/gramps/trunk/src/cli/grampscli.py", >> line >> 281, in do_reg_plugins >> self._pmgr.reg_plugins(const.PLUGINS_DIR) >> File >> "/home/benny/programs/gramps/trunk/src/gen/plug/_manager.py", >> line 109, in reg_plugins >> for (dirpath, dirnames, filenames) in >> os.walk(direct, followlinks=True): >> TypeError: walk() got an unexpected keyword argument >> 'followlinks > > Please remove. Do not follow links. What will be the workflow for developing third-party plugins (gramps-addons)? I'd rather not have to be copying files back and forth, myself. -Doug > ~Brian > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day > trial. Simplify your report design, integration and deployment - and focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > Gramps-devel mailing list > Gramps-devel@... > https://lists.sourceforge.net/lists/listinfo/gramps-devel > ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Gramps-devel mailing list Gramps-devel@... https://lists.sourceforge.net/lists/listinfo/gramps-devel |
|
|
Re: follow links
by Benny Malengier
::
Rate this Message:
2009/11/6 Doug Blank <doug.blank@...>:
> On Fri, Nov 6, 2009 at 9:02 AM, Brian Matherly <brian@...> wrote: >>> Crash in python 2.5 for os.walk >>> with followlinks=True as this is only >>> present in 2.6 >>> >>> Is there a reason to actually set this to True? I would >>> consider that >>> a risk. Ok to remove? Or should I build in a test for >>> platform.python_version_tuple for this? >>> >>> FYI, the bug: >>> >>> Traceback (most recent call last): >>> File >>> "/home/benny/programs/gramps/trunk/src/gui/grampsgui.py", >>> line >>> 324, in __startgramps >>> Gramps(argparser) >>> File >>> "/home/benny/programs/gramps/trunk/src/gui/grampsgui.py", >>> line >>> 247, in __init__ >>> self.vm = ViewManager(dbstate) >>> File >>> "/home/benny/programs/gramps/trunk/src/gui/viewmanager.py", >>> line 243, in __init__ >>> self.do_reg_plugins() >>> File >>> "/home/benny/programs/gramps/trunk/src/gui/viewmanager.py", >>> line 626, in do_reg_plugins >>> error = CLIManager.do_reg_plugins(self) >>> File >>> "/home/benny/programs/gramps/trunk/src/cli/grampscli.py", >>> line >>> 281, in do_reg_plugins >>> self._pmgr.reg_plugins(const.PLUGINS_DIR) >>> File >>> "/home/benny/programs/gramps/trunk/src/gen/plug/_manager.py", >>> line 109, in reg_plugins >>> for (dirpath, dirnames, filenames) in >>> os.walk(direct, followlinks=True): >>> TypeError: walk() got an unexpected keyword argument >>> 'followlinks >> >> Please remove. Do not follow links. > > What will be the workflow for developing third-party plugins > (gramps-addons)? I'd rather not have to be copying files back and > forth, myself. It should be as easy as defining a third directory to scan in the _pluginreg registration code. So we take a directory ~/.gramps/gramps-addons/contrib and register plugins there also Benny ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Gramps-devel mailing list Gramps-devel@... https://lists.sourceforge.net/lists/listinfo/gramps-devel |
|
|
Re: follow links
by Brian Matherly
::
Rate this Message:
> > Please remove. Do not follow links.
> > What will be the workflow for developing third-party > plugins > (gramps-addons)? I'd rather not have to be copying files > back and > forth, myself. > > -Doug > > > ~Brian The plugin manager searches in /home/user/.gramps/plugins (or something like that). You could develop them there with no conflict. ~Brian ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Gramps-devel mailing list Gramps-devel@... https://lists.sourceforge.net/lists/listinfo/gramps-devel |
|
|
Re: follow links
by Doug Blank-2
::
Rate this Message:
On Fri, Nov 6, 2009 at 9:09 AM, Benny Malengier
<benny.malengier@...> wrote: > 2009/11/6 Doug Blank <doug.blank@...>: >> On Fri, Nov 6, 2009 at 9:02 AM, Brian Matherly <brian@...> wrote: >>>> Crash in python 2.5 for os.walk >>>> with followlinks=True as this is only >>>> present in 2.6 >>>> >>>> Is there a reason to actually set this to True? I would >>>> consider that >>>> a risk. Ok to remove? Or should I build in a test for >>>> platform.python_version_tuple for this? >>>> >>>> FYI, the bug: >>>> >>>> Traceback (most recent call last): >>>> File >>>> "/home/benny/programs/gramps/trunk/src/gui/grampsgui.py", >>>> line >>>> 324, in __startgramps >>>> Gramps(argparser) >>>> File >>>> "/home/benny/programs/gramps/trunk/src/gui/grampsgui.py", >>>> line >>>> 247, in __init__ >>>> self.vm = ViewManager(dbstate) >>>> File >>>> "/home/benny/programs/gramps/trunk/src/gui/viewmanager.py", >>>> line 243, in __init__ >>>> self.do_reg_plugins() >>>> File >>>> "/home/benny/programs/gramps/trunk/src/gui/viewmanager.py", >>>> line 626, in do_reg_plugins >>>> error = CLIManager.do_reg_plugins(self) >>>> File >>>> "/home/benny/programs/gramps/trunk/src/cli/grampscli.py", >>>> line >>>> 281, in do_reg_plugins >>>> self._pmgr.reg_plugins(const.PLUGINS_DIR) >>>> File >>>> "/home/benny/programs/gramps/trunk/src/gen/plug/_manager.py", >>>> line 109, in reg_plugins >>>> for (dirpath, dirnames, filenames) in >>>> os.walk(direct, followlinks=True): >>>> TypeError: walk() got an unexpected keyword argument >>>> 'followlinks >>> >>> Please remove. Do not follow links. >> >> What will be the workflow for developing third-party plugins >> (gramps-addons)? I'd rather not have to be copying files back and >> forth, myself. > > It should be as easy as defining a third directory to scan in the > _pluginreg registration code. > So we take a directory > ~/.gramps/gramps-addons/contrib > > and register plugins there also Could ~/.gramps/gramps-addons itself be a link then? If we start os.walk with ~/.gramps/gramps-addons/contrib and gramps-addons was a link, it wouldn't be following links. That would be fine. -Doug > Benny > ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Gramps-devel mailing list Gramps-devel@... https://lists.sourceforge.net/lists/listinfo/gramps-devel |
|
|
Re: follow links
by Doug Blank-2
::
Rate this Message:
On Fri, Nov 6, 2009 at 9:19 AM, Doug Blank <doug.blank@...> wrote:
> On Fri, Nov 6, 2009 at 9:09 AM, Benny Malengier > <benny.malengier@...> wrote: >> 2009/11/6 Doug Blank <doug.blank@...>: >>> On Fri, Nov 6, 2009 at 9:02 AM, Brian Matherly <brian@...> wrote: >>>>> Crash in python 2.5 for os.walk >>>>> with followlinks=True as this is only >>>>> present in 2.6 >>>>> >>>>> Is there a reason to actually set this to True? I would >>>>> consider that >>>>> a risk. Ok to remove? Or should I build in a test for >>>>> platform.python_version_tuple for this? >>>>> >>>>> FYI, the bug: >>>>> >>>>> Traceback (most recent call last): >>>>> File >>>>> "/home/benny/programs/gramps/trunk/src/gui/grampsgui.py", >>>>> line >>>>> 324, in __startgramps >>>>> Gramps(argparser) >>>>> File >>>>> "/home/benny/programs/gramps/trunk/src/gui/grampsgui.py", >>>>> line >>>>> 247, in __init__ >>>>> self.vm = ViewManager(dbstate) >>>>> File >>>>> "/home/benny/programs/gramps/trunk/src/gui/viewmanager.py", >>>>> line 243, in __init__ >>>>> self.do_reg_plugins() >>>>> File >>>>> "/home/benny/programs/gramps/trunk/src/gui/viewmanager.py", >>>>> line 626, in do_reg_plugins >>>>> error = CLIManager.do_reg_plugins(self) >>>>> File >>>>> "/home/benny/programs/gramps/trunk/src/cli/grampscli.py", >>>>> line >>>>> 281, in do_reg_plugins >>>>> self._pmgr.reg_plugins(const.PLUGINS_DIR) >>>>> File >>>>> "/home/benny/programs/gramps/trunk/src/gen/plug/_manager.py", >>>>> line 109, in reg_plugins >>>>> for (dirpath, dirnames, filenames) in >>>>> os.walk(direct, followlinks=True): >>>>> TypeError: walk() got an unexpected keyword argument >>>>> 'followlinks >>>> >>>> Please remove. Do not follow links. >>> >>> What will be the workflow for developing third-party plugins >>> (gramps-addons)? I'd rather not have to be copying files back and >>> forth, myself. >> >> It should be as easy as defining a third directory to scan in the >> _pluginreg registration code. >> So we take a directory >> ~/.gramps/gramps-addons/contrib >> >> and register plugins there also > > Could ~/.gramps/gramps-addons itself be a link then? If we start > os.walk with ~/.gramps/gramps-addons/contrib and gramps-addons was a > link, it wouldn't be following links. That would be fine. I think the following is a better solution all the way around: Developers might want to replace their ~/.gramps/plugins with a link to /wherever/gramps-addons/contrib That way, what ever they are developing can be kept in the addons development location, and this makes it easy to move a personal plugin into a shared addon. And, we don't need to do anything special... gramps still just searches just those two places. So, I've removed the followlinks option (trunk revision 13509) and will change the recommendations on addons workflow: http://www.gramps-project.org/wiki/index.php?title=Addons_Development Thanks! -Doug > -Doug > >> Benny >> > ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Gramps-devel mailing list Gramps-devel@... https://lists.sourceforge.net/lists/listinfo/gramps-devel |
| Free embeddable forum powered by Nabble | Forum Help |
