git pull request etiquette

View: New views
3 Messages — Rating Filter:   Alert me  

git pull request etiquette

by Burt Beckwith :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

By default a git pull request selects all of the committers. I created a pull request but didn't want to spam everybody so I unselected everyone but Graeme - what's the standard approach?

Burt


signature.asc (204 bytes) Download Attachment

Re: git pull request etiquette

by Peter Ledbrook :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

> By default a git pull request selects all of the committers. I created a pull request but didn't want to spam everybody so I unselected everyone but Graeme - what's the standard approach?

Not sure. Most pull requests go to all committers, which is fine with
me. If one person pulls the changes and commits them, then it
shouldn't be possible for another person to do the same (because the
commits will have the same ID).

Cheers,

Peter

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email



Re: git pull request etiquette

by Graeme Rocher-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Its ok to send to all developers, sending to just me has the danger
that I may miss it (!)

On Sat, Oct 24, 2009 at 4:37 PM, Burt Beckwith <burt@...> wrote:
> By default a git pull request selects all of the committers. I created a pull request but didn't want to spam everybody so I unselected everyone but Graeme - what's the standard approach?
>
> Burt
>



--
Graeme Rocher
Head of Grails Development
SpringSource - Weapons for the War on Java Complexity
http://www.springsource.com

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email