gmail default follow link behaviour change

[Rohan Nicholls-3]

For anyone who is interested.

If you follow a link from gmail with the mouse, it always starts in a new tab/window.

The "C-c f" functionality in gmail mode does not do this, which is what I want
and I keep forgetting the C-u prefix, so here is a patch to make this behaviour
default.  Again, not very exciting, but does the job.

For anyone that's interested. :)

Rohan

[gmail-follow-link.diff]

---

diff --git a/modules/page-modes/gmail.js b/modules/page-modes/gmail.js
index ed49568..692b282 100644
--- a/modules/page-modes/gmail.js
+++ b/modules/page-modes/gmail.js
@@ -24,7 +24,7 @@ define_keymap("gmail_keymap", $parent = content_buffer_normal_keymap);
         define_key(keymap, "C-c x", "shell-command-on-file");
         define_key(keymap, "C-c s", "save");
         define_key(keymap, "C-c r", "reload");
-        define_key(keymap, "C-c f", "follow");
+        define_key(keymap, "C-c f", "follow-new-buffer");
         define_key(keymap, "C-c t", "follow-top");
 
         define_key(keymap, "tab", null, $fallthrough);

---

_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

[John J. Foerch]

On Wed, Sep 02, 2009 at 11:36:03AM +0200, Rohan Nicholls wrote:

> For anyone who is interested.
>
> If you follow a link from gmail with the mouse, it always starts in a new tab/
> window.
>
> The "C-c f" functionality in gmail mode does not do this, which is what I want
> and I keep forgetting the C-u prefix, so here is a patch to make this behaviour
> default.  Again, not very exciting, but does the job.
>
> For anyone that's interested. :)
>
> Rohan

Hi Rohan,

  I would prefer to find out why gmail behaves this way, since for
ordinary links, the follow command just creates a fake mouse-click.  By
reason, it should have the same effect as clicking with a real mouse.

--
John Foerch
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

[Vinh Nguyen]

--
This e-mail/fax message, including any attachments, is for the sole
use of the intended recipient(s) and may contain confidential and
privileged information. Any unauthorized review, use, disclosure or
distribution is prohibited. If you are not the intended recipient,
please contact the sender by reply e-mail/fax and destroy all copies
of the original message.



On Wed, Sep 2, 2009 at 2:36 AM, Rohan
Nicholls<rohan.nicholls@...> wrote:
> If you follow a link from gmail with the mouse, it always starts in a new
> tab/window.
>
> The "C-c f" functionality in gmail mode does not do this, which is what I
> want
> and I keep forgetting the C-u prefix, so here is a patch to make this
> behaviour
> default.  Again, not very exciting, but does the job.

both clicking and hitting "C-c f" in gmail mode opens the link in a
new buffer and goes there, like the command  "follow-new-buffer."
what do u get with C-c f?  i'm not getting the same behavior as you.

Vinh
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror

[Rohan Nicholls-3]

On Thu, Sep 3, 2009 at 11:21 AM, Rohan
Nicholls<rohan.nicholls@...> wrote:

> On Wed, Sep 2, 2009 at 10:30 PM, Vinh Nguyen<vinhdizzo@...> wrote:
>> On Wed, Sep 2, 2009 at 2:36 AM, Rohan
>> Nicholls<rohan.nicholls@...> wrote:
>>> If you follow a link from gmail with the mouse, it always starts in a new
>>> tab/window.
>>>
>>> The "C-c f" functionality in gmail mode does not do this, which is what I
>>> want
>>> and I keep forgetting the C-u prefix, so here is a patch to make this
>>> behaviour
>>> default.  Again, not very exciting, but does the job.
>>
>> both clicking and hitting "C-c f" in gmail mode opens the link in a
>> new buffer and goes there, like the command  "follow-new-buffer."
>> what do u get with C-c f?  i'm not getting the same behavior as you.
>>
>
> If I hit C-c f I get the link being connected to in the current frame,
> which means I lose gmail until I go back.  It has always done
> this for me, hence the change.  Maybe there is something about my
> system that causes this...
>

Okay, I am not sure what is going on, because on my machine at home, it
does what Vinh was saying, and opens the link in a new tab/window.  So,
it must be something strange with my setup.  I will mess with the mac at
work tomorrow, and see what happens.

Thanks for the help, but this seems to be a patch for me alone. :)

Rohan
_______________________________________________
Conkeror mailing list
Conkeror@...
https://www.mozdev.org/mailman/listinfo/conkeror