gnutls guile warnings

View: New views
3 Messages — Rating Filter:   Alert me  

gnutls guile warnings

by Simon Josefsson-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi Ludo,

building recent GnuTLS gives some warnings:

make[4]: Entering directory `/home/jas/src/gnutls/guile/src'
/bin/sh ../../libtool  --tag=CC   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../..  -I../../lib/includes -I../../lib/includes -I../../libextra/includes -I../.. -I.  -Wno-strict-prototypes  -I../../lib/gl -I../../lib/gl  -g -O2 -MT libguile_gnutls_v_1_la-core.lo -MD -MP -MF .deps/libguile_gnutls_v_1_la-core.Tpo -c -o libguile_gnutls_v_1_la-core.lo `test -f 'core.c' || echo './'`core.c
libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -I../../lib/includes -I../../lib/includes -I../../libextra/includes -I../.. -I. -Wno-strict-prototypes -I../../lib/gl -I../../lib/gl -g -O2 -MT libguile_gnutls_v_1_la-core.lo -MD -MP -MF .deps/libguile_gnutls_v_1_la-core.Tpo -c core.c  -fPIC -DPIC -o .libs/libguile_gnutls_v_1_la-core.o
In file included from enums.h:6,
                 from core.c:27:
../../config.h:68:1: warning: "GNUTLS_COMPAT_H" redefined
In file included from ../../lib/includes/gnutls/gnutls.h:48,
                 from core.c:22:
../../lib/includes/gnutls/compat.h:4:1: warning: this is the location of the previous definition

The cause seems simple: including "config.h" is not done as the first
thing in these files, so gnutls/compat.h ends up being included before
config.h.  The solution is to make sure "config.h" is included first.
However, I'm not sure how you would prefer to fix this, so would you
mind taking a look at this?  I can fix this later if you don't have
time, but then I'll do it my way which may not be what you want. :-)

/Simon


_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@...
http://lists.gnu.org/mailman/listinfo/gnutls-devel

Re: gnutls guile warnings

by Ludovic Courtès-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi Simon,

Simon Josefsson <simon@...> writes:

> The cause seems simple: including "config.h" is not done as the first
> thing in these files, so gnutls/compat.h ends up being included before
> config.h.  The solution is to make sure "config.h" is included first.

Indeed.  I just pushed a fix and a few minor Guile-related fixlets to
‘master’.  Please let me know if it’s OK with you.

Thanks!

Ludo’.


_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@...
http://lists.gnu.org/mailman/listinfo/gnutls-devel

Re: gnutls guile warnings

by Simon Josefsson-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

ludo@... (Ludovic Courtès) writes:

> Hi Simon,
>
> Simon Josefsson <simon@...> writes:
>
>> The cause seems simple: including "config.h" is not done as the first
>> thing in these files, so gnutls/compat.h ends up being included before
>> config.h.  The solution is to make sure "config.h" is included first.
>
> Indeed.  I just pushed a fix and a few minor Guile-related fixlets to
> ‘master’.  Please let me know if it’s OK with you.

Works fine here.  Thank you!

/Simon


_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@...
http://lists.gnu.org/mailman/listinfo/gnutls-devel