gtk-gnutella-devel Digest, Vol 34, Issue 2

View: New views
1 Messages — Rating Filter:   Alert me  

gtk-gnutella-devel Digest, Vol 34, Issue 2

by gtk-gnutella-devel-request :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Send gtk-gnutella-devel mailing list submissions to
        gtk-gnutella-devel@...

To subscribe or unsubscribe via the World Wide Web, visit
        https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel
or, via email, send a message with subject or body 'help' to
        gtk-gnutella-devel-request@...

You can reach the person managing the list at
        gtk-gnutella-devel-owner@...

When replying, please edit your Subject line so it is more specific
than "Re: Contents of gtk-gnutella-devel digest..."


Today's Topics:

   1. Re:  Odd assertion failure in iso3166.c (Bill Pringlemeir)
   2. Re:  Crash after Bitzi Lookup attempt (Larry Nieves)
   3. Re:  Odd assertion failure in iso3166.c (Raphael Manfredi)
   4. Re:  Odd assertion failure in iso3166.c (Raphael Manfredi)
   5. Re:  Odd assertion failure in iso3166.c (Matthew Lye)
   6. Re:  Odd assertion failure in iso3166.c (Raphael Manfredi)
   7.  Build problem? (Lars Nordlund)


----------------------------------------------------------------------

Message: 1
Date: Tue, 03 Nov 2009 14:25:02 -0500
From: Bill Pringlemeir <bpringle@...>
Subject: Re: [gtk-gnutella-devel] Odd assertion failure in iso3166.c
To: Matthew Lye <mlye@...>
Cc: gtk-gnutella-devel@...
Message-ID: <87r5sfs969.fsf@...>
Content-Type: text/plain; charset=us-ascii

On  3 Nov 2009, mlye@... wrote:

> Hey all,
>
> I have encountered a crash that I find rather perplexing, seemingly in
> iso3166.c:

I have had preplexing problems as well with stack traces.  I find this
method gives the best stack traces with '-02' (which will be the
default).

./gtk-gnutella --log-stderr err --log-stdout log --pause-on-crash

I run a 'topless' version on i386 debian for days and never get this
crash.  However, now that I think about it, I configure with '-U
d_enablenls' to disable multi-lingual support.

Anyways, the '--pause-on-crash' option gives better stack traces than
a core file at least for me.  Perhaps you already do this?  I haven't
run gtkg for a few days because I was intending to install a new
un-encrypted hard drive to increase performance... but I have been
putting that off so I will run the current head.

I am guessing that you are gtk2 and did you do a full build?  It is
possible that something is amiss with an incremental build; especially
if you update often and I think you had a time change like me.

fwiw,
Bill Pringlemeir.



------------------------------

Message: 2
Date: Tue, 3 Nov 2009 20:47:24 +0100
From: Larry Nieves <lanieves@...>
Subject: Re: [gtk-gnutella-devel] Crash after Bitzi Lookup attempt
To: gtk-gnutella-devel@...
Message-ID: <20091103194724.GB16920@...>
Content-Type: text/plain; charset="utf-8"

On Sun, Nov 01, 2009 at 12:13:10PM +0000, Raphael Manfredi wrote:
> Quoting Larry Nieves <lanieves@...> from ml.softs.gtk-gnutella.devel:
> :It crashes again.
> :Revision: 17150
>
> OK, try with r17153.

Great!

It is working again as expected.

Cheers!
--
Larry Alex?nder Nieves Colmen?rez               <lanieves@...>
El Liberal Venezolano                 http://liberal-venezolano.net/
GPG Public Key: 0x3F25527E
Key Fingerprint = 3C08 E8AC DE25 CEC6 731D  B9B4 BD9E 03B0 3F25 527E
gpg --recv-keys 0x3F25527E --keyserver hkp://wwwkeys.eu.pgp.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: Digital signature

------------------------------

Message: 3
Date: Tue, 3 Nov 2009 22:29:29 +0000 (UTC)
From: Raphael_Manfredi@... (Raphael Manfredi)
Subject: Re: [gtk-gnutella-devel] Odd assertion failure in iso3166.c
To: gtk-gnutella-devel@...
Message-ID: <hcqas9$a2u$1@...>
Content-Type: text/plain; charset="iso-8859-1"

Quoting Matthew Lye <mlye@...> from ml.softs.gtk-gnutella.devel:
:Hey all,
:
:I have encountered a crash that I find rather perplexing, seemingly in  
:iso3166.c:
:
:> #2  0x001e93d8 in assertion_failure (data=<value temporarily  
:> unavailable, due to optimizations>) at fast_assert.c:104
:> #3  0x001fbfc4 in iso3166_country_cc (code=0) at iso3166.c:423
:> #4  0x00189e50 in render_sources (d=<value temporarily unavailable,  
:> due to optimizations>, row=0, column=1) at fileinfo.c:284
:
:It would appear that iso316_country_cc os being passed a guint16 value  
:of 0x0, and subsequently failing the assertion "g_assert(code <  
:G_N_ELEMENTS(iso3166_countries))".  Which would not be possible,  
:unless G_N_ELEMENTS(iso3166_countries) were (a) also zero, or (b)  
:evaluated as a [negative] signed integer rather than an unsigned  
:integer.

Could be an optimizer bug.  Do you get the crash if you compile with -O0?

I agree with you the insertion failing with code=0 is unsettling, but
the stack track could be wrong, especially due to the optimization
and some arguments being passed by registers, or some calls being
inlined (like here, where render_sources() seemingly calls
iso3166_country_cc() while in fact it has to go through
guc_download_get_country().  And iso3166_country_entry() does not appear
in the stack, which is where the assertion is really.

So try with -O0 to see whether you crash at all, and then we'll get to
know what code really was.

Raphael



------------------------------

Message: 4
Date: Tue, 3 Nov 2009 22:31:54 +0000 (UTC)
From: Raphael_Manfredi@... (Raphael Manfredi)
Subject: Re: [gtk-gnutella-devel] Odd assertion failure in iso3166.c
To: gtk-gnutella-devel@...
Message-ID: <hcqb0q$a2u$2@...>
Content-Type: text/plain; charset="iso-8859-1"

Quoting Matthew Lye <mlye@...> from ml.softs.gtk-gnutella.devel:
:in frame 5:
:row = 0,
:i = 1, and
:{struct download}key = {magic = DOWNLOAD_MAGIC, src_handle =  
:2434507541, src_handle_valid = 1,
:   error_str = "Requeued due to timeout at 10:41:53 - rescheduled for  
:10:42:13 #1\00037:43 #0", '\0' <repeats 181 times>, status =  
:GTA_DL_DONE, io_opaque = 0x0, rx = 0x0, bio = 0x0,
:   server = 0x3552c80, list_idx = DL_LIST_STOPPED, file_info =  

What would be interesting here is *d->server, since this is where the
country is stored.

Raphael



------------------------------

Message: 5
Date: Tue, 3 Nov 2009 20:35:20 -0500
From: Matthew Lye <mlye@...>
Subject: Re: [gtk-gnutella-devel] Odd assertion failure in iso3166.c
To: gtk-gnutella-devel@...
Message-ID: <F6499A09-5E50-4C4D-9302-E8FBFEEB281A@...>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes


On 3-Nov-09, at 5:31 PM, Raphael Manfredi wrote:

> Quoting Matthew Lye <mlye@...> from ml.softs.gtk-
> gnutella.devel:
> :in frame 5:
> :row = 0,
> :i = 1, and
> :{struct download}key = {magic = DOWNLOAD_MAGIC, src_handle =
> :2434507541, src_handle_valid = 1,
> :   error_str = "Requeued due to timeout at 10:41:53 - rescheduled for
> :10:42:13 #1\00037:43 #0", '\0' <repeats 181 times>, status =
> :GTA_DL_DONE, io_opaque = 0x0, rx = 0x0, bio = 0x0,
> :   server = 0x3552c80, list_idx = DL_LIST_STOPPED, file_info =
>
> What would be interesting here is *d->server, since this is where the
> country is stored.

{struct dl_server}key->server = {magic = DL_SERVER_MAGIC, refcnt = 3,  
key = 0x32f62e0, list = {0x32f64e0, 0x0,
     0x335f240}, vendor = 0x4e892d0 "LimeWire/4.18.8", hostname = 0x0,
   proxies = 0x35da5d0, sha1_counts = 0x97f3390, retry_after =  
1257296421,
   dns_lookup = 0, proxies_stamp = 0, last_connect = 0, parq_version =  
{major = 0,
     minor = 7305}, speed_avg = 256, attrs = 60096512, country = 19539}

So that explains the assertion failure, at least.




------------------------------

Message: 6
Date: Wed, 4 Nov 2009 17:39:50 +0000 (UTC)
From: Raphael_Manfredi@... (Raphael Manfredi)
Subject: Re: [gtk-gnutella-devel] Odd assertion failure in iso3166.c
To: gtk-gnutella-devel@...
Message-ID: <hcse96$3pv$1@...>
Content-Type: text/plain; charset="iso-8859-1"

Quoting Matthew Lye <mlye@...> from ml.softs.gtk-gnutella.devel:
:So that explains the assertion failure, at least.

Indeed.

In r17182 I have added an assertion to check that the server's country
code remains valid at all times.  This is by no means a fix, but a starting
point to see at which time things get corrupted.

Raphael



------------------------------

Message: 7
Date: Fri, 6 Nov 2009 00:28:40 +0100
From: Lars Nordlund <lars.nordlund@...>
Subject: [gtk-gnutella-devel] Build problem?
To: gtk-gnutella-devel@...
Message-ID: <20091106002840.5c76c789@laphroaig>
Content-Type: text/plain; charset=US-ASCII

Hi

When building gtk-gnutella from HEAD I get this failure:

if test -f dba; then \
                /usr/pkgsrc/wip/gtk-gnutella-current/work/.tools/bin/mv dba dba~; fi
cc -o dba  dba.o util.o  -Lshell -lshell -Lcore -lcore -Ldht -ldht -Lui/gtk -lgtk-common -lgtkx -lgtk-common -ldht -lcore -Llib -lshared -Lsdbm -lsdbm -lshared -Wl,-R/usr/pkg/lib -L/usr/pkg/lib -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lpangocairo-1.0 -lgio-2.0 -lXext -lXrender -lXinerama -lXi -lXrandr -lXcursor -lXfixes -lpangoft2-1.0 -lcairo -lX11 -lpango-1.0 -lm -lfreetype -lfontconfig -lgobject-2.0 -lgmodule-2.0 -lglib-2.0 -lintl   -Wl,-R/usr/pkg/lib -L/usr/pkg/lib -lgobject-2.0 -lglib-2.0 -lintl   -Wl,-R/usr/pkg/lib -L/usr/pkg/lib -lxml2    -Wl,-R/usr/pkg/lib -L/usr/pkg/lib -lgnutls    -O2 -g  -L. -lsdbm -L../lib -lshared -Wl,-R/usr/pkg/lib -L/usr/pkg/lib -lgobject-2.0 -lglib-2.0 -lintl  
ld: cannot find -lshell
gmake[4]: *** [dba] Error 1

I created these patches to avoid the problem.

===> lars@laphroaig:/usr/pkgsrc/wip/gtk-gnutella-current %cat patches/patch-aa
$NetBSD$

--- src/Jmakefile.orig 2009-11-05 05:37:01.000000000 +0100
+++ src/Jmakefile
@@ -77,11 +77,11 @@ CFLAGS = -I.. -I. \
 
 DPFLAGS = $(CFLAGS)
 LDFLAGS = \
- -Lshell -lshell \
- -Lcore -lcore \
- -Ldht -ldht \
+ -L../shell -lshell \
+ -L../core -lcore \
+ -L../dht -ldht \
 |case d_headless in undef
- -Lui/gtk -lgtk-common -lgtkx -lgtk-common \
+ -L../ui/gtk -lgtk-common -lgtkx -lgtk-common \
 -case
  -ldht -lcore -Llib -lshared -Lsdbm -lsdbm -lshared \
  $(GTK_LDFLAGS) $(XML2_LDFLAGS) $(DBUS_LDFLAGS) $(GNUTLS_LDFLAGS) \
===> lars@laphroaig:/usr/pkgsrc/wip/gtk-gnutella-current %cat patches/patch-ab
$NetBSD$

--- src/Makefile.SH.orig 2009-11-05 23:54:27.000000000 +0100
+++ src/Makefile.SH
@@ -126,14 +126,14 @@ CFLAGS = -I.. -I. \
 
 DPFLAGS = $(CFLAGS)
 LDFLAGS = \
- -Lshell -lshell \
- -Lcore -lcore \
- -Ldht -ldht \
+ -L../shell -lshell \
+ -L../core -lcore \
+ -L../dht -ldht \
 !NO!SUBS!
 case "$d_headless" in
 undef)
  $spitshell >>Makefile <<'!NO!SUBS!'
- -Lui/gtk -lgtk-common -lgtkx -lgtk-common \
+ -L../ui/gtk -lgtk-common -lgtkx -lgtk-common \
 !NO!SUBS!
  ;;
 esac


I am not sure I need to patch both the Jmakefile and the Makefile.SH;
but I hope you get the idea about the problem I am seeing and the
changed -L path.

I do not understand why I am the only one seeing this? It seems no
fresh checkouts are buildable? This makes me think that I am doing
something wrong/strange here..

Best regards,
        Lars Nordlund



------------------------------

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

------------------------------

_______________________________________________
gtk-gnutella-devel mailing list
gtk-gnutella-devel@...
https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel


End of gtk-gnutella-devel Digest, Vol 34, Issue 2
*************************************************