hal truncating block.device on freebsd-8.0rc1

[J.R. Oldroyd-2]

Attached USB camera in umass mode.  Doesn't automount.

Running hald --verbose shows:

...
21:02:23.301 [W] hf-block.c:49: unable to stat /dev/msdosfs/NIKON: No such file or directory
Run started hald-probe-volume (60000) (0)
!  full path is '/usr/local/libexec/hald-probe-volume', program_dir is '/usr/local/libexec'
pid 6469: rc=1 signaled=0: /usr/local/libexec/hald-probe-volume
21:02:23.313 [I] hald.c:108: Added device to GDL; udi=/org/freedesktop/Hal/devices/volume_part2_size_4095705600_block
21:02:23.322 [I] hf-devd.c:316: received devd event: !system=DEVFS subsystem=CDEV type=CREATE cdev=pass1
21:02:23.330 [I] hf-devd.c:316: received devd event: !system=DEVFS subsystem=CDEV type=CREATE cdev=da1
21:02:23.331 [I] hf-devd.c:316: received devd event: !system=DEVFS subsystem=CDEV type=CREATE cdev=da1s1
21:02:23.331 [I] hf-devd.c:316: received devd event: !system=DEVFS subsystem=CDEV type=CREATE cdev=msdosfs/NIKON D300
...

# ls -l /dev/msdosfs
total 0
crw-r-----  1 root  operator    0, 110 Oct 22 21:02 NIKON D300

# lshal
...
udi = '/org/freedesktop/Hal/devices/volume_part2_size_4095705600_block'
  block.device = '/dev/msdosfs/NIKON'  (string)
  block.is_volume = false  (bool)
  block.storage_device = '/org/freedesktop/Hal/devices/storage_model_D300'  (string)
  info.capabilities = {'block'} (string list)
  info.category = 'block'  (string)
  info.parent = '/org/freedesktop/Hal/devices/volume_part2_size_4095705600'  (string)
  info.product = 'Block Device'  (string)
  info.subsystem = 'block'  (string)
  info.udi = '/org/freedesktop/Hal/devices/volume_part2_size_4095705600_block'  (string)
...

Looks like hal is truncating the device name from "NIKON D300" to
just "NIKON" so the mount is failing.

        -jr
_______________________________________________
freebsd-gnome@... mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "freebsd-gnome-unsubscribe@..."

[Joe Marcus Clarke-2]

On Thu, 2009-10-22 at 21:25 -0400, J.R. Oldroyd wrote:

> Attached USB camera in umass mode.  Doesn't automount.
>
> Running hald --verbose shows:
>
> ...
> 21:02:23.301 [W] hf-block.c:49: unable to stat /dev/msdosfs/NIKON: No such file or directory
> Run started hald-probe-volume (60000) (0)
> !  full path is '/usr/local/libexec/hald-probe-volume', program_dir is '/usr/local/libexec'
> pid 6469: rc=1 signaled=0: /usr/local/libexec/hald-probe-volume
> 21:02:23.313 [I] hald.c:108: Added device to GDL; udi=/org/freedesktop/Hal/devices/volume_part2_size_4095705600_block
> 21:02:23.322 [I] hf-devd.c:316: received devd event: !system=DEVFS subsystem=CDEV type=CREATE cdev=pass1
> 21:02:23.330 [I] hf-devd.c:316: received devd event: !system=DEVFS subsystem=CDEV type=CREATE cdev=da1
> 21:02:23.331 [I] hf-devd.c:316: received devd event: !system=DEVFS subsystem=CDEV type=CREATE cdev=da1s1
> 21:02:23.331 [I] hf-devd.c:316: received devd event: !system=DEVFS subsystem=CDEV type=CREATE cdev=msdosfs/NIKON D300
> ...
>
> # ls -l /dev/msdosfs
> total 0
> crw-r-----  1 root  operator    0, 110 Oct 22 21:02 NIKON D300
>
> # lshal
> ...
> udi = '/org/freedesktop/Hal/devices/volume_part2_size_4095705600_block'
>   block.device = '/dev/msdosfs/NIKON'  (string)
>   block.is_volume = false  (bool)
>   block.storage_device = '/org/freedesktop/Hal/devices/storage_model_D300'  (string)
>   info.capabilities = {'block'} (string list)
>   info.category = 'block'  (string)
>   info.parent = '/org/freedesktop/Hal/devices/volume_part2_size_4095705600'  (string)
>   info.product = 'Block Device'  (string)
>   info.subsystem = 'block'  (string)
>   info.udi = '/org/freedesktop/Hal/devices/volume_part2_size_4095705600_block'  (string)
> ...
>
> Looks like hal is truncating the device name from "NIKON D300" to
> just "NIKON" so the mount is failing.

Hal doesn't support volumes with spaces in their names.  This is
documented in the FreeBSD HAL FAQ at
http://www.freebsd.org/gnome/docs/halfaq.html .  Patches to add support
for this are very welcome.

Joe

>
> -jr
> _______________________________________________
> freebsd-gnome@... mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-gnome
> To unsubscribe, send any mail to "freebsd-gnome-unsubscribe@..."
>
--
PGP Key : http://www.marcuscom.com/pgp.asc

[J.R. Oldroyd-2]

On Fri, 23 Oct 2009 00:02:03 -0400, Joe Marcus Clarke <marcus@...> wrote:
>
> Hal doesn't support volumes with spaces in their names.  This is
> documented in the FreeBSD HAL FAQ at
> http://www.freebsd.org/gnome/docs/halfaq.html .  Patches to add support
> for this are very welcome.
>
> Joe
>

That doc, and some googling which found two year old email from you,
show that this is apparently a long-standing problem with geom/glabel.

Any pointers on where the defective code might lie?

        -jr
_______________________________________________
freebsd-gnome@... mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "freebsd-gnome-unsubscribe@..."

[Joe Marcus Clarke-2]

On Fri, 2009-10-23 at 01:37 -0400, J.R. Oldroyd wrote:

> On Fri, 23 Oct 2009 00:02:03 -0400, Joe Marcus Clarke <marcus@...> wrote:
> >
> > Hal doesn't support volumes with spaces in their names.  This is
> > documented in the FreeBSD HAL FAQ at
> > http://www.freebsd.org/gnome/docs/halfaq.html .  Patches to add support
> > for this are very welcome.
> >
> > Joe
> >
>
> That doc, and some googling which found two year old email from you,
> show that this is apparently a long-standing problem with geom/glabel.
>
> Any pointers on where the defective code might lie?

hald/freebsd/hf-storage.c.  The fix would be to process
kern.geom.confxml instead of kern.geom.conftxt.

Joe

--
PGP Key : http://www.marcuscom.com/pgp.asc

[J.R. Oldroyd-2]

On Fri, 23 Oct 2009 01:44:32 -0400, Joe Marcus Clarke <marcus@...> wrote:

>
> On Fri, 2009-10-23 at 01:37 -0400, J.R. Oldroyd wrote:
> > On Fri, 23 Oct 2009 00:02:03 -0400, Joe Marcus Clarke <marcus@...> wrote:
> > >
> > > Hal doesn't support volumes with spaces in their names.  This is
> > > documented in the FreeBSD HAL FAQ at
> > > http://www.freebsd.org/gnome/docs/halfaq.html .  Patches to add support
> > > for this are very welcome.
> > >
> > > Joe
> > >
> >
> > That doc, and some googling which found two year old email from you,
> > show that this is apparently a long-standing problem with geom/glabel.
> >
> > Any pointers on where the defective code might lie?
>
> hald/freebsd/hf-storage.c.  The fix would be to process
> kern.geom.confxml instead of kern.geom.conftxt.
>
> Joe
>

I have a simple patch to the conftxt parser that looks for LABEL
lines and appends fields until the "i" field is in the right
place.  This fixes things for this camera.

I have no other devices at hand to test to see if anything broke,
however.

The replacement files/patch-hald_hf-storage.c with the additional
patch is here:
    http://opal.com/jr/hal/patch-hald_hf-storage.c

By the way, the patch file should probably be renamed to
files/patch-hald_freebsd_hf-storage.c for consistency with the
other patch files there.

        -jr
_______________________________________________
freebsd-gnome@... mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "freebsd-gnome-unsubscribe@..."

[Joe Marcus Clarke-2]

On Fri, 2009-10-23 at 14:19 -0400, J.R. Oldroyd wrote:

> On Fri, 23 Oct 2009 01:44:32 -0400, Joe Marcus Clarke <marcus@...> wrote:
> >
> > On Fri, 2009-10-23 at 01:37 -0400, J.R. Oldroyd wrote:
> > > On Fri, 23 Oct 2009 00:02:03 -0400, Joe Marcus Clarke <marcus@...> wrote:
> > > >
> > > > Hal doesn't support volumes with spaces in their names.  This is
> > > > documented in the FreeBSD HAL FAQ at
> > > > http://www.freebsd.org/gnome/docs/halfaq.html .  Patches to add support
> > > > for this are very welcome.
> > > >
> > > > Joe
> > > >
> > >
> > > That doc, and some googling which found two year old email from you,
> > > show that this is apparently a long-standing problem with geom/glabel.
> > >
> > > Any pointers on where the defective code might lie?
> >
> > hald/freebsd/hf-storage.c.  The fix would be to process
> > kern.geom.confxml instead of kern.geom.conftxt.
> >
> > Joe
> >
>
> I have a simple patch to the conftxt parser that looks for LABEL
> lines and appends fields until the "i" field is in the right
> place.  This fixes things for this camera.
>
> I have no other devices at hand to test to see if anything broke,
> however.
>
> The replacement files/patch-hald_hf-storage.c with the additional
> patch is here:
>     http://opal.com/jr/hal/patch-hald_hf-storage.c

Thanks.  I believe this will work given that the format of conftxt looks
to be consistent across 6.X, 7.X, 8.X, and 9.X.  I've modified the patch
some for safety and style, and added it to hal-0.5.13 which will be
committed with GNOME 2.28 when 8.0 is released.

Joe

>
> By the way, the patch file should probably be renamed to
> files/patch-hald_freebsd_hf-storage.c for consistency with the
> other patch files there.
>
> -jr
>
--
PGP Key : http://www.marcuscom.com/pgp.asc

[J.R. Oldroyd-2]

On Sat, 24 Oct 2009 02:35:42 -0400, Joe Marcus Clarke <marcus@...> wrote:
> >
> > I have a simple patch to the conftxt parser that looks for LABEL
> > lines and appends fields until the "i" field is in the right
> > place.  This fixes things for this camera.
> >

> Thanks.  I believe this will work given that the format of conftxt looks
> to be consistent across 6.X, 7.X, 8.X, and 9.X.  I've modified the patch
> some for safety and style, and added it to hal-0.5.13 which will be
> committed with GNOME 2.28 when 8.0 is released.
>
> Joe
>

You're welcome.

Your earlier note about parsing confxml would probably be the
correct, long-term solution.  This solution will not properly
handle names with multiple spaces or with tabs - the parser will
eliminate those and leave just single spaces.

But I don't have time to write an xml parser!  And I think this
solution is an improvement over not having it at all.  I suspect
devices that use multiple spaces or tabs are rare.

Don't forget to update the documentation at that URL you sent me
too.

        -jr
_______________________________________________
freebsd-gnome@... mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "freebsd-gnome-unsubscribe@..."