hg: jdk7/2d/jdk: 6795908: Refactor FontManager
|
View:
New views
14 Messages
—
Rating Filter:
Alert me
|
 |
hg: jdk7/2d/jdk: 6795908: Refactor FontManager
by Roman Kennke-2
::
Rate this Message:
Changeset: 64b0c953635d
Author: rkennke Date: 2009-08-07 18:31 +0200 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/64b0c953635d 6795908: Refactor FontManager Reviewed-by: prr, igor ! make/sun/awt/FILES_export_windows.gmk ! make/sun/awt/make.depend ! make/sun/awt/mapfile-mawt-vers ! make/sun/awt/mapfile-vers-linux ! make/sun/font/mapfile-vers ! make/sun/font/mapfile-vers.openjdk ! make/sun/headless/mapfile-vers ! make/sun/xawt/mapfile-vers ! src/share/classes/com/sun/java/swing/plaf/gtk/PangoFonts.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Font.java ! src/share/classes/java/awt/GraphicsEnvironment.java ! src/share/classes/javax/swing/plaf/nimbus/Defaults.template ! src/share/classes/javax/swing/text/StyleContext.java ! src/share/classes/sun/awt/FontConfiguration.java ! src/share/classes/sun/font/CMap.java ! src/share/classes/sun/font/CompositeFont.java ! src/share/classes/sun/font/CompositeGlyphMapper.java ! src/share/classes/sun/font/FileFont.java ! src/share/classes/sun/font/FileFontStrike.java ! src/share/classes/sun/font/FontDesignMetrics.java ! src/share/classes/sun/font/FontFamily.java ! src/share/classes/sun/font/FontManager.java ! src/share/classes/sun/font/FontManagerNativeLibrary.java ! src/share/classes/sun/font/FontResolver.java ! src/share/classes/sun/font/FontScaler.java ! src/share/classes/sun/font/FreetypeFontScaler.java ! src/share/classes/sun/font/GlyphLayout.java ! src/share/classes/sun/font/PhysicalStrike.java ! src/share/classes/sun/font/StandardGlyphVector.java ! src/share/classes/sun/font/StrikeCache.java ! src/share/classes/sun/font/TrueTypeFont.java ! src/share/classes/sun/font/TrueTypeGlyphMapper.java ! src/share/classes/sun/font/Type1Font.java ! src/share/classes/sun/font/Type1GlyphMapper.java ! src/share/classes/sun/java2d/SunGraphics2D.java ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java ! src/share/classes/sun/print/PSPrinterJob.java ! src/share/classes/sun/print/PathGraphics.java ! src/share/classes/sun/swing/SwingUtilities2.java ! src/share/native/sun/font/sunFont.c ! src/share/native/sun/font/sunfontids.h ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java ! src/solaris/classes/sun/awt/motif/MFontConfiguration.java ! src/solaris/classes/sun/awt/motif/MToolkit.java ! src/solaris/classes/sun/font/FcFontConfiguration.java ! src/solaris/classes/sun/font/NativeFont.java ! src/solaris/classes/sun/font/NativeStrike.java ! src/solaris/native/sun/awt/fontpath.c ! src/windows/classes/sun/awt/Win32GraphicsEnvironment.java ! src/windows/classes/sun/awt/windows/WFontConfiguration.java ! src/windows/classes/sun/awt/windows/WPathGraphics.java ! src/windows/classes/sun/awt/windows/WPrinterJob.java ! src/windows/classes/sun/awt/windows/WToolkit.java ! src/windows/native/sun/font/fontpath.c ! src/windows/native/sun/windows/awt_Win32GraphicsEnv.cpp |
|
|
Re: hg: jdk7/2d/jdk: 6795908: Refactor FontManager
by gnu_andrew
::
Rate this Message:
2009/8/7 <roman@...>:
> Changeset: 64b0c953635d > Author: rkennke > Date: 2009-08-07 18:31 +0200 > URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/64b0c953635d > > 6795908: Refactor FontManager > Reviewed-by: prr, igor > > ! make/sun/awt/FILES_export_windows.gmk > ! make/sun/awt/make.depend > ! make/sun/awt/mapfile-mawt-vers > ! make/sun/awt/mapfile-vers-linux > ! make/sun/font/mapfile-vers > ! make/sun/font/mapfile-vers.openjdk > ! make/sun/headless/mapfile-vers > ! make/sun/xawt/mapfile-vers > ! src/share/classes/com/sun/java/swing/plaf/gtk/PangoFonts.java > ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java > ! src/share/classes/java/awt/Component.java > ! src/share/classes/java/awt/Font.java > ! src/share/classes/java/awt/GraphicsEnvironment.java > ! src/share/classes/javax/swing/plaf/nimbus/Defaults.template > ! src/share/classes/javax/swing/text/StyleContext.java > ! src/share/classes/sun/awt/FontConfiguration.java > ! src/share/classes/sun/font/CMap.java > ! src/share/classes/sun/font/CompositeFont.java > ! src/share/classes/sun/font/CompositeGlyphMapper.java > ! src/share/classes/sun/font/FileFont.java > ! src/share/classes/sun/font/FileFontStrike.java > ! src/share/classes/sun/font/FontDesignMetrics.java > ! src/share/classes/sun/font/FontFamily.java > ! src/share/classes/sun/font/FontManager.java > ! src/share/classes/sun/font/FontManagerNativeLibrary.java > ! src/share/classes/sun/font/FontResolver.java > ! src/share/classes/sun/font/FontScaler.java > ! src/share/classes/sun/font/FreetypeFontScaler.java > ! src/share/classes/sun/font/GlyphLayout.java > ! src/share/classes/sun/font/PhysicalStrike.java > ! src/share/classes/sun/font/StandardGlyphVector.java > ! src/share/classes/sun/font/StrikeCache.java > ! src/share/classes/sun/font/TrueTypeFont.java > ! src/share/classes/sun/font/TrueTypeGlyphMapper.java > ! src/share/classes/sun/font/Type1Font.java > ! src/share/classes/sun/font/Type1GlyphMapper.java > ! src/share/classes/sun/java2d/SunGraphics2D.java > ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java > ! src/share/classes/sun/print/PSPrinterJob.java > ! src/share/classes/sun/print/PathGraphics.java > ! src/share/classes/sun/swing/SwingUtilities2.java > ! src/share/native/sun/font/sunFont.c > ! src/share/native/sun/font/sunfontids.h > ! src/solaris/classes/sun/awt/X11/XToolkit.java > ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java > ! src/solaris/classes/sun/awt/motif/MFontConfiguration.java > ! src/solaris/classes/sun/awt/motif/MToolkit.java > ! src/solaris/classes/sun/font/FcFontConfiguration.java > ! src/solaris/classes/sun/font/NativeFont.java > ! src/solaris/classes/sun/font/NativeStrike.java > ! src/solaris/native/sun/awt/fontpath.c > ! src/windows/classes/sun/awt/Win32GraphicsEnvironment.java > ! src/windows/classes/sun/awt/windows/WFontConfiguration.java > ! src/windows/classes/sun/awt/windows/WPathGraphics.java > ! src/windows/classes/sun/awt/windows/WPrinterJob.java > ! src/windows/classes/sun/awt/windows/WToolkit.java > ! src/windows/native/sun/font/fontpath.c > ! src/windows/native/sun/windows/awt_Win32GraphicsEnv.cpp > > This change breaks bootstrapping: /mnt/builder/icedtea7/bootstrap/jdk1.6.0/bin/javac -J-XX:ThreadStackSize=1536 -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx896m -J-Xms128m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -encoding ascii -source 6 -target 6 -XDignore.symbol.file=true -d /mnt/builder/icedtea7/openjdk-boot/build/linux-amd64/btclasses \ -sourcepath ../../tools/src -classpath /mnt/builder/icedtea7/bootstrap/jdk1.7.0/jre/lib/rt-closed.jar \ ../../tools/src/build/tools/fontchecker/FontChecker.java Annotation processing got disabled, since it requires a 1.6 compliant JVM ---------- 1. ERROR in ../../tools/src/build/tools/fontchecker/FontChecker.java (at line 339) String fontPath = FontManager.getFontPath(true); ^^^^^^^^^^^ The method getFontPath(boolean) is undefined for the type FontManager With the change to FontManager, getFontPath(boolean) is now in SunFontManager on JDK7 making it impossible to bootstrap with OpenJDK7 itself (SunFontManager.getFontPath(boolean)) and OpenJDK6 (FontManager.getFontPath(boolean)). Can we please either move getFontPath back into FontManager or change the fontchecker tool? Thanks, -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 |
|
|
Re: hg: jdk7/2d/jdk: 6795908: Refactor FontManager
by phil.race
::
Rate this Message:
Or we could stop building fontchecker and discard it.
It was introduced in the 1.4.2 when we had native code that sometimes crashed the JRE on seeing a bad font file. The windows jre installer used it in 1.4.2 and 1.5. The installer stopped using it in 1.6 (6239557) but we continued to build it. Looks like in JDK7 build 20 Kelly moved some things around in prep. for openjdk and we probably lost track it still existed, much less is being built. There's also a version in the closed/src/test directory that was intended as a standalone manual test tool, but can't have been buildable since 1.4.x days! -phil. Andrew John Hughes wrote: > 2009/8/7 <roman@...>: >> Changeset: 64b0c953635d >> Author: rkennke >> Date: 2009-08-07 18:31 +0200 >> URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/64b0c953635d >> >> 6795908: Refactor FontManager >> Reviewed-by: prr, igor >> >> ! make/sun/awt/FILES_export_windows.gmk >> ! make/sun/awt/make.depend >> ! make/sun/awt/mapfile-mawt-vers >> ! make/sun/awt/mapfile-vers-linux >> ! make/sun/font/mapfile-vers >> ! make/sun/font/mapfile-vers.openjdk >> ! make/sun/headless/mapfile-vers >> ! make/sun/xawt/mapfile-vers >> ! src/share/classes/com/sun/java/swing/plaf/gtk/PangoFonts.java >> ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java >> ! src/share/classes/java/awt/Component.java >> ! src/share/classes/java/awt/Font.java >> ! src/share/classes/java/awt/GraphicsEnvironment.java >> ! src/share/classes/javax/swing/plaf/nimbus/Defaults.template >> ! src/share/classes/javax/swing/text/StyleContext.java >> ! src/share/classes/sun/awt/FontConfiguration.java >> ! src/share/classes/sun/font/CMap.java >> ! src/share/classes/sun/font/CompositeFont.java >> ! src/share/classes/sun/font/CompositeGlyphMapper.java >> ! src/share/classes/sun/font/FileFont.java >> ! src/share/classes/sun/font/FileFontStrike.java >> ! src/share/classes/sun/font/FontDesignMetrics.java >> ! src/share/classes/sun/font/FontFamily.java >> ! src/share/classes/sun/font/FontManager.java >> ! src/share/classes/sun/font/FontManagerNativeLibrary.java >> ! src/share/classes/sun/font/FontResolver.java >> ! src/share/classes/sun/font/FontScaler.java >> ! src/share/classes/sun/font/FreetypeFontScaler.java >> ! src/share/classes/sun/font/GlyphLayout.java >> ! src/share/classes/sun/font/PhysicalStrike.java >> ! src/share/classes/sun/font/StandardGlyphVector.java >> ! src/share/classes/sun/font/StrikeCache.java >> ! src/share/classes/sun/font/TrueTypeFont.java >> ! src/share/classes/sun/font/TrueTypeGlyphMapper.java >> ! src/share/classes/sun/font/Type1Font.java >> ! src/share/classes/sun/font/Type1GlyphMapper.java >> ! src/share/classes/sun/java2d/SunGraphics2D.java >> ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java >> ! src/share/classes/sun/print/PSPrinterJob.java >> ! src/share/classes/sun/print/PathGraphics.java >> ! src/share/classes/sun/swing/SwingUtilities2.java >> ! src/share/native/sun/font/sunFont.c >> ! src/share/native/sun/font/sunfontids.h >> ! src/solaris/classes/sun/awt/X11/XToolkit.java >> ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java >> ! src/solaris/classes/sun/awt/motif/MFontConfiguration.java >> ! src/solaris/classes/sun/awt/motif/MToolkit.java >> ! src/solaris/classes/sun/font/FcFontConfiguration.java >> ! src/solaris/classes/sun/font/NativeFont.java >> ! src/solaris/classes/sun/font/NativeStrike.java >> ! src/solaris/native/sun/awt/fontpath.c >> ! src/windows/classes/sun/awt/Win32GraphicsEnvironment.java >> ! src/windows/classes/sun/awt/windows/WFontConfiguration.java >> ! src/windows/classes/sun/awt/windows/WPathGraphics.java >> ! src/windows/classes/sun/awt/windows/WPrinterJob.java >> ! src/windows/classes/sun/awt/windows/WToolkit.java >> ! src/windows/native/sun/font/fontpath.c >> ! src/windows/native/sun/windows/awt_Win32GraphicsEnv.cpp >> >> > > This change breaks bootstrapping: > > /mnt/builder/icedtea7/bootstrap/jdk1.6.0/bin/javac > -J-XX:ThreadStackSize=1536 -J-XX:-PrintVMOptions > -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx896m > -J-Xms128m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -encoding ascii > -source 6 -target 6 -XDignore.symbol.file=true -d > /mnt/builder/icedtea7/openjdk-boot/build/linux-amd64/btclasses \ > -sourcepath ../../tools/src -classpath > /mnt/builder/icedtea7/bootstrap/jdk1.7.0/jre/lib/rt-closed.jar \ > ../../tools/src/build/tools/fontchecker/FontChecker.java > Annotation processing got disabled, since it requires a 1.6 compliant JVM > ---------- > 1. ERROR in ../../tools/src/build/tools/fontchecker/FontChecker.java > (at line 339) > String fontPath = FontManager.getFontPath(true); > ^^^^^^^^^^^ > The method getFontPath(boolean) is undefined for the type FontManager > > With the change to FontManager, getFontPath(boolean) is now in > SunFontManager on JDK7 making it impossible to bootstrap with OpenJDK7 > itself (SunFontManager.getFontPath(boolean)) and OpenJDK6 > (FontManager.getFontPath(boolean)). > > Can we please either move getFontPath back into FontManager or change > the fontchecker tool? > > Thanks, |
|
|
hg: jdk7/2d/jdk: 6795908: Refactor FontManager
by Kelly O'Hair
::
Rate this Message:
Is someone fixing this bootstrap build problem with FontManager.getFontPath(true) and the fontchecker? Not sure I care much how it gets fixed, I just need it fixed. -kto |
|
|
Re: hg: jdk7/2d/jdk: 6795908: Refactor FontManager
by gnu_andrew
::
Rate this Message:
2009/10/26 Kelly O'Hair <Kelly.Ohair@...>:
> > Is someone fixing this bootstrap build problem with > FontManager.getFontPath(true) and the fontchecker? > > Not sure I care much how it gets fixed, I just need it fixed. > > -kto > > You and me both! I'll look at removing fontchecker. -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 |
|
|
Re: hg: jdk7/2d/jdk: 6795908: Refactor FontManager
by Igor Nekrestyanov
::
Rate this Message:
Andrew,
i've filed 6895287 for this and plan to fix it soon. (this will likely a bit faster in terms of "time to get fix into master"). -igor On 10/26/09 11:19 AM, Andrew John Hughes wrote: > 2009/10/26 Kelly O'Hair<Kelly.Ohair@...>: > >> Is someone fixing this bootstrap build problem with >> FontManager.getFontPath(true) and the fontchecker? >> >> Not sure I care much how it gets fixed, I just need it fixed. >> >> -kto >> >> >> > You and me both! I'll look at removing fontchecker. > |
|
|
Re: hg: jdk7/2d/jdk: 6795908: Refactor FontManager
by gnu_andrew
::
Rate this Message:
2009/10/26 Igor Nekrestyanov <Igor.Nekrestyanov@...>:
> Andrew, > > i've filed 6895287 for this and plan to fix it soon. > (this will likely a bit faster in terms of "time to get fix into master"). > > -igor > Thanks for filing a bug ID for this. I'm already working on a webrev for this, so let's not duplicate the work. I'll post it as soon as it builds. > On 10/26/09 11:19 AM, Andrew John Hughes wrote: >> >> 2009/10/26 Kelly O'Hair<Kelly.Ohair@...>: >> >>> >>> Is someone fixing this bootstrap build problem with >>> FontManager.getFontPath(true) and the fontchecker? >>> >>> Not sure I care much how it gets fixed, I just need it fixed. >>> >>> -kto >>> >>> >>> >> >> You and me both! I'll look at removing fontchecker. >> > > -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 |
|
|
Re: hg: jdk7/2d/jdk: 6795908: Refactor FontManager
by phil.race
::
Rate this Message:
Igor is also fixing the closed src ..
-phil. Andrew John Hughes wrote: > 2009/10/26 Igor Nekrestyanov <Igor.Nekrestyanov@...>: > >> Andrew, >> >> i've filed 6895287 for this and plan to fix it soon. >> (this will likely a bit faster in terms of "time to get fix into master"). >> >> -igor >> >> > > Thanks for filing a bug ID for this. I'm already working on a webrev > for this, so let's not duplicate the work. I'll post it as soon as it > builds. > > >> On 10/26/09 11:19 AM, Andrew John Hughes wrote: >> >>> 2009/10/26 Kelly O'Hair<Kelly.Ohair@...>: >>> >>> >>>> Is someone fixing this bootstrap build problem with >>>> FontManager.getFontPath(true) and the fontchecker? >>>> >>>> Not sure I care much how it gets fixed, I just need it fixed. >>>> >>>> -kto >>>> >>>> >>>> >>>> >>> You and me both! I'll look at removing fontchecker. >>> >>> >> > > > > |
|
|
Re: hg: jdk7/2d/jdk: 6795908: Refactor FontManager
by Igor Nekrestyanov
::
Rate this Message:
I think that's ok.
I can take Andrew's webrev and apply my changes and then putback to both workspaces. -igor On 10/26/09 1:16 PM, Phil Race wrote: > Igor is also fixing the closed src .. > > -phil. > > Andrew John Hughes wrote: >> 2009/10/26 Igor Nekrestyanov <Igor.Nekrestyanov@...>: >>> Andrew, >>> >>> i've filed 6895287 for this and plan to fix it soon. >>> (this will likely a bit faster in terms of "time to get fix into >>> master"). >>> >>> -igor >>> >> >> Thanks for filing a bug ID for this. I'm already working on a webrev >> for this, so let's not duplicate the work. I'll post it as soon as it >> builds. >> >>> On 10/26/09 11:19 AM, Andrew John Hughes wrote: >>>> 2009/10/26 Kelly O'Hair<Kelly.Ohair@...>: >>>> >>>>> Is someone fixing this bootstrap build problem with >>>>> FontManager.getFontPath(true) and the fontchecker? >>>>> >>>>> Not sure I care much how it gets fixed, I just need it fixed. >>>>> >>>>> -kto >>>>> >>>>> >>>>> >>>> You and me both! I'll look at removing fontchecker. >>>> >> >> >> > |
|
|
Re: hg: jdk7/2d/jdk: 6795908: Refactor FontManager
by gnu_andrew
::
Rate this Message:
2009/10/26 Phil Race <Phil.Race@...>:
> Igor is also fixing the closed src .. > > -phil. > Right, well obviously I can't fix the proprietary source code base by definition. I don't think that's an acceptable reason for refusing external contributions. If you want to continue to maintain a proprietary version as well, then you need to be prepared to integrate community contributions into it. I've applied the following webrev to the AWT tree: http://cr.openjdk.java.net/~andrew/6895287/webrev.01/ and it builds. It also works when applied to the IcedTea forest, removing the original error I posted. Just give the nod and I can push this. > Andrew John Hughes wrote: >> >> 2009/10/26 Igor Nekrestyanov <Igor.Nekrestyanov@...>: >> >>> >>> Andrew, >>> >>> i've filed 6895287 for this and plan to fix it soon. >>> (this will likely a bit faster in terms of "time to get fix into >>> master"). >>> >>> -igor >>> >>> >> >> Thanks for filing a bug ID for this. I'm already working on a webrev >> for this, so let's not duplicate the work. I'll post it as soon as it >> builds. >> >> >>> >>> On 10/26/09 11:19 AM, Andrew John Hughes wrote: >>> >>>> >>>> 2009/10/26 Kelly O'Hair<Kelly.Ohair@...>: >>>> >>>> >>>>> >>>>> Is someone fixing this bootstrap build problem with >>>>> FontManager.getFontPath(true) and the fontchecker? >>>>> >>>>> Not sure I care much how it gets fixed, I just need it fixed. >>>>> >>>>> -kto >>>>> >>>>> >>>>> >>>>> >>>> >>>> You and me both! I'll look at removing fontchecker. >>>> >>>> >>> >>> >> >> >> >> > > -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 |
|
|
Re: hg: jdk7/2d/jdk: 6795908: Refactor FontManager
by phil.race
::
Rate this Message:
The fix looks fine. I think it should go via the build forest, in the
expectation that build is likely to integrate to master before AWT or 2D (which would have been the second choice). And its not a proprietary vs open thing, rather it seemed more efficient to me to do both at once. -phil. Andrew John Hughes wrote: > 2009/10/26 Phil Race <Phil.Race@...>: > >> Igor is also fixing the closed src .. >> >> -phil. >> >> > > Right, well obviously I can't fix the proprietary source code base by > definition. I don't think that's an acceptable reason for refusing > external contributions. If you want to continue to maintain a > proprietary version as well, then you need to be prepared to integrate > community contributions into it. > > I've applied the following webrev to the AWT tree: > > http://cr.openjdk.java.net/~andrew/6895287/webrev.01/ > > and it builds. It also works when applied to the IcedTea forest, > removing the original error I posted. > > Just give the nod and I can push this. > > >> Andrew John Hughes wrote: >> >>> 2009/10/26 Igor Nekrestyanov <Igor.Nekrestyanov@...>: >>> >>> >>>> Andrew, >>>> >>>> i've filed 6895287 for this and plan to fix it soon. >>>> (this will likely a bit faster in terms of "time to get fix into >>>> master"). >>>> >>>> -igor >>>> >>>> >>>> >>> Thanks for filing a bug ID for this. I'm already working on a webrev >>> for this, so let's not duplicate the work. I'll post it as soon as it >>> builds. >>> >>> >>> >>>> On 10/26/09 11:19 AM, Andrew John Hughes wrote: >>>> >>>> >>>>> 2009/10/26 Kelly O'Hair<Kelly.Ohair@...>: >>>>> >>>>> >>>>> >>>>>> Is someone fixing this bootstrap build problem with >>>>>> FontManager.getFontPath(true) and the fontchecker? >>>>>> >>>>>> Not sure I care much how it gets fixed, I just need it fixed. >>>>>> >>>>>> -kto >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>> You and me both! I'll look at removing fontchecker. >>>>> >>>>> >>>>> >>>> >>> >>> >>> >> > > > > |
|
|
Re: hg: jdk7/2d/jdk: 6795908: Refactor FontManager
by gnu_andrew
::
Rate this Message:
2009/10/26 Phil Race <Phil.Race@...>:
> The fix looks fine. I think it should go via the build forest, in the > expectation > that build is likely to integrate to master before AWT or 2D (which > would have been the second choice). > Ok, I can push this now or do you still want to? > And its not a proprietary vs open thing, rather it seemed more efficient > to me to do both at once. > Yes, I agree that's (slightly) more efficient but my point was that only Sun developers can patch the proprietary tree - I don't have the option of doing 'both at once'. So, by taking such a stance you're effectively ruling out direct external contribution. > -phil. > > Andrew John Hughes wrote: >> >> 2009/10/26 Phil Race <Phil.Race@...>: >> >>> >>> Igor is also fixing the closed src .. >>> >>> -phil. >>> >>> >> >> Right, well obviously I can't fix the proprietary source code base by >> definition. I don't think that's an acceptable reason for refusing >> external contributions. If you want to continue to maintain a >> proprietary version as well, then you need to be prepared to integrate >> community contributions into it. >> >> I've applied the following webrev to the AWT tree: >> >> http://cr.openjdk.java.net/~andrew/6895287/webrev.01/ >> >> and it builds. It also works when applied to the IcedTea forest, >> removing the original error I posted. >> >> Just give the nod and I can push this. >> >> >>> >>> Andrew John Hughes wrote: >>> >>>> >>>> 2009/10/26 Igor Nekrestyanov <Igor.Nekrestyanov@...>: >>>> >>>> >>>>> >>>>> Andrew, >>>>> >>>>> i've filed 6895287 for this and plan to fix it soon. >>>>> (this will likely a bit faster in terms of "time to get fix into >>>>> master"). >>>>> >>>>> -igor >>>>> >>>>> >>>>> >>>> >>>> Thanks for filing a bug ID for this. I'm already working on a webrev >>>> for this, so let's not duplicate the work. I'll post it as soon as it >>>> builds. >>>> >>>> >>>> >>>>> >>>>> On 10/26/09 11:19 AM, Andrew John Hughes wrote: >>>>> >>>>> >>>>>> >>>>>> 2009/10/26 Kelly O'Hair<Kelly.Ohair@...>: >>>>>> >>>>>> >>>>>> >>>>>>> >>>>>>> Is someone fixing this bootstrap build problem with >>>>>>> FontManager.getFontPath(true) and the fontchecker? >>>>>>> >>>>>>> Not sure I care much how it gets fixed, I just need it fixed. >>>>>>> >>>>>>> -kto >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> You and me both! I'll look at removing fontchecker. >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>> >>>> >>>> >>> >>> >> >> >> >> > > -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 |
|
|
Re: hg: jdk7/2d/jdk: 6795908: Refactor FontManager
by phil.race
::
Rate this Message:
Andrew John Hughes wrote:
> 2009/10/26 Phil Race <Phil.Race@...>: > >> The fix looks fine. I think it should go via the build forest, in the >> expectation >> that build is likely to integrate to master before AWT or 2D (which >> would have been the second choice). >> >> > > Ok, I can push this now or do you still want to? > You can go ahead but I think it would be better to push it to build-dev. Acc. to http://openjdk.java.net/projects/jdk7/builds/ AWT/Swing integrate right before build, but I'm not sure AWT are integrating this time and if they I think a PIT build repo has already been spun off since its now so close to the integration slot. -phil. > >> And its not a proprietary vs open thing, rather it seemed more efficient >> to me to do both at once. >> >> > > Yes, I agree that's (slightly) more efficient but my point was that > only Sun developers can patch the proprietary tree - I don't have the > option of doing 'both at once'. So, by taking such a stance you're > effectively ruling out direct external contribution. > > >> -phil. >> >> Andrew John Hughes wrote: >> >>> 2009/10/26 Phil Race <Phil.Race@...>: >>> >>> >>>> Igor is also fixing the closed src .. >>>> >>>> -phil. >>>> >>>> >>>> >>> Right, well obviously I can't fix the proprietary source code base by >>> definition. I don't think that's an acceptable reason for refusing >>> external contributions. If you want to continue to maintain a >>> proprietary version as well, then you need to be prepared to integrate >>> community contributions into it. >>> >>> I've applied the following webrev to the AWT tree: >>> >>> http://cr.openjdk.java.net/~andrew/6895287/webrev.01/ >>> >>> and it builds. It also works when applied to the IcedTea forest, >>> removing the original error I posted. >>> >>> Just give the nod and I can push this. >>> >>> >>> >>>> Andrew John Hughes wrote: >>>> >>>> >>>>> 2009/10/26 Igor Nekrestyanov <Igor.Nekrestyanov@...>: >>>>> >>>>> >>>>> >>>>>> Andrew, >>>>>> >>>>>> i've filed 6895287 for this and plan to fix it soon. >>>>>> (this will likely a bit faster in terms of "time to get fix into >>>>>> master"). >>>>>> >>>>>> -igor >>>>>> >>>>>> >>>>>> >>>>>> >>>>> Thanks for filing a bug ID for this. I'm already working on a webrev >>>>> for this, so let's not duplicate the work. I'll post it as soon as it >>>>> builds. >>>>> >>>>> >>>>> >>>>> >>>>>> On 10/26/09 11:19 AM, Andrew John Hughes wrote: >>>>>> >>>>>> >>>>>> >>>>>>> 2009/10/26 Kelly O'Hair<Kelly.Ohair@...>: >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>>> Is someone fixing this bootstrap build problem with >>>>>>>> FontManager.getFontPath(true) and the fontchecker? >>>>>>>> >>>>>>>> Not sure I care much how it gets fixed, I just need it fixed. >>>>>>>> >>>>>>>> -kto >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> You and me both! I'll look at removing fontchecker. >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>>> >>> >>> >>> >> > > > > |
|
|
Re: hg: jdk7/2d/jdk: 6795908: Refactor FontManager
by gnu_andrew
::
Rate this Message:
2009/10/26 Phil Race <Phil.Race@...>:
> Andrew John Hughes wrote: >> >> 2009/10/26 Phil Race <Phil.Race@...>: >> >>> >>> The fix looks fine. I think it should go via the build forest, in the >>> expectation >>> that build is likely to integrate to master before AWT or 2D (which >>> would have been the second choice). >>> >>> >> >> Ok, I can push this now or do you still want to? >> > > You can go ahead but I think it would be better to push it to build-dev. > > Acc. to http://openjdk.java.net/projects/jdk7/builds/ AWT/Swing integrate > right before build, but I'm not sure AWT are integrating this time and if > they I think a PIT build repo has already been spun off since its now so > close > to the integration slot. Sorry, should have been clearer. I agree with your logic on this, and so intended to (and did) push to build-dev: http://hg.openjdk.java.net/jdk7/build/jdk/rev/9bc5338675e0 > > -phil. > > > > >> >>> >>> And its not a proprietary vs open thing, rather it seemed more efficient >>> to me to do both at once. >>> >>> >> >> Yes, I agree that's (slightly) more efficient but my point was that >> only Sun developers can patch the proprietary tree - I don't have the >> option of doing 'both at once'. So, by taking such a stance you're >> effectively ruling out direct external contribution. >> >> >>> >>> -phil. >>> >>> Andrew John Hughes wrote: >>> >>>> >>>> 2009/10/26 Phil Race <Phil.Race@...>: >>>> >>>> >>>>> >>>>> Igor is also fixing the closed src .. >>>>> >>>>> -phil. >>>>> >>>>> >>>>> >>>> >>>> Right, well obviously I can't fix the proprietary source code base by >>>> definition. I don't think that's an acceptable reason for refusing >>>> external contributions. If you want to continue to maintain a >>>> proprietary version as well, then you need to be prepared to integrate >>>> community contributions into it. >>>> >>>> I've applied the following webrev to the AWT tree: >>>> >>>> http://cr.openjdk.java.net/~andrew/6895287/webrev.01/ >>>> >>>> and it builds. It also works when applied to the IcedTea forest, >>>> removing the original error I posted. >>>> >>>> Just give the nod and I can push this. >>>> >>>> >>>> >>>>> >>>>> Andrew John Hughes wrote: >>>>> >>>>> >>>>>> >>>>>> 2009/10/26 Igor Nekrestyanov <Igor.Nekrestyanov@...>: >>>>>> >>>>>> >>>>>> >>>>>>> >>>>>>> Andrew, >>>>>>> >>>>>>> i've filed 6895287 for this and plan to fix it soon. >>>>>>> (this will likely a bit faster in terms of "time to get fix into >>>>>>> master"). >>>>>>> >>>>>>> -igor >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> Thanks for filing a bug ID for this. I'm already working on a webrev >>>>>> for this, so let's not duplicate the work. I'll post it as soon as it >>>>>> builds. >>>>>> >>>>>> >>>>>> >>>>>> >>>>>>> >>>>>>> On 10/26/09 11:19 AM, Andrew John Hughes wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> 2009/10/26 Kelly O'Hair<Kelly.Ohair@...>: >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> Is someone fixing this bootstrap build problem with >>>>>>>>> FontManager.getFontPath(true) and the fontchecker? >>>>>>>>> >>>>>>>>> Not sure I care much how it gets fixed, I just need it fixed. >>>>>>>>> >>>>>>>>> -kto >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> You and me both! I'll look at removing fontchecker. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>> >>>> >>>> >>> >>> >> >> >> >> > > -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 |
| Free embeddable forum powered by Nabble | Forum Help |
