hg: jdk7/tl/jdk: 6880672: Replace quicksort in java.util.Arrays with dual-pivot implementation

View: New views
2 Messages — Rating Filter:   Alert me  

hg: jdk7/tl/jdk: 6880672: Replace quicksort in java.util.Arrays with dual-pivot implementation

by Alan Bateman :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Changeset: b05abb410c52
Author:    alanb
Date:      2009-10-29 11:18 +0000
URL:       http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b05abb410c52

6880672: Replace quicksort in java.util.Arrays with dual-pivot implementation
Reviewed-by: jjb
Contributed-by: vladimir.yaroslavskiy@..., joshua.bloch@..., jbentley@...

! make/java/java/FILES_java.gmk
! src/share/classes/java/util/Arrays.java
+ src/share/classes/java/util/DualPivotQuicksort.java


Re: hg: jdk7/tl/jdk: 6880672: Replace quicksort in java.util.Arrays with dual-pivot implementation

by jonathan.gibbons :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Alan.Bateman@... wrote:

> Changeset: b05abb410c52
> Author:    alanb
> Date:      2009-10-29 11:18 +0000
> URL:       http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b05abb410c52
>
> 6880672: Replace quicksort in java.util.Arrays with dual-pivot implementation
> Reviewed-by: jjb
> Contributed-by: vladimir.yaroslavskiy@..., joshua.bloch@..., jbentley@...
>
> ! make/java/java/FILES_java.gmk
> ! src/share/classes/java/util/Arrays.java
> + src/share/classes/java/util/DualPivotQuicksort.java
>
>  

Alan,

My hudson falls over with a stack overflow at
DualPivotQuicksort.java:477 when doing a full build (SKIP_BOOT_CYCLE=false)

> at java.util.DualPivotQuicksort.dualPivotQuicksort(DualPivotQuicksort.java:477)
> at java.util.DualPivotQuicksort.dualPivotQuicksort(DualPivotQuicksort.java:477)
> at java.util.DualPivotQuicksort.dualPivotQuicksort(DualPivotQuicksort.java:477)
> at java.util.DualPivotQuicksort.dualPivotQuicksort(DualPivotQuicksort.java:477)
> at java.util.DualPivotQuicksort.dualPivotQuicksort(DualPivotQuicksort.java:477)
> at java.util.DualPivotQuicksort.dualPivotQuicksort(DualPivotQuicksort.java:477)
> at java.util.DualPivotQuicksort.dualPivotQuicksort(DualPivotQuicksort.java:477)
> gnumake[4]: *** [/x/hudson/jobs/jdk7.tl.langtools-jdk/workspace/tl/build/solaris-sparc/classes/sun/text/resources/CharacterBreakIteratorData] Error 1
> gnumake[4]: Leaving directory `/x/hudson/jobs/jdk7.tl.langtools-jdk/workspace/tl/jdk/make/java/text'
> gnumake[3]: *** [all] Error 1
> gnumake[3]: Leaving directory `/x/hudson/jobs/jdk7.tl.langtools-jdk/workspace/tl/jdk/make/java'
> gnumake[2]: *** [all] Error 1
> gnumake[2]: Leaving directory `/x/hudson/jobs/jdk7.tl.langtools-jdk/workspace/tl/jdk/make'
> gnumake[1]: *** [jdk-build] Error 2
> gnumake[1]: Leaving directory `/x/hudson/jobs/jdk7.tl.langtools-jdk/workspace/tl'
> gnumake: *** [build_product_image] Error 2
> Sending e-mails to: jonathan.gibbons@...
> finished: FAILURE
>  
Full log for Sun folk at:

http://javac.sfbay:8080/hudson/job/jdk7.tl.langtools-jdk/80/console

-- Jon