include configuration file

[Дмитрий Чижевский]

Hello! 

I made some changes to Icecast sources and added <include/> tag into icecast.xml.

Is this interesting? Can i commit that?

Sorry for my english :)

Dmitriy Chechotkin, 

Saint-Petersburg, Russia.

_______________________________________________
Icecast-dev mailing list
Icecast-dev@...
http://lists.xiph.org/mailman/listinfo/icecast-dev

On Wed, Sep 22, 2010 at 09:23:02AM +0400, Дмитрий Чижевский wrote:
> I made some changes to Icecast sources and added <include/> tag into
> icecast.xml.
> Is this interesting?
>
It is. I have series of servers and I always wanted to synchronize list of
mount points without password.

-- Petr


_______________________________________________
Icecast-dev mailing list
Icecast-dev@...
http://lists.xiph.org/mailman/listinfo/icecast-dev

[Streamfinder]

Are people using the icecast official source or the updated version by KH? http://www.xiphicecast.webspace.virginmedia.com/

I think that version has a lot of fixes and added stability... can we merge it back in with the main source?

Sorry for my English

On Wed, Sep 22, 2010 at 1:04 AM, Petr Pisar <petr.pisar@...> wrote:

On Wed, Sep 22, 2010 at 09:23:02AM +0400, Дмитрий Чижевский wrote:
> I made some changes to Icecast sources and added <include/> tag into
> icecast.xml.
> Is this interesting?
>

It is. I have series of servers and I always wanted to synchronize list of
mount points without password.

-- Petr

_______________________________________________
Icecast-dev mailing list
Icecast-dev@...
http://lists.xiph.org/mailman/listinfo/icecast-dev

_______________________________________________
Icecast-dev mailing list
Icecast-dev@...
http://lists.xiph.org/mailman/listinfo/icecast-dev

[Karl Heyes]

On 22/09/10 06:23, Дмитрий Чижевский wrote:
> Hello!
> I made some changes to Icecast sources and added<include/>  tag into
> icecast.xml.
> Is this interesting? Can i commit that?
>

You can always send patches for review, but without seeing the patch
then it would be hard to proceed on it.  Is this to include an external
xml file within this xml?


karl

_______________________________________________
Icecast-dev mailing list
Icecast-dev@...
http://lists.xiph.org/mailman/listinfo/icecast-dev

[Karl Heyes]

On 22/09/10 13:54, Streamfinder wrote:
> Are people using the icecast official source or the updated version by KH?
> http://www.xiphicecast.webspace.virginmedia.com/
>
> I think that version has a lot of fixes and added stability... can we merge
> it back in with the main source?
>

There are a number of fixes that I'm separating for committing to trunk
but there are a lot of changes in the kh tree that are for performance
in certain load cases or certain features that may never go into trunk
so doing a straight merge is not the way to go.

karl.

_______________________________________________
Icecast-dev mailing list
Icecast-dev@...
http://lists.xiph.org/mailman/listinfo/icecast-dev

On Wed, Sep 22, 2010 at 02:31:24PM +0100, Karl Heyes wrote:
> On 22/09/10 06:23, Дмитрий Чижевский wrote:
> > I made some changes to Icecast sources and added<include/>  tag into
> > icecast.xml.
>
[...]
> Is this to include an external xml file within this xml?
>
Actullly, libxslt (or maybe libxml2) support XInclude. This approach is more
standard and allows even non-local URIs. This feature must be enabled in
application code probably.

-- Petr


_______________________________________________
Icecast-dev mailing list
Icecast-dev@...
http://lists.xiph.org/mailman/listinfo/icecast-dev

[Thomas B. Ruecker-2]

On Wed, Sep 22, 2010 at 03:46:15PM +0200, Petr Pisar wrote:

> On Wed, Sep 22, 2010 at 02:31:24PM +0100, Karl Heyes wrote:
> > On 22/09/10 06:23, Дмитрий Чижевский wrote:
> > > I made some changes to Icecast sources and added<include/>  tag into
> > > icecast.xml.
> >
> [...]
> > Is this to include an external xml file within this xml?
> >
> Actullly, libxslt (or maybe libxml2) support XInclude. This approach is more
> standard and allows even non-local URIs. This feature must be enabled in
> application code probably.

IIRC I made someone try this feature of libxml2 and it works in stock icecast,
but only for server start. If you try to HUP the server, hell breaks loose.

I may be wrong as I didn't try it myself, but I'm pretty sure it was something
to that tune.

Cheers

Thomas
_______________________________________________
Icecast-dev mailing list
Icecast-dev@...
http://lists.xiph.org/mailman/listinfo/icecast-dev

[Karl Heyes]

On 22/09/10 21:21, Thomas B. Ruecker wrote:

> On Wed, Sep 22, 2010 at 03:46:15PM +0200, Petr Pisar wrote:
>> On Wed, Sep 22, 2010 at 02:31:24PM +0100, Karl Heyes wrote:
>>> On 22/09/10 06:23, Дмитрий Чижевский wrote:
>>>> I made some changes to Icecast sources and added<include/>   tag into
>>>> icecast.xml.
>>>
>> [...]
>>> Is this to include an external xml file within this xml?
>>>
>> Actullly, libxslt (or maybe libxml2) support XInclude. This approach is more
>> standard and allows even non-local URIs. This feature must be enabled in
>> application code probably.
>
> IIRC I made someone try this feature of libxml2 and it works in stock icecast,
> but only for server start. If you try to HUP the server, hell breaks loose.
>
> I may be wrong as I didn't try it myself, but I'm pretty sure it was something
> to that tune.

I can see that being more of a chroot/changeowner case issue than
something triggered from HUP (excluding any memory corruption issue).

karl.


_______________________________________________
Icecast-dev mailing list
Icecast-dev@...
http://lists.xiph.org/mailman/listinfo/icecast-dev