introduction and questions

[Thorsten Toepper]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA224

jezra wrote:
> Unfortunately, after renaming the package and the compiled binary, I
> needed to edit and rename the man page and the associated help
> directives in the source code to reflect the changes to the package
> and binary name. Since I don't wish to step on anyone toes regarding
> application name collision, I'll hold off on submitting the PKGBUILD.

Well you can simply solve that using $pkgname in the build part of the
PKGBUILD, I guess the "p" stands for "player" so it wouldn't be a
problem if you name it for example "sa-player" as the files also get
that name and your package does not conflict the other "sap" package any
longer.

# Contributor: jezra lickter <jezra at jezra dot net>

pkgname=sa-player
pkgver=0.4.4
pkgrel=1
pkgdesc="A command line audio player utilizing gstreamer and ncurses"
arch=('i686')
url="http://www.jezra.net/projects/sap/"
license=('GPL3')
depends=('gstreamer0.10-base' 'ncurses')
makedepends=('vala>=0.7.2')
source=(http://launchpad.net/sap+/0.4.4/0.4.4/+download/sap-0.4.4.tar.gz)
md5sums=('c8ec9cb57b925b0634d6853c839f30cb')

build() {
        cd $srcdir/$pkgname-$pkgver
        valac --thread --pkg curses --pkg gstreamer-0.10 curses_ui.vala
audioplayer.vala main_controller.vala -o ${pkgname} -X -lncurses || return 1
        install -Dm755 ${pkgname} $pkgdir/usr/bin/${pkgname} || return 1
        install -Dm644 ${pkgname}.1 $pkgdir/usr/share/man/man1/${pkgname}.1 ||
return 1

}
#end of code

- --
Jabber: atsutane@... Blog: http://atsutane.freethoughts.de/
Key: 295AFBF4     FP: 39F8 80E5 0E49 A4D1 1341 E8F9 39E4 F17F 295A FBF4
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iFYEARELAAYFAkpTsAIACgkQOeTxfyla+/TmzQDgj85/eLxbplw1zo4haBo7g9ZG
35MIkB5Srv6SUQDfS/2XsaJN3ekdLbPcj5dXMYTjXO6hYFskAXb38Q==
=tqwz
-----END PGP SIGNATURE-----

[jezra]

On Tue, Jul 7, 2009 at 1:28 PM, Thorsten
Toepper<atsutane@...> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA224
>
> jezra wrote:
>> Unfortunately, after renaming the package and the compiled binary, I
>> needed to edit and rename the man page and the associated help
>> directives in the source code to reflect the changes to the package
>> and binary name. Since I don't wish to step on anyone toes regarding
>> application name collision, I'll hold off on submitting the PKGBUILD.
>
> Well you can simply solve that using $pkgname in the build part of the
> PKGBUILD, I guess the "p" stands for "player" so it wouldn't be a
> problem if you name it for example "sa-player" as the files also get
> that name and your package does not conflict the other "sap" package any
> longer.
>
> # Contributor: jezra lickter <jezra at jezra dot net>
>
> pkgname=sa-player
> pkgver=0.4.4
> pkgrel=1
> pkgdesc="A command line audio player utilizing gstreamer and ncurses"
> arch=('i686')
> url="http://www.jezra.net/projects/sap/"
> license=('GPL3')
> depends=('gstreamer0.10-base' 'ncurses')
> makedepends=('vala>=0.7.2')
> source=(http://launchpad.net/sap+/0.4.4/0.4.4/+download/sap-0.4.4.tar.gz)
> md5sums=('c8ec9cb57b925b0634d6853c839f30cb')
>
> build() {
>        cd $srcdir/$pkgname-$pkgver
>        valac --thread --pkg curses --pkg gstreamer-0.10 curses_ui.vala
> audioplayer.vala main_controller.vala -o ${pkgname} -X -lncurses || return 1
>        install -Dm755 ${pkgname} $pkgdir/usr/bin/${pkgname} || return 1
>        install -Dm644 ${pkgname}.1 $pkgdir/usr/share/man/man1/${pkgname}.1 ||
> return 1
>
> }
> #end of code
>
> - --
> Jabber: atsutane@... Blog: http://atsutane.freethoughts.de/
> Key: 295AFBF4     FP: 39F8 80E5 0E49 A4D1 1341 E8F9 39E4 F17F 295A FBF4
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
> iFYEARELAAYFAkpTsAIACgkQOeTxfyla+/TmzQDgj85/eLxbplw1zo4haBo7g9ZG
> 35MIkB5Srv6SUQDfS/2XsaJN3ekdLbPcj5dXMYTjXO6hYFskAXb38Q==
> =tqwz
> -----END PGP SIGNATURE-----
>

I thought package names had to be alphanumeric characters and the "-"
would make the package name invalid? Although the change does work, it
would require a custom edit of the source code and man page for
building the app for the Arch distribution. Although it isn't much of
a problem, I'm hesitant to commit myself to always needing to make the
change for future version of the software.

[xyne]

> I thought package names had to be alphanumeric characters and the "-"
> would make the package name invalid? Although the change does work, it
> would require a custom edit of the source code and man page for
> building the app for the Arch distribution. Although it isn't much of
> a problem, I'm hesitant to commit myself to always needing to make the
> change for future version of the software.


I think the previous suggestion was limited to changing the package
name. Just call it sa-player, add "sap" to the conflicts line (and maybe
add "sap" to the description as well to make it clear) and then leave
the rest of it alone. If others want to install this alongside the other
"sap" package then they can either hack it themselves or contact the
upstream devs to get the name collision resolved.

Changing the name throughout the souce code would not be an elegant
solution and would only lead to unnecessary complication for others
wishing to use the package, especially if it is ever a dependency for
other packages.

[jezra]

On Wed, 8 Jul 2009 07:13:13 +0200
Xyne <xyne@...> wrote:

> > I thought package names had to be alphanumeric characters and the
> > "-" would make the package name invalid? Although the change does
> > work, it would require a custom edit of the source code and man
> > page for building the app for the Arch distribution. Although it
> > isn't much of a problem, I'm hesitant to commit myself to always
> > needing to make the change for future version of the software.
>
>
> I think the previous suggestion was limited to changing the package
> name. Just call it sa-player, add "sap" to the conflicts line (and
> maybe add "sap" to the description as well to make it clear) and then
> leave the rest of it alone. If others want to install this alongside
> the other "sap" package then they can either hack it themselves or
> contact the upstream devs to get the name collision resolved.
>
> Changing the name throughout the souce code would not be an elegant
> solution and would only lead to unnecessary complication for others
> wishing to use the package, especially if it is ever a dependency for
> other packages.

That seems to be a very reasonable solution. Can anyone think of a
reason I should not implement just changing the package name as a
solution?