is Bug 8123 fixed in imp 4.3.4 and horde 3.3.5

[Michael Menge]

Hi,

I upgradet to  imp 4.3.4 and horde 3.3.5 and I still see this problem:
http://bugs.horde.org/ticket/8123

I wonder if this bug should be fixed in these versions and if,
what upgrade step I have might have missed?



Regards

     Michael Menge

--------------------------------------------------------------------------------
M.Menge                                Tel.: [phone]
Universität Tübingen                   Fax.: [phone]
Zentrum für Datenverarbeitung          mail:  
michael.menge@...
Wächterstraße 76
72074 Tübingen

--
IMP mailing list - Join the hunt: http://horde.org/bounties/#imp
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: imp-unsubscribe@...

[Jan Schneider]

Zitat von Michael Menge <michael.menge@...>:

> Hi,
>
> I upgradet to  imp 4.3.4 and horde 3.3.5 and I still see this problem:
> http://bugs.horde.org/ticket/8123
>
> I wonder if this bug should be fixed in these versions and if,
> what upgrade step I have might have missed?

Yes, it's fixed and working fine here.

Jan.

--
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/

--
IMP mailing list - Join the hunt: http://horde.org/bounties/#imp
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: imp-unsubscribe@...

[Michael Menge]

Quoting Jan Schneider <jan@...>:

> Zitat von Michael Menge <michael.menge@...>:
>
>> Hi,
>>
>> I upgradet to  imp 4.3.4 and horde 3.3.5 and I still see this problem:
>> http://bugs.horde.org/ticket/8123
>>
>> I wonder if this bug should be fixed in these versions and if,
>> what upgrade step I have might have missed?
>
> Yes, it's fixed and working fine here.
>

could you give me a hint which file was changed or a link to the commit?

> Jan.
>
> --
> Do you need professional PHP or Horde consulting?
> http://horde.org/consulting/
>
> --
> IMP mailing list - Join the hunt: http://horde.org/bounties/#imp
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: imp-unsubscribe@...
>

--------------------------------------------------------------------------------
M.Menge                                Tel.: [phone]
Universität Tübingen                   Fax.: [phone]
Zentrum für Datenverarbeitung          mail:  
michael.menge@...
Wächterstraße 76
72074 Tübingen

--
IMP mailing list - Join the hunt: http://horde.org/bounties/#imp
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: imp-unsubscribe@...

[Jan Schneider]

Zitat von Michael Menge <michael.menge@...>:

> Quoting Jan Schneider <jan@...>:
>
>> Zitat von Michael Menge <michael.menge@...>:
>>
>>> Hi,
>>>
>>> I upgradet to  imp 4.3.4 and horde 3.3.5 and I still see this problem:
>>> http://bugs.horde.org/ticket/8123
>>>
>>> I wonder if this bug should be fixed in these versions and if,
>>> what upgrade step I have might have missed?
>>
>> Yes, it's fixed and working fine here.
>>
>
> could you give me a hint which file was changed or a link to the commit?

http://cvs.horde.org/diff.php/horde/js/src/Attic/accesskeys.js?sa=1&r1=1.7.2.4&r2=1.7.2.5

Jan.

--
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/

--
IMP mailing list - Join the hunt: http://horde.org/bounties/#imp
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: imp-unsubscribe@...

[Michael Menge]

Quoting Jan Schneider <jan@...>:

> Zitat von Michael Menge <michael.menge@...>:
>
>> Quoting Jan Schneider <jan@...>:
>>
>>> Zitat von Michael Menge <michael.menge@...>:
>>>
>>>> Hi,
>>>>
>>>> I upgradet to  imp 4.3.4 and horde 3.3.5 and I still see this problem:
>>>> http://bugs.horde.org/ticket/8123
>>>>
>>>> I wonder if this bug should be fixed in these versions and if,
>>>> what upgrade step I have might have missed?
>>>
>>> Yes, it's fixed and working fine here.
>>>
>>
>> could you give me a hint which file was changed or a link to the commit?
>
> http://cvs.horde.org/diff.php/horde/js/src/Attic/accesskeys.js?sa=1&r1=1.7.2.4&r2=1.7.2.5

Thanks, I found the problem. As we used patches do upgrade, we
updated js/src/accesskeys.js but not js/accesskeys.js

how do i genereate the js/*.js ?
Which other type of files needs to be updated after using patches?


--------------------------------------------------------------------------------
M.Menge                                Tel.: [phone]
Universität Tübingen                   Fax.: [phone]
Zentrum für Datenverarbeitung          mail:  
michael.menge@...
Wächterstraße 76
72074 Tübingen

--
IMP mailing list - Join the hunt: http://horde.org/bounties/#imp
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: imp-unsubscribe@...

[Jan Schneider]

Zitat von Michael Menge <michael.menge@...>:

> Quoting Jan Schneider <jan@...>:
>
>> Zitat von Michael Menge <michael.menge@...>:
>>
>>> Quoting Jan Schneider <jan@...>:
>>>
>>>> Zitat von Michael Menge <michael.menge@...>:
>>>>
>>>>> Hi,
>>>>>
>>>>> I upgradet to  imp 4.3.4 and horde 3.3.5 and I still see this problem:
>>>>> http://bugs.horde.org/ticket/8123
>>>>>
>>>>> I wonder if this bug should be fixed in these versions and if,
>>>>> what upgrade step I have might have missed?
>>>>
>>>> Yes, it's fixed and working fine here.
>>>>
>>>
>>> could you give me a hint which file was changed or a link to the commit?
>>
>> http://cvs.horde.org/diff.php/horde/js/src/Attic/accesskeys.js?sa=1&r1=1.7.2.4&r2=1.7.2.5
>
> Thanks, I found the problem. As we used patches do upgrade, we
> updated js/src/accesskeys.js but not js/accesskeys.js

These should be included in the patches as well.

> how do i genereate the js/*.js ?

With horde-js-compress.php or any other js compressor. Or if you don't  
care about the file size, simply copy it over.

> Which other type of files needs to be updated after using patches?

Any binary files.

Jan.

--
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/

--
IMP mailing list - Join the hunt: http://horde.org/bounties/#imp
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: imp-unsubscribe@...

[Michael Menge]

Quoting Jan Schneider <jan@...>:

> Zitat von Michael Menge <michael.menge@...>:
>
>> Quoting Jan Schneider <jan@...>:
>>
>>> Zitat von Michael Menge <michael.menge@...>:
>>>
>>>> Quoting Jan Schneider <jan@...>:
>>>>
>>>>> Zitat von Michael Menge <michael.menge@...>:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I upgradet to  imp 4.3.4 and horde 3.3.5 and I still see this problem:
>>>>>> http://bugs.horde.org/ticket/8123
>>>>>>
>>>>>> I wonder if this bug should be fixed in these versions and if,
>>>>>> what upgrade step I have might have missed?
>>>>>
>>>>> Yes, it's fixed and working fine here.
>>>>>
>>>>
>>>> could you give me a hint which file was changed or a link to the commit?
>>>
>>> http://cvs.horde.org/diff.php/horde/js/src/Attic/accesskeys.js?sa=1&r1=1.7.2.4&r2=1.7.2.5
>>
>> Thanks, I found the problem. As we used patches do upgrade, we
>> updated js/src/accesskeys.js but not js/accesskeys.js
>
> These should be included in the patches as well.
>

grep "+++" patch-horde-3.3.3-3.3.4 | grep -F 'accesskeys.js'
+++ horde-3.3.4/js/src/accesskeys.js    2009-03-26 12:05:18.000000000 +0100

:-(
>
>> Which other type of files needs to be updated after using patches?
>
> Any binary files.
>
Is there a list of changed (binary) files? Or a script to generate  
such a list from cvs?



--------------------------------------------------------------------------------
M.Menge                                Tel.: [phone]
Universität Tübingen                   Fax.: [phone]
Zentrum für Datenverarbeitung          mail:  
michael.menge@...
Wächterstraße 76
72074 Tübingen

--
IMP mailing list - Join the hunt: http://horde.org/bounties/#imp
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: imp-unsubscribe@...

[Jan Schneider]

Zitat von Michael Menge <michael.menge@...>:

> Quoting Jan Schneider <jan@...>:
>
>> Zitat von Michael Menge <michael.menge@...>:
>>
>>> Quoting Jan Schneider <jan@...>:
>>>
>>>> Zitat von Michael Menge <michael.menge@...>:
>>>>
>>>>> Quoting Jan Schneider <jan@...>:
>>>>>
>>>>>> Zitat von Michael Menge <michael.menge@...>:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> I upgradet to  imp 4.3.4 and horde 3.3.5 and I still see this problem:
>>>>>>> http://bugs.horde.org/ticket/8123
>>>>>>>
>>>>>>> I wonder if this bug should be fixed in these versions and if,
>>>>>>> what upgrade step I have might have missed?
>>>>>>
>>>>>> Yes, it's fixed and working fine here.
>>>>>>
>>>>>
>>>>> could you give me a hint which file was changed or a link to the commit?
>>>>
>>>> http://cvs.horde.org/diff.php/horde/js/src/Attic/accesskeys.js?sa=1&r1=1.7.2.4&r2=1.7.2.5
>>>
>>> Thanks, I found the problem. As we used patches do upgrade, we
>>> updated js/src/accesskeys.js but not js/accesskeys.js
>>
>> These should be included in the patches as well.
>>
>
> grep "+++" patch-horde-3.3.3-3.3.4 | grep -F 'accesskeys.js'
> +++ horde-3.3.4/js/src/accesskeys.js    2009-03-26 12:05:18.000000000 +0100
>
> :-(

Maybe it has been forgotten to run the compressor before the release.

>>> Which other type of files needs to be updated after using patches?
>>
>> Any binary files.
>>
> Is there a list of changed (binary) files? Or a script to generate  
> such a list from cvs?

IIRC the release announcement contains a list of those files.

Jan.

--
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/

--
IMP mailing list - Join the hunt: http://horde.org/bounties/#imp
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: imp-unsubscribe@...