iscsitarget-0.4.15 fails to compile against 2.6.22.1

[Sam-161]

Hello,

the current ietd version fails to compile against vanilla 2.6.22.1
The error is:

event.c: In function 'event_init':
event.c:98: warning: passing argument 4 of 'netlink_kernel_create' from
incompatible pointer type
event.c:98: error: too few arguments to function 'netlink_kernel_create'

Obviously they changed netlink_kernel_create to have more arguments.
Can someone provide a patch to make it work?

Thanks


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Iscsitarget-devel mailing list
Iscsitarget-devel@...
https://lists.sourceforge.net/lists/listinfo/iscsitarget-devel

[Tuomas Leikola]

On 7/20/07, Sam <spam-goes-to-dev-null@...> wrote:

> the current ietd version fails to compile against vanilla 2.6.22.1
> The error is:
>
> event.c: In function 'event_init':
> event.c:98: warning: passing argument 4 of 'netlink_kernel_create' from
> incompatible pointer type
> event.c:98: error: too few arguments to function 'netlink_kernel_create'
>
> Obviously they changed netlink_kernel_create to have more arguments.
> Can someone provide a patch to make it work?
>

It appears safe to fix this by pasing NULL as the 4th parameter. (the
added parameter is a mutex to serialize callbacks, but if NULL is
passed, a default one is used.)

I'm in the process of testing this now.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Iscsitarget-devel mailing list
Iscsitarget-devel@...
https://lists.sourceforge.net/lists/listinfo/iscsitarget-devel

[Tuomas Leikola]

On 8/8/07, Tuomas Leikola <tuomas.leikola@...> wrote:
> I'm in the process of testing this now.
>

And it seems fine. I'll leave it out for someone smarter than me to
figure out if the locking is actually correct.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Iscsitarget-devel mailing list
Iscsitarget-devel@...
https://lists.sourceforge.net/lists/listinfo/iscsitarget-devel

[Arne Redlich-2]

Tuomas Leikola <tuomas.leikola@...> schrieb:

> On 8/8/07, Tuomas Leikola <tuomas.leikola@...> wrote:
> > I'm in the process of testing this now.
> >
>
> And it seems fine. I'll leave it out for someone smarter than me to
> figure out if the locking is actually correct.
>

It's already fixed in the repository.

Arne

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Iscsitarget-devel mailing list
Iscsitarget-devel@...
https://lists.sourceforge.net/lists/listinfo/iscsitarget-devel

[raul-peru]

Hey, do you make changes in witch files? I need to set iSCSI target in a Centos 5 (2.6.22) and I have the same problems.

Arne Redlich-2 wrote:

Tuomas Leikola <[e-mail]> schrieb:

> On 8/8/07, Tuomas Leikola <[e-mail]> wrote:
> > I'm in the process of testing this now.
> >
>
> And it seems fine. I'll leave it out for someone smarter than me to
> figure out if the locking is actually correct.
>

It's already fixed in the repository.

Arne

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Iscsitarget-devel mailing list
[e-mail]
https://lists.sourceforge.net/lists/listinfo/iscsitarget-devel