jar compression level; JOSM takes too long to compile

View: New views
2 Messages — Rating Filter:   Alert me  

jar compression level; JOSM takes too long to compile

by Sebastian Klein :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

Frederik Ramm changed the jar compression level to maximum (9) in r2368.
While I thank him for bringing this up, I would rather set it to 0
(uncompressed).

This is because I spend quite some time waiting for JOSM to compile and
compress.
This is what I get:

comress level         time for dist task
---------------------------------------------
9                               6-7 s
default                     4 s
0                               2 s


For the releases we need of course level 9. So the scripts for the
nightly builds would run

 > ant -Dclevel=9 dist

And use this parameter in the ant file:

Index: build.xml
===================================================================
--- build.xml    (revision 2375)
+++ build.xml    (working copy)
@@ -12,7 +12,12 @@
 <project name="josm" default="dist" basedir=".">
     <property name="test.dir" value="test" />
     <property name="src.dir" value="src" />
-    <property name="build.dir" value="build"/>
+    <property name="build.dir" value="build"/>
+  
+    <!-- compression level (run 'ant -Dclevel=9' for maximum
compression) -->
+    <condition property="clevel" value="${clevel}" else="0">
+        <isset property="clevel" />
+    </condition>
 
     <!-- Java classpath addition (all jar files to compile tests with
this) -->
     <path id="classpath">
@@ -72,7 +77,7 @@
 
         <!-- create josm-custom.jar -->
         <delete file="dist/josm-custom.jar"/>
-        <jar destfile="dist/josm-custom.jar" basedir="build" level="9">
+        <jar destfile="dist/josm-custom.jar" basedir="build"
level="${clevel}">
         <!-- add attribute excludes="**/*BZip2*,**/*Bzip2*" to create a
non-bzip2 supporting jar -->
             <manifest>
                 <attribute name="Main-class" value="JOSM" />



_______________________________________________
josm-dev mailing list
josm-dev@...
http://lists.openstreetmap.org/listinfo/josm-dev

Re: jar compression level; JOSM takes too long to compile

by Sebastian Klein :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

apparently no one cares about this.

So I checked it in but set the default value to 9. The current behavior
is *not* changed.

(Just setting the value to 0 in my local copy is not an option because
it might get checked in accidentally. :)  )

__

Basti

_______________________________________________
josm-dev mailing list
josm-dev@...
http://lists.openstreetmap.org/listinfo/josm-dev