Nabble - java.net - Facelets

AW: Re: Bug in c:forEach ?

2009-12-17T04:33:34Z

OK,here´s my complete class which compiled withour problem for me:

---------------

package com.sun.facelets.tag.jstl.core;

import java.io.Serializable;

public final class IterationStatus implements Serializable {

private static final long serialVersionUID = 1L;

private final int index;

private final boolean first;

private final boolean last;

private final boolean even;

private final Integer begin;

private final Integer end;

private final Integer step;

public IterationStatus(boolean first, boolean last, int index, Integer begin, Integer end, Integer step) {
this.index = index;
this.begin = begin;
this.end = end;
this.step = step;
this.first = first;
this.last = last;
// Bugfix - taken from Mojarra 2.01 implementation (otherwise Nullpointer in c:forEach with using varStatus and not setting begin & end)
int iBegin = ((begin != null) ? begin : 0);
int iStep = ((step != null) ? step : 1);
this.even = ((index - iBegin) / iStep) % 2 == 0;
//this.even = (index - begin.intValue() / step.intValue()) % 2 == 0;
}

public boolean isFirst() {
return this.first;
}

public boolean isLast() {
return this.last;
}

public boolean isEven() {
return even;
}

public boolean isOdd() {
return !even;
}

public Integer getBegin() {
return begin;
}

public Integer getEnd() {
return end;
}

public int getIndex() {
return index;
}

public Integer getStep() {
return step;
}

}

---------------

-----Ursprüngliche Nachricht-----
Von: Wessel van Norel [mailto:delgurth@...]
Gesendet: Donnerstag, 17. Dezember 2009 12:27
An: users@...
Betreff: Re: Bug in c:forEach ?

P.s.

With your fix copy/pasted I'm getting compile errors.

Guess it should be

int iBegin = ((begin != null) ? begin.intValue() : 0);
int iStep = ((step != null) ? step.intValue() : 1);
this.even = ((index - iBegin) / iStep) % 2 == 0;

compile:
[javac] Compiling 149 source files to build\classes
[javac] src\java\com\sun\facelets\tag\jstl\core\IterationStatus.java:54:
incompatible types for ?: neither is a subtype of the other
[javac] second operand: java.lang.Integer
[javac] third operand : int
[javac] int iBegin = ((begin != null) ? begin : 0);
[javac] ^
[javac] src\java\com\sun\facelets\tag\jstl\core\IterationStatus.java:55:
incompatible types for ?: neither is a subtype of the other
[javac] second operand: java.lang.Integer
[javac] third operand : int
[javac] int iStep = ((step != null) ? step : 1);
[javac] ^
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] 2 errors

On Thu, Dec 17, 2009 at 9:56 AM, Jan Ziegler <jan.ziegler@...> wrote:

> Yes seems to be a bug,
>
> I had the same problem. Whenever no begin-value is given on c:forEach - the nullpointer occurs.
>
> Therefore I took the source code and changed the line
>
> this.even = (index - begin.intValue() / step.intValue()) % 2 == 0;
>
> to this:
>
> int iBegin = ((begin != null) ? begin : 0);
> int iStep = ((step != null) ? step : 1);
> this.even = ((index - iBegin) / iStep) % 2 == 0;
>
> Now you have defaults. By the way this is taken from the JSF Mojarra 2.01 implementation. They already fixed this bug (in Myfaces 2.0 alpha is also hasn´t been fixed yet).
>
> Quite confusing at the moment having 3 "branches" of facelets like facelets-1.1.15jsf1.2 / mojarra 2 / myfaces 2...hope this all gets clearer soon...
>
>
> Greetz
> jan
>
> -----Ursprüngliche Nachricht-----
> Von: Wessel van Norel [mailto:delgurth@...]
> Gesendet: Mittwoch, 16. Dezember 2009 15:11
> An: users@...
> Betreff: Bug in c:forEach ?
>
> Dear List,
>
> We recently upgraded from facelets-1.1.14 to facelets-1.1.15-jsf1.2
> and we are getting NullPointerExceptions on IterationStatus on our
> c:forEach tags.
>
> The exception occurs when you don't set begin and step, because these
> 2 parameters are Integers, but are not checked for null values on line
> 54[1]:
>
> this.even = (index - begin.intValue() / step.intValue()) % 2 == 0;
>
> Perhaps this line should contain defaults for begin (0) and step (1)?
>
> The involved part from the stacktrace:
>
> java.lang.NullPointerException
> at com.sun.facelets.tag.jstl.core.IterationStatus.<init>(IterationStatus.java:54)
> at com.sun.facelets.tag.jstl.core.ForEachHandler.apply(ForEachHandler.java:165)
> at com.sun.facelets.tag.jsf.ComponentHandler.applyNextHandler(ComponentHandler.java:360)
>
> Regards,
> Wessel van Norel
>
> [1] https://facelets.dev.java.net/source/browse/facelets/src/java/com/sun/facelets/tag/jstl/core/IterationStatus.java?annotate=1.5
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@...
> For additional commands, e-mail: users-help@...
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@...
> For additional commands, e-mail: users-help@...
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@...
For additional commands, e-mail: users-help@...

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@...
For additional commands, e-mail: users-help@...

Nabble - java.net - Facelets

AW: Re: Bug in c:forEach ?

Re: Bug in c:forEach ?

Re: Bug in c:forEach ?

AW: Bug in c:forEach ?

Bug in c:forEach ?

Re: Pass method binding to a template - Attribute should be optional

Re: Inlining text - Security

Re: Inlining text - Security

Re: Need help with using HashMap in facelets

Pass method binding to a template - Attribute should be optional

RE: Inlining text - Security

Inlining text - Security

Re: Re : producting javascript file with facelets

Re : producting javascript file with facelets

Re: producting javascript file with facelets

producting javascript file with facelets

Re: duplicate Id for a component feature_reques

duplicate Id for a component feature_reques

PhaseListener and ViewHandler

Re: Need help with using HashMap in facelets

Need help with using HashMap in facelets

[Issue 347] TagValueExpression.equals does not work properly

[Issue 360] c:forEach: duplicated ID when component removed and then added back

[Issue 361] New - 321 bug fix has potential problems. Better fix suggested here.

[Issue 360] c:forEach: duplicated ID when component removed and then added back

[Issue 360] New - c:forEach: duplicated ID when component removed and then added back

IE blocks Cookies in iFrame

[Issue 359] New - Error in initialization sequence

Is it possible to get Facelets 1.1.14 uploaded to Maven Central?

[Issue 358] New - Custom component with children - Child component added dynamically at end appears as first child when rendered

Re: Problem with XHTML, Facelets and Chrome

Problem with XHTML, Facelets and Chrome

Programmatic usage of Facelets for dynamic component creation

Re: Accessing local variables via EL in custom tag handler

[ANNOUNCE] New JSF Summit sessions and workshops added!