jirb_swing broken in trunk

[rjst]

Hi,

    It appears that jirb_swing is broken in trunk for some time now. I
did a clean build, and ran bin\jirb_swing, but it won't show the prompt.

thanks,
Ricardo


---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

[Stephen Bannasch-3]

>Hi,
>
>   It appears that jirb_swing is broken in trunk for some time now. I did a clean build, and ran bin\jirb_swing, but it won't show the prompt.

I created an issue http://jira.codehaus.org/browse/JRUBY-2025

The regression occurred in 5665

$ svn up -r5665; ant clean; ant; jirb_swing
U    src/org/jruby/RubyInstanceConfig.java
U    src/org/jruby/util/IOHandlerNio.java
U    src/org/jruby/util/IOHandlerNioBuffered.java
U    src/org/jruby/util/AbstractIOHandler.java
U    src/org/jruby/RubyGlobal.java
U    src/org/jruby/RubyIO.java
Updated to revision 5665.

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

[Damian Steer]

On 23 Jan 2008, at 15:45, Stephen Bannasch wrote:

>> Hi,
>>
>>  It appears that jirb_swing is broken in trunk for some time now. I  
>> did a clean build, and ran bin\jirb_swing, but it won't show the  
>> prompt.
>
> I created an issue http://jira.codehaus.org/browse/JRUBY-2025
>
> The regression occurred in 5665

Thanks very much for this report, and tracking the offending changeset  
down.

The cause is the way the text area hooks into $stdout et al as a fake  
OutputStream. That won't work anymore with the refactored IO system.

I think the easiest fix is to make it a WritableByteChannel, which  
I'll have a go at later.

Damian

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

[Damian Steer]

On 23 Jan 2008, at 16:44, Damian Steer wrote:

>
> On 23 Jan 2008, at 15:45, Stephen Bannasch wrote:
>
>>> Hi,
>>>
>>> It appears that jirb_swing is broken in trunk for some time now. I  
>>> did a clean build, and ran bin\jirb_swing, but it won't show the  
>>> prompt.
>>
>> I created an issue http://jira.codehaus.org/browse/JRUBY-2025
>>
>> The regression occurred in 5665
>
> Thanks very much for this report, and tracking the offending  
> changeset down.
>
> The cause is the way the text area hooks into $stdout et al as a  
> fake OutputStream. That won't work anymore with the refactored IO  
> system.
>
> I think the easiest fix is to make it a WritableByteChannel, which  
> I'll have a go at later.
>
> Damian

Patch attached to the issue. It certainly fixes /an/ issue (the  
specific one Stephen reports) but I'm not so sure about Ricardo's.

Ricardo, can you see if it helps? I don't have a windows machine.

Damian

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

[rjst]

Hi,

    It does fix the bug I reported.

thanks,
Ricardo


Damian Steer wrote:

>
> On 23 Jan 2008, at 16:44, Damian Steer wrote:
>
>>
>> On 23 Jan 2008, at 15:45, Stephen Bannasch wrote:
>>
>>>> Hi,
>>>>
>>>> It appears that jirb_swing is broken in trunk for some time now. I
>>>> did a clean build, and ran bin\jirb_swing, but it won't show the
>>>> prompt.
>>>
>>> I created an issue http://jira.codehaus.org/browse/JRUBY-2025
>>>
>>> The regression occurred in 5665
>>
>> Thanks very much for this report, and tracking the offending
>> changeset down.
>>
>> The cause is the way the text area hooks into $stdout et al as a fake
>> OutputStream. That won't work anymore with the refactored IO system.
>>
>> I think the easiest fix is to make it a WritableByteChannel, which
>> I'll have a go at later.
>>
>> Damian
>
> Patch attached to the issue. It certainly fixes /an/ issue (the
> specific one Stephen reports) but I'm not so sure about Ricardo's.
>
> Ricardo, can you see if it helps? I don't have a windows machine.
>
> Damian
>
> ---------------------------------------------------------------------
> To unsubscribe from this list please visit:
>
>    http://xircles.codehaus.org/manage_email
>
>

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email