jmx-dev [PATCH] Fix compilation problem

[Roman Kennke-3]

Hi,

I posted this some time ago, but I think it may have been forgotten.
This fixes a small problem in OpenConverter, which can't be compiled
using the Eclipse compiler. Infact, the code is not valid Java and is
only accepted by javac due to a bug in javac:

http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6400189

It would be nice to have this patch integrated.

Cheers, Roman

--
Dipl.-Inform. (FH) Roman Kennke, Software Engineer, http://kennke.org
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: [phone]
USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe
Geschäftsführer: Dr. James J. Hunt

[patch.txt]

---

diff -r 37a05a11f281 -r 2b6c2ce8cd88 src/share/classes/com/sun/jmx/mbeanserver/OpenConverter.java
--- a/src/share/classes/com/sun/jmx/mbeanserver/OpenConverter.java      Sat Dec 01 00:00:00 2007 +0000
+++ b/src/share/classes/com/sun/jmx/mbeanserver/OpenConverter.java      Tue Dec 18 15:30:58 2007 +0100
@@ -1152,7 +1152,7 @@ public abstract class OpenConverter {
             // Also remember the set of properties in that constructor
             // so we can test unambiguity.
             Set<BitSet> getterIndexSets = newSet();
-            for (Constructor constr : annotatedConstrList) {
+            for (Constructor<?> constr : annotatedConstrList) {
                 String[] propertyNames =
                     constr.getAnnotation(propertyNamesClass).value();
 

---

[daniel.fuchs]

Hi Roman,

The bug has already been fixed some times ago in 6-open, see
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6643627

and also in jdk7/tl/jdk see this changeset:
http://hg.openjdk.java.net/jdk7/tl/jdk/rev/01f7eeea81f1

Apparently we forgot to change the state of the JDK 7 sub CR in
the bug database. Thanks for the heads up, and sorry for the
mistake!

Cheers,

-- daniel
http://blogs.sun.com/jmxetc

Roman Kennke wrote:

> Hi,
>
> I posted this some time ago, but I think it may have been forgotten.
> This fixes a small problem in OpenConverter, which can't be compiled
> using the Eclipse compiler. Infact, the code is not valid Java and is
> only accepted by javac due to a bug in javac:
>
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6400189
>
> It would be nice to have this patch integrated.
>
> Cheers, Roman
>
>

[eamonn.mcmanus]

Oops, this is my fault. I fixed the bug in build 25 of JDK 7 so you should see it once that is promoted, next Wednesday according to the schedule.

Daniel Fuchs wrote:

Hi Roman,

The bug has already been fixed some times ago in 6-open, see
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6643627

and also in jdk7/tl/jdk see this changeset:
http://hg.openjdk.java.net/jdk7/tl/jdk/rev/01f7eeea81f1

Apparently we forgot to change the state of the JDK 7 sub CR in
the bug database. Thanks for the heads up, and sorry for the
mistake!

Cheers,

-- daniel
http://blogs.sun.com/jmxetc

Roman Kennke wrote:

Hi,

I posted this some time ago, but I think it may have been forgotten.
This fixes a small problem in OpenConverter, which can't be compiled
using the Eclipse compiler. Infact, the code is not valid Java and is
only accepted by javac due to a bug in javac:

http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6400189

It would be nice to have this patch integrated.

Cheers, Roman