jmx-dev Review request: 6323980: Annotations to simplify MBean development

[eamonn.mcmanus]

I'm looking for reviewers for this fairly substantial change to the JMX
API and implementation in JDK7. I need at least one reviewer with commit
rights to openjdk. Any other reviewers will be acknowledged in the
changeset message.

The context:
http://weblogs.java.net/blog/emcmanus/archive/2007/08/defining_mbeans.html

The specification changes:
http://weblogs.java.net/blog/emcmanus/archive/6323980-specdiff.html

The code changes:
http://weblogs.java.net/blog/emcmanus/archive/6323980-webrev.zip

Thanks,

--
Éamonn McManus   JMX Spec Lead   http://weblogs.java.net/blog/emcmanus/

[jean-francois.denise]

Hello Eamonn,
I mainly focus on new Annotations and impact on public classes. I
noticed that Description Annotation targets FIELD. I was not able to
find a case where the FIELD target is needed. But perhaps that I missed
something there.

JF.


Eamonn McManus wrote:

> I'm looking for reviewers for this fairly substantial change to the
> JMX API and implementation in JDK7. I need at least one reviewer with
> commit rights to openjdk. Any other reviewers will be acknowledged in
> the changeset message.
>
> The context:
> http://weblogs.java.net/blog/emcmanus/archive/2007/08/defining_mbeans.html 
>
>
> The specification changes:
> http://weblogs.java.net/blog/emcmanus/archive/6323980-specdiff.html
>
> The code changes:
> http://weblogs.java.net/blog/emcmanus/archive/6323980-webrev.zip
>
> Thanks,
>

--
Jean-Francois Denise  JMX team
Interested in netbeans ==> http://blogs.sun.com/roller/page/jmxnetbeans

[eamonn.mcmanus]

JF,

Excellent point! Although we might imagine that someone would want to
reuse the @Description annotation for another purpose where FIELD would
be valid, I don't think they would gain much doing that versus creating
their own @Description with the semantics they want. So we should remove
FIELD from the @Target, at least until we do use it for something.

Thanks,

Éamonn McManus   JMX Spec Lead   http://weblogs.java.net/blog/emcmanus/



Jean-Francois Denise wrote:

> Hello Eamonn,
> I mainly focus on new Annotations and impact on public classes. I
> noticed that Description Annotation targets FIELD. I was not able to
> find a case where the FIELD target is needed. But perhaps that I
> missed something there.
>
> JF.
>
>
> Eamonn McManus wrote:
>> I'm looking for reviewers for this fairly substantial change to the
>> JMX API and implementation in JDK7. I need at least one reviewer with
>> commit rights to openjdk. Any other reviewers will be acknowledged in
>> the changeset message.
>>
>> The context:
>> http://weblogs.java.net/blog/emcmanus/archive/2007/08/defining_mbeans.html 
>>
>>
>> The specification changes:
>> http://weblogs.java.net/blog/emcmanus/archive/6323980-specdiff.html
>>
>> The code changes:
>> http://weblogs.java.net/blog/emcmanus/archive/6323980-webrev.zip
>>
>> Thanks,
>>
>
>

[daniel.fuchs]

Hi Eamonn,

Sorry for the late review. Here is my feedback:

com/sun/jmx/mbeanserver/Introspector.java

getStandardMBeanInterface()
can now also return a class (not necessarily  an interface).
Maybe the method javadoc could say so.

addDescriptorFieldsToMap(), addAnnotationFieldsToMap():
I think I understand the logic there, but if I ever have to
fix something in this code I'll be very grateful to find a comment
with an example of annotated class and an explanation of what each
of these methods looks for in the annotated class.

test/javax/management/Introspector/AnnotatedMBeanTest.java

This test could also check that Impact=UNKNOWN by default, and
add an @ManagedOperation method where Impact is set to
something else.

-- daniel
http://blogs.sun.com/jmxetc

Eamonn McManus wrote:

> I'm looking for reviewers for this fairly substantial change to the JMX
> API and implementation in JDK7. I need at least one reviewer with commit
> rights to openjdk. Any other reviewers will be acknowledged in the
> changeset message.
>
> The context:
> http://weblogs.java.net/blog/emcmanus/archive/2007/08/defining_mbeans.html
>
> The specification changes:
> http://weblogs.java.net/blog/emcmanus/archive/6323980-specdiff.html
>
> The code changes:
> http://weblogs.java.net/blog/emcmanus/archive/6323980-webrev.zip
>
> Thanks,
>