jmx-dev Review requested: 6592586: RequiredModelMBean prints a WARNING message when calling getAttributes() for a non-existing attr

[daniel.fuchs]

Also fixed several occurrences of the WARNING level....

-- daniel
http://blogs.sun.com/jmxetc


--- /jmgt/user/dfuchs/openjdk/jdk/webrev/raw_files/old/src/share/classes/javax/management/modelmbean/RequiredModelMBean.java Thu May 29 17:32:30 2008
+++ /jmgt/user/dfuchs/openjdk/jdk/webrev/raw_files/new/src/share/classes/javax/management/modelmbean/RequiredModelMBean.java Thu May 29 17:32:30 2008
@@ -1696,8 +1696,8 @@
             } catch (Exception e) {
                 // eat exceptions because interface doesn't have an
                 // exception on it
-                if (MODELMBEAN_LOGGER.isLoggable(Level.WARNING)) {
-                    MODELMBEAN_LOGGER.logp(Level.WARNING,
+                if (MODELMBEAN_LOGGER.isLoggable(Level.FINER)) {
+                    MODELMBEAN_LOGGER.logp(Level.FINER,
                             RequiredModelMBean.class.getName(),
                         "getAttributes(String[])",
                             "Failed to get \"" + attrNames[i] + "\": ", e);
@@ -1857,8 +1857,8 @@
                                             attrValue.getClass().getName() +
                                                            " received.");
                     } catch (ClassNotFoundException x) {
-                        if (MODELMBEAN_LOGGER.isLoggable(Level.WARNING)) {
-                            MODELMBEAN_LOGGER.logp(Level.WARNING,
+                        if (MODELMBEAN_LOGGER.isLoggable(Level.FINER)) {
+                            MODELMBEAN_LOGGER.logp(Level.FINER,
                                     RequiredModelMBean.class.getName(),
                                 "setAttribute(Attribute)","Class " +
                                     attrType + " for attribute "
@@ -2224,8 +2224,8 @@
                             ntfyObj.getMessage() + " Severity = " +
                             (String)ntfyDesc.getFieldValue("severity"));
                     } catch (Exception e) {
-                        if (MODELMBEAN_LOGGER.isLoggable(Level.WARNING)) {
-                            MODELMBEAN_LOGGER.logp(Level.WARNING,
+                        if (MODELMBEAN_LOGGER.isLoggable(Level.FINER)) {
+                            MODELMBEAN_LOGGER.logp(Level.FINER,
                                     RequiredModelMBean.class.getName(),
                                     "sendNotification(Notification)",
                                     "Failed to log " +
@@ -2618,8 +2618,8 @@
                            " Old value = " + oldv +
                            " New value = " + newv);
                     } catch (Exception e) {
-                        if (MODELMBEAN_LOGGER.isLoggable(Level.WARNING)) {
-                            MODELMBEAN_LOGGER.logp(Level.WARNING,
+                        if (MODELMBEAN_LOGGER.isLoggable(Level.FINER)) {
+                            MODELMBEAN_LOGGER.logp(Level.FINER,
                                     RequiredModelMBean.class.getName(),mth,
                                 "Failed to log " + ntfyObj.getType() +
                                     " notification: ", e);
@@ -2644,8 +2644,8 @@
                            " Old value = " + oldv +
                            " New value = " + newv);
                     } catch (Exception e) {
-                        if (MODELMBEAN_LOGGER.isLoggable(Level.WARNING)) {
-                            MODELMBEAN_LOGGER.logp(Level.WARNING,
+                        if (MODELMBEAN_LOGGER.isLoggable(Level.FINER)) {
+                            MODELMBEAN_LOGGER.logp(Level.FINER,
                                     RequiredModelMBean.class.getName(),mth,
                                 "Failed to log " + ntfyObj.getType() +
                                     " notification: ", e);

[eamonn.mcmanus]

Reviewed OK. Level.FINE might be more appropriate than Level.FINER for
exceptions from writeToLog.

Éamonn McManus   JMX Spec Lead   http://weblogs.java.net/blog/emcmanus/



Daniel Fuchs wrote:

> Also fixed several occurrences of the WARNING level....
>
> -- daniel
> http://blogs.sun.com/jmxetc
>
> The attachment(s) "" has been removed from this email because it
> contained a type of attachment known to carry viruses and other
> harmful software. The attachment has been removed for your protection,
> as well as that of Sun's network.
> If you know the sender and were expecting the attachment, please
> contact the sender and have them re-send the file using the .zip
> format. If the sender is unknown or if the email looks unusual or is
> unexpected, please delete it now.
> Additional information: http://antivirus.central.sun.com/ 

[daniel.fuchs]

Eamonn McManus wrote:
> Reviewed OK. Level.FINE might be more appropriate than Level.FINER for
> exceptions from writeToLog.

OK, good feedback. I will make the modifications.

>
> Éamonn McManus   JMX Spec Lead   http://weblogs.java.net/blog/emcmanus/
>
>
>
> Daniel Fuchs wrote:
>> Also fixed several occurrences of the WARNING level....
>>
>> -- daniel
>> http://blogs.sun.com/jmxetc
>>
>> The attachment(s) "" has been removed from this email because it
>> contained a type of attachment known to carry viruses and other
>> harmful software. The attachment has been removed for your protection,
>> as well as that of Sun's network.
>> If you know the sender and were expecting the attachment, please
>> contact the sender and have them re-send the file using the .zip
>> format. If the sender is unknown or if the email looks unusual or is
>> unexpected, please delete it now.
>> Additional information: http://antivirus.central.sun.com/ 
>