jsdIStackFrame.line changes?

[John J. Barton]

When running on the FF 3.7 nightly build, Firebug 1.5a25 fails this test
case
https://getfirebug.com/tests/content/script/singleStepping/index.html

If you follow the instructions on the page using Firebug 1.5a25 and FF
3.5.3 you end up on line 14 at step 3.

If you follow the instructions on the page using Firebug 1.5a25 and FF
3.7 you end up on line 13 at step 3.

13 function clicker() {
14    dataDiv = document.getElementById("data");
15    dataDiv.innerHTML += fibonacci(iter++) + "<br/>";
16 }

It looks like the line table for 'clicker' is slightly different with
pc=0 being assigned to line 13 in FF 3.7 and line 14 in FF 3.5.

Does anyone know which of these is correct?

jjb
_______________________________________________
dev-tech-js-engine mailing list
dev-tech-js-engine@...
https://lists.mozilla.org/listinfo/dev-tech-js-engine

[John J. Barton]

John J Barton wrote:

> When running on the FF 3.7 nightly build, Firebug 1.5a25 fails this test
> case
> https://getfirebug.com/tests/content/script/singleStepping/index.html
>
> If you follow the instructions on the page using Firebug 1.5a25 and FF
> 3.5.3 you end up on line 14 at step 3.
>
> If you follow the instructions on the page using Firebug 1.5a25 and FF
> 3.7 you end up on line 13 at step 3.
>
> 13 function clicker() {
> 14    dataDiv = document.getElementById("data");
> 15    dataDiv.innerHTML += fibonacci(iter++) + "<br/>";
> 16 }
>
> It looks like the line table for 'clicker' is slightly different with
> pc=0 being assigned to line 13 in FF 3.7 and line 14 in FF 3.5.
>
> Does anyone know which of these is correct?

Anyone? How can I resolve this?  Our test suite relies on line number
tests and they fail on FF 3.6/3.7, but we don't know what the correct
answer is. Is 3.6 wrong or was 3.5 wrong?

jjb
_______________________________________________
dev-tech-js-engine mailing list
dev-tech-js-engine@...
https://lists.mozilla.org/listinfo/dev-tech-js-engine

[Boris Zbarsky]

On 10/8/09 11:58 AM, John J. Barton wrote:
>> https://getfirebug.com/tests/content/script/singleStepping/index.html
>>
>> If you follow the instructions on the page using Firebug 1.5a25 and FF
>> 3.5.3 you end up on line 14 at step 3.
>>
>> If you follow the instructions on the page using Firebug 1.5a25 and FF
>> 3.7 you end up on line 13 at step 3.

Line 13 is clearly correct in that testcase, no?  That is the text
|function clicker| appears on line 13 of the file...

-Boris
_______________________________________________
dev-tech-js-engine mailing list
dev-tech-js-engine@...
https://lists.mozilla.org/listinfo/dev-tech-js-engine

[Boris Zbarsky]

On 10/8/09 12:48 PM, John J. Barton wrote:

> How about:
> 13 function clicker()
> 14
> 15 {
> 16
> 17 dataDiv = document.getElementById("data");
> 18 dataDiv.innerHTML += fibonacci(iter++) + "<br/>";
> 19
> 20 }
>
> Should PC = 0 appear on line 13?

Ah, the pc-to-line mapping...  I have no idea on that, sorry.  You want
Brendan or some such.

-Boris
_______________________________________________
dev-tech-js-engine mailing list
dev-tech-js-engine@...
https://lists.mozilla.org/listinfo/dev-tech-js-engine

[John J. Barton]

Boris Zbarsky wrote:

> On 10/8/09 11:58 AM, John J. Barton wrote:
>>> https://getfirebug.com/tests/content/script/singleStepping/index.html
>>>
>>> If you follow the instructions on the page using Firebug 1.5a25 and FF
>>> 3.5.3 you end up on line 14 at step 3.
>>>
>>> If you follow the instructions on the page using Firebug 1.5a25 and FF
>>> 3.7 you end up on line 13 at step 3.
>
> Line 13 is clearly correct in that testcase, no?  That is the text
> |function clicker| appears on line 13 of the file...
>
> -Boris

How about:
13 function clicker()
14
15 {
16
17 dataDiv = document.getElementById("data");
18 dataDiv.innerHTML += fibonacci(iter++) + "<br/>";
19
20 }

Should PC = 0 appear on line 13?  This was never true in the past. Was
it wrong then and right now?

jjb
_______________________________________________
dev-tech-js-engine mailing list
dev-tech-js-engine@...
https://lists.mozilla.org/listinfo/dev-tech-js-engine