kde4 Integration

In response to the recent kde4 posting about the patchfiles:

Kubuntu too has interest in starting to ship with better OOo and KDE
integration as well as removing the dependency on kde3 and the old qt3
libraries. I have committed to making this happen from the Kubuntu
side for the next release (Karmic). I am glad to hear that the vcl
patches apply cleanly now. I am currently at UDS, but will begin
taking a closer look at all of these problems once I get home. My
current goal is to rewrite the fpicker component into the OOo tree
instead of having it as an external application (unless I can be
convinced of a good reason not to??) Also, depending on how the vcl
patches work out I plan an overhaul of that part of the system as
well.

Anyone interested in helping with the porting/re-writing please let me
know. I will also do my best to keep the OO list updated on my
progress and where I end up hosting my branch.

Anyone have more feedback on the issue?

Thanks.
~Roman

---------- Forwarded message ----------
From: Christoph Willing <c.willing@...>
To: dev@...
Date: Thu, 28 May 2009 21:11:53 +1000
Subject: [go-oo.org Dev] 3.1.0.5 KDE4 status?
Since the next Slackware (and I suspect most distros that support KDE)
will have KDE 4.x, I'd like to be able to provide OO with the KDE4
option enabled. I've added KDE4 locally to my distro-config but it
looks like the patches brought in by this option are out of date (see
first patch failure below).

I manually fixed the first failed patch file (kde4-kdebe.diff) so that
is would apply cleanly but then another patch failed
(kde4-fpicker.diff) which is quite a bit messier to fix. Before I
continue down that path,

1. is KDE4 option supported for the 3.1 release? It looks broken right
now - less than ideal for a release. I see its marked "Experimental"
in the apply file

2. does anyone have the corrected patches waiting to submit?

3. has anyone succeeded in setting KDE4 option with 3.1.0.5 as is?


>From the apply file, it looks like only one distro includes KDE4
explicitly at the moment so maybe this area of the code isn't much
exercised. However it would be a shame to release it broken when some
distros are perhaps just about to release new versions with kde-4.x).


chris


#### This is the first failed patch when KDE4 is enabled ####
.....
.....
kde4-kdebe.diff: testing...<
/var/tmp/openoffice-3.1.0.5/patches/dev300/./kde4-kdebe.diff sed
's/^\(@.*\)\r$/\1/' | patch  -l -p0  -d
/var/tmp/openoffice-3.1.0.5/build/ooo310-m11 --dry-run
patching file shell/source/backends/kdebe/kdecommonlayer.cxx
Hunk #1 succeeded at 87 (offset -17 lines).
Hunk #3 succeeded at 145 (offset -17 lines).
patching file shell/source/backends/kdebe/kdeinetlayer.cxx
Hunk #1 succeeded at 94 (offset -14 lines).
Hunk #3 succeeded at 144 (offset -14 lines).
Hunk #5 succeeded at 190 (offset -14 lines).
Hunk #7 succeeded at 232 (offset -14 lines).
patching file shell/source/backends/kdebe/kdepathslayer.cxx
Hunk #1 FAILED at 107.
Hunk #2 succeeded at 115 (offset -22 lines).
1 out of 2 hunks FAILED -- saving rejects to file
shell/source/backends/kdebe/kdepathslayer.cxx.rej
Testing patch kde4-kdebe.diff failed. at
/var/tmp/openoffice-3.1.0.5/patches/apply.pl line 97.
make: *** [stamp/patch.apply] Error 1




Christoph Willing                       [phone]
QCIF Access Grid Manager
University of Queensland

_______________________________________________
Dev mailing list
Dev@...
http://lists.go-oo.org/listinfo.cgi/dev-go-oo.org
_______________________________________________
Dev mailing list
Dev@...
http://lists.go-oo.org/listinfo.cgi/dev-go-oo.org

[Jan Holesovsky]

Hi Roman,

On Friday 29 May 2009, Roman Shtylman wrote:

> In response to the recent kde4 posting about the patchfiles:
>
> Kubuntu too has interest in starting to ship with better OOo and KDE
> integration as well as removing the dependency on kde3 and the old qt3
> libraries. I have committed to making this happen from the Kubuntu
> side for the next release (Karmic). I am glad to hear that the vcl
> patches apply cleanly now. I am currently at UDS, but will begin
> taking a closer look at all of these problems once I get home. My
> current goal is to rewrite the fpicker component into the OOo tree
> instead of having it as an external application (unless I can be
> convinced of a good reason not to??)

So great to hear this!

Well - the problem with the internal fpicker is that you have to share the Qt
event loop with the VCL one.  But luckily, Petr did some work on this some
time ago (to be able to make the systray quickstarter working), please see
the commit f9506e62d2dfd9ab30f1e202698e70fe7910ab58 for more information.

Basically, you'll need at least patches/test/vcl-add-simle-qteventloop.diff,
and maybe some additions to that.

Some inspiration might be also in patches/test/vcl-add-simle-qteventloop.diff
[which is Petr's proof-of-concept code for the systray quickstarter - would
be great to finish it for KDE4 at some stage too ;-)]

> Also, depending on how the vcl
> patches work out I plan an overhaul of that part of the system as
> well.
>
> Anyone interested in helping with the porting/re-writing please let me
> know. I will also do my best to keep the OO list updated on my
> progress and where I end up hosting my branch.

Incidentally, do you have a blog?  If you plan to blog about all this, I'd be
more than happy to add you to planet.go-oo.org.  And if you are not on #go-oo
channel on irc.freenode.net yet, we'll be glad to see you there too :-)

Regards,
Kendy
_______________________________________________
Dev mailing list
Dev@...
http://lists.go-oo.org/listinfo.cgi/dev-go-oo.org

[Petr Mladek]

On Friday 29 May 2009, Jan Holesovsky wrote:
> Basically, you'll need at least
> patches/test/vcl-add-simle-qteventloop.diff, and maybe some additions to
> that.
>
> Some inspiration might be also in
> patches/test/vcl-add-simle-qteventloop.diff [which is Petr's
> proof-of-concept code for the systray quickstarter - would be great to
> finish it for KDE4 at some stage too ;-)]

Kendy wanted to point to
patches/test/sfx2-test-kde-systray-stuff.diff

It is just an easy systray menu that I tried to start from OOo. It worked only
partly because the qteventloop was not complete (missing timers, ...).

Also we need to add the right menu entries and functionality. You can take
inspiration in the GNOME systray plugin.


--
Best Regards,

Petr Mladek
software developer
---------------------------------------------------------------------  
SUSE LINUX, s. r. o.                        e-mail: pmladek@...
Lihovarská 1060/12                          tel: [phone]
190 00 Prague 9                             fax: [phone]
Czech Republic                              http://www.suse.cz/
_______________________________________________
Dev mailing list
Dev@...
http://lists.go-oo.org/listinfo.cgi/dev-go-oo.org