tag:old.nabble.com,2006:forum-6401
Nabble - koffice
2009-11-24T07:49:21Z
koffice home is <a href="http://www.kde.org" target="_top" rel="nofollow">here</a>.
tag:old.nabble.com,2006:post-26498376
Re: Review Request: Class KoFrameBorder for drawing borders for frames and Header/Footer styles implementation
2009-11-24T07:49:21Z
2009-11-24T07:49:21Z
Bugzilla from zander@kde.org
On Tuesday 24. November 2009 11.59.35 Mani Chandrasekar wrote:
<br>> Added LGPL License text for Header file and updated the source file.
<br><br>Sorry, you missed the "or later" part.
<br>Thats required for contributions to KOffice libs.
<br><br>Please use that.
<br>--
<br>Thomas Zander
<br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26498376&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26494855
Re: Review Request: Class KoFrameBorder for drawing borders for frames and Header/Footer styles implementation
2009-11-24T04:10:18Z
2009-11-24T04:10:18Z
prasad_ncm
<br>-----------------------------------------------------------
<br>This is an automatically generated e-mail. To reply, visit:
<br><a href="http://reviewboard.kde.org/r/2268/" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2268/</a><br>-----------------------------------------------------------
<br><br>(Updated 2009-11-24 12:10:18.746516)
<br><br><br>Review request for KOffice.
<br><br><br>Changes
<br>-------
<br><br>Setting standard values for writing-mode/num-format in KoPageLayout
<br><br><br>Summary
<br>-------
<br><br>* Created a new class KoFrameBorder inherited from KoShapeBorderModel to handle borders for Frames. This class stores style information using KoBorder.
<br>* I have moved Paint function from KWCanvas to KoBorder, which can be used by KoFrameBorder. As it is common for both KWCanvas and KoFrameBorder.
<br>* Header/Footer styles are now supported. Background color/Image fill, Complex borders (color border and border with different width and styles).
<br><br>KoFrameBorder::fillStyle(KoGenStyle &style, KoShapeSavingContext &context)
<br>How do i store the style information of Complex borders, As it is possible to have different colors for different sides.
<br><br>Saving back the header/footer information is still not implemented. The header/footer-style should be saved as a child of the style:page-layout; but using the addChildElement its instead saved as a child of style:page-layout-properties. Any idea how this can be implemented ?
<br><br><br>Diffs (updated)
<br>-----
<br><br> trunk/koffice/kword/part/KWCanvas.h 1051253
<br> trunk/koffice/kword/part/KWCanvas.cpp 1051253
<br> trunk/koffice/kword/part/KWOdfLoader.cpp 1051253
<br> trunk/koffice/kword/part/KWPageStyle.h 1051253
<br> trunk/koffice/kword/part/KWPageStyle.cpp 1051253
<br> trunk/koffice/kword/part/KWPageStyle_p.h 1051253
<br> trunk/koffice/kword/part/frames/KWTextFrameSet.h 1051253
<br> trunk/koffice/kword/part/frames/KWTextFrameSet.cpp 1051253
<br> trunk/koffice/libs/flake/CMakeLists.txt 1051253
<br> trunk/koffice/libs/flake/KoFrameBorder.h PRE-CREATION
<br> trunk/koffice/libs/flake/KoFrameBorder.cpp PRE-CREATION
<br> trunk/koffice/libs/odf/KoBorder.h 1051253
<br> trunk/koffice/libs/odf/KoBorder.cpp 1051253
<br> trunk/koffice/libs/widgets/KoPageLayout.h 1051253
<br> trunk/koffice/libs/widgets/KoPageLayout.cpp 1051253
<br><br>Diff: <a href="http://reviewboard.kde.org/r/2268/diff" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2268/diff</a><br><br><br>Testing
<br>-------
<br><br>I have done testing with few documents and works fine.
<br><br><br>Thanks,
<br><br>Mani
<br><br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26494855&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26493969
Re: Review Request: Class KoFrameBorder for drawing borders for frames and Header/Footer styles implementation
2009-11-24T02:59:35Z
2009-11-24T02:59:35Z
prasad_ncm
<br>-----------------------------------------------------------
<br>This is an automatically generated e-mail. To reply, visit:
<br><a href="http://reviewboard.kde.org/r/2268/" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2268/</a><br>-----------------------------------------------------------
<br><br>(Updated 2009-11-24 10:59:34.964132)
<br><br><br>Review request for KOffice.
<br><br><br>Changes
<br>-------
<br><br>Added LGPL License text for Header file and updated the source file.
<br><br><br>Summary
<br>-------
<br><br>* Created a new class KoFrameBorder inherited from KoShapeBorderModel to handle borders for Frames. This class stores style information using KoBorder.
<br>* I have moved Paint function from KWCanvas to KoBorder, which can be used by KoFrameBorder. As it is common for both KWCanvas and KoFrameBorder.
<br>* Header/Footer styles are now supported. Background color/Image fill, Complex borders (color border and border with different width and styles).
<br><br>KoFrameBorder::fillStyle(KoGenStyle &style, KoShapeSavingContext &context)
<br>How do i store the style information of Complex borders, As it is possible to have different colors for different sides.
<br><br>Saving back the header/footer information is still not implemented. The header/footer-style should be saved as a child of the style:page-layout; but using the addChildElement its instead saved as a child of style:page-layout-properties. Any idea how this can be implemented ?
<br><br><br>Diffs (updated)
<br>-----
<br><br> trunk/koffice/kword/part/KWCanvas.h 1051253
<br> trunk/koffice/kword/part/KWCanvas.cpp 1051253
<br> trunk/koffice/kword/part/KWOdfLoader.cpp 1051253
<br> trunk/koffice/kword/part/KWPageStyle.h 1051253
<br> trunk/koffice/kword/part/KWPageStyle.cpp 1051253
<br> trunk/koffice/kword/part/KWPageStyle_p.h 1051253
<br> trunk/koffice/kword/part/frames/KWTextFrameSet.h 1051253
<br> trunk/koffice/kword/part/frames/KWTextFrameSet.cpp 1051253
<br> trunk/koffice/libs/flake/CMakeLists.txt 1051253
<br> trunk/koffice/libs/flake/KoFrameBorder.h PRE-CREATION
<br> trunk/koffice/libs/flake/KoFrameBorder.cpp PRE-CREATION
<br> trunk/koffice/libs/odf/KoBorder.h 1051253
<br> trunk/koffice/libs/odf/KoBorder.cpp 1051253
<br> trunk/koffice/libs/widgets/KoPageLayout.h 1051253
<br> trunk/koffice/libs/widgets/KoPageLayout.cpp 1051253
<br><br>Diff: <a href="http://reviewboard.kde.org/r/2268/diff" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2268/diff</a><br><br><br>Testing
<br>-------
<br><br>I have done testing with few documents and works fine.
<br><br><br>Thanks,
<br><br>Mani
<br><br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26493969&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26486973
Re: koffice/kword/part
2009-11-23T14:13:16Z
2009-11-23T14:13:16Z
Bugzilla from zander@kde.org
On Tuesday 17. November 2009 11.56.39 Inge Wallin wrote:
<br>> > So you don't want to debug it?
<br>>
<br>> Didn't say that. :-)
<br>>
<br>> Just saying that the patch for the page borders aren't responsible for the
<br>> failure.
<br><br>I fixed this issue now in tonights commits.
<br>--
<br>Thomas Zander
<br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26486973&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26479087
Re: Review Request: Class KoFrameBorder for drawing borders for frames and Header/Footer styles implementation
2009-11-23T06:27:37Z
2009-11-23T06:27:37Z
Bugzilla from zander@kde.org
On Monday 23. November 2009 13.13.36 Mani Chandrasekar wrote:
<div class='shrinkable-quote'><br>> -----------------------------------------------------------
<br>> This is an automatically generated e-mail. To reply, visit:
<br>> <a href="http://reviewboard.kde.org/r/2268/" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2268/</a><br>> -----------------------------------------------------------
<br>>
<br>> Review request for KOffice.
<br>>
<br>>
<br>> Summary
<br>> -------
<br>>
<br>> * Created a new class KoFrameBorder inherited from KoShapeBorderModel to
<br>> handle borders for Frames. This class stores style information using
<br>> KoBorder.
</div><br>The new KoFrameBorder cpp file doesn't have a copyright header and the
<br>header file has the wrong license (GPLv2-only).
<br><br>Both have to be LGPLv2+, per the koffice library license policy.
<br><br>--
<br>Thomas Zander
<br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26479087&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26478835
Re: Review Request: Go to a specified page in KWord
2009-11-23T06:15:49Z
2009-11-23T06:15:49Z
Bugzilla from zander@kde.org
<br>-----------------------------------------------------------
<br>This is an automatically generated e-mail. To reply, visit:
<br><a href="http://reviewboard.kde.org/r/2230/#review3237" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2230/#review3237</a><br>-----------------------------------------------------------
<br><br>Ship it!
<br><br><br>Looks good, please commit.
<br><br>- Thomas
<br><br><br>On 2009-11-21 10:39:36, Mani Chandrasekar wrote:
<div class='shrinkable-quote'><br>>
<br>> -----------------------------------------------------------
<br>> This is an automatically generated e-mail. To reply, visit:
<br>> <a href="http://reviewboard.kde.org/r/2230/" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2230/</a><br>> -----------------------------------------------------------
<br>>
<br>> (Updated 2009-11-21 10:39:36)
<br>>
<br>>
<br>> Review request for KOffice.
<br>>
<br>>
<br>> Summary
<br>> -------
<br>>
<br>> Patch would provide functionality like go to specified page or prev/next page for KWord
<br>>
<br>>
<br>> Diffs
<br>> -----
<br>>
<br>> trunk/koffice/kword/part/KWView.h 1051253
<br>> trunk/koffice/kword/part/KWView.cpp 1051253
<br>>
<br>> Diff: <a href="http://reviewboard.kde.org/r/2230/diff" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2230/diff</a><br>>
<br>>
<br>> Testing
<br>> -------
<br>>
<br>> Done testing with different document & various zoom levels
<br>>
<br>>
<br>> Thanks,
<br>>
<br>> Mani
<br>>
<br>>
</div><br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26478835&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26477023
Review Request: Class KoFrameBorder for drawing borders for frames and Header/Footer styles implementation
2009-11-23T04:13:36Z
2009-11-23T04:13:36Z
prasad_ncm
<br>-----------------------------------------------------------
<br>This is an automatically generated e-mail. To reply, visit:
<br><a href="http://reviewboard.kde.org/r/2268/" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2268/</a><br>-----------------------------------------------------------
<br><br>Review request for KOffice.
<br><br><br>Summary
<br>-------
<br><br>* Created a new class KoFrameBorder inherited from KoShapeBorderModel to handle borders for Frames. This class stores style information using KoBorder.
<br>* I have moved Paint function from KWCanvas to KoBorder, which can be used by KoFrameBorder. As it is common for both KWCanvas and KoFrameBorder.
<br>* Header/Footer styles are now supported. Background color/Image fill, Complex borders (color border and border with different width and styles).
<br><br>KoFrameBorder::fillStyle(KoGenStyle &style, KoShapeSavingContext &context)
<br>How do i store the style information of Complex borders, As it is possible to have different colors for different sides.
<br><br>Saving back the header/footer information is still not implemented. The header/footer-style should be saved as a child of the style:page-layout; but using the addChildElement its instead saved as a child of style:page-layout-properties. Any idea how this can be implemented ?
<br><br><br>Diffs
<br>-----
<br><br> trunk/koffice/kword/part/KWCanvas.h 1051253
<br> trunk/koffice/kword/part/KWCanvas.cpp 1051253
<br> trunk/koffice/kword/part/KWOdfLoader.cpp 1051253
<br> trunk/koffice/kword/part/KWPageStyle.h 1051253
<br> trunk/koffice/kword/part/KWPageStyle.cpp 1051253
<br> trunk/koffice/kword/part/KWPageStyle_p.h 1051253
<br> trunk/koffice/kword/part/frames/KWTextFrameSet.h 1051253
<br> trunk/koffice/kword/part/frames/KWTextFrameSet.cpp 1051253
<br> trunk/koffice/libs/flake/CMakeLists.txt 1051253
<br> trunk/koffice/libs/flake/KoFrameBorder.h PRE-CREATION
<br> trunk/koffice/libs/flake/KoFrameBorder.cpp PRE-CREATION
<br> trunk/koffice/libs/odf/KoBorder.h 1051253
<br> trunk/koffice/libs/odf/KoBorder.cpp 1051253
<br> trunk/koffice/libs/widgets/KoPageLayout.h 1051253
<br> trunk/koffice/libs/widgets/KoPageLayout.cpp 1051253
<br><br>Diff: <a href="http://reviewboard.kde.org/r/2268/diff" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2268/diff</a><br><br><br>Testing
<br>-------
<br><br>I have done testing with few documents and works fine.
<br><br><br>Thanks,
<br><br>Mani
<br><br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26477023&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26469037
Re: Kspread row limit
2009-11-22T12:17:15Z
2009-11-22T12:17:15Z
Bugzilla from zander@kde.org
On Sunday 22. November 2009 20.27.09 Hendrik Grahl wrote:
<br>> As the comparison chart [1] indicates common spreadsheet programs have
<br>> vastly different values of supported rows and columns. I propose that
<br>> Kspread should strive to become compliant with the limits now present in
<br>> Excel 2007: 1,048,576 rows, 16,384 columns.
<br><br>That sounds like the worst possible reason to change the design of kspread.
<br>Naturally I'm all for interoperability, but you are not suggesting
<br>interoperability, you are suggesting we get a bigger number than others. No
<br>user cares about that.
<br><br>--
<br>Thomas Zander
<br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26469037&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26468601
Kspread row limit
2009-11-22T11:27:09Z
2009-11-22T11:27:09Z
Bugzilla from kde@glokal.eu
Hi,
<br>I wanted to bring up the topic of row and column limits in Kspread and
<br>the different potential solutions didn't seem to be quite ready for a
<br>bugreport yet.
<br><br>As the comparison chart [1] indicates common spreadsheet programs have
<br>vastly different values of supported rows and columns. I propose that
<br>Kspread should strive to become compliant with the limits now present in
<br>Excel 2007: 1,048,576 rows, 16,384 columns.
<br><br>One reason is to be compatible with the current version of the primary
<br>spreadsheet application around the world. Another more important one is
<br>that it does not look like OpenOffice will reach the Excel 2007
<br>limitations any time soon [3] and it presents a significant possibility
<br>of highlighting the superior architecture of Koffice. While OpenOffice has
<br>many legacy issues to optimize, the changes to Kspread are of course not
<br>trivial but in all likelihood less difficult.
<br><br>I tried to see how Kspread would fare when the limit was drastically
<br>increased but was not able to actually make it work. I changed the
<br>maxRows reference to something like 0x10000 and 0x100000 (the latter a
<br>further byte in hex, I presume?) in Global.h but due to my nonexistent
<br>knowledge of C++ I wasn't able to distinguish why this change was not
<br>sufficient. Type mismatch, maybe? Or a limitation elsewhere in the code?
<br><br>The question remains what to do about compatibility with other
<br>spreadsheet applications with differing limitations. I propose one popup
<br>notice when the user's editing first exceeds 65,536 rows to inform the
<br>user that he or she is now creating a document that will not be
<br>compatible with many applications such as Gnumeric, Excel 2003 and
<br>OpenOffice Calc[2].
<br><br>Exceeding column boundaries should probably trigger three popups: one
<br>for above 256 (for Excel 2003, Gnumeric and Calc 2), as well as for
<br>above 1,024 (for Calc 3) and also for above 16,384 due to the Excel 2007
<br>limitation when Kspread can already go up to 32,767. The last popup
<br>could be scrapped if Kspread were to be reduced from supporting 32,767
<br>columns to 16,384.
<br><br>Thank you for considering this subject!
<br><br>[1]
<br><a href="http://en.wikipedia.org/w/index.php?title=OpenOffice.org_Calc&oldid=321110016#Specifications" target="_top" rel="nofollow">http://en.wikipedia.org/w/index.php?title=OpenOffice.org_Calc&oldid=321110016#Specifications</a><br>[2] The correct description of the afflicted OpenOffice versions is a bit
<br>tricky, since they plan on increasing their limits but there is no
<br>distinct time-frame and even 3.2 might be a bit unlikely. Therefore,
<br>stating something like "up until and including 3.1" might give the
<br>reader the impression that 3.2 would support it. A further link with a
<br>detailed description might therefore be necessary.
<br>[3] Interesting page about limits in OpenOffice:
<br><a href="http://wiki.services.openoffice.org/wiki/Calc/hacks/number_of_rows" target="_top" rel="nofollow">http://wiki.services.openoffice.org/wiki/Calc/hacks/number_of_rows</a><br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26468601&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26467595
Re: xml:id preservation and RDF metadata support for ODF
2009-11-22T09:54:00Z
2009-11-22T09:54:00Z
monkeyiq
On Sat, 2009-11-21 at 04:58 +0100, Thorsten Zachmann wrote:
<div class='shrinkable-quote'><div class='shrinkable-quote'><br>> Hello,
<br>>
<br>> On Friday 20 November 2009 09:27:50 Ben Martin wrote:
<br>> > Abstract:
<br>> > The non-RDF question is about preserving xml:id on ODF across
<br>> > load/save cycles.
<br>> >
<br>> > Hi,
<br>> > I'm adding support for loading and saving RDF metadata in ODF
<br>> > documents for kword. Of course, other ODF like documents like
<br>> > spreadsheets which support RDF can also be added to the KOffice suite,
<br>> > I've tried to make what I've done generic so it can be expanded as such.
<br>> > I'm focusing on kword right now.
<br>> >
<br>> > I've mostly got external manifest.rdf based metadata working, but I'm
<br>> > having a few problems with so called inline RDF. From the ODF
<br>> > specification, inline RDF follows a slightly askew subset of RDFa. This
<br>> > means that one can have xhtml:about, xhtml:property and xhtml:content
<br>> > associated with an XML node and these are used to generate an RDF triple
<br>> > during loading. I mostly have loading of such metadata working, with a
<br>> > few little corner cases to address.
<br>> >
<br>> > The two problems I have found is that KOffice discards xml:id
<br>> > attributes during load and that I need to track the node that inline RDF
<br>> > gets generated from in order to store it back properly on document save.
<br>> > These problems are somewhat intermixed because if xml:id's can be saved
<br>> > for input documents, then saving the xhtml:about etc could also be done
<br>> > in the same code.
<br>> >
<br>> > I thought I'd ask advise from the list because adding xml:id support
<br>> > seems like a fairly intrusive change, and those currently more familiar
<br>> > with the codebase might have some ideas as to how to best support it.
<br>> > The xhtml:about attribute can appear on many XML elements including
<br>> > text:p.
<br>> >
<br>> > From my investigations, the pertinent code is in the class KoTextLoader.
<br>> > Looking at KoTextLoader::loadParagraph() if there is a style applied
<br>> > then KoParagraphStyle is used, then loadSpan() is called and, if the
<br>> > text:p has no style and only a text child node cursor.insertText() is
<br>> > called. This means there are many choices for where to store an xml:id
<br>> > for the text:p, but none of them straightforward.
<br>>
<br>> I don't think the KoParagraphStyle is a good place to store the stuff as it can
<br>> be reused for different paragraphs. Maybe the someone more familiar with KoText
<br>> can comment.
</div></div>Yes, the biggest impediment is the mismatch between the ODF document
<br>structure and the KOffice in memory representation of a document. As
<br>mentioned, the text:p being dissolved on document load.
<br><br>Another thought I had was possibly some container like object, or start
<br>+end marker pairing, which has no effect to the document itself but
<br>which would be able to store the xml:id and because it exists in the
<br>document would expand, contract and be copy+pasted along with text.
<br>Though there are all sorts of charming corner cases there too, clearly a
<br>paste would need to modify the xml:id so it was still document-unique.
<br><br>Upon further reflection, there are two distinct cases that I need to
<br>address:
<br><br>A) The xml:id is referred to from RDF which was either stored in
<br>content.xml, manifest.rdf or one of the RDF/XML files referenced by
<br>manifest.rdf. The link needs to be able to be traversed once the
<br>document is loaded (so you can find out what the RDF is referring too),
<br>and when saving if the xml:id changes, the RDF has to be updated to
<br>s/old-xml:id/new-xml:id/g
<br><br>B) There is some inline RDF which defines the object using element
<br>scope. See OpenDocument-v1.2-part1-cd03.pdf, section 18.907 on page
<br>#630. For example:
<br><text:p xhtml:about="uri-a" xhtml:property="waffle">
<br> The text between the text:p and end of it will form the object of the
<br>RDF triple. This is tricky because the user might edit the text, cut,
<br>paste or any number of other operations, including operations that might
<br>apply a style across the text:p boundary itself.
<br></text:p>
<br><br>For case (B), because text:p just adds text to the cursor.insertText(),
<br>the exact start/end scope of the text:p goes missing. There doesn't
<br>currently seem to be any correct place to attach any anchor saying "this
<br>is uri-a" or "this is where uri-a starts and ends". In this case, the
<br>about and property attributes would need to be saved back to a text:p
<br>when the document is saved again.
<br><br><div class='shrinkable-quote'><div class='shrinkable-quote'><br>>
<br>> > Looking at other elements, it seems that KoInline, KoShape for example
<br>> > would also need some augmentation to store an xml:id if one was supplied
<br>> > in the input ODF file so that the xml:id can be preserved on save.
<br>> >
<br>> > I look forward to any thoughts or preferences on how the koffice hackers
<br>> > would like to see the xml:id support added...
<br>> >
<br>>
<br>> thanks for the very detailed explanation. I think there are two possible
<br>> solutions:
<br>>
<br>> 1. Don't store the xml:id of the element but attach the meta data to it. This
<br>> could be done by having a class containing all the metadata for one element.
<br>> and store the data according to the element.
</div></div>I failed to mention in the initial email that according to the spec the
<br>xml:id can be referenced from the RDF stored in manifest.rdf and others.
<br>So the xml:id needs to be able to be resolved to the relevant chunk of
<br>the loaded document if some of the RDF statements are to be used.
<br><br>Currently, I store the loaded inline RDF (from content.xml) using the
<br>same class that handles the manifest.rdf. By storing all RDF in one
<br>central place it can be easily queried regardless of where it came from
<br>and where it is to be saved back too. Using graph context, the
<br>providence is tracked allowing proper placement during save. But of
<br>course, when saving content.xml again, any RDF that was loaded from it
<br>should go back into it... ideally, the same XML elements that had the
<br>RDF on them during load should have it on them during save, but some of
<br>those like text:p do not have a 1-1 object in the loaded KOffice
<br>docuemnt.
<br><br><br><br>> 2. Have a map with the xml:id to metadata.
<br><br>Having a map from xml:id to the metadata is easy enough, it is when I
<br>want to get the document object for an xml:id that I run into trouble.
<br><br>For example, an RDF triple (from manifest.rdf) might be like
<br>[uri:example-element-2], [pkg:idref], "id_world"}
<br><br>Where the content.xml file might contain
<br><text:meta xml:id="id_world">world</text:meta>
<br>or
<br><text:p xml:id="id_world">world</text:p>
<br><br><br>>
<br>> Storing the metadata internally has the benefit of no need to synchronize a
<br>> central map when e.g. a element is deleted/created ... That is also the way
<br>> koffice works most of the time, not keeping the old ids but generating new ones
<br>> on save.
<br><br>One issue here is that even the RDF from the external manifest.rdf file
<br>can reference elements in content.xml by their xml:id. So for the
<br>metadata from manifest.rdf to remain valid, the xml:id values must be
<br>either preserved or the RDF triples modified at save time to use the
<br>newly generated xml:id values in place of the old.
<br><br>Aside from the xml:id thing, there is also the main issue I'm having
<br>where I need some way to scope some ODF elements like text:p in a loaded
<br>KOffice document so I have some C++ object to attach either xml:id
<br>and/or metadata too. If anyone has any hints as to what I could use for
<br>such a non displaying container that would be wonderful.
<br><br>> Also koffice might handle stuff differently internally as saved in odf so
<br>> keeping the data in sync might be problematic. This also means the xml:id is
<br>> not preserved, but it should not harm as the data is saved back again with a
<br>> new xml:id.
<br>> Having a separate map makes it easier to load save the data.
<br>>
<br>> I hope that explains it a little bit more. Looking to here form you on what
<br>> you think.
<br><br>I'll probably be on IRC in the .de afternoon until about 19:00.
<br><br><br>>
<br>> Thorsten
<br><br /> <br />_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26467595&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><div class="small"><br/><img src="http://old.nabble.com/images/icon_attachment.gif" > <strong>signature.asc</strong> (204 bytes) <a href="http://old.nabble.com/attachment/26467595/0/signature.asc" target="_top">Download Attachment</a></div><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26467568
Re: koffice
2009-11-22T09:52:27Z
2009-11-22T09:52:27Z
Jaroslaw Staniek
2009/11/12 Thomas Zander <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26467568&i=0" target="_top" rel="nofollow">zander@...</a>>:
<br><br>> Could you please give some more reasoning? Just a "Does not belong" is an
<br>> opinion, I'd like to know the source of that opinion so I can see why and
<br>> think along.
<br><br>It's more generic, and thus can be used in places that do not depend on flake.
<br>Is that good reason?
<br><br>--
<br>regards / pozdrawiam, Jaroslaw Staniek
<br> Kexi & KOffice (<a href="http://www.kexi-project.org" target="_top" rel="nofollow">http://www.kexi-project.org</a>, <a href="http://www.koffice.org" target="_top" rel="nofollow">http://www.koffice.org</a>)
<br> KDE Libraries for MS Windows (<a href="http://windows.kde.org" target="_top" rel="nofollow">http://windows.kde.org</a>)
<br> <a href="http://www.linkedin.com/in/jstaniek" target="_top" rel="nofollow">http://www.linkedin.com/in/jstaniek</a><br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26467568&i=1" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26466202
Re: End lines patch
2009-11-22T07:26:46Z
2009-11-22T07:26:46Z
Jérémy Lugagne
I don't understand how to describe the endings with that enum ? the enum contains only the type of the ending and the full description are in svg file ? or ?!<br><br>Jérémy.<br><br><div class="gmail_quote">2009/11/22 Thomas Zander <span dir="ltr"><<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26466202&i=0" target="_top" rel="nofollow">zander@...</a>></span><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="im">On Sunday 22. November 2009 13.55.49 Jérémy Lugagne wrote:<br>
> Hi,<br>
><br>
> Yesterday night, i talked with TZander and CyrilleB about this docker (and<br>
> classes) and for them, the best approach for the endings is : make one svg<br>
> by ending and generate only one QSVGRenderer by SVG file and work on it in<br>
> painting method of the KoLineEnd (or KoMarker now).<br>
<br>
</div>Let me write down what I remember fromt he discussion;<br>
<br>
the current approach of generating a bytearray with an svg seems a bit odd.<br>
<br>
The suggestion we came up with is to have an enum on KoPathShape with all the<br>
known (ODF) line endings.<br>
Then have a setter on KoPathShape for both the begin and end of the line using<br>
that enum.<br>
Then paint the line ending using QPainter calls in the KoPathShape code.<br>
<br>
One of the enum values should represent an external SVG. So the user can set<br>
an svg that will be used as a line-ending.<br>
<br>
This means that we get 2 ways of painting line endings; one based on QPainter<br>
and one based on svg.<br>
And the QPainter one will have to implement all line ending types that ODF<br>
has.<br>
<div class="im"><br>
> So, what do you think<br>
> about this approach ?<br>
</div>--<br>
<font color="#888888">Thomas Zander<br>
</font><div><div></div><div class="h5">_______________________________________________<br>
koffice-devel mailing list<br>
<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26466202&i=1" target="_top" rel="nofollow">koffice-devel@...</a><br>
<a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_blank" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br>
</div></div></blockquote></div><br>
<br />_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26466202&i=2" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26465929
Re: End lines patch
2009-11-22T06:54:15Z
2009-11-22T06:54:15Z
Bugzilla from zander@kde.org
On Sunday 22. November 2009 13.55.49 Jérémy Lugagne wrote:
<br>> Hi,
<br>>
<br>> Yesterday night, i talked with TZander and CyrilleB about this docker (and
<br>> classes) and for them, the best approach for the endings is : make one svg
<br>> by ending and generate only one QSVGRenderer by SVG file and work on it in
<br>> painting method of the KoLineEnd (or KoMarker now).
<br><br>Let me write down what I remember fromt he discussion;
<br><br>the current approach of generating a bytearray with an svg seems a bit odd.
<br><br>The suggestion we came up with is to have an enum on KoPathShape with all the
<br>known (ODF) line endings.
<br>Then have a setter on KoPathShape for both the begin and end of the line using
<br>that enum.
<br>Then paint the line ending using QPainter calls in the KoPathShape code.
<br><br>One of the enum values should represent an external SVG. So the user can set
<br>an svg that will be used as a line-ending.
<br><br>This means that we get 2 ways of painting line endings; one based on QPainter
<br>and one based on svg.
<br>And the QPainter one will have to implement all line ending types that ODF
<br>has.
<br><br>> So, what do you think
<br>> about this approach ?
<br>--
<br>Thomas Zander
<br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26465929&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26465083
Re: End lines patch
2009-11-22T04:55:49Z
2009-11-22T04:55:49Z
Jérémy Lugagne
Hi, <br><br>Yesterday night, i talked with TZander and CyrilleB about this docker (and classes) and for them, the best approach for the endings is : make one svg by ending and generate only one QSVGRenderer by SVG file and work on it in painting method of the KoLineEnd (or KoMarker now). So, what do you think about this approach ?<br>
<br>For your comments i'll fix it asap.<br><br>Regards,<br><br>Jérémy<br>
<br />_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26465083&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26463287
Re: Review Request: Add struct KoFontFace
2009-11-21T23:22:36Z
2009-11-21T23:22:36Z
Thorsten Zachmann
<br>-----------------------------------------------------------
<br>This is an automatically generated e-mail. To reply, visit:
<br><a href="http://reviewboard.kde.org/r/2257/#review3230" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2257/#review3230</a><br>-----------------------------------------------------------
<br><br><br><br>trunk/koffice/filters/kword/msword-odf/texthandler.cpp
<br><<a href="http://reviewboard.kde.org/r/2257/#comment2557" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2257/#comment2557</a>>
<br><br> How about setting the font name in the constructor?
<br>
<br> The additional attributes are not yet set as far as I can see or do I miss something?
<br><br><br><br>trunk/koffice/libs/odf/KoFontFace.h
<br><<a href="http://reviewboard.kde.org/r/2257/#comment2556" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2257/#comment2556</a>>
<br><br> Please use a class here, as in the forward declaration also class is used. If this is mixed it will not compile on windows as far as I know.
<br><br><br><br>trunk/koffice/libs/odf/KoGenStyles.h
<br><<a href="http://reviewboard.kde.org/r/2257/#comment2558" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2257/#comment2558</a>>
<br><br> is this needed? For all th eother stuff in KoGenStyles it is only possible to add which makes sence as you would not add it if you don't want it to be saved.
<br><br><br><br>trunk/koffice/libs/odf/KoGenStyles.cpp
<br><<a href="http://reviewboard.kde.org/r/2257/#comment2559" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2257/#comment2559</a>>
<br><br> Can it happen that a name could be come up two times?
<br><br><br>- Thorsten
<br><br><br>On 2009-11-21 11:21:49, Inge Wallin wrote:
<div class='shrinkable-quote'><br>>
<br>> -----------------------------------------------------------
<br>> This is an automatically generated e-mail. To reply, visit:
<br>> <a href="http://reviewboard.kde.org/r/2257/" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2257/</a><br>> -----------------------------------------------------------
<br>>
<br>> (Updated 2009-11-21 11:21:49)
<br>>
<br>>
<br>> Review request for KOffice.
<br>>
<br>>
<br>> Summary
<br>> -------
<br>>
<br>> Here is the first patch in a small patchset that will add filters for the MS 2007 XML file formats. Note that I am only the middle man here.
<br>>
<br>> This patch adds the struct KoFontFace that is a public data structure representing a font style. It is saved as a style:font-face element. Before this patch, only the font name was available, which was saved as a style:name attribute of style:font-face. Also, svg:font-family was saved as a copy.
<br>>
<br>> Now the old behaviour is still available but in addition, new attributes can be specified in order to make the description of a font more accurate
<br>> (style:font-family-generic, svg:font-style, style:font-pitch). These are needed for increasing quality of import/export filters and is already used in the MSOOXML filters. The ODF specification offers even more attributes.
<br>>
<br>> The patch also contains fix for use of m_mainStyles->addFontFace() in two places, both in KWord.
<br>>
<br>>
<br>> Diffs
<br>> -----
<br>>
<br>> trunk/koffice/filters/kword/msword-odf/document.cpp 1051976
<br>> trunk/koffice/filters/kword/msword-odf/texthandler.cpp 1051976
<br>> trunk/koffice/libs/odf/CMakeLists.txt 1051975
<br>> trunk/koffice/libs/odf/KoFontFace.h PRE-CREATION
<br>> trunk/koffice/libs/odf/KoFontFace.cpp PRE-CREATION
<br>> trunk/koffice/libs/odf/KoGenStyles.h 1051975
<br>> trunk/koffice/libs/odf/KoGenStyles.cpp 1051975
<br>>
<br>> Diff: <a href="http://reviewboard.kde.org/r/2257/diff" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2257/diff</a><br>>
<br>>
<br>> Testing
<br>> -------
<br>>
<br>>
<br>> Thanks,
<br>>
<br>> Inge
<br>>
<br>>
</div><br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26463287&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26463231
Re: End lines patch
2009-11-21T23:08:55Z
2009-11-21T23:08:55Z
Thorsten Zachmann
Hello Jérémy,
<br><br>On Friday 20 November 2009 23:13:35 Jérémy Lugagne wrote:
<br>> Hi,
<br>>
<br>> I made a patch to add shapes and the end of lines.
<br>>
<br>> If you have a question, do not hesitate and ask me here or on IRC (XwZ).
<br><br>would it be possible to rename KoLineEnd and the methods to something like
<br>KoMarker. In a discussion with Jan he told me that in svg there is also the
<br>possibility to have markers at any position of a path. So that might be
<br>something which will come later.
<br><br>Here are some comments:
<br><br>+class KoEndLineShapeModel : public QAbstractListModel
<br>+{
<br>+public:
<br>+ KoEndLineShapeModel( QObject * parent = 0 );
<br>+ ~KoEndLineShapeModel() {}
<br><br>Please move the implementation into the source file.
<br><br>+++ plugins/dockers/shapeendlines/KoShapeEndLinesDocker.h (révision 0)
<br>...
<br>+#include <KoUnit.h>
<br>+#include <KoXmlReader.h>
<br>+#include <KoCanvasObserver.h>
<br>+#include <QtGui/QDockWidget>
<br>+#include <QListView>
<br>+#include <QDockWidget>
<br>+#include <kdebug.h>
<br>+#include <QStringList>
<br><br>Please move the includes not needed in the header into the source file.
<br><br>+class KoShapeBorderModel;
<br>+class KoCanvasController;
<br>+class KoLineEnd;
<br><br>looks like the above forward declarations are not needed.
<br><br>+class QComboBox;
<br>+class QSlider;
<br>+class KoCanvasBase;
<br>+
<br>+/// A docker for setting properties of end lines
<br>+class KoShapeEndLinesDocker : public QDockWidget, public KoCanvasObserver
<br>+{
<br>+ Q_OBJECT
<br>+
<br>+public:
<br>+ /// Creates the end lines docker
<br>+ KoShapeEndLinesDocker();
<br>+ virtual ~KoShapeEndLinesDocker();
<br>+private slots:
<br>+ void applyChanges();
<br>+ /// End Line has changed
<br>+ void beginEndLineChanged(int index);
<br>+ void endEndLineChanged(int index);
<br>+ void beginEndLineSizeChanged(int index);
<br>+ void endEndLineSizeChanged(int index);
<br>+
<br>+ /// selection has changed
<br>+ void selectionChanged();
<br>+ /// reimplemented
<br>+ virtual void setCanvas( KoCanvasBase *canvas );
<br>+ void setEnabled(bool enable);
<br>+private:
<br>+ KoCanvasBase* m_canvas;
<br>+ KoXmlDocument m_doc;
<br><br>The m_doc is not needed in the header. Just use a temporary KoXmlDocument when
<br>reading the config file.
<br><br>+ QString m_beginEndLineCurrentName;
<br>+ QString m_endEndLineCurrentName;
<br><br>the above two are not needed. They are only set but never used. Please remove
<br><br>+ int m_iconW;
<br>+ int m_iconH;
<br><br>These two are no needed just set the values correct values on m_iconSize
<br>construction. Please remove.
<br><br>+ int m_beginSize;
<br>+ int m_endSize;
<br>+ QSize m_iconSize;
<br><br>+ QMap<QString, QString> m_pathEndLineMap;
<br>+ QMap<QString, QString> m_viewEndLineMap;
<br><br>The above two variables are not used. Please remove.
<br><br>+ QComboBox * m_beginEndLineComboBox;
<br>+ QSlider * m_beginEndLineSize;
<br>+ QSlider * m_endEndLineSize;
<br>+}
<br><br>One more thing throughout the code. The coding style for koffice was updated
<br>since the code was written.
<br><br>+ virtual void setCanvas( KoCanvasBase *canvas );
<br><br>there are no more spaces used after the opening bracket and before the closing
<br>bracket. So the above should be like:
<br><br>+ virtual void setCanvas(KoCanvasBase *canvas);
<br><br>I only looked at the above class for now. If I find more time I will also look
<br>at the rest.
<br><br>Thanks for your good work,
<br><br>Thorsten
<br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26463231&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26456093
Re: Review Request: MS 2007 XML filters!
2009-11-21T04:25:16Z
2009-11-21T04:25:16Z
Cyrille Berger
<br>-----------------------------------------------------------
<br>This is an automatically generated e-mail. To reply, visit:
<br><a href="http://reviewboard.kde.org/r/2258/#review3220" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2258/#review3220</a><br>-----------------------------------------------------------
<br><br>Ship it!
<br><br><br>I think it should be ok to commit.
<br><br>- Cyrille
<br><br><br>On 2009-11-21 12:11:26, Inge Wallin wrote:
<div class='shrinkable-quote'><br>>
<br>> -----------------------------------------------------------
<br>> This is an automatically generated e-mail. To reply, visit:
<br>> <a href="http://reviewboard.kde.org/r/2258/" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2258/</a><br>> -----------------------------------------------------------
<br>>
<br>> (Updated 2009-11-21 12:11:26)
<br>>
<br>>
<br>> Review request for KOffice.
<br>>
<br>>
<br>> Summary
<br>> -------
<br>>
<br>> Here they are: the MS 2007 filters. (Please don't say MSOOXML, because these filters are supposed to be compatible with MS Office 2007, and they don't implement the ISO standard OOXML.)
<br>>
<br>> Note that this is a quite large patch and it only touches *one* existing file: CMakeLists.txt. I would ask to only review large problems. The smaller ones can surely be fixed within the repository after the import.
<br>>
<br>>
<br>> Diffs
<br>> -----
<br>>
<br>> trunk/koffice/filters/CMakeLists.txt 1052057
<br>> trunk/koffice/filters/kpresenter/CMakeLists.txt 1052057
<br>> trunk/koffice/filters/kpresenter/pptx/CMakeLists.txt PRE-CREATION
<br>> trunk/koffice/filters/kpresenter/pptx/PptxImport.h PRE-CREATION
<br>> trunk/koffice/filters/kpresenter/pptx/PptxImport.cpp PRE-CREATION
<br>> trunk/koffice/filters/kpresenter/pptx/PptxXmlDocumentReader.h PRE-CREATION
<br>> trunk/koffice/filters/kpresenter/pptx/PptxXmlDocumentReader.cpp PRE-CREATION
<br>> trunk/koffice/filters/kpresenter/pptx/PptxXmlSlideReader.h PRE-CREATION
<br>> trunk/koffice/filters/kpresenter/pptx/PptxXmlSlideReader.cpp PRE-CREATION
<br>> trunk/koffice/filters/kpresenter/pptx/README PRE-CREATION
<br>> trunk/koffice/filters/kpresenter/pptx/kpresenter_pptx_import.desktop PRE-CREATION
<br>> trunk/koffice/filters/kspread/CMakeLists.txt 1052057
<br>> trunk/koffice/filters/kspread/xlsx/CMakeLists.txt PRE-CREATION
<br>> trunk/koffice/filters/kspread/xlsx/XlsxImport.h PRE-CREATION
<br>> trunk/koffice/filters/kspread/xlsx/XlsxImport.cpp PRE-CREATION
<br>> trunk/koffice/filters/kspread/xlsx/XlsxXmlDocumentReader.h PRE-CREATION
<br>> trunk/koffice/filters/kspread/xlsx/XlsxXmlDocumentReader.cpp PRE-CREATION
<br>> trunk/koffice/filters/kspread/xlsx/XlsxXmlSharedStringsReader.h PRE-CREATION
<br>> trunk/koffice/filters/kspread/xlsx/XlsxXmlSharedStringsReader.cpp PRE-CREATION
<br>> trunk/koffice/filters/kspread/xlsx/XlsxXmlStylesReader.h PRE-CREATION
<br>> trunk/koffice/filters/kspread/xlsx/XlsxXmlStylesReader.cpp PRE-CREATION
<br>> trunk/koffice/filters/kspread/xlsx/XlsxXmlWorksheetReader.h PRE-CREATION
<br>> trunk/koffice/filters/kspread/xlsx/XlsxXmlWorksheetReader.cpp PRE-CREATION
<br>> trunk/koffice/filters/kspread/xlsx/kspread_xlsx_import.desktop PRE-CREATION
<br>> trunk/koffice/filters/kword/CMakeLists.txt 1052057
<br>> trunk/koffice/filters/kword/docx/CMakeLists.txt PRE-CREATION
<br>> trunk/koffice/filters/kword/docx/DocxImport.h PRE-CREATION
<br>> trunk/koffice/filters/kword/docx/DocxImport.cpp PRE-CREATION
<br>> trunk/koffice/filters/kword/docx/DocxXmlDocumentReader.h PRE-CREATION
<br>> trunk/koffice/filters/kword/docx/DocxXmlDocumentReader.cpp PRE-CREATION
<br>> trunk/koffice/filters/kword/docx/DocxXmlFontTableReader.h PRE-CREATION
<br>> trunk/koffice/filters/kword/docx/DocxXmlFontTableReader.cpp PRE-CREATION
<br>> trunk/koffice/filters/kword/docx/DocxXmlStylesReader.h PRE-CREATION
<br>> trunk/koffice/filters/kword/docx/DocxXmlStylesReader.cpp PRE-CREATION
<br>> trunk/koffice/filters/kword/docx/README PRE-CREATION
<br>> trunk/koffice/filters/kword/docx/kword_docx_import.desktop PRE-CREATION
<br>> trunk/koffice/filters/kword/msword-odf/document.cpp 1052057
<br>> trunk/koffice/filters/kword/msword-odf/texthandler.cpp 1052057
<br>> trunk/koffice/filters/libmsooxml/CMakeLists.txt PRE-CREATION
<br>> trunk/koffice/filters/libmsooxml/MsooXmlCommonReader.h PRE-CREATION
<br>> trunk/koffice/filters/libmsooxml/MsooXmlCommonReader.cpp PRE-CREATION
<br>> trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h PRE-CREATION
<br>> trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLMethods.h PRE-CREATION
<br>> trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderImpl.h PRE-CREATION
<br>> trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderMethods.h PRE-CREATION
<br>> trunk/koffice/filters/libmsooxml/MsooXmlContentTypes.h PRE-CREATION
<br>> trunk/koffice/filters/libmsooxml/MsooXmlImport.h PRE-CREATION
<br>> trunk/koffice/filters/libmsooxml/MsooXmlImport.cpp PRE-CREATION
<br>> trunk/koffice/filters/libmsooxml/MsooXmlReader.h PRE-CREATION
<br>> trunk/koffice/filters/libmsooxml/MsooXmlReader.cpp PRE-CREATION
<br>> trunk/koffice/filters/libmsooxml/MsooXmlReader_p.h PRE-CREATION
<br>> trunk/koffice/filters/libmsooxml/MsooXmlRelationships.h PRE-CREATION
<br>> trunk/koffice/filters/libmsooxml/MsooXmlRelationships.cpp PRE-CREATION
<br>> trunk/koffice/filters/libmsooxml/MsooXmlRelationshipsReader.h PRE-CREATION
<br>> trunk/koffice/filters/libmsooxml/MsooXmlRelationshipsReader.cpp PRE-CREATION
<br>> trunk/koffice/filters/libmsooxml/MsooXmlSchemas.h PRE-CREATION
<br>> trunk/koffice/filters/libmsooxml/MsooXmlThemesReader.h PRE-CREATION
<br>> trunk/koffice/filters/libmsooxml/MsooXmlThemesReader.cpp PRE-CREATION
<br>> trunk/koffice/filters/libmsooxml/MsooXmlUtils.h PRE-CREATION
<br>> trunk/koffice/filters/libmsooxml/MsooXmlUtils.cpp PRE-CREATION
<br>> trunk/koffice/filters/libmsooxml/msooxml_export.h PRE-CREATION
<br>> trunk/koffice/kpresenter/part/kpresenter.desktop 1052057
<br>> trunk/koffice/kpresenter/part/kpresenterpart.desktop 1052057
<br>> trunk/koffice/kspread/kspread.desktop 1052057
<br>> trunk/koffice/kspread/kspreadpart.desktop 1052057
<br>> trunk/koffice/kword/part/kword.desktop 1052057
<br>> trunk/koffice/kword/part/kwordpart.desktop 1052057
<br>>
<br>> Diff: <a href="http://reviewboard.kde.org/r/2258/diff" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2258/diff</a><br>>
<br>>
<br>> Testing
<br>> -------
<br>>
<br>>
<br>> Thanks,
<br>>
<br>> Inge
<br>>
<br>>
</div><br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26456093&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26455983
Review Request: MS 2007 XML filters!
2009-11-21T04:11:03Z
2009-11-21T04:11:03Z
Bugzilla from inge@lysator.liu.se
<br>-----------------------------------------------------------
<br>This is an automatically generated e-mail. To reply, visit:
<br><a href="http://reviewboard.kde.org/r/2258/" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2258/</a><br>-----------------------------------------------------------
<br><br>Review request for KOffice.
<br><br><br>Summary
<br>-------
<br><br>Here they are: the MS 2007 filters. (Please don't say MSOOXML, because these filters are supposed to be compatible with MS Office 2007, and they don't implement the ISO standard OOXML.)
<br><br>Note that this is a quite large patch and it only touches *one* existing file: CMakeLists.txt. I would ask to only review large problems. The smaller ones can surely be fixed within the repository after the import.
<br><br><br>Diffs
<br>-----
<br><br> trunk/koffice/filters/CMakeLists.txt 1052057
<br> trunk/koffice/filters/kpresenter/CMakeLists.txt 1052057
<br> trunk/koffice/filters/kpresenter/pptx/CMakeLists.txt PRE-CREATION
<br> trunk/koffice/filters/kpresenter/pptx/PptxImport.h PRE-CREATION
<br> trunk/koffice/filters/kpresenter/pptx/PptxImport.cpp PRE-CREATION
<br> trunk/koffice/filters/kpresenter/pptx/PptxXmlDocumentReader.h PRE-CREATION
<br> trunk/koffice/filters/kpresenter/pptx/PptxXmlDocumentReader.cpp PRE-CREATION
<br> trunk/koffice/filters/kpresenter/pptx/PptxXmlSlideReader.h PRE-CREATION
<br> trunk/koffice/filters/kpresenter/pptx/PptxXmlSlideReader.cpp PRE-CREATION
<br> trunk/koffice/filters/kpresenter/pptx/README PRE-CREATION
<br> trunk/koffice/filters/kpresenter/pptx/kpresenter_pptx_import.desktop PRE-CREATION
<br> trunk/koffice/filters/kspread/CMakeLists.txt 1052057
<br> trunk/koffice/filters/kspread/xlsx/CMakeLists.txt PRE-CREATION
<br> trunk/koffice/filters/kspread/xlsx/XlsxImport.h PRE-CREATION
<br> trunk/koffice/filters/kspread/xlsx/XlsxImport.cpp PRE-CREATION
<br> trunk/koffice/filters/kspread/xlsx/XlsxXmlDocumentReader.h PRE-CREATION
<br> trunk/koffice/filters/kspread/xlsx/XlsxXmlDocumentReader.cpp PRE-CREATION
<br> trunk/koffice/filters/kspread/xlsx/XlsxXmlSharedStringsReader.h PRE-CREATION
<br> trunk/koffice/filters/kspread/xlsx/XlsxXmlSharedStringsReader.cpp PRE-CREATION
<br> trunk/koffice/filters/kspread/xlsx/XlsxXmlStylesReader.h PRE-CREATION
<br> trunk/koffice/filters/kspread/xlsx/XlsxXmlStylesReader.cpp PRE-CREATION
<br> trunk/koffice/filters/kspread/xlsx/XlsxXmlWorksheetReader.h PRE-CREATION
<br> trunk/koffice/filters/kspread/xlsx/XlsxXmlWorksheetReader.cpp PRE-CREATION
<br> trunk/koffice/filters/kspread/xlsx/kspread_xlsx_import.desktop PRE-CREATION
<br> trunk/koffice/filters/kword/CMakeLists.txt 1052057
<br> trunk/koffice/filters/kword/docx/CMakeLists.txt PRE-CREATION
<br> trunk/koffice/filters/kword/docx/DocxImport.h PRE-CREATION
<br> trunk/koffice/filters/kword/docx/DocxImport.cpp PRE-CREATION
<br> trunk/koffice/filters/kword/docx/DocxXmlDocumentReader.h PRE-CREATION
<br> trunk/koffice/filters/kword/docx/DocxXmlDocumentReader.cpp PRE-CREATION
<br> trunk/koffice/filters/kword/docx/DocxXmlFontTableReader.h PRE-CREATION
<br> trunk/koffice/filters/kword/docx/DocxXmlFontTableReader.cpp PRE-CREATION
<br> trunk/koffice/filters/kword/docx/DocxXmlStylesReader.h PRE-CREATION
<br> trunk/koffice/filters/kword/docx/DocxXmlStylesReader.cpp PRE-CREATION
<br> trunk/koffice/filters/kword/docx/README PRE-CREATION
<br> trunk/koffice/filters/kword/docx/kword_docx_import.desktop PRE-CREATION
<br> trunk/koffice/filters/kword/msword-odf/document.cpp 1052057
<br> trunk/koffice/filters/kword/msword-odf/texthandler.cpp 1052057
<br> trunk/koffice/filters/libmsooxml/CMakeLists.txt PRE-CREATION
<br> trunk/koffice/filters/libmsooxml/MsooXmlCommonReader.h PRE-CREATION
<br> trunk/koffice/filters/libmsooxml/MsooXmlCommonReader.cpp PRE-CREATION
<br> trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h PRE-CREATION
<br> trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLMethods.h PRE-CREATION
<br> trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderImpl.h PRE-CREATION
<br> trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderMethods.h PRE-CREATION
<br> trunk/koffice/filters/libmsooxml/MsooXmlContentTypes.h PRE-CREATION
<br> trunk/koffice/filters/libmsooxml/MsooXmlImport.h PRE-CREATION
<br> trunk/koffice/filters/libmsooxml/MsooXmlImport.cpp PRE-CREATION
<br> trunk/koffice/filters/libmsooxml/MsooXmlReader.h PRE-CREATION
<br> trunk/koffice/filters/libmsooxml/MsooXmlReader.cpp PRE-CREATION
<br> trunk/koffice/filters/libmsooxml/MsooXmlReader_p.h PRE-CREATION
<br> trunk/koffice/filters/libmsooxml/MsooXmlRelationships.h PRE-CREATION
<br> trunk/koffice/filters/libmsooxml/MsooXmlRelationships.cpp PRE-CREATION
<br> trunk/koffice/filters/libmsooxml/MsooXmlRelationshipsReader.h PRE-CREATION
<br> trunk/koffice/filters/libmsooxml/MsooXmlRelationshipsReader.cpp PRE-CREATION
<br> trunk/koffice/filters/libmsooxml/MsooXmlSchemas.h PRE-CREATION
<br> trunk/koffice/filters/libmsooxml/MsooXmlThemesReader.h PRE-CREATION
<br> trunk/koffice/filters/libmsooxml/MsooXmlThemesReader.cpp PRE-CREATION
<br> trunk/koffice/filters/libmsooxml/MsooXmlUtils.h PRE-CREATION
<br> trunk/koffice/filters/libmsooxml/MsooXmlUtils.cpp PRE-CREATION
<br> trunk/koffice/filters/libmsooxml/msooxml_export.h PRE-CREATION
<br> trunk/koffice/kpresenter/part/kpresenter.desktop 1052057
<br> trunk/koffice/kpresenter/part/kpresenterpart.desktop 1052057
<br> trunk/koffice/kspread/kspread.desktop 1052057
<br> trunk/koffice/kspread/kspreadpart.desktop 1052057
<br> trunk/koffice/kword/part/kword.desktop 1052057
<br> trunk/koffice/kword/part/kwordpart.desktop 1052057
<br><br>Diff: <a href="http://reviewboard.kde.org/r/2258/diff" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2258/diff</a><br><br><br>Testing
<br>-------
<br><br><br>Thanks,
<br><br>Inge
<br><br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26455983&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26455614
Review Request: Add struct KoFontFace
2009-11-21T03:21:19Z
2009-11-21T03:21:19Z
Bugzilla from inge@lysator.liu.se
<br>-----------------------------------------------------------
<br>This is an automatically generated e-mail. To reply, visit:
<br><a href="http://reviewboard.kde.org/r/2257/" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2257/</a><br>-----------------------------------------------------------
<br><br>Review request for KOffice.
<br><br><br>Summary
<br>-------
<br><br>Here is the first patch in a small patchset that will add filters for the MS 2007 XML file formats. Note that I am only the middle man here.
<br><br>This patch adds the struct KoFontFace that is a public data structure representing a font style. It is saved as a style:font-face element. Before this patch, only the font name was available, which was saved as a style:name attribute of style:font-face. Also, svg:font-family was saved as a copy.
<br><br>Now the old behaviour is still available but in addition, new attributes can be specified in order to make the description of a font more accurate
<br>(style:font-family-generic, svg:font-style, style:font-pitch). These are needed for increasing quality of import/export filters and is already used in the MSOOXML filters. The ODF specification offers even more attributes.
<br><br>The patch also contains fix for use of m_mainStyles->addFontFace() in two places, both in KWord.
<br><br><br>Diffs
<br>-----
<br><br> trunk/koffice/filters/kword/msword-odf/document.cpp 1051976
<br> trunk/koffice/filters/kword/msword-odf/texthandler.cpp 1051976
<br> trunk/koffice/libs/odf/CMakeLists.txt 1051975
<br> trunk/koffice/libs/odf/KoFontFace.h PRE-CREATION
<br> trunk/koffice/libs/odf/KoFontFace.cpp PRE-CREATION
<br> trunk/koffice/libs/odf/KoGenStyles.h 1051975
<br> trunk/koffice/libs/odf/KoGenStyles.cpp 1051975
<br><br>Diff: <a href="http://reviewboard.kde.org/r/2257/diff" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2257/diff</a><br><br><br>Testing
<br>-------
<br><br><br>Thanks,
<br><br>Inge
<br><br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26455614&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26455321
Re: Review Request: Go to a specified page in KWord
2009-11-21T02:39:36Z
2009-11-21T02:39:36Z
prasad_ncm
<br>-----------------------------------------------------------
<br>This is an automatically generated e-mail. To reply, visit:
<br><a href="http://reviewboard.kde.org/r/2230/" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2230/</a><br>-----------------------------------------------------------
<br><br>(Updated 2009-11-21 10:39:36.405206)
<br><br><br>Review request for KOffice.
<br><br><br>Changes
<br>-------
<br><br>Updated the patch
<br><br><br>Summary
<br>-------
<br><br>Patch would provide functionality like go to specified page or prev/next page for KWord
<br><br><br>Diffs (updated)
<br>-----
<br><br> trunk/koffice/kword/part/KWView.h 1051253
<br> trunk/koffice/kword/part/KWView.cpp 1051253
<br><br>Diff: <a href="http://reviewboard.kde.org/r/2230/diff" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2230/diff</a><br><br><br>Testing
<br>-------
<br><br>Done testing with different document & various zoom levels
<br><br><br>Thanks,
<br><br>Mani
<br><br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26455321&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26453585
Re: xml:id preservation and RDF metadata support for ODF
2009-11-20T19:58:14Z
2009-11-20T19:58:14Z
Thorsten Zachmann
Hello,
<br><br>On Friday 20 November 2009 09:27:50 Ben Martin wrote:
<br>> Abstract:
<br>> The non-RDF question is about preserving xml:id on ODF across
<br> > load/save cycles.
<div class='shrinkable-quote'><br>>
<br>> Hi,
<br>> I'm adding support for loading and saving RDF metadata in ODF
<br>> documents for kword. Of course, other ODF like documents like
<br>> spreadsheets which support RDF can also be added to the KOffice suite,
<br>> I've tried to make what I've done generic so it can be expanded as such.
<br>> I'm focusing on kword right now.
<br>>
<br>> I've mostly got external manifest.rdf based metadata working, but I'm
<br>> having a few problems with so called inline RDF. From the ODF
<br>> specification, inline RDF follows a slightly askew subset of RDFa. This
<br>> means that one can have xhtml:about, xhtml:property and xhtml:content
<br>> associated with an XML node and these are used to generate an RDF triple
<br>> during loading. I mostly have loading of such metadata working, with a
<br>> few little corner cases to address.
<br>>
<br>> The two problems I have found is that KOffice discards xml:id
<br>> attributes during load and that I need to track the node that inline RDF
<br>> gets generated from in order to store it back properly on document save.
<br>> These problems are somewhat intermixed because if xml:id's can be saved
<br>> for input documents, then saving the xhtml:about etc could also be done
<br>> in the same code.
<br>>
<br>> I thought I'd ask advise from the list because adding xml:id support
<br>> seems like a fairly intrusive change, and those currently more familiar
<br>> with the codebase might have some ideas as to how to best support it.
<br>> The xhtml:about attribute can appear on many XML elements including
<br>> text:p.
<br>>
<br>> From my investigations, the pertinent code is in the class KoTextLoader.
<br>> Looking at KoTextLoader::loadParagraph() if there is a style applied
<br>> then KoParagraphStyle is used, then loadSpan() is called and, if the
<br>> text:p has no style and only a text child node cursor.insertText() is
<br>> called. This means there are many choices for where to store an xml:id
<br>> for the text:p, but none of them straightforward.
</div><br>I don't think the KoParagraphStyle is a good place to store the stuff as it can
<br>be reused for different paragraphs. Maybe the someone more familiar with KoText
<br>can comment.
<br><br>> Looking at other elements, it seems that KoInline, KoShape for example
<br>> would also need some augmentation to store an xml:id if one was supplied
<br>> in the input ODF file so that the xml:id can be preserved on save.
<br>>
<br>> I look forward to any thoughts or preferences on how the koffice hackers
<br>> would like to see the xml:id support added...
<br>>
<br><br>thanks for the very detailed explanation. I think there are two possible
<br>solutions:
<br><br>1. Don't store the xml:id of the element but attach the meta data to it. This
<br>could be done by having a class containing all the metadata for one element.
<br>and store the data according to the element.
<br>2. Have a map with the xml:id to metadata.
<br><br>Storing the metadata internally has the benefit of no need to synchronize a
<br>central map when e.g. a element is deleted/created ... That is also the way
<br>koffice works most of the time, not keeping the old ids but generating new ones
<br>on save. Also koffice might handle stuff differently internally as saved in odf so
<br>keeping the data in sync might be problematic. This also means the xml:id is
<br>not preserved, but it should not harm as the data is saved back again with a
<br>new xml:id.
<br>Having a separate map makes it easier to load save the data.
<br><br>I hope that explains it a little bit more. Looking to here form you on what
<br>you think.
<br><br>Thorsten
<br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26453585&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26451858
Re: End lines patch
2009-11-20T15:06:51Z
2009-11-20T15:06:51Z
Jérémy Lugagne
Sorry i have forgotten the patch.<br><br>Regards,<br><br>Jérémy.<br>
<br />Index: plugins/dockers/Plugin.cpp
<br>===================================================================
<br>--- plugins/dockers/Plugin.cpp (révision 1051656)
<br>+++ plugins/dockers/Plugin.cpp (copie de travail)
<br>@@ -26,7 +26,7 @@
<br> # include "colordocker/ColorDockerFactory.h"
<br> #endif
<br> #include "shapecollection/KoShapeCollectionDocker.h"
<br>-
<br>+#include "shapeendlines/KoEndLinesDockerFactory.h"
<br> #include <KoDockRegistry.h>
<br>
<br> #include <kgenericfactory.h>
<br>@@ -46,6 +46,7 @@
<br> KoDockRegistry::instance()->add(new ColorDockerFactory());
<br> #endif
<br> KoDockRegistry::instance()->add(new KoShapeCollectionDockerFactory());
<br>+ KoDockRegistry::instance()->add(new KoEndLinesDockerFactory());
<br> }
<br>
<br> #include "Plugin.moc"
<br>Index: plugins/dockers/shapeendlines/endLineStyle/endLine.xml
<br>===================================================================
<br>--- plugins/dockers/shapeendlines/endLineStyle/endLine.xml (révision 0)
<br>+++ plugins/dockers/shapeendlines/endLineStyle/endLine.xml (révision 0)
<br>@@ -0,0 +1,14 @@
<br>+<?xml version="1.0" standalone="no"?>
<br>+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 20010904//EN"
<br>+ "<a href="http://www.w3.org/TR/2001/REC-SVG-20010904/DTD/svg10.dtd" target="_top" rel="nofollow">http://www.w3.org/TR/2001/REC-SVG-20010904/DTD/svg10.dtd</a>">
<br>+<lineends>
<br>+ <draw:marker draw:name="Arrow" draw:display-name="Arrow" svg:viewBox="0 0 20 30" svg:d="m10 0-10 30h20z"/>
<br>+ <draw:marker draw:name="Circle" draw:display-name="Circle" svg:viewBox="0 0 1131 1131" svg:d="m462 1118-102-29-102-51-93-72-72-93-51-102-29-102-13-105 13-102 29-106 51-102 72-89 93-72 102-50 102-34 106-9 101 9 106 34 98 50 93 72 72 89 51 102 29 106 13 102-13 105-29 102-51 102-72 93-93 72-98 51-106 29-101 13z"/>
<br>+ <draw:marker draw:name="Dimension_20_Lines" draw:display-name="Dimension Lines" svg:viewBox="0 0 836 110" svg:d="m0 0h278 278 280v36 36 38h-278-278-280v-36-36z"/>
<br>+ <draw:marker draw:name="Double_20_Arrow" draw:display-name="Double Arrow" svg:viewBox="0 0 1131 1918" svg:d="m737 1131h394l-564-1131-567 1131h398l-398 787h1131z"/>
<br>+ <draw:marker draw:name="Line_20_Arrow" draw:display-name="Line Arrow" svg:viewBox="0 0 1122 2243" svg:d="m0 2108v17 17l12 42 30 34 38 21 43 4 29-8 30-21 25-26 13-34 343-1532 339 1520 13 42 29 34 39 21 42 4 42-12 34-30 21-42v-39-12l-4 4-440-1998-9-42-25-39-38-25-43-8-42 8-38 25-26 39-8 42z"/>
<br>+ <draw:marker draw:name="Square" draw:display-name="Square" svg:viewBox="0 0 10 10" svg:d="m0
<br>+0h10v10h-10z"/>
<br>+ <draw:marker draw:name="Square_20_45" draw:display-name="Square 45" svg:viewBox="0 0 1131 1131" svg:d="m0 564 564 567 567-567-567-564z"/>
<br>+ <draw:marker draw:name="new_shape" draw:display-name="new shape" svg:viewBox="0 0 100 150" svg:d="M 50 0 L 0 55 L 40 55 L 0 100 L 100 100 L 60 55 L 100 55 L 50 0 z"/>
<br>+</lineends>
<br>Index: plugins/dockers/shapeendlines/endLineStyle/CMakeLists.txt
<br>===================================================================
<br>--- plugins/dockers/shapeendlines/endLineStyle/CMakeLists.txt (révision 0)
<br>+++ plugins/dockers/shapeendlines/endLineStyle/CMakeLists.txt (révision 0)
<br>@@ -0,0 +1,3 @@
<br>+install( FILES
<br>+ endLine.xml
<br>+ DESTINATION ${DATA_INSTALL_DIR}/koffice/endLineStyle)
<br>Index: plugins/dockers/shapeendlines/KoEndLineShapeModel.h
<br>===================================================================
<br>--- plugins/dockers/shapeendlines/KoEndLineShapeModel.h (révision 0)
<br>+++ plugins/dockers/shapeendlines/KoEndLineShapeModel.h (révision 0)
<br>@@ -0,0 +1,54 @@
<br>+/* This file is part of the KDE project
<br>+ * Copyright (C) 2008 Alexia Allanic
<br>+ *
<br>+ * This library is free software; you can redistribute it and/or
<br>+ * modify it under the terms of the GNU Library General Public
<br>+ * License as published by the Free Software Foundation; either
<br>+ * version 2 of the License, or (at your option) any later version.
<br>+ *
<br>+ * This library is distributed in the hope that it will be useful,
<br>+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
<br>+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
<br>+ * Library General Public License for more details.
<br>+ *
<br>+ * You should have received a copy of the GNU Library General Public License
<br>+ * along with this library; see the file COPYING.LIB. If not, write to
<br>+ * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
<br>+ * Boston, MA 02110-1301, USA.
<br>+ */
<br>+
<br>+#ifndef KOENDLINESHAPEMODEL_H_
<br>+#define KOENDLINESHAPEMODEL_H_
<br>+
<br>+#include <QAbstractItemModel>
<br>+#include <QList>
<br>+#include <QString>
<br>+#include <QIcon>
<br>+
<br>+/**
<br>+ * Struct containing the information stored in KoEndLineShape item
<br>+ */
<br>+struct KoEndLineShape
<br>+{
<br>+ KoEndLineShape()
<br>+ {
<br>+ };
<br>+
<br>+ QString id;
<br>+ QString name;
<br>+ QIcon icon;
<br>+};
<br>+
<br>+class KoEndLineShapeModel : public QAbstractListModel
<br>+{
<br>+public:
<br>+ KoEndLineShapeModel( QObject * parent = 0 );
<br>+ ~KoEndLineShapeModel() {}
<br>+ int rowCount(const QModelIndex &parent = QModelIndex()) const;
<br>+ QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const;
<br>+ void setShapeTemplateList(const QList<KoEndLineShape>& newlist);
<br>+private:
<br>+ QList<KoEndLineShape> m_shapeTemplateList;
<br>+};
<br>+
<br>+#endif
<br>\ No newline at end of file
<br>Index: plugins/dockers/shapeendlines/KoEndLinesDockerFactory.h
<br>===================================================================
<br>--- plugins/dockers/shapeendlines/KoEndLinesDockerFactory.h (révision 0)
<br>+++ plugins/dockers/shapeendlines/KoEndLinesDockerFactory.h (révision 0)
<br>@@ -0,0 +1,38 @@
<br>+/* This file is part of the KDE project
<br>+ Copyright (C) 2009 Jeremy Lugagne <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26451858&i=0" target="_top" rel="nofollow">lugagne.jeremy@...</a>>
<br>+
<br>+ This library is free software; you can redistribute it and/or
<br>+ modify it under the terms of the GNU Library General Public
<br>+ License as published by the Free Software Foundation; either
<br>+ version 2 of the License, or (at your option) any later version.
<br>+
<br>+ This library is distributed in the hope that it will be useful,
<br>+ but WITHOUT ANY WARRANTY; without even the implied warranty of
<br>+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
<br>+ Library General Public License for more details.
<br>+
<br>+ You should have received a copy of the GNU Library General Public License
<br>+ along with this library; see the file COPYING.LIB. If not, write to
<br>+ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
<br>+ * Boston, MA 02110-1301, USA.
<br>+*/
<br>+
<br>+#ifndef KOENDLINESDOCKERFACTORY_H
<br>+#define KOENDLINESDOCKERFACTORY_H
<br>+
<br>+#include <KoDockFactory.h>
<br>+#include <QtGui/QDockWidget>
<br>+
<br>+/// the factory which creates the shape properties docker
<br>+class KoEndLinesDockerFactory : public KoDockFactory
<br>+{
<br>+public:
<br>+ KoEndLinesDockerFactory();
<br>+
<br>+ virtual QString id() const;
<br>+ virtual QDockWidget* createDockWidget();
<br>+ virtual DockPosition defaultDockPosition() const;
<br>+
<br>+};
<br>+
<br>+#endif // KOENDLINESDOCKERFACTORY_H
<br>Index: plugins/dockers/shapeendlines/KoShapeEndLinesDocker.cpp
<br>===================================================================
<br>--- plugins/dockers/shapeendlines/KoShapeEndLinesDocker.cpp (révision 0)
<br>+++ plugins/dockers/shapeendlines/KoShapeEndLinesDocker.cpp (révision 0)
<br>@@ -0,0 +1,208 @@
<br>+/* This file is part of the KDE project
<br>+ Made by Tomislav Lukman (<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26451858&i=1" target="_top" rel="nofollow">tomislav.lukman@...</a>)
<br>+ Copyright (C) 2009 Jeremy Lugagne <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26451858&i=2" target="_top" rel="nofollow">lugagne.jeremy@...</a>>
<br>+
<br>+ This library is free software; you can redistribute it and/or
<br>+ modify it under the terms of the GNU Library General Public
<br>+ License as published by the Free Software Foundation; either
<br>+ version 2 of the License, or (at your option) any later version.
<br>+
<br>+ This library is distributed in the hope that it will be useful,
<br>+ but WITHOUT ANY WARRANTY; without even the implied warranty of
<br>+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
<br>+ Library General Public License for more details.
<br>+
<br>+ You should have received a copy of the GNU Library General Public License
<br>+ along with this library; see the file COPYING.LIB. If not, write to
<br>+ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
<br>+ * Boston, MA 02110-1301, USA.
<br>+*/
<br>+
<br>+#include "KoShapeEndLinesDocker.h"
<br>+
<br>+#include <KoToolManager.h>
<br>+#include <KoCanvasBase.h>
<br>+#include <KoCanvasController.h>
<br>+#include <KoShapeManager.h>
<br>+#include <klocale.h>
<br>+#include <KoOdfReadStore.h>
<br>+#include <kstandarddirs.h>
<br>+#include <KoShape.h>
<br>+#include <KoSelection.h>
<br>+#include <KoPathShape.h>
<br>+#include <KoLineEnd.h>
<br>+
<br>+#include <QList>
<br>+#include <QLabel>
<br>+#include <QGridLayout>
<br>+#include <QComboBox>
<br>+#include <QSlider>
<br>+
<br>+
<br>+KoShapeEndLinesDocker::KoShapeEndLinesDocker()
<br>+{
<br>+ setWindowTitle( i18n( "End Lines" ) );
<br>+
<br>+ QWidget *mainWidget = new QWidget( this );
<br>+ QGridLayout *mainLayout = new QGridLayout( mainWidget );
<br>+
<br>+ // Define the two QComboBox
<br>+ m_iconW = 20;
<br>+ m_iconH = 20;
<br>+ m_iconSize.setHeight(m_iconH);
<br>+ m_iconSize.setWidth(m_iconW);
<br>+ m_beginEndLineComboBox = new QComboBox( mainWidget );
<br>+ m_beginEndLineComboBox->setIconSize(m_iconSize);
<br>+
<br>+ qRegisterMetaType<KoLineEnd>("KoLineEnd");
<br>+
<br>+ QPixmap qp(m_iconSize);
<br>+ qp.fill(Qt::transparent);
<br>+ QVariant beginNone;
<br>+ QVariant endNone;
<br>+ m_beginEndLineComboBox->addItem(QIcon(qp),"None", beginNone.fromValue( KoLineEnd() ) );
<br>+ m_endEndLineComboBox = new QComboBox( mainWidget );
<br>+ m_endEndLineComboBox->setIconSize(m_iconSize);
<br>+ m_endEndLineComboBox->addItem(QIcon(qp),"None", beginNone.fromValue( KoLineEnd() ) );
<br>+
<br>+ int proportion = 3;
<br>+ QString fileName( KStandardDirs::locate( "data","koffice/endLineStyle/endLine.xml" ) );
<br>+ if ( ! fileName.isEmpty() ) {
<br>+ QFile file( fileName );
<br>+ QString errorMessage;
<br>+ if ( KoOdfReadStore::loadAndParse( &file, m_doc, errorMessage, fileName ) ) {
<br>+ KoXmlElement drawMarker, lineEndElement(m_doc.namedItem("lineends").toElement());
<br>+
<br>+ forEachElement(drawMarker, lineEndElement){
<br>+
<br>+ KoLineEnd temp(drawMarker.attribute("display-name"),drawMarker.attribute("d"),drawMarker.attribute("viewBox"));
<br>+
<br>+ QIcon drawIcon(temp.drawIcon(m_iconSize, proportion));
<br>+
<br>+ QVariant beginValue;
<br>+ QVariant endValue;
<br>+ // add icon and label in the two QComboBox
<br>+ m_beginEndLineComboBox->addItem( drawIcon, temp.name(), beginValue.fromValue( temp ) );
<br>+ m_endEndLineComboBox->addItem( drawIcon, temp.name(), endValue.fromValue( temp ) );
<br>+ }
<br>+ }
<br>+ }
<br>+
<br>+ // Add Begin to the docker
<br>+ QLabel * beginEndLineLabel = new QLabel( i18n( "Begin :" ), mainWidget );
<br>+ mainLayout->addWidget( beginEndLineLabel, 0, 0 );
<br>+ mainLayout->addWidget( m_beginEndLineComboBox,1,0,1,3);
<br>+ m_beginEndLineSize = new QSlider(Qt::Horizontal);
<br>+ m_beginEndLineSize->setRange(0, 100);
<br>+ mainLayout->addWidget( m_beginEndLineSize,2,0,1,3);
<br>+ connect( m_beginEndLineComboBox, SIGNAL( activated( int ) ), this, SLOT( beginEndLineChanged( int ) ) );
<br>+ connect( m_beginEndLineSize, SIGNAL( valueChanged( int ) ), this, SLOT( beginEndLineSizeChanged( int ) ) );
<br>+
<br>+ // Add End to the docker
<br>+ QLabel * endEndLineLabel = new QLabel( i18n( "End :" ), mainWidget );
<br>+ mainLayout->addWidget( endEndLineLabel, 3, 0 );
<br>+ mainLayout->addWidget( m_endEndLineComboBox,4,0,1,3);
<br>+ m_endEndLineSize = new QSlider(Qt::Horizontal);
<br>+ m_endEndLineSize->setRange(0, 100);
<br>+ mainLayout->addWidget( m_endEndLineSize,5,0,1,3);
<br>+ connect( m_endEndLineComboBox, SIGNAL( activated( int ) ), this, SLOT( endEndLineChanged( int ) ) );
<br>+ connect( m_endEndLineSize, SIGNAL( valueChanged( int ) ), this, SLOT( endEndLineSizeChanged( int ) ) );
<br>+
<br>+
<br>+ mainLayout->setRowStretch( 5, 1 );
<br>+ mainLayout->setColumnStretch( 1, 1 );
<br>+ mainLayout->setColumnStretch( 2, 1 );
<br>+ mainLayout->setColumnStretch( 3, 1 );
<br>+
<br>+ setWidget( mainWidget );
<br>+ setEnabled ( false );
<br>+}
<br>+
<br>+KoShapeEndLinesDocker::~KoShapeEndLinesDocker()
<br>+{
<br>+}
<br>+
<br>+void KoShapeEndLinesDocker::applyChanges()
<br>+{
<br>+ KoSelection *selection = m_canvas->shapeManager()->selection();
<br>+ KoLineEnd begin ( m_beginEndLineComboBox->itemData( m_beginEndLineComboBox->currentIndex() ).value<KoLineEnd>() );
<br>+ KoLineEnd end( m_endEndLineComboBox->itemData( m_endEndLineComboBox->currentIndex() ).value<KoLineEnd>() ) ;
<br>+
<br>+ QList<KoShape*> list = selection->selectedShapes();
<br>+ QList<KoShape*>::const_iterator i;
<br>+ for (i = list.constBegin(); i != list.constEnd(); ++i){
<br>+ KoPathShape *pathShape;
<br>+ if( ( pathShape = dynamic_cast<KoPathShape*>( *i ) ) ){
<br>+ pathShape->setBeginLineEnd(begin);
<br>+ pathShape->setEndLineEnd(end);
<br>+ pathShape->getBeginLineEnd().setSize(m_beginSize);
<br>+ pathShape->getEndLineEnd().setSize(m_endSize);
<br>+ pathShape->update();
<br>+ }
<br>+ }
<br>+}
<br>+
<br>+
<br>+void KoShapeEndLinesDocker::setEnabled(bool enable)
<br>+{
<br>+ m_beginEndLineComboBox->setEnabled(enable);
<br>+ m_endEndLineComboBox->setEnabled(enable);
<br>+ m_beginEndLineSize->setEnabled(enable);
<br>+ m_endEndLineSize->setEnabled(enable);
<br>+}
<br>+
<br>+void KoShapeEndLinesDocker::beginEndLineChanged(int index)
<br>+{
<br>+ m_beginEndLineComboBox->setCurrentIndex(index);
<br>+ m_beginEndLineCurrentName = m_beginEndLineComboBox->itemText(index);
<br>+ applyChanges();
<br>+}
<br>+
<br>+void KoShapeEndLinesDocker::endEndLineChanged(int index)
<br>+{
<br>+ m_endEndLineComboBox->setCurrentIndex(index);
<br>+ m_endEndLineCurrentName = m_endEndLineComboBox->itemText(index);
<br>+ applyChanges();
<br>+}
<br>+
<br>+void KoShapeEndLinesDocker::beginEndLineSizeChanged(int size)
<br>+{
<br>+ m_beginSize = size;
<br>+ applyChanges();
<br>+}
<br>+
<br>+void KoShapeEndLinesDocker::endEndLineSizeChanged(int size)
<br>+{
<br>+ m_endSize = size;
<br>+ applyChanges();
<br>+}
<br>+
<br>+void KoShapeEndLinesDocker::selectionChanged()
<br>+{
<br>+ KoSelection *selection = m_canvas->shapeManager()->selection();
<br>+ if ( selection ) {
<br>+ KoShape* shape = selection->firstSelectedShape();
<br>+ if(shape){
<br>+ if(shape->shapeId() == "KoPathShape"){
<br>+ KoPathShape* pathShape = dynamic_cast<KoPathShape*>(shape);
<br>+ m_endEndLineSize->setSliderPosition(pathShape->getBeginLineEnd().getSize());
<br>+ m_beginEndLineSize->setSliderPosition(pathShape->getEndLineEnd().getSize());
<br>+ setEnabled ( true );
<br>+ }else{
<br>+ setEnabled ( false );
<br>+ }
<br>+ }else{
<br>+ setEnabled ( false );
<br>+ }
<br>+ }else{
<br>+ setEnabled ( false );
<br>+ }
<br>+}
<br>+
<br>+void KoShapeEndLinesDocker::setCanvas( KoCanvasBase *canvas )
<br>+{
<br>+ m_canvas = canvas;
<br>+ connect(m_canvas->shapeManager(), SIGNAL(selectionChanged()), this, SLOT(selectionChanged()));
<br>+}
<br>+#include "KoShapeEndLinesDocker.moc"
<br>+
<br>Index: plugins/dockers/shapeendlines/KoShapeEndLinesDocker.h
<br>===================================================================
<br>--- plugins/dockers/shapeendlines/KoShapeEndLinesDocker.h (révision 0)
<br>+++ plugins/dockers/shapeendlines/KoShapeEndLinesDocker.h (révision 0)
<br>@@ -0,0 +1,81 @@
<br>+/* This file is part of the KDE project
<br>+ Made by Tomislav Lukman (<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26451858&i=3" target="_top" rel="nofollow">tomislav.lukman@...</a>)
<br>+ Copyright (C) 2009 Jeremy Lugagne <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26451858&i=4" target="_top" rel="nofollow">lugagne.jeremy@...</a>>
<br>+
<br>+ This library is free software; you can redistribute it and/or
<br>+ modify it under the terms of the GNU Library General Public
<br>+ License as published by the Free Software Foundation; either
<br>+ version 2 of the License, or (at your option) any later version.
<br>+
<br>+ This library is distributed in the hope that it will be useful,
<br>+ but WITHOUT ANY WARRANTY; without even the implied warranty of
<br>+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
<br>+ Library General Public License for more details.
<br>+
<br>+ You should have received a copy of the GNU Library General Public License
<br>+ along with this library; see the file COPYING.LIB. If not, write to
<br>+ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
<br>+ * Boston, MA 02110-1301, USA.
<br>+*/
<br>+
<br>+#ifndef KOSHAPEENDLINESDOCKER_H
<br>+#define KOSHAPEENDLINESDOCKER_H
<br>+
<br>+#include <KoUnit.h>
<br>+#include <KoXmlReader.h>
<br>+#include <KoCanvasObserver.h>
<br>+#include <QtGui/QDockWidget>
<br>+#include <QListView>
<br>+#include <QDockWidget>
<br>+#include <kdebug.h>
<br>+#include <QStringList>
<br>+
<br>+class KoShapeBorderModel;
<br>+class KoCanvasController;
<br>+class KoLineEnd;
<br>+class QComboBox;
<br>+class QSlider;
<br>+class KoCanvasBase;
<br>+
<br>+/// A docker for setting properties of end lines
<br>+class KoShapeEndLinesDocker : public QDockWidget, public KoCanvasObserver
<br>+{
<br>+ Q_OBJECT
<br>+
<br>+public:
<br>+ /// Creates the end lines docker
<br>+ KoShapeEndLinesDocker();
<br>+ virtual ~KoShapeEndLinesDocker();
<br>+private slots:
<br>+ void applyChanges();
<br>+ /// End Line has changed
<br>+ void beginEndLineChanged(int index);
<br>+ void endEndLineChanged(int index);
<br>+ void beginEndLineSizeChanged(int index);
<br>+ void endEndLineSizeChanged(int index);
<br>+
<br>+ /// selection has changed
<br>+ void selectionChanged();
<br>+ /// reimplemented
<br>+ virtual void setCanvas( KoCanvasBase *canvas );
<br>+ void setEnabled(bool enable);
<br>+private:
<br>+ KoCanvasBase* m_canvas;
<br>+ KoXmlDocument m_doc;
<br>+ QString m_beginEndLineCurrentName;
<br>+ QString m_endEndLineCurrentName;
<br>+ int m_iconW;
<br>+ int m_iconH;
<br>+ int m_beginSize;
<br>+ int m_endSize;
<br>+ QSize m_iconSize;
<br>+ QMap<QString, QString> m_pathEndLineMap;
<br>+ QMap<QString, QString> m_viewEndLineMap;
<br>+ QComboBox * m_beginEndLineComboBox;
<br>+ QComboBox * m_endEndLineComboBox;
<br>+ QSlider * m_beginEndLineSize;
<br>+ QSlider * m_endEndLineSize;
<br>+};
<br>+
<br>+#endif // KOSHAPEENDLINESDOCKER_H
<br>+
<br>Index: plugins/dockers/shapeendlines/KoEndLineShapeModel.cpp
<br>===================================================================
<br>--- plugins/dockers/shapeendlines/KoEndLineShapeModel.cpp (révision 0)
<br>+++ plugins/dockers/shapeendlines/KoEndLineShapeModel.cpp (révision 0)
<br>@@ -0,0 +1,65 @@
<br>+/* This file is part of the KDE project
<br>+ * Copyright (C) 2008 Alexia Allanic
<br>+ *
<br>+ * This library is free software; you can redistribute it and/or
<br>+ * modify it under the terms of the GNU Library General Public
<br>+ * License as published by the Free Software Foundation; either
<br>+ * version 2 of the License, or (at your option) any later version.
<br>+ *
<br>+ * This library is distributed in the hope that it will be useful,
<br>+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
<br>+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
<br>+ * Library General Public License for more details.
<br>+ *
<br>+ * You should have received a copy of the GNU Library General Public License
<br>+ * along with this library; see the file COPYING.LIB. If not, write to
<br>+ * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
<br>+ * Boston, MA 02110-1301, USA.
<br>+ */
<br>+
<br>+#include "KoEndLineShapeModel.h"
<br>+
<br>+KoEndLineShapeModel::KoEndLineShapeModel( QObject * parent )
<br>+ : QAbstractListModel( parent )
<br>+{
<br>+
<br>+}
<br>+
<br>+int KoEndLineShapeModel::rowCount( const QModelIndex &/*parent*/ ) const
<br>+{
<br>+
<br>+}
<br>+
<br>+QVariant KoEndLineShapeModel::data( const QModelIndex &index, int role ) const
<br>+{
<br>+ if (!index.isValid() || index.row() > m_shapeTemplateList.count ())
<br>+ return QVariant();
<br>+
<br>+ switch(role)
<br>+ {
<br>+ //case Qt::ToolTipRole:
<br>+ // return m_shapeTemplateList[index.row()].toolTip;
<br>+
<br>+ case Qt::DecorationRole:
<br>+ return m_shapeTemplateList[index.row()].icon;
<br>+
<br>+ case Qt::UserRole:
<br>+ return m_shapeTemplateList[index.row()].id;
<br>+
<br>+ // case Qt::UserRole + 1:
<br>+ // return m_shapeTemplateList[index.row()].properties;
<br>+
<br>+ case Qt::DisplayRole:
<br>+ return m_shapeTemplateList[index.row()].name;
<br>+
<br>+ default:
<br>+ return QVariant();
<br>+ }
<br>+
<br>+ return QVariant();
<br>+}
<br>+void KoEndLineShapeModel::setShapeTemplateList(const QList<KoEndLineShape>& newlist)
<br>+{
<br>+ m_shapeTemplateList = newlist;
<br>+ reset();
<br>+}
<br>Index: plugins/dockers/shapeendlines/KoEndLinesDockerFactory.cpp
<br>===================================================================
<br>--- plugins/dockers/shapeendlines/KoEndLinesDockerFactory.cpp (révision 0)
<br>+++ plugins/dockers/shapeendlines/KoEndLinesDockerFactory.cpp (révision 0)
<br>@@ -0,0 +1,43 @@
<br>+/* This file is part of the KDE project
<br>+ Copyright (C) 2009 Jeremy Lugagne <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26451858&i=5" target="_top" rel="nofollow">lugagne.jeremy@...</a>>
<br>+
<br>+ This library is free software; you can redistribute it and/or
<br>+ modify it under the terms of the GNU Library General Public
<br>+ License as published by the Free Software Foundation; either
<br>+ version 2 of the License, or (at your option) any later version.
<br>+
<br>+ This library is distributed in the hope that it will be useful,
<br>+ but WITHOUT ANY WARRANTY; without even the implied warranty of
<br>+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
<br>+ Library General Public License for more details.
<br>+
<br>+ You should have received a copy of the GNU Library General Public License
<br>+ along with this library; see the file COPYING.LIB. If not, write to
<br>+ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
<br>+ * Boston, MA 02110-1301, USA.
<br>+*/
<br>+
<br>+#include "KoEndLinesDockerFactory.h"
<br>+#include "KoShapeEndLinesDocker.h"
<br>+
<br>+KoEndLinesDockerFactory::KoEndLinesDockerFactory()
<br>+{
<br>+}
<br>+
<br>+QString KoEndLinesDockerFactory::id() const
<br>+{
<br>+ return QString("End Lines");
<br>+}
<br>+
<br>+QDockWidget* KoEndLinesDockerFactory::createDockWidget()
<br>+{
<br>+ KoShapeEndLinesDocker* widget = new KoShapeEndLinesDocker();
<br>+ widget->setObjectName(id());
<br>+
<br>+ return widget;
<br>+}
<br>+
<br>+KoDockFactory::DockPosition KoEndLinesDockerFactory::defaultDockPosition() const
<br>+{
<br>+ return DockMinimized;
<br>+}
<br>Index: plugins/dockers/shapeendlines/pics/triangle.svg
<br>===================================================================
<br>--- plugins/dockers/shapeendlines/pics/triangle.svg (révision 0)
<br>+++ plugins/dockers/shapeendlines/pics/triangle.svg (révision 0)
<br>@@ -0,0 +1,12 @@
<br>+<?xml version="1.0" standalone="no"?>
<br>+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 20010904//EN"
<br>+ "<a href="http://www.w3.org/TR/2001/REC-SVG-20010904/DTD/svg10.dtd" target="_top" rel="nofollow">http://www.w3.org/TR/2001/REC-SVG-20010904/DTD/svg10.dtd</a>">
<br>+<svg width="4cm" height="4cm" viewBox="0 0 400 400"
<br>+ xmlns="<a href="http://www.w3.org/2000/svg" target="_top" rel="nofollow">http://www.w3.org/2000/svg</a>">
<br>+ <title>Exemple triangle01- exemple simple d'un 'path'</title>
<br>+ <desc>Un tracé dessinant un triangle</desc>
<br>+ <rect x="1" y="1" width="398" height="398"
<br>+ fill="none" stroke="blue" />
<br>+ <path d="M 100 100 L 300 100 L 200 300 z"
<br>+ fill="black" stroke="black" stroke-width="3" />
<br>+</svg>
<br>Index: plugins/dockers/shapeendlines/pics/CMakeLists.txt
<br>===================================================================
<br>--- plugins/dockers/shapeendlines/pics/CMakeLists.txt (révision 0)
<br>+++ plugins/dockers/shapeendlines/pics/CMakeLists.txt (révision 0)
<br>@@ -0,0 +1,5 @@
<br>+install( FILES
<br>+ triangle.svg
<br>+ DESTINATION ${DATA_INSTALL_DIR}/kpresenter/pics)
<br>+
<br>+kde4_install_icons( ${ICON_INSTALL_DIR} )
<br>\ No newline at end of file
<br>Index: plugins/dockers/CMakeLists.txt
<br>===================================================================
<br>--- plugins/dockers/CMakeLists.txt (révision 1051656)
<br>+++ plugins/dockers/CMakeLists.txt (copie de travail)
<br>@@ -48,6 +48,9 @@
<br> linestyleselector/LineStyleModel.cpp
<br> linestyleselector/LineStyleSelector.cpp
<br>
<br>+ shapeendlines/KoShapeEndLinesDocker.cpp
<br>+ shapeendlines/KoEndLinesDockerFactory.cpp
<br>+
<br> styledocker/StyleButtonBox.cpp
<br> styledocker/StylePreview.cpp
<br> styledocker/StyleDocker.cpp
<br>@@ -57,6 +60,8 @@
<br> )
<br>
<br> add_subdirectory( strokedocker/pics )
<br>+add_subdirectory( shapeendlines/pics )
<br>+add_subdirectory( shapeendlines/endLineStyle )
<br>
<br> if (NOT NO_PIGMENT)
<br> set(kofficedockers_SRCS ${kofficedockers_SRCS}
<br>Index: libs/flake/KoLineEnd.h
<br>===================================================================
<br>--- libs/flake/KoLineEnd.h (révision 0)
<br>+++ libs/flake/KoLineEnd.h (révision 0)
<br>@@ -0,0 +1,79 @@
<br>+/* This file is part of the KDE project
<br>+ Copyright (C) 2009 Jeremy Lugagne <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26451858&i=6" target="_top" rel="nofollow">lugagne.jeremy@...</a>>
<br>+
<br>+ This library is free software; you can redistribute it and/or
<br>+ modify it under the terms of the GNU Library General Public
<br>+ License as published by the Free Software Foundation; either
<br>+ version 2 of the License, or (at your option) any later version.
<br>+
<br>+ This library is distributed in the hope that it will be useful,
<br>+ but WITHOUT ANY WARRANTY; without even the implied warranty of
<br>+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
<br>+ Library General Public License for more details.
<br>+
<br>+ You should have received a copy of the GNU Library General Public License
<br>+ along with this library; see the file COPYING.LIB. If not, write to
<br>+ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
<br>+ * Boston, MA 02110-1301, USA.
<br>+*/
<br>+
<br>+
<br>+#ifndef KOLINEEND_H
<br>+#define KOLINEEND_H
<br>+
<br>+#include <KoUnit.h>
<br>+#include <KoXmlReader.h>
<br>+#include <KoCanvasObserver.h>
<br>+#include <QtGui/QDockWidget>
<br>+#include <QListView>
<br>+#include <QDockWidget>
<br>+#include <kdebug.h>
<br>+#include <QStringList>
<br>+#include "flake_export.h"
<br>+#include <QObject>
<br>+#include <QMetaType>
<br>+
<br>+class KoShapeBorderModel;
<br>+class KoCanvasController;
<br>+class KoPathShape;
<br>+class KoPathPoint;
<br>+class QPainter;
<br>+class QRectF;
<br>+class QMatrix;
<br>+
<br>+class FLAKE_EXPORT KoLineEnd : public QObject {
<br>+Q_OBJECT
<br>+
<br>+public:
<br>+ KoLineEnd(const QString &name, const QString &path, const QString &view, const QString& transform = QString());
<br>+ KoLineEnd();
<br>+ KoLineEnd(const KoLineEnd &);
<br>+ KoLineEnd& operator=(const KoLineEnd&);
<br>+ virtual ~KoLineEnd();
<br>+ QIcon drawIcon(const QSize &size, const int proportion);
<br>+ QString name() const;
<br>+ QString path() const;
<br>+ QString viewBox() const;
<br>+ QString transform() const;
<br>+ void setTransform(const QString &transform);
<br>+ QByteArray generateSVG(const QSize &size, const QString &comment = QString());
<br>+ QByteArray getSVG() const;
<br>+ void paint(QPainter &painter, const KoPathPoint* point);
<br>+ static QPointF computeAngle(const KoPathPoint* point);
<br>+ int getSize();
<br>+
<br>+public slots:
<br>+ void setSize(int size);
<br>+
<br>+private:
<br>+ QString m_name;
<br>+ QString m_path;
<br>+ QString m_view;
<br>+ QByteArray m_svg;
<br>+ QString m_transform;
<br>+ int m_size;
<br>+};
<br>+
<br>+Q_DECLARE_METATYPE(KoLineEnd);
<br>+#endif // KOLINEEND_H
<br>+
<br>Index: libs/flake/KoPathShape.h
<br>===================================================================
<br>--- libs/flake/KoPathShape.h (révision 1051656)
<br>+++ libs/flake/KoPathShape.h (copie de travail)
<br>@@ -2,6 +2,7 @@
<br> Copyright (C) 2006 Thorsten Zachmann <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26451858&i=7" target="_top" rel="nofollow">zachmann@...</a>>
<br> Copyright (C) 2007,2009 Thomas Zander <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26451858&i=8" target="_top" rel="nofollow">zander@...</a>>
<br> Copyright (C) 2006-2008 Jan Hambrecht <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26451858&i=9" target="_top" rel="nofollow">jaham@...</a>>
<br>+ Copyright (C) 2009 Jeremy Lugagne <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26451858&i=10" target="_top" rel="nofollow">lugagne.jeremy@...</a>>
<br>
<br> This library is free software; you can redistribute it and/or
<br> modify it under the terms of the GNU Library General Public
<br>@@ -28,8 +29,10 @@
<br>
<br> #include "KoShape.h"
<br> #include "KoPathSegment.h"
<br>+#include "KoLineEnd.h"
<br>
<br> #define KoPathShapeId "KoPathShape"
<br>+#define KoPathShapeEndLineSize 15
<br>
<br> class KoPathShape;
<br> class KoPathPoint;
<br>@@ -429,7 +432,21 @@
<br> * @return the specific shape id
<br> */
<br> virtual QString pathShapeId() const;
<br>+ /**
<br>+ * @brief Add a line end at the begining of the path
<br>+ * @param path the path in svg's d format attribute
<br>+ */
<br>+ void setBeginLineEnd(const KoLineEnd &path);
<br>+
<br>+ /**
<br>+ * @brief Add a line end at the ending of the path
<br>+ * @param path the path in svg's d format attribute
<br>+ */
<br>+ void setEndLineEnd(const KoLineEnd &path);
<br>
<br>+ KoLineEnd& getEndLineEnd();
<br>+ KoLineEnd& getBeginLineEnd();
<br>+
<br> /// Returns a odf/svg string represenatation of the path data with the given matrix applied.
<br> QString toString(const QMatrix &matrix) const;
<br>
<br>@@ -447,6 +464,10 @@
<br> KoPathShape(KoPathShapePrivate &);
<br>
<br> private:
<br>+ KoLineEnd beginLineEnd;
<br>+ KoLineEnd endLineEnd;
<br>+
<br>+
<br> // TODO move all the private methods to live on the d pointer object
<br> void map(const QMatrix &matrix);
<br>
<br>Index: libs/flake/CMakeLists.txt
<br>===================================================================
<br>--- libs/flake/CMakeLists.txt (révision 1051656)
<br>+++ libs/flake/CMakeLists.txt (copie de travail)
<br>@@ -105,6 +105,7 @@
<br> KoFilterEffectRegistry.cpp
<br> KoFilterEffectConfigWidgetBase.cpp
<br> KoFilterEffectRenderContext.cpp
<br>+ KoLineEnd.cpp
<br> commands/KoShapeGroupCommand.cpp
<br> commands/KoShapeAlignCommand.cpp
<br> commands/KoShapeBackgroundCommand.cpp
<br>Index: libs/flake/KoPathShape.cpp
<br>===================================================================
<br>--- libs/flake/KoPathShape.cpp (révision 1051656)
<br>+++ libs/flake/KoPathShape.cpp (copie de travail)
<br>@@ -2,6 +2,7 @@
<br> Copyright (C) 2006-2008 Thorsten Zachmann <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26451858&i=11" target="_top" rel="nofollow">zachmann@...</a>>
<br> Copyright (C) 2006-2008 Jan Hambrecht <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26451858&i=12" target="_top" rel="nofollow">jaham@...</a>>
<br> Copyright (C) 2007-2009 Thomas Zander <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26451858&i=13" target="_top" rel="nofollow">zander@...</a>>
<br>+ Copyright (C) 2009 Jeremy Lugagne <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26451858&i=14" target="_top" rel="nofollow">lugagne.jeremy@...</a>>
<br>
<br> This library is free software; you can redistribute it and/or
<br> modify it under the terms of the GNU Library General Public
<br>@@ -226,6 +227,11 @@
<br> QPainterPath path(outline());
<br> path.setFillRule(d->fillRule);
<br>
<br>+ if (m_subpaths.first())
<br>+ endLineEnd.paint(painter, m_subpaths.first()->first());
<br>+ if (m_subpaths.last())
<br>+ beginLineEnd.paint(painter, m_subpaths.last()->last());
<br>+
<br> if (background())
<br> background()->paint(painter, path);
<br> //paintDebug( painter );
<br>@@ -1302,3 +1308,23 @@
<br>
<br> return outlinePath.contains(point);
<br> }
<br>+
<br>+void KoPathShape::setBeginLineEnd( const KoLineEnd &path )
<br>+{
<br>+ beginLineEnd = path;
<br>+}
<br>+
<br>+void KoPathShape::setEndLineEnd( const KoLineEnd &path )
<br>+{
<br>+ endLineEnd = path;
<br>+}
<br>+
<br>+KoLineEnd& KoPathShape::getBeginLineEnd()
<br>+{
<br>+ return beginLineEnd;
<br>+}
<br>+
<br>+KoLineEnd& KoPathShape::getEndLineEnd()
<br>+{
<br>+ return endLineEnd;
<br>+}
<br>Index: libs/flake/KoLineEnd.cpp
<br>===================================================================
<br>--- libs/flake/KoLineEnd.cpp (révision 0)
<br>+++ libs/flake/KoLineEnd.cpp (révision 0)
<br>@@ -0,0 +1,200 @@
<br>+/* This file is part of the KDE project
<br>+ Copyright (C) 2009 Jeremy Lugagne <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26451858&i=15" target="_top" rel="nofollow">lugagne.jeremy@...</a>>
<br>+
<br>+ This library is free software; you can redistribute it and/or
<br>+ modify it under the terms of the GNU Library General Public
<br>+ License as published by the Free Software Foundation; either
<br>+ version 2 of the License, or (at your option) any later version.
<br>+
<br>+ This library is distributed in the hope that it will be useful,
<br>+ but WITHOUT ANY WARRANTY; without even the implied warranty of
<br>+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
<br>+ Library General Public License for more details.
<br>+
<br>+ You should have received a copy of the GNU Library General Public License
<br>+ along with this library; see the file COPYING.LIB. If not, write to
<br>+ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
<br>+ * Boston, MA 02110-1301, USA.
<br>+*/
<br>+
<br>+#include "KoLineEnd.h"
<br>+#include "KoPathPoint.h"
<br>+#include "KoPathPointData.h"
<br>+
<br>+#include <QPixmap>
<br>+#include <QIcon>
<br>+#include <QSvgRenderer>
<br>+#include <QPainter>
<br>+#include <QRectF>
<br>+#include <QBrush>
<br>+#include <QMatrix>
<br>+
<br>+//qRegisterMetaType<KoLineEnd>("KoLineEnd");
<br>+
<br>+KoLineEnd::KoLineEnd(const QString &name, const QString &path, const QString &view, const QString& transform)
<br>+{
<br>+ m_name = name;
<br>+ m_path = path;
<br>+ m_view = view;
<br>+ m_transform = transform;
<br>+ m_size = 5;
<br>+}
<br>+
<br>+KoLineEnd::KoLineEnd()
<br>+{
<br>+}
<br>+
<br>+KoLineEnd::KoLineEnd(const KoLineEnd &lineEnd)
<br>+{
<br>+ m_name = lineEnd.m_name;
<br>+ m_path = lineEnd.m_path;
<br>+ m_view = lineEnd.m_view;
<br>+ m_svg = lineEnd.m_svg;
<br>+ m_size = lineEnd.m_size;
<br>+}
<br>+
<br>+KoLineEnd& KoLineEnd::operator=(const KoLineEnd &lineEnd)
<br>+{
<br>+ m_name = lineEnd.m_name;
<br>+ m_path = lineEnd.m_path;
<br>+ m_view = lineEnd.m_view;
<br>+ m_svg = lineEnd.m_svg;
<br>+ m_size = lineEnd.m_size;
<br>+}
<br>+
<br>+KoLineEnd::~KoLineEnd()
<br>+{
<br>+}
<br>+
<br>+void KoLineEnd::setSize ( int size )
<br>+{
<br>+ m_size = size;
<br>+}
<br>+
<br>+int KoLineEnd::getSize()
<br>+{
<br>+ return m_size;
<br>+}
<br>+
<br>+QByteArray KoLineEnd::generateSVG ( const QSize &size, const QString &comment )
<br>+{
<br>+ QByteArray width(QString::number(size.width()).toUtf8());
<br>+ QByteArray height(QString::number(size.height()).toUtf8());
<br>+ QByteArray str("<?xml version=\"1.0\" standalone=\"no\"?>");
<br>+ str.append("<!--"+comment.toUtf8()+"-->");
<br>+ str.append("<!DOCTYPE svg PUBLIC \"-//W3C//DTD SVG 20010904//EN\" \"<a href="http://www.w3.org/TR/2001/REC-SVG-20010904/DTD/svg10.dtd" target="_top" rel="nofollow">http://www.w3.org/TR/2001/REC-SVG-20010904/DTD/svg10.dtd</a>\">");
<br>+ str.append("<svg width=\""+width+"px\" height=\""+height+"px\" viewBox=\""+m_view.toUtf8()+"\" preserveAspectRatio=\"xMidYMid meet\" xmlns=\"<a href="http://www.w3.org/2000/svg" target="_top" rel="nofollow">http://www.w3.org/2000/svg</a>\">");
<br>+ str.append("<path width=\""+width+"px\" height=\""+height+"px\" fill=\"black\" d=\""+m_path.toUtf8()+"\" transform=\""+m_transform.toUtf8()+"\" />");
<br>+ str.append("</svg>");
<br>+ m_svg = str;
<br>+ return str;
<br>+}
<br>+
<br>+QByteArray KoLineEnd::getSVG() const
<br>+{
<br>+ return m_svg;
<br>+}
<br>+
<br>+QIcon KoLineEnd::drawIcon(const QSize &size, const int proportion)
<br>+{
<br>+ QSvgRenderer endLineRenderer;
<br>+ QPixmap endLinePixmap(size);
<br>+ endLinePixmap.fill(QColor(Qt::transparent));
<br>+ QPainter endLinePainter(&endLinePixmap);
<br>+ // Convert path to SVG
<br>+ //endLineRenderer.load(generateSVG(QSize(size.width()-6, size.height()-6)));
<br>+ endLineRenderer.load(generateSVG(QSize(30, 30)));
<br>+ endLineRenderer.render(&endLinePainter, QRectF(proportion, proportion, size.width()-(proportion*2), size.height()-(proportion*2)));
<br>+
<br>+ // return QIcon
<br>+ return QIcon (endLinePixmap);
<br>+}
<br>+
<br>+QString KoLineEnd::name() const
<br>+{
<br>+ return m_name;
<br>+}
<br>+
<br>+QString KoLineEnd::path() const
<br>+{
<br>+ return m_path;
<br>+}
<br>+
<br>+QString KoLineEnd::viewBox() const
<br>+{
<br>+ return m_view;
<br>+}
<br>+
<br>+QString KoLineEnd::transform() const
<br>+{
<br>+ return m_transform;
<br>+}
<br>+
<br>+void KoLineEnd::setTransform(const QString &transform)
<br>+{
<br>+ m_transform = transform;
<br>+}
<br>+
<br>+void KoLineEnd::paint(QPainter &painter, const KoPathPoint* point)
<br>+{
<br>+ QPointF vector;
<br>+ QMatrix matrix;
<br>+ vector = KoLineEnd::computeAngle(point);
<br>+ vector.setY(vector.y()*-1);
<br>+ QLineF line(QPointF(0,0), vector);
<br>+ int angle = ((int)line.angle()+90)%360;
<br>+ float x = point->point().x()-m_size;
<br>+ float y = point->point().y()-m_size;
<br>+ QRectF rect(QPointF(x, y), QSizeF(m_size, m_size));
<br>+ m_transform.clear();
<br>+ QStringList viewBoxValues = m_view.split(" ");
<br>+
<br>+ if(viewBoxValues.count() == 4){
<br>+ int centerX = viewBoxValues.at(2).toInt()/2;
<br>+ int centerY = viewBoxValues.at(3).toInt()/2;
<br>+ m_transform.append("translate("+QString::number(centerX)+", "+QString::number(centerY)+"), rotate("+QString::number(angle)+", "+QString::number(centerX)+", "+QString::number(centerY)+")");
<br>+ }
<br>+
<br>+ painter.setBackgroundMode(Qt::OpaqueMode);
<br>+ painter.setBackground(QBrush(Qt::red));
<br>+ QSvgRenderer endLineRenderer;
<br>+ QSize endLineSize = QSize(qRound(rect.width()), qRound(rect.height()));
<br>+ endLineRenderer.load(generateSVG(endLineSize));
<br>+ endLineRenderer.render(&painter, rect);
<br>+
<br>+}
<br>+
<br>+QPointF KoLineEnd::computeAngle(const KoPathPoint* point)
<br>+{
<br>+ KoPathShape * path = point->parent();
<br>+ KoPathPointIndex index = path->pathPointIndex(point);
<br>+
<br>+ /// check if it is a start point
<br>+ if (point->properties() & KoPathPoint::StartSubpath) {
<br>+ if (point->activeControlPoint2()) {
<br>+ return point->point() - point->controlPoint2();
<br>+ } else {
<br>+ KoPathPoint * next = path->pointByIndex(KoPathPointIndex(index.first, index.second + 1));
<br>+ if (! next)
<br>+ return QPointF();
<br>+ else if (next->activeControlPoint1())
<br>+ return point->point() - next->controlPoint1();
<br>+ else
<br>+ return point->point() - next->point();
<br>+ }
<br>+ } else {
<br>+ if (point->activeControlPoint1()) {
<br>+ return point->point() - point->controlPoint1();
<br>+ } else {
<br>+ KoPathPoint * prev = path->pointByIndex(KoPathPointIndex(index.first, index.second - 1));
<br>+ if (! prev)
<br>+ return QPointF();
<br>+ else if (prev->activeControlPoint2())
<br>+ return point->point() - prev->controlPoint2();
<br>+ else
<br>+ return point->point() - prev->point();
<br>+ }
<br>+ }
<br>+}
<br>+#include "KoLineEnd.moc"
<br>+
<br><br />_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26451858&i=16" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26451111
End lines patch
2009-11-20T14:13:35Z
2009-11-20T14:13:35Z
Jérémy Lugagne
Hi,<br><br>I made a patch to add shapes and the end of lines.<br><br>If you have a question, do not hesitate and ask me here or on IRC (XwZ).<br><br>I send it here beacause i can't send it on the reviewboard (i don't know why).<br>
<br>Regards,<br><br>Jérémy.<br>
<br />_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26451111&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26444368
Re: Review Request: Go to a specified page in KWord
2009-11-20T06:41:46Z
2009-11-20T06:41:46Z
Bugzilla from zander@kde.org
<br>-----------------------------------------------------------
<br>This is an automatically generated e-mail. To reply, visit:
<br><a href="http://reviewboard.kde.org/r/2230/#review3183" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2230/#review3183</a><br>-----------------------------------------------------------
<br><br><br><br>trunk/koffice/kword/part/KWView.cpp
<br><<a href="http://reviewboard.kde.org/r/2230/#comment2538" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2230/#comment2538</a>>
<br><br> Please use m_gui->canvasController() instead
<br><br><br><br>trunk/koffice/kword/part/KWView.cpp
<br><<a href="http://reviewboard.kde.org/r/2230/#comment2540" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2230/#comment2540</a>>
<br><br> Not sure if we want to use QScrollBar, can you try to use KoCanvasController::setScrollBarValue() instead?
<br><br><br><br>trunk/koffice/kword/part/KWView.cpp
<br><<a href="http://reviewboard.kde.org/r/2230/#comment2539" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2230/#comment2539</a>>
<br><br> You should not use the zoomHandler bug instead use the viewmode.
<br> See KWCanvas::viewMode()
<br><br><br>- Thomas
<br><br><br>On 2009-11-20 14:10:38, Mani Chandrasekar wrote:
<div class='shrinkable-quote'><br>>
<br>> -----------------------------------------------------------
<br>> This is an automatically generated e-mail. To reply, visit:
<br>> <a href="http://reviewboard.kde.org/r/2230/" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2230/</a><br>> -----------------------------------------------------------
<br>>
<br>> (Updated 2009-11-20 14:10:38)
<br>>
<br>>
<br>> Review request for KOffice.
<br>>
<br>>
<br>> Summary
<br>> -------
<br>>
<br>> Patch would provide functionality like go to specified page or prev/next page for KWord
<br>>
<br>>
<br>> Diffs
<br>> -----
<br>>
<br>> trunk/koffice/kword/part/KWView.h 1051253
<br>> trunk/koffice/kword/part/KWView.cpp 1051253
<br>>
<br>> Diff: <a href="http://reviewboard.kde.org/r/2230/diff" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2230/diff</a><br>>
<br>>
<br>> Testing
<br>> -------
<br>>
<br>> Done testing with different document & various zoom levels
<br>>
<br>>
<br>> Thanks,
<br>>
<br>> Mani
<br>>
<br>>
</div><br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26444368&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26443923
Re: Review Request: A graph walker - base class for merging
2009-11-20T06:13:24Z
2009-11-20T06:13:24Z
Bugzilla from dimula73@gmail.com
<br>-----------------------------------------------------------
<br>This is an automatically generated e-mail. To reply, visit:
<br><a href="http://reviewboard.kde.org/r/2229/" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2229/</a><br>-----------------------------------------------------------
<br><br>(Updated 2009-11-20 14:13:23.954858)
<br><br><br>Review request for KOffice.
<br><br><br>Summary (updated)
<br>-------
<br><br>Added KisGraphWalker.
<br><br>It walks through the graph and visits every node in a bottom-up way. It provides essential options for caching projection and for collecting node's properties in a reversed (top-down) way. It will be used in calculation of need/change rects for nodes.
<br><br>Why it is needed?
<br>1) It allows you to walk through the graph in a bottom-up and top-down way in the same time. This is like KisUpdateStrategy used to work, but... (see 2) )
<br>2) It doesn't use any node's internal structures or static members like KisUpdateStrategy and KisGroupLayer::updateProjectiopn used to use. It means that several "walkers" can work simultaneously on a single image.
<br>At the moment we can't do this because KisGroupLayer::updateProjection uses filthyNode member.
<br><br>What it is supposed to do?
<br>1) updater should know which rect will be changed during update and which one will be needed. It will help him to parallelize merge operations.
<br>2) "changeRect" is collected on a way forward
<br>3) "needRect" is collected on a way back (see KisLayer::applyMasks)
<br>4) merges will be parallelized with the help of special walkers too
<br><br><br>Diffs
<br>-----
<br><br> trunk/koffice/krita/image/CMakeLists.txt 1045641
<br> trunk/koffice/krita/image/kis_graph_walker.h PRE-CREATION
<br> trunk/koffice/krita/image/kis_graph_walker.cc PRE-CREATION
<br> trunk/koffice/krita/image/tests/CMakeLists.txt 1045627
<br> trunk/koffice/krita/image/tests/kis_graph_walker_test.h PRE-CREATION
<br> trunk/koffice/krita/image/tests/kis_graph_walker_test.cpp PRE-CREATION
<br><br>Diff: <a href="http://reviewboard.kde.org/r/2229/diff" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2229/diff</a><br><br><br>Testing
<br>-------
<br><br><br>Thanks,
<br><br>Dmitry
<br><br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26443923&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26443888
Review Request: Go to a specified page in KWord
2009-11-20T06:10:39Z
2009-11-20T06:10:39Z
prasad_ncm
<br>-----------------------------------------------------------
<br>This is an automatically generated e-mail. To reply, visit:
<br><a href="http://reviewboard.kde.org/r/2230/" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2230/</a><br>-----------------------------------------------------------
<br><br>Review request for KOffice.
<br><br><br>Summary
<br>-------
<br><br>Patch would provide functionality like go to specified page or prev/next page for KWord
<br><br><br>Diffs
<br>-----
<br><br> trunk/koffice/kword/part/KWView.h 1051253
<br> trunk/koffice/kword/part/KWView.cpp 1051253
<br><br>Diff: <a href="http://reviewboard.kde.org/r/2230/diff" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2230/diff</a><br><br><br>Testing
<br>-------
<br><br>Done testing with different document & various zoom levels
<br><br><br>Thanks,
<br><br>Mani
<br><br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26443888&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26443435
Re: Review Request: A graph walker - base class for merging
2009-11-20T05:44:02Z
2009-11-20T05:44:02Z
Bugzilla from boud@valdyas.org
<br>-----------------------------------------------------------
<br>This is an automatically generated e-mail. To reply, visit:
<br><a href="http://reviewboard.kde.org/r/2229/#review3182" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2229/#review3182</a><br>-----------------------------------------------------------
<br><br><br>It's okay, I guess, except for some niggles:
<br><br>s/crowling/crawling
<br><br>The method name greetOnBackwardWay doesn't seem correct English: greetOnWayBack would perhaps be better, but I might have misunderstood its functios
<br><br>I'd like some docs, including the purpose of the class in the class apidox, also some discussion on how this approach works in a multi-threaded environment.
<br><br><br>- Boudewijn
<br><br><br>On 2009-11-20 13:05:37, Dmitry Kazakov wrote:
<div class='shrinkable-quote'><br>>
<br>> -----------------------------------------------------------
<br>> This is an automatically generated e-mail. To reply, visit:
<br>> <a href="http://reviewboard.kde.org/r/2229/" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2229/</a><br>> -----------------------------------------------------------
<br>>
<br>> (Updated 2009-11-20 13:05:37)
<br>>
<br>>
<br>> Review request for KOffice.
<br>>
<br>>
<br>> Summary
<br>> -------
<br>>
<br>> Added KisGraphWalker.
<br>>
<br>> It walks through the graph and visits every node in a bottom-up way. It provides essential options for caching projection and for collecting node's properties in a reversed (top-down) way. It will be used in calculation of need/change rects for nodes.
<br>>
<br>>
<br>> Diffs
<br>> -----
<br>>
<br>> trunk/koffice/krita/image/CMakeLists.txt 1045641
<br>> trunk/koffice/krita/image/kis_graph_walker.h PRE-CREATION
<br>> trunk/koffice/krita/image/kis_graph_walker.cc PRE-CREATION
<br>> trunk/koffice/krita/image/tests/CMakeLists.txt 1045627
<br>> trunk/koffice/krita/image/tests/kis_graph_walker_test.h PRE-CREATION
<br>> trunk/koffice/krita/image/tests/kis_graph_walker_test.cpp PRE-CREATION
<br>>
<br>> Diff: <a href="http://reviewboard.kde.org/r/2229/diff" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2229/diff</a><br>>
<br>>
<br>> Testing
<br>> -------
<br>>
<br>>
<br>> Thanks,
<br>>
<br>> Dmitry
<br>>
<br>>
</div><br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26443435&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26443429
Re: Review Request: A graph walker - base class for merging
2009-11-20T05:43:54Z
2009-11-20T05:43:54Z
Bugzilla from boud@valdyas.org
<br>-----------------------------------------------------------
<br>This is an automatically generated e-mail. To reply, visit:
<br><a href="http://reviewboard.kde.org/r/2229/#review3181" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2229/#review3181</a><br>-----------------------------------------------------------
<br><br><br>It's okay, I guess, except for some niggles:
<br><br>s/crowling/crawling
<br><br>The method name greetOnBackwardWay doesn't seem correct English: greetOnWayBack would perhaps be better, but I might have misunderstood its functios
<br><br>I'd like some docs, including the purpose of the class in the class apidox, also some discussion on how this approach works in a multi-threaded environment.
<br><br><br>- Boudewijn
<br><br><br>On 2009-11-20 13:05:37, Dmitry Kazakov wrote:
<div class='shrinkable-quote'><br>>
<br>> -----------------------------------------------------------
<br>> This is an automatically generated e-mail. To reply, visit:
<br>> <a href="http://reviewboard.kde.org/r/2229/" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2229/</a><br>> -----------------------------------------------------------
<br>>
<br>> (Updated 2009-11-20 13:05:37)
<br>>
<br>>
<br>> Review request for KOffice.
<br>>
<br>>
<br>> Summary
<br>> -------
<br>>
<br>> Added KisGraphWalker.
<br>>
<br>> It walks through the graph and visits every node in a bottom-up way. It provides essential options for caching projection and for collecting node's properties in a reversed (top-down) way. It will be used in calculation of need/change rects for nodes.
<br>>
<br>>
<br>> Diffs
<br>> -----
<br>>
<br>> trunk/koffice/krita/image/CMakeLists.txt 1045641
<br>> trunk/koffice/krita/image/kis_graph_walker.h PRE-CREATION
<br>> trunk/koffice/krita/image/kis_graph_walker.cc PRE-CREATION
<br>> trunk/koffice/krita/image/tests/CMakeLists.txt 1045627
<br>> trunk/koffice/krita/image/tests/kis_graph_walker_test.h PRE-CREATION
<br>> trunk/koffice/krita/image/tests/kis_graph_walker_test.cpp PRE-CREATION
<br>>
<br>> Diff: <a href="http://reviewboard.kde.org/r/2229/diff" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2229/diff</a><br>>
<br>>
<br>> Testing
<br>> -------
<br>>
<br>>
<br>> Thanks,
<br>>
<br>> Dmitry
<br>>
<br>>
</div><br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26443429&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26443434
Re: Review Request: A graph walker - base class for merging
2009-11-20T05:43:48Z
2009-11-20T05:43:48Z
Bugzilla from boud@valdyas.org
<br>-----------------------------------------------------------
<br>This is an automatically generated e-mail. To reply, visit:
<br><a href="http://reviewboard.kde.org/r/2229/#review3180" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2229/#review3180</a><br>-----------------------------------------------------------
<br><br><br>It's okay, I guess, except for some niggles:
<br><br>s/crowling/crawling
<br><br>The method name greetOnBackwardWay doesn't seem correct English: greetOnWayBack would perhaps be better, but I might have misunderstood its functios
<br><br>I'd like some docs, including the purpose of the class in the class apidox, also some discussion on how this approach works in a multi-threaded environment.
<br><br><br>- Boudewijn
<br><br><br>On 2009-11-20 13:05:37, Dmitry Kazakov wrote:
<div class='shrinkable-quote'><br>>
<br>> -----------------------------------------------------------
<br>> This is an automatically generated e-mail. To reply, visit:
<br>> <a href="http://reviewboard.kde.org/r/2229/" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2229/</a><br>> -----------------------------------------------------------
<br>>
<br>> (Updated 2009-11-20 13:05:37)
<br>>
<br>>
<br>> Review request for KOffice.
<br>>
<br>>
<br>> Summary
<br>> -------
<br>>
<br>> Added KisGraphWalker.
<br>>
<br>> It walks through the graph and visits every node in a bottom-up way. It provides essential options for caching projection and for collecting node's properties in a reversed (top-down) way. It will be used in calculation of need/change rects for nodes.
<br>>
<br>>
<br>> Diffs
<br>> -----
<br>>
<br>> trunk/koffice/krita/image/CMakeLists.txt 1045641
<br>> trunk/koffice/krita/image/kis_graph_walker.h PRE-CREATION
<br>> trunk/koffice/krita/image/kis_graph_walker.cc PRE-CREATION
<br>> trunk/koffice/krita/image/tests/CMakeLists.txt 1045627
<br>> trunk/koffice/krita/image/tests/kis_graph_walker_test.h PRE-CREATION
<br>> trunk/koffice/krita/image/tests/kis_graph_walker_test.cpp PRE-CREATION
<br>>
<br>> Diff: <a href="http://reviewboard.kde.org/r/2229/diff" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2229/diff</a><br>>
<br>>
<br>> Testing
<br>> -------
<br>>
<br>>
<br>> Thanks,
<br>>
<br>> Dmitry
<br>>
<br>>
</div><br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26443434&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26443398
Re: Review Request: A graph walker - base class for merging
2009-11-20T05:40:06Z
2009-11-20T05:40:06Z
Bugzilla from lukast.dev@gmail.com
Hi,
<br><br>> It walks through the graph and visits every node in a bottom-up way. It
<br>> provides essential options for caching projection and for collecting
<br>> node's properties in a reversed (top-down) way. It will be used in
<br>> calculation of need/change rects for nodes.
<br><br>can you explain what functionality it brings or which bug it fixes? It is out
<br>of my field, so I don't get this first explanation...
<br><br>I would like to do some testing of it first and then review.
<br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26443398&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26443104
Re: koffice/libs/flake/commands
2009-11-20T05:16:08Z
2009-11-20T05:16:08Z
Bugzilla from boud@valdyas.org
On Thursday 19 November 2009, Sven Langkamp wrote:
<br>> SVN commit 1051493 by langkamp:
<br>>
<br>> apply Thomas patch to fix undo/redo after reparenting
<br>> BUG:212209
<br><br><br>I think this should be backported. Any objections?
<br><div class='shrinkable-quote'><br>>
<br>>
<br>> M +1 -0 KoShapeCreateCommand.cpp
<br>>
<br>>
<br>> --- trunk/koffice/libs/flake/commands/KoShapeCreateCommand.cpp
<br>> #1051492:1051493 @@ -66,6 +66,7 @@
<br>> d->shapeParent->addChild(d->shape);
<br>> // the parent has to be there when it is added to the
<br>> KoShapeControllerBase d->controller->addShape(d->shape);
<br>> + d->shapeParent = d->shape->parent(); // update parent if the
<br>> 'addShape' changed it d->deleteShape = false;
<br>> }
<br>>
</div><br><br>--
<br>Boudewijn Rempt | <a href="http://www.valdyas.org" target="_top" rel="nofollow">http://www.valdyas.org</a><br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26443104&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26442984
Review Request: A graph walker - base class for merging
2009-11-20T05:05:38Z
2009-11-20T05:05:38Z
Bugzilla from dimula73@gmail.com
<br>-----------------------------------------------------------
<br>This is an automatically generated e-mail. To reply, visit:
<br><a href="http://reviewboard.kde.org/r/2229/" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2229/</a><br>-----------------------------------------------------------
<br><br>Review request for KOffice.
<br><br><br>Summary
<br>-------
<br><br>Added KisGraphWalker.
<br><br>It walks through the graph and visits every node in a bottom-up way. It provides essential options for caching projection and for collecting node's properties in a reversed (top-down) way. It will be used in calculation of need/change rects for nodes.
<br><br><br>Diffs
<br>-----
<br><br> trunk/koffice/krita/image/CMakeLists.txt 1045641
<br> trunk/koffice/krita/image/kis_graph_walker.h PRE-CREATION
<br> trunk/koffice/krita/image/kis_graph_walker.cc PRE-CREATION
<br> trunk/koffice/krita/image/tests/CMakeLists.txt 1045627
<br> trunk/koffice/krita/image/tests/kis_graph_walker_test.h PRE-CREATION
<br> trunk/koffice/krita/image/tests/kis_graph_walker_test.cpp PRE-CREATION
<br><br>Diff: <a href="http://reviewboard.kde.org/r/2229/diff" target="_top" rel="nofollow">http://reviewboard.kde.org/r/2229/diff</a><br><br><br>Testing
<br>-------
<br><br><br>Thanks,
<br><br>Dmitry
<br><br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26442984&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26440380
xml:id preservation and RDF metadata support for ODF
2009-11-20T00:27:50Z
2009-11-20T00:27:50Z
monkeyiq
Abstract:
<br> The non-RDF question is about preserving xml:id on ODF across
<br>load/save cycles.
<br><br>Hi,
<br> I'm adding support for loading and saving RDF metadata in ODF
<br>documents for kword. Of course, other ODF like documents like
<br>spreadsheets which support RDF can also be added to the KOffice suite,
<br>I've tried to make what I've done generic so it can be expanded as such.
<br>I'm focusing on kword right now.
<br><br> I've mostly got external manifest.rdf based metadata working, but I'm
<br>having a few problems with so called inline RDF. From the ODF
<br>specification, inline RDF follows a slightly askew subset of RDFa. This
<br>means that one can have xhtml:about, xhtml:property and xhtml:content
<br>associated with an XML node and these are used to generate an RDF triple
<br>during loading. I mostly have loading of such metadata working, with a
<br>few little corner cases to address.
<br><br> The two problems I have found is that KOffice discards xml:id
<br>attributes during load and that I need to track the node that inline RDF
<br>gets generated from in order to store it back properly on document save.
<br>These problems are somewhat intermixed because if xml:id's can be saved
<br>for input documents, then saving the xhtml:about etc could also be done
<br>in the same code.
<br><br> I thought I'd ask advise from the list because adding xml:id support
<br>seems like a fairly intrusive change, and those currently more familiar
<br>with the codebase might have some ideas as to how to best support it.
<br>The xhtml:about attribute can appear on many XML elements including
<br>text:p.
<br><br>From my investigations, the pertinent code is in the class KoTextLoader.
<br>Looking at KoTextLoader::loadParagraph() if there is a style applied
<br>then KoParagraphStyle is used, then loadSpan() is called and, if the
<br>text:p has no style and only a text child node cursor.insertText() is
<br>called. This means there are many choices for where to store an xml:id
<br>for the text:p, but none of them straightforward.
<br><br>Looking at other elements, it seems that KoInline, KoShape for example
<br>would also need some augmentation to store an xml:id if one was supplied
<br>in the input ODF file so that the xml:id can be preserved on save.
<br><br>I look forward to any thoughts or preferences on how the koffice hackers
<br>would like to see the xml:id support added...
<br><br><br /> <br />_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26440380&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><div class="small"><br/><img src="http://old.nabble.com/images/icon_attachment.gif" > <strong>signature.asc</strong> (204 bytes) <a href="http://old.nabble.com/attachment/26440380/0/signature.asc" target="_top">Download Attachment</a></div><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26425343
Re: koffice/libs/flake
2009-11-19T04:26:12Z
2009-11-19T04:26:12Z
Thorsten Zachmann
On Thursday 19 November 2009 13:17:34 Thorsten Zachmann wrote:
<br><br>> > Notice also that the unit test seems to fail with an assert;
<br>> > <a href="http://www.koffice.org/testresults/status.html" target="_top" rel="nofollow">http://www.koffice.org/testresults/status.html</a><br>>
<br>> Strange. Works on my machine without problems.
<br><br>Fixed by committing the missing file.
<br><br>Thorsten
<br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26425343&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>
tag:old.nabble.com,2006:post-26425258
Re: koffice/libs/flake
2009-11-19T04:17:34Z
2009-11-19T04:17:34Z
Thorsten Zachmann
On Thursday 19 November 2009 13:01:05 Thomas Zander wrote:
<br>> On Thursday 19. November 2009 06.56.02 Thorsten Zachmann wrote:
<br>> > Can this be backported?
<br>>
<br>> Maybe its a good idea to first fix the issues we identified in this thread
<br>> before backporting to a stable branch :)
<br><br>And what should the issues be?
<br><br>> Notice also that the unit test seems to fail with an assert;
<br>> <a href="http://www.koffice.org/testresults/status.html" target="_top" rel="nofollow">http://www.koffice.org/testresults/status.html</a><br>>
<br>Strange. Works on my machine without problems.
<br><br>Thorsten
<br>_______________________________________________
<br>koffice-devel mailing list
<br><a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26425258&i=0" target="_top" rel="nofollow">koffice-devel@...</a>
<br><a href="https://mail.kde.org/mailman/listinfo/koffice-devel" target="_top" rel="nofollow">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><p>From forum: <a href="http://old.nabble.com/koffice-devel-f6403.html" embed="fixTarget[6403]" target="_top" >koffice-devel</a></p>