koffice/karbon/plugins/filtereffects

View: New views
8 Messages — Rating Filter:   Alert me  

koffice/karbon/plugins/filtereffects

by Thorsten Zachmann :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

SVN commit 1044567 by zachmann:

o make compile with kde < 4.3.0

@koffice-devel: At the moment our minmum required kde version is 4.1. I
don't know if 4.1 still works. 4.2 does work again with this commit. Do
we want to keep 4.1 as minumum version or do we want to increase this?

CCMAIL: koffice-devel@...


 M  +11 -0     ComponentTransferEffectConfigWidget.cpp  


--- trunk/koffice/karbon/plugins/filtereffects/ComponentTransferEffectConfigWidget.cpp #1044566:1044567
@@ -20,6 +20,7 @@
 #include "ComponentTransferEffectConfigWidget.h"
 #include "KoFilterEffect.h"
 
+#include <kdeversion.h>
 #include <KNumInput>
 #include <KComboBox>
 #include <KLineEdit>
@@ -96,11 +97,15 @@
     QGridLayout * linearLayout = new QGridLayout(linearWidget);
     linearLayout->addWidget(new QLabel(i18n("Slope"), linearWidget), 0, 0);
     m_slope = new KDoubleNumInput(linearWidget);
+#if KDE_IS_VERSION( 4,3,0 )
     m_slope->setSingleStep(ValueStep);
+#endif
     linearLayout->addWidget(m_slope, 0, 1);
     linearLayout->addWidget(new QLabel(i18n("Intercept")), 1, 0);
     m_intercept = new KDoubleNumInput(linearWidget);
+#if KDE_IS_VERSION( 4,3,0 )
     m_intercept->setSingleStep(ValueStep);
+#endif
     linearLayout->addWidget(m_intercept, 1, 1);
     linearLayout->addItem(new QSpacerItem(0, 1, QSizePolicy::Minimum, QSizePolicy::MinimumExpanding), 2, 0);
     linearLayout->setContentsMargins(0,0,0,0);
@@ -111,15 +116,21 @@
     QGridLayout * gammaLayout = new QGridLayout(gammaWidget);
     gammaLayout->addWidget(new QLabel(i18n("Amplitude"), gammaWidget), 0, 0);
     m_amplitude = new KDoubleNumInput(gammaWidget);
+#if KDE_IS_VERSION( 4,3,0 )
     m_amplitude->setSingleStep(ValueStep);
+#endif
     gammaLayout->addWidget(m_amplitude, 0, 1);
     gammaLayout->addWidget(new QLabel(i18n("Exponent"), gammaWidget), 1, 0);
     m_exponent = new KDoubleNumInput(gammaWidget);
+#if KDE_IS_VERSION( 4,3,0 )
     m_exponent->setSingleStep(ValueStep);
+#endif
     gammaLayout->addWidget(m_exponent, 1, 1);
     gammaLayout->addWidget(new QLabel(i18n("Offset"), gammaWidget), 2, 0);
     m_offset = new KDoubleNumInput(gammaWidget);
+#if KDE_IS_VERSION( 4,3,0 )
     m_offset->setSingleStep(ValueStep);
+#endif
     gammaLayout->addWidget(m_offset, 2, 1);
     gammaLayout->addItem(new QSpacerItem(0, 1, QSizePolicy::Minimum, QSizePolicy::MinimumExpanding), 3, 0);    
     gammaLayout->setContentsMargins(0,0,0,0);
_______________________________________________
koffice-devel mailing list
koffice-devel@...
https://mail.kde.org/mailman/listinfo/koffice-devel

Re: koffice/karbon/plugins/filtereffects

by Bugzilla from boud@valdyas.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wednesday 04 November 2009, Thorsten Zachmann wrote:
> SVN commit 1044567 by zachmann:
>
> o make compile with kde < 4.3.0
>
> @koffice-devel: At the moment our minmum required kde version is 4.1. I
> don't know if 4.1 still works. 4.2 does work again with this commit. Do
> we want to keep 4.1 as minumum version or do we want to increase this?
>

I am all for increasing the minimum to 4.3.

--
Boudewijn Rempt | http://www.valdyas.org
_______________________________________________
koffice-devel mailing list
koffice-devel@...
https://mail.kde.org/mailman/listinfo/koffice-devel

Re: koffice/karbon/plugins/filtereffects

by Cyrille Berger :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wednesday 04 November 2009, Thorsten Zachmann wrote:
> SVN commit 1044567 by zachmann:
>
> o make compile with kde < 4.3.0
>
> @koffice-devel: At the moment our minmum required kde version is 4.1. I
> don't know if 4.1 still works. 4.2 does work again with this commit. Do
> we want to keep 4.1 as minumum version or do we want to increase this?
I think it is a lie from us to pretend that 4.1 works, so unless someone wants
to test compilation/run with 4.1, then we should update the minimum version to
at least 4.2

--
Cyrille Berger
_______________________________________________
koffice-devel mailing list
koffice-devel@...
https://mail.kde.org/mailman/listinfo/koffice-devel

Re: koffice/karbon/plugins/filtereffects

by Jonathan Schmidt-Dominé - Developer :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


> I think it is a lie from us to pretend that 4.1 works, so unless someone
>  wants to test compilation/run with 4.1, then we should update the minimum
>  version to at least 4.2
Who wants to use KDE 4.1? Thos who use KDE 4 use at least 4.2... (I think).

------------------------

Automatisch eingefügte Signatur:
Es lebe die Freiheit!
Stoppt den Gebrauch proprietärer Software!
Operating System: GNU/Linux
Kernel: Linux 2.6.31-ARCH
Distribution: Arch Linux
Qt: 4.6.0
KDE: 4.3.73 (KDE 4.3.73 (KDE 4.4 >= 20091026))
KMail: 1.12.90
http://gnu.org/
http://kde.org/
http://windows7sins.org/

_______________________________________________
koffice-devel mailing list
koffice-devel@...
https://mail.kde.org/mailman/listinfo/koffice-devel

Re: koffice/karbon/plugins/filtereffects

by Bugzilla from lukast.dev@gmail.com :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wednesday 04 November 2009 08:06:29 Boudewijn Rempt wrote:

> On Wednesday 04 November 2009, Thorsten Zachmann wrote:
> > SVN commit 1044567 by zachmann:
> >
> > o make compile with kde < 4.3.0
> >
> > @koffice-devel: At the moment our minmum required kde version is 4.1. I
> > don't know if 4.1 still works. 4.2 does work again with this commit. Do
> > we want to keep 4.1 as minumum version or do we want to increase this?
>
> I am all for increasing the minimum to 4.3.
>

I'm with you too. KDE 4.3 for KOffice 2.2 please!
_______________________________________________
koffice-devel mailing list
koffice-devel@...
https://mail.kde.org/mailman/listinfo/koffice-devel

Re: koffice/karbon/plugins/filtereffects

by Cyrille Berger :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wednesday 04 November 2009, Boudewijn Rempt wrote:

> On Wednesday 04 November 2009, Thorsten Zachmann wrote:
> > SVN commit 1044567 by zachmann:
> >
> > o make compile with kde < 4.3.0
> >
> > @koffice-devel: At the moment our minmum required kde version is 4.1. I
> > don't know if 4.1 still works. 4.2 does work again with this commit. Do
> > we want to keep 4.1 as minumum version or do we want to increase this?
>
> I am all for increasing the minimum to 4.3.
On the other hand, we might wait for 4.4 (I suppose there are still users of
4.2). In the case koffice 2.2 need Qt 4.6 (which I heard rumors that it might be
the case), the only KDE release that is working with 4.6 would be 4.4. So we
could jump both requirement at the same time.

--
Cyrille Berger
_______________________________________________
koffice-devel mailing list
koffice-devel@...
https://mail.kde.org/mailman/listinfo/koffice-devel

Re: koffice/karbon/plugins/filtereffects

by Bugzilla from boud@valdyas.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wednesday 04 November 2009, Cyrille Berger wrote:
 
> On the other hand, we might wait for 4.4 (I suppose there are still users
>  of 4.2). In the case koffice 2.2 need Qt 4.6 (which I heard rumors that it
>  might be the case), the only KDE release that is working with 4.6 would be
>  4.4. So we could jump both requirement at the same time.

I don't care much one way or another. It's just that I'm not sure that we've
actually got people compiling against 4.2 -- and 4.3 is so much better that I
suspect pretty much everyone will have upgraded by now :-).

--
Boudewijn Rempt | http://www.valdyas.org
_______________________________________________
koffice-devel mailing list
koffice-devel@...
https://mail.kde.org/mailman/listinfo/koffice-devel

Re: koffice/karbon/plugins/filtereffects

by Bugzilla from zander@kde.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wednesday 4. November 2009 20.02.11 Boudewijn Rempt wrote:
> I don't care much one way or another. It's just that I'm not sure that
> we've actually got people compiling against 4.2 -- and 4.3 is so much
> better that I suspect pretty much everyone will have upgraded by now :-).

I hope to do so soon. When I have a little time to download a new ISO and
reinstall.
Will take me at least a couple of weeks still, though.
--
Thomas Zander
_______________________________________________
koffice-devel mailing list
koffice-devel@...
https://mail.kde.org/mailman/listinfo/koffice-devel