kte autobrace
|
View:
New views
14 Messages
—
Rating Filter:
Alert me
|
 |
kte autobrace
by Bugzilla from dhdev@gmx.de
::
Rate this Message:
|
|
|
Re: kte autobrace
by Bugzilla from mail@milianw.de
::
Rate this Message:
On Monday 05 October 2009 21:21:32 Dominik Haumann wrote:
> Hi, > > at http://techbase.kde.org/Talk:Schedules/KDE4/4.4_Feature_Plan someone > wrote: > Can you add this in kate? > svn://anonsvn.kde.org/home/kde/trunk/playground/devtools/kte_autobrace > > Anyone interested and volunteers to have a look at it ? I use that plugin all the time, it's by far better than what Kate/KWrite gives you by default in it's options (the dump "autocomplete braces" option). So I think: Definitly import it to kdesdk/kate or even kdelibs. What kind of volunteer work do you need? (OT/PS: any news on the highlighter? I'm still waiting since last wednesday :P) -- Milian Wolff mail@... http://milianw.de _______________________________________________ KWrite-Devel mailing list KWrite-Devel@... https://mail.kde.org/mailman/listinfo/kwrite-devel |
|
|
Re: kte autobrace
by Bugzilla from dhdev@gmx.de
::
Rate this Message:
|
|
|
Re: kte autobrace
by Bugzilla from mail@milianw.de
::
Rate this Message:
On Tuesday 06 October 2009 20:03:18 Dominik Haumann wrote:
> On Tuesday 06 October 2009, Milian Wolff wrote: > > On Monday 05 October 2009 21:21:32 Dominik Haumann wrote: > > > Hi, > > > > > > at http://techbase.kde.org/Talk:Schedules/KDE4/4.4_Feature_Plan someone > > > wrote: > > > Can you add this in kate? > > > > > > svn://anonsvn.kde.org/home/kde/trunk/playground/devtools/kte_autobrace > > > > > > Anyone interested and volunteers to have a look at it ? > > > > I use that plugin all the time, it's by far better than what Kate/KWrite > > gives you by default in it's options (the dump "autocomplete braces" > > option). > > > > So I think: Definitly import it to kdesdk/kate or even kdelibs. > > kdesdk usually only contains Kate and Kate app plugins, i.e. no ktexteditor > plugins. I guess kte_autobrace is a ktexteditor plugin? > > What kind of volunteer work do you need? > > simply someone who does the work: review + commit to trunk. I'll take a look. -- Milian Wolff mail@... http://milianw.de _______________________________________________ KWrite-Devel mailing list KWrite-Devel@... https://mail.kde.org/mailman/listinfo/kwrite-devel |
|
|
Re: kte autobrace
by Bugzilla from dhdev@gmx.de
::
Rate this Message:
|
|
|
Re: kte autobrace
by Bugzilla from mail@milianw.de
::
Rate this Message:
On Wednesday 07 October 2009 19:06:25 Dominik Haumann wrote:
> On Tuesday 06 October 2009, Milian Wolff wrote: > > On Tuesday 06 October 2009 20:03:18 Dominik Haumann wrote: > > > On Tuesday 06 October 2009, Milian Wolff wrote: > > > > On Monday 05 October 2009 21:21:32 Dominik Haumann wrote: > > > > > Hi, > > > > > > > > > > at http://techbase.kde.org/Talk:Schedules/KDE4/4.4_Feature_Plan > > > > > someone wrote: > > > > > Can you add this in kate? > > > > > > > > > > svn://anonsvn.kde.org/home/kde/trunk/playground/devtools/kte_autobr > > > > >ace > > > > > > > > > > Anyone interested and volunteers to have a look at it ? > > > > > > > > I use that plugin all the time, it's by far better than what > > > > Kate/KWrite gives you by default in it's options (the dump > > > > "autocomplete braces" option). > > > > > > > > So I think: Definitly import it to kdesdk/kate or even kdelibs. > > > > > > kdesdk usually only contains Kate and Kate app plugins, i.e. no > > > ktexteditor plugins. I guess kte_autobrace is a ktexteditor plugin? > > > > True, where are ktexteditor plugins supposed to live? Somewhere in > > kdelibs? > > yes: kdelibs/kate/plugins/ > > > > > What kind of volunteer work do you need? > > > > > > simply someone who does the work: review + commit to trunk. > > > > I'll take a look. - very clean - well documented - follows the KDELibs style TODO in my eyes: - clear license/copyright, who wrote it? The header is jpetso, the implementation is ereslibre? is that really correct? - warn when the user has auto-brackets enabled, see also: http://reviewboard.kde.org/r/1882/ Having auto-brackets enabled does not work together with this plugin. I'd like to see a dialog explaining this issue and also offering to un-set auto-bracket. Of course don't forget to connect to changes in the kate configuration when the user tries to re-enable auto-bracket. - make the plugin more intelligent. I know that it currently limits its scope for performance reasons, but I'm often hit by the following issue: existing code: namespace foobar { class someclass { }; } Now I frequently try to add something to the namespace, above the class. I place the cursor after foobar { and hit return. The plugin will insert another brace => fail. I doubt making the code more intelligent, maybe by using a simple parser instead of regular expressions, would introduce such a big performance penalty. Even if my feature wish is not incorporated, I'd still say: Lets ship this plugin with kdelibs in 4.4! OT: I'd like to see auto brace support in Kate improve even more, if required not as a plugin, but directly in source. I'd like to have something like the current auto-bracket, but with overwriting support, i.e.: I press '(', get '(|)', with '|' == cursor position. If I now write ')' I'd want '()|' instead of '()|)'. This would make this plugin redundant. What should be done as well though is probably the following: '(' => '(|') => hit return, get => '(\n |\n)' i.e. return not only inserts a single newline, but inserts a newline, indents the next line (already done via indent scripts), but the following brace/bracket/parens should be put on the line _after_ that. -- Milian Wolff mail@... http://milianw.de _______________________________________________ KWrite-Devel mailing list KWrite-Devel@... https://mail.kde.org/mailman/listinfo/kwrite-devel |
|
|
Re: kte autobrace
by Bugzilla from jpetso@gmx.at
::
Rate this Message:
|
|
|
Re: kte autobrace
by Bugzilla from mail@milianw.de
::
Rate this Message:
On Wednesday 21 October 2009 20:02:04 Jakob Petsovits wrote:
> On Wednesday 21 October 2009, Milian Wolff wrote: > > On Wednesday 07 October 2009 19:06:25 Dominik Haumann wrote: > > > On Tuesday 06 October 2009, Milian Wolff wrote: > > > > On Tuesday 06 October 2009 20:03:18 Dominik Haumann wrote: > > > > > On Tuesday 06 October 2009, Milian Wolff wrote: > > > > > > On Monday 05 October 2009 21:21:32 Dominik Haumann wrote: > > > > > > > Hi, > > > > > > > > > > > > > > at http://techbase.kde.org/Talk:Schedules/KDE4/4.4_Feature_Plan > > > > > > > someone wrote: > > > > > > > Can you add this in kate? > > > > > > > > > > > > > > svn://anonsvn.kde.org/home/kde/trunk/playground/devtools/kte_au > > > > > > >to br ace > > > > > > > > > > > > > > Anyone interested and volunteers to have a look at it ? > > > > > > > > > > > > I use that plugin all the time, it's by far better than what > > > > > > Kate/KWrite gives you by default in it's options (the dump > > > > > > "autocomplete braces" option). > > > > > > > > > > > > So I think: Definitly import it to kdesdk/kate or even kdelibs. > > > > > > > > > > kdesdk usually only contains Kate and Kate app plugins, i.e. no > > > > > ktexteditor plugins. I guess kte_autobrace is a ktexteditor plugin? > > > > > > > > True, where are ktexteditor plugins supposed to live? Somewhere in > > > > kdelibs? > > > > > > yes: kdelibs/kate/plugins/ > > > > > > > > > What kind of volunteer work do you need? > > > > > > > > > > simply someone who does the work: review + commit to trunk. > > > > > > > > I'll take a look. > > > > First look at the code base: > > > > - very clean > > - well documented > > - follows the KDELibs style > > > > TODO in my eyes: > > > > - clear license/copyright, who wrote it? The header is jpetso, the > > implementation is ereslibre? is that really correct? > > hm, no, that's not really correct, I wrote the whole plugin. > My guess is that ereslibre's copyright comes from the hello-world plugin > example that I started from, can't check though atm (busily working away at > work, as can be seen by this email). > > - warn when the user has auto-brackets enabled, see also: > > http://reviewboard.kde.org/r/1882/ > > Having auto-brackets enabled does not work together with this plugin. I'd > > like to see a dialog explaining this issue and also offering to un-set > > auto-bracket. Of course don't forget to connect to changes in the kate > > configuration when the user tries to re-enable auto-bracket. > > Well it does work, but you need to delete the auto-inserted brace before > pressing Enter. I think it should be possible to recognize that case and > act correctly on it, I just didn't do it because I think the auto-brackets > mode is dreadful. something it's not really "auto" anymore :P > > - make the plugin more intelligent. I know that it currently limits its > > scope for performance reasons, but I'm often hit by the following issue: > > > > existing code: > > namespace foobar { > > class someclass { > > }; > > } > > > > Now I frequently try to add something to the namespace, above the class. > > I place the cursor after foobar { and hit return. The plugin will insert > > another brace => fail. > > No it doesn't? > It has code that specifically makes sure that a brace is only inserted when > the next line is not indented further than the one above (= foobar line). > Are you sure you're not using an outdated version or anything? > (Also, I'll make sure I committed that part to SVN, but I believe I did.) namespace foobar { class someclass { }; } I actually use it myself most of the time, just not in the snippet above :) Here of course, kte_autobrace fails. Using indendation is imo not good, instead it should look at the number of opened/closed braces and act accordingly. > > I doubt making the code more intelligent, maybe by using a simple parser > > instead of regular expressions, would introduce such a big performance > > penalty. > > Using regexps was not so much about performance but rather about ease > of coding :P Having the above in mind, maybe a parser is really required, since using regexps on the whole, possible big, file will lead to noticably performance penalties. One could potentially even make it somewhat "smart" with storing brace occurences, though this might fail on LISP or other docs with much braces/parens and the like. One should probably profile/benchmark this, and see how much time would be spent on a big file, when inserting a line at the bottom. > > Even if my feature wish is not incorporated, I'd still say: Lets ship > > this plugin with kdelibs in 4.4! > > > > OT: > > I'd like to see auto brace support in Kate improve even more, if required > > not as a plugin, but directly in source. I'd like to have something like > > the current auto-bracket, but with overwriting support, i.e.: > > > > I press '(', get '(|)', with '|' == cursor position. If I now write ')' > > I'd want '()|' instead of '()|)'. This would make this plugin redundant. > > What should be done as well though is probably the following: > > '(' => '(|') => hit return, get => '(\n |\n)' > > i.e. return not only inserts a single newline, but inserts a newline, > > indents the next line (already done via indent scripts), but the > > following brace/bracket/parens should be put on the line _after_ that. > > +1! > > Wishes, > Jakob > > P.S.: thanks for taking the effort to get my plugin upstreamed - I didn't > do it because... hm... why was that, actually? I guess it's because it > should probably be implemented as an improvement to auto-brackets instead > of a separate plugin. Which I obviously never got around to tackle. for Kate I think pushing the plugin to kdelibs for now is really the way to go. PS: Thanks for your thesis on KDevelop-PG-Qt, helped me to understand that stuff finally ;-) Have a nice day -- Milian Wolff mail@... http://milianw.de _______________________________________________ KWrite-Devel mailing list KWrite-Devel@... https://mail.kde.org/mailman/listinfo/kwrite-devel |
|
|
Re: kte autobrace
by Bugzilla from jpetso@gmx.at
::
Rate this Message:
|
|
|
Re: kte autobrace
by Bugzilla from mail@milianw.de
::
Rate this Message:
On Thursday, 22. October 2009 01:14:35 Jakob Petsovits wrote:
> On Wednesday 21 October 2009, Jakob Petsovits wrote: > > On Wednesday 21 October 2009, Milian Wolff wrote: > > > - make the plugin more intelligent. I know that it currently limits > > > its scope for performance reasons, but I'm often hit by the following > > > issue: > > > > > > existing code: > > > namespace foobar { > > > class someclass { > > > }; > > > } > > > > > > Now I frequently try to add something to the namespace, above the > > > class. I place the cursor after foobar { and hit return. The plugin > > > will insert another brace => fail. > > > > No it doesn't? > > It has code that specifically makes sure that a brace is only inserted > > when the next line is not indented further than the one above (= foobar > > line). Are you sure you're not using an outdated version or anything? > > (Also, I'll make sure I committed that part to SVN, but I believe I did.) > > Yep, no pending changes, it's all in SVN. > That example should not expose the incorrect behavior that you described. > It certainly doesn't on my system. hence the problem occurs. Just wrote it that way in the Email, dunno why :) Sorry for the confusion! -- Milian Wolff mail@... http://milianw.de _______________________________________________ KWrite-Devel mailing list KWrite-Devel@... https://mail.kde.org/mailman/listinfo/kwrite-devel |
|
|
Re: kte autobrace
by Bugzilla from ereslibre@kde.org
::
Rate this Message:
|
|
|
Re: kte autobrace
by Bugzilla from jpetso@gmx.at
::
Rate this Message:
|
|
|
Re: kte autobrace
by Bugzilla from mail@milianw.de
::
Rate this Message:
On Friday 23 October 2009 05:55:41 Jakob Petsovits wrote:
... > May I suggest a different solution instead which involves a simple list of > strings or regexps to search for in a line, causing the plugin not to > trigger, with "namespace" being in the default list of exceptions? That > will work just as well, and can even be configured easily if you put it in > a kte_autobracerc file. (Such a file would also make it very easy to > customize the characters to trigger the plugin.) OK - do you have any time to implement this so we can still push this into 4.4? Else I'll push the plugin into KDELibs it in the next days. Maybe I have some time to also implement that feature (as it bugs me personally quite a lot). Should this plugin go through KDE Review? Imo its code is really clean and "simple", so I don't see a need for it. But I'm not yet acquainted enough with the KDE way of doing these things :) -- Milian Wolff mail@... http://milianw.de _______________________________________________ KWrite-Devel mailing list KWrite-Devel@... https://mail.kde.org/mailman/listinfo/kwrite-devel |
|
|
Re: kte autobrace
by Bugzilla from mail@milianw.de
::
Rate this Message:
On Wednesday 11 November 2009 00:24:02 Milian Wolff wrote:
> On Friday 23 October 2009 05:55:41 Jakob Petsovits wrote: > ... > > > May I suggest a different solution instead which involves a simple list > > of strings or regexps to search for in a line, causing the plugin not to > > trigger, with "namespace" being in the default list of exceptions? That > > will work just as well, and can even be configured easily if you put it > > in a kte_autobracerc file. (Such a file would also make it very easy to > > customize the characters to trigger the plugin.) > > OK - do you have any time to implement this so we can still push this into > 4.4? > > Else I'll push the plugin into KDELibs it in the next days. Maybe I have > some time to also implement that feature (as it bugs me personally quite a > lot). > > Should this plugin go through KDE Review? Imo its code is really clean and > "simple", so I don't see a need for it. But I'm not yet acquainted enough > with the KDE way of doing these things :) weeks (esp. checking whether "the other" auto brace feature is enabled and warn the user - oh string changes, have to do it today I think). -- Milian Wolff mail@... http://milianw.de _______________________________________________ KWrite-Devel mailing list KWrite-Devel@... https://mail.kde.org/mailman/listinfo/kwrite-devel |
signature.asc (204 bytes) | Free embeddable forum powered by Nabble | Forum Help |
