layout test expectation files without tests

[Shinichiro Hamaji-2]

Hi WebKit,

I found there are several expectation files which don't have
corresponding tests. Most of them are fine. People just forgot to remove
expectation files when they removed the tests. However, there are some
cases in which people forgot to add test files. For such cases, I
think we should add the test files if possible.

Here is the list of such cases. I hope original authors will put these tests.

- editing/execCommand/5482524
author: justing
trac: http://trac.webkit.org/changeset/26558

- editing/execCommand/outdent-blockquote-test5
author: kmccullough
trac: http://trac.webkit.org/changeset/43729

- editing/pasteboard/4944770
author: justing
trac: http://trac.webkit.org/changeset/19036

- fast/dynamic/8952-reduction
author: darin
trac: http://trac.webkit.org/changeset/15459
comment: now the png file is in platform/mac

- fast/forms/basic-textareas-quirks
author: ojan
trac: http://trac.webkit.org/changeset/41792

Thanks!
_______________________________________________
webkit-dev mailing list
webkit-dev@...
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[Darin Adler]

On Oct 21, 2009, at 2:17 AM, Shinichiro Hamaji wrote:

> However, there are some cases in which people forgot to add test  
> files.

Thanks for tackling this!

> - fast/dynamic/8952-reduction
> author: darin
> trac: http://trac.webkit.org/changeset/15459
> comment: now the png file is in platform/mac

In this case, I believe what actually happened (3 years ago! it's hard  
to remember) was that my test was originally named 8952-reduction in  
my local directory and I renamed it to move-node-with-selection before  
checking in, but forgot to rename the PNG file.

We should definitely removeLayoutTests/fast/dynamic/8952-reduction-
expected.png -- there is no reason to keep it around. I did not forget  
to add a test file in this case.

     -- Darin

_______________________________________________
webkit-dev mailing list
webkit-dev@...
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[Ojan Vafai-2]

On Wed, Oct 21, 2009 at 2:17 AM, Shinichiro Hamaji <hamaji@...> wrote:

- fast/forms/basic-textareas-quirks
author: ojan
trac: http://trac.webkit.org/changeset/41792

Doh. The quirks version of this test was rolled into the basic-textareas.html test before checking in. I'll remove the extra expectations later today.

Ojan 

_______________________________________________
webkit-dev mailing list
webkit-dev@...
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev