lib/div: Overriding TS config via FF
|
View:
New views
7 Messages
—
Rating Filter:
Alert me
|
 |
lib/div: Overriding TS config via FF
by Jochen Rieger
::
Rate this Message:
Hey lib/div devs,
finally I managed to dig deeper into the lib/div framework instead of just following the mailinglists discussions about it. A long awaited situation! :) I found one behaviour to be worth changed (or maybe I just did not find the right way to do it): When retrieving configurations via $this->configurations->get('someConfKey'); I will ALWAYS get the FF value in case the same key exists in TS and FF. I think it might be better to use the flexform value ONLY IF something was entered there. Would be kind of a nobrainer in class.tx_lib_configurations.php: foreach((array) $data as $sheet => $languages) { foreach((array) $languages[$languagePointer] as $key => $def) { // just use ff value if something was entered if ($def[$valuePointer] != '') { $this->set($key, $def[$valuePointer]); } } } What do you think? Cheers, Jochen -- Connecta AG TYPO3 Development http://www.connecta.ag _______________________________________________ TYPO3-team-extension-coordination mailing list TYPO3-team-extension-coordination@... http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-extension-coordination |
|
|
Re: lib/div: Overriding TS config via FF
by Daniel Bruessler-2
::
Rate this Message:
Hello Jochen,
yes shure, that should be changed. In the moment there's nobody working on lib/div. Do you have a sourceforge-account to add it via SVN? Cheers! Daniel > Hey lib/div devs, > > finally I managed to dig deeper into the lib/div framework instead of > just following the mailinglists discussions about it. A long awaited > situation! :) > > I found one behaviour to be worth changed (or maybe I just did not find > the right way to do it): > > When retrieving configurations via > > $this->configurations->get('someConfKey'); > > I will ALWAYS get the FF value in case the same key exists in TS and FF. > I think it might be better to use the flexform value ONLY IF something > was entered there. Would be kind of a nobrainer in > > class.tx_lib_configurations.php: > > foreach((array) $data as $sheet => $languages) { > foreach((array) $languages[$languagePointer] as $key => $def) { > > // just use ff value if something was entered > if ($def[$valuePointer] != '') { > $this->set($key, $def[$valuePointer]); > } > } > } > > What do you think? > > Cheers, > Jochen > > -- > Connecta AG TYPO3 Development > http://www.connecta.ag TYPO3-team-extension-coordination mailing list TYPO3-team-extension-coordination@... http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-extension-coordination |
|
|
Re: lib/div: Overriding TS config via FF
by Jochen Rieger
::
Rate this Message:
Hi Daniel,
> yes shure, that should be changed. In the moment there's nobody working > on lib/div. Do you have a sourceforge-account to add it via SVN? my Sourceforge account is jochen_rieger ... but I don't think I have write access to typo3xdev SVN, do I? Cheers, Jochen _______________________________________________ TYPO3-team-extension-coordination mailing list TYPO3-team-extension-coordination@... http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-extension-coordination |
|
|
|
|
|
Re: lib/div: Overriding TS config via FF
by Jochen Rieger
::
Rate this Message:
Dear Philip,
> Well I think it should be change, but please > let's go beta and start to prevent new changes from breaking code > already done. > Change ok but by making a new class variable that > can be set and activates this new option so that the code already done > stays functional. you are absolutely right. But would it really break anything? I don't see that. Checking if a FF value contains more than any empty string (nothing!) won't change functionality. Besides ... I consider this more as a bugfix than an added feature because the usual behaviour in TYPO3 is just the the fix would make it: You have general settings via TS but you can override them via flexform IN CASE you enter something. You wouldn't want an empty FF field to delete the default TS settings for a config option, would ya? Regards, Jochen _______________________________________________ TYPO3-team-extension-coordination mailing list TYPO3-team-extension-coordination@... http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-extension-coordination |
|
|
Re: lib/div: Overriding TS config via FF
by Daniel Bruessler-2
::
Rate this Message:
Hello Elmar,
please come back! We need you ;-) +++ Hello Philip, this change will not break the functionality of an extension you developed on base of lib/div. This would be a bugfix. http://typo3.org/extensions/repository/view/lib/0.1.0/ Changes since lib 0.1.0 will be 0.1.1 - or not? Existing extensions you made with lib/div are not affected when you don't upgrade lib/div. Or is the problem because you're using the current SVN-version? If yes we should tag the current lib-version as 0.1.1 - what do you think about it? +++ Hello Jochen, you need to ask Andreas Otto for write-access. But keep in contact with Philip before because a tagging for "0.1.1" seems to be in need. Cheers! Daniel > Hi all, > My SCREAM -> "Helmar where are > you?????" > Well I think it should be change, but please > let's go beta and start to prevent new changes from breaking code > already done. > Change ok but by making a new class variable that > can be set and activates this new option so that the code already done > stays functional. > Do you now why we have 5 fingers because the fish > we came from add 5 bones on his lateral fins. Nature uses what she have > but does not break the line. > Best regards, > Philip > Almeida > sourceforge-account to add it via SVN? >> my Sourceforge > account is >> jochen_rieger > I don't think I have write access to typo3xdev SVN, do I? >> Cheers, >> Jochen _______________________________________________ TYPO3-team-extension-coordination mailing list TYPO3-team-extension-coordination@... http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-extension-coordination |
|
|
Re: lib/div: Overriding TS config via FF
by Franz Holzinger
::
Rate this Message:
Daniel Brüßler a écrit :
> Hello Elmar, > > please come back! We need you ;-) > > +++ When will Elmar be back? You is now the head of the ECT ? - Franz _______________________________________________ TYPO3-team-extension-coordination mailing list TYPO3-team-extension-coordination@... http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-extension-coordination |
| Free embeddable forum powered by Nabble | Forum Help |
