libkcompact patch (track numbers)

[Marco Nelles-2]

Hi,


I've done some testing on libkcddb http submit and it seems to work so far.
However I want to check some things, so these are not my final words. I will
give you a test report as soon as I'm ready with the testing.

I've found another bug in libkcompactdisk leading to track titles like
- Track 0
- Track 0
...
- Track 0
- Track 10
- Track 11

instead of Track 1, Track 2, Track 3 and so on.

It's my first kde patch. If there are any special things I have to consider for
further patches please tell me.


Regards, Marco

[libkcompactdisk.patch]

---

--- wmlib_interface.cpp.org     2009-08-15 21:58:40.000000000 +0200
+++ wmlib_interface.cpp 2009-08-15 21:59:04.000000000 +0200
@@ -234,7 +234,7 @@
                                        m_trackTitles.append(i18n("Unknown Title"));
                                        for(i = 1; i <= m_tracks; i++) {
                                                m_trackArtists.append(i18n("Unknown Artist"));
-                                               m_trackTitles.append(ki18n("Track %1").subs(i, 2).toString());
+                                               m_trackTitles.append(ki18n("Track %1").subs(i).toString());
                                        }

 kDebug() << "m_tracks " << m_tracks;

---

_______________________________________________
kde-multimedia mailing list
kde-multimedia@...
https://mail.kde.org/mailman/listinfo/kde-multimedia

[Richard Lärkäng-2]

Hi!

On Saturday 15 August 2009 22:13:30 Marco Nelles wrote:
> Hi,
>
>
> I've done some testing on libkcddb http submit and it seems to work so far.
> However I want to check some things, so these are not my final words. I
> will give you a test report as soon as I'm ready with the testing.

OK, sounds good.

> I've found another bug in libkcompactdisk leading to track titles like
> - Track 0
> - Track 0
> ...
> - Track 0
> - Track 10
> - Track 11
>
> instead of Track 1, Track 2, Track 3 and so on.
>
> It's my first kde patch. If there are any special things I have to consider
> for further patches please tell me.

Thanks for the patch, I can confirm it fixes the problem for me here too. On the
other hand, to me the current usage (of KLocalizedString::subs) seems correct,
so it looks like the patch is covering up a bug somewhere else, so I'm a
little hesitant to the patch.

/Richard Lärkäng

>
>
> Regards, Marco
_______________________________________________
kde-multimedia mailing list
kde-multimedia@...
https://mail.kde.org/mailman/listinfo/kde-multimedia