libng-1.4.0beta82 is available

View: New views
20 Messages — Rating Filter:   Alert me  
< Prev | 1 - 2 | Next >

libng-1.4.0beta82 is available

by Glenn Randers-Pehrson :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

libpng-1.4.0beta82 is available from
ftp://ftp.simplesystems.org/pub/png-group/src
and from
http://libpng.sourceforge.net/index.html

version 1.4.0beta82
  Moved redundant IHDR checking into new png_check_IHDR() in png.c
    and report all errors found in the IHDR data.
  Eliminated useless call to png_check_cHRM() from pngset.c

Glenn

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

Re: libng-1.4.0beta82 is available

by Arnaud BOEGLIN :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

Sorry to be late, I'm in Europe ! I tried the version 1.4.0beta82 and  
it works ! Great and fast job, thanks you very much. But it strange  
that I'm the first one to report this. Snow leopard is released since  
1 month now.

Regards,
Arnaud BOEGLIN.


On Sep 25, 2009, at 2:22 AM, Glenn Randers-Pehrson wrote:

> libpng-1.4.0beta82 is available from
> ftp://ftp.simplesystems.org/pub/png-group/src
> and from
> http://libpng.sourceforge.net/index.html
>
> version 1.4.0beta82
>  Moved redundant IHDR checking into new png_check_IHDR() in png.c
>    and report all errors found in the IHDR data.
>  Eliminated useless call to png_check_cHRM() from pngset.c
>
> Glenn
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry® Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart  
> your
> developing skills, take BlackBerry mobile applications to market and  
> stay
> ahead of the curve. Join us from November 9-12, 2009. Register  
> now!
> http://p.sf.net/sfu/devconf
> _______________________________________________
> png-mng-implement mailing list
> png-mng-implement@...
> https://lists.sourceforge.net/lists/listinfo/png-mng-implement


------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

Re: libng-1.4.0beta82 is available

by John Bowler-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

From: Arnaud BOEGLIN [mailto:a.boeglin67@...]
>Sorry to be late, I'm in Europe ! I tried the version 1.4.0beta82 and  
>it works ! Great and fast job, thanks you very much. But it strange  
>that I'm the first one to report this. Snow leopard is released since  
>1 month now.

I think Glenn expected it to fail in a more meaningful way ;-)  The fact
that it doesn't strongly suggests that it is a bug, probably a memory
overwrite (random heap corruption), in your own program.

John Bowler <jbowler@...>



------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

Re: libng-1.4.0beta82 is available

by Arnaud BOEGLIN :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I don't think so, I tried with a lot of versions, and many times. Now,  
it doesn't crash anymore.
I also expected me to see an error. If you have other versions to  
submit me, I'll test them, or If
I've again the same problem I'll email you.

Arnaud BOEGLIN.


On Sep 25, 2009, at 3:41 PM, John Bowler wrote:

> From: Arnaud BOEGLIN [mailto:a.boeglin67@...]
>> Sorry to be late, I'm in Europe ! I tried the version 1.4.0beta82 and
>> it works ! Great and fast job, thanks you very much. But it strange
>> that I'm the first one to report this. Snow leopard is released since
>> 1 month now.
>
> I think Glenn expected it to fail in a more meaningful way ;-)  The  
> fact
> that it doesn't strongly suggests that it is a bug, probably a memory
> overwrite (random heap corruption), in your own program.
>
> John Bowler <jbowler@...>
>
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry® Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart  
> your
> developing skills, take BlackBerry mobile applications to market and  
> stay
> ahead of the curve. Join us from November 9-12, 2009. Register  
> now!
> http://p.sf.net/sfu/devconf
> _______________________________________________
> png-mng-implement mailing list
> png-mng-implement@...
> https://lists.sourceforge.net/lists/listinfo/png-mng-implement


------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

Re: libng-1.4.0beta82 is available

by glennrp-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


----- Original Message -----
From: "John Bowler" <john.cunningham.bowler@...>
To: "PNG/MNG implementation discussion list" <png-mng-implement@...>
Sent: Friday, September 25, 2009 10:41:13 AM GMT -05:00 US/Canada Eastern
Subject: Re: [png-mng-implement] libng-1.4.0beta82 is available

From: Arnaud BOEGLIN [mailto:a.boeglin67@...]
>Sorry to be late, I'm in Europe ! I tried the version 1.4.0beta82 and  
>it works ! Great and fast job, thanks you very much. But it strange  
>that I'm the first one to report this. Snow leopard is released since  
>1 month now.

I think Glenn expected it to fail in a more meaningful way ;-)

       Indeed I did.  When I first saw the bug report I thought
       I recalled that you would have gotten a "width or height == 0"
       error report instead of the report you got.  Then I looked at
       libpng and realized that there were two separate, slightly
       different, validity checks of the IHDR data.  In beta82
       I combined both checks into a single new function in png.c,
       and made it more thorough and verbose (and hopefully more
       useful, efficient, and simpler to maintain).  I did *not*
       expect it to fix your problem!

       Glenn

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

Re: libng-1.4.0beta82 is available

by Arnaud BOEGLIN :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Yes, I thought you expected it. Thank you for all. It's a great job  
again !

Arnaud BOEGLIN.

On Sep 25, 2009, at 3:59 PM, glennrp@... wrote:

>
> ----- Original Message -----
> From: "John Bowler" <john.cunningham.bowler@...>
> To: "PNG/MNG implementation discussion list" <png-mng-implement@...
> >
> Sent: Friday, September 25, 2009 10:41:13 AM GMT -05:00 US/Canada  
> Eastern
> Subject: Re: [png-mng-implement] libng-1.4.0beta82 is available
>
> From: Arnaud BOEGLIN [mailto:a.boeglin67@...]
>> Sorry to be late, I'm in Europe ! I tried the version 1.4.0beta82 and
>> it works ! Great and fast job, thanks you very much. But it strange
>> that I'm the first one to report this. Snow leopard is released since
>> 1 month now.
>
> I think Glenn expected it to fail in a more meaningful way ;-)
>
>       Indeed I did.  When I first saw the bug report I thought
>       I recalled that you would have gotten a "width or height == 0"
>       error report instead of the report you got.  Then I looked at
>       libpng and realized that there were two separate, slightly
>       different, validity checks of the IHDR data.  In beta82
>       I combined both checks into a single new function in png.c,
>       and made it more thorough and verbose (and hopefully more
>       useful, efficient, and simpler to maintain).  I did *not*
>       expect it to fix your problem!
>
>       Glenn
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry® Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart  
> your
> developing skills, take BlackBerry mobile applications to market and  
> stay
> ahead of the curve. Join us from November 9-12, 2009. Register  
> now!
> http://p.sf.net/sfu/devconf
> _______________________________________________
> png-mng-implement mailing list
> png-mng-implement@...
> https://lists.sourceforge.net/lists/listinfo/png-mng-implement


------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

Re: libng-1.4.0beta82 is available

by Glenn Randers-Pehrson :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Fri, Sep 25, 2009 at 10:52 AM, Arnaud BOEGLIN <a.boeglin67@...> wrote:
> If you have other versions to
> submit me, I'll test them, or If
> I've again the same problem I'll email you.

Please try libpng-1.2.41beta01

Glenn

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

Re: libng-1.4.0beta82 is available

by Arnaud BOEGLIN :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I'll do it, but I had a big week end, I do it tonight or tomorrow.

Arnaud BOEGLIN.

On Sep 25, 2009, at 6:19 PM, Glenn Randers-Pehrson wrote:

> On Fri, Sep 25, 2009 at 10:52 AM, Arnaud BOEGLIN <a.boeglin67@...
> > wrote:
>> If you have other versions to
>> submit me, I'll test them, or If
>> I've again the same problem I'll email you.
>
> Please try libpng-1.2.41beta01
>
> Glenn
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry® Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart  
> your
> developing skills, take BlackBerry mobile applications to market and  
> stay
> ahead of the curve. Join us from November 9-12, 2009. Register  
> now!
> http://p.sf.net/sfu/devconf
> _______________________________________________
> png-mng-implement mailing list
> png-mng-implement@...
> https://lists.sourceforge.net/lists/listinfo/png-mng-implement


------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

Re: libng-1.4.0beta82 is available

by Arnaud BOEGLIN :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

With libpng-1.2.41beta01 I've got this on stderr :

libpng warning: Image width exceeds user limit in IHDR
libpng error: Invalid IHDR data

Arnaud BOEGLIN.

On Sep 25, 2009, at 6:19 PM, Glenn Randers-Pehrson wrote:

> On Fri, Sep 25, 2009 at 10:52 AM, Arnaud BOEGLIN <a.boeglin67@...
> > wrote:
>> If you have other versions to
>> submit me, I'll test them, or If
>> I've again the same problem I'll email you.
>
> Please try libpng-1.2.41beta01
>
> Glenn
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry® Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart  
> your
> developing skills, take BlackBerry mobile applications to market and  
> stay
> ahead of the curve. Join us from November 9-12, 2009. Register  
> now!
> http://p.sf.net/sfu/devconf
> _______________________________________________
> png-mng-implement mailing list
> png-mng-implement@...
> https://lists.sourceforge.net/lists/listinfo/png-mng-implement


------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

Re: libng-1.4.0beta82 is available

by Glenn Randers-Pehrson :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Unless you have changed it, the user limit is defined in pngconf.h:
pngconf.h:#  define PNG_USER_WIDTH_MAX 1000000L

So it's likely you have somehow swapped the bytes in info_ptr->width.

Width is read by png_get_uint_31(), so the failure is probably there.
It's probably as I originally suspected a BIG_ENDIAN vs LITTLE_ENDIAN
problem.

Glenn

On Mon, Sep 28, 2009 at 10:03 AM, Arnaud BOEGLIN <a.boeglin67@...> wrote:

> Hi,
>
> With libpng-1.2.41beta01 I've got this on stderr :
>
> libpng warning: Image width exceeds user limit in IHDR
> libpng error: Invalid IHDR data
>
> Arnaud BOEGLIN.
>
> On Sep 25, 2009, at 6:19 PM, Glenn Randers-Pehrson wrote:
>
>> On Fri, Sep 25, 2009 at 10:52 AM, Arnaud BOEGLIN <a.boeglin67@...
>> > wrote:
>>> If you have other versions to
>>> submit me, I'll test them, or If
>>> I've again the same problem I'll email you.
>>
>> Please try libpng-1.2.41beta01
>>
>> Glenn
>>
>> ------------------------------------------------------------------------------
>> Come build with us! The BlackBerry® Developer Conference in SF, CA
>> is the only developer event you need to attend this year. Jumpstart
>> your
>> developing skills, take BlackBerry mobile applications to market and
>> stay
>> ahead of the curve. Join us from November 9-12, 2009. Register
>> now!
>> http://p.sf.net/sfu/devconf
>> _______________________________________________
>> png-mng-implement mailing list
>> png-mng-implement@...
>> https://lists.sourceforge.net/lists/listinfo/png-mng-implement
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry® Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9-12, 2009. Register now!
> http://p.sf.net/sfu/devconf
> _______________________________________________
> png-mng-implement mailing list
> png-mng-implement@...
> https://lists.sourceforge.net/lists/listinfo/png-mng-implement
>

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

Re: libng-1.4.0beta82 is available

by John Bowler-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

From: Glenn Randers-Pehrson [mailto:glennrp@...]
>Width is read by png_get_uint_31(), so the failure is probably there.
>It's probably as I originally suspected a BIG_ENDIAN vs LITTLE_ENDIAN
>problem.

For that to be correct PNG_BIG_ENDIAN_SUPPORTED would have to have been
defined - since the code in absence of this #define works correctly
regardless of the machine architecture.  (None of the standard code in
libpng needs to know the byte sex of the hardware does it?)

The bug would also be reproducible on 1.4.0beta82, assuming everything has
been compiled with the same options, but:

From: Arnaud BOEGLIN [mailto:a.boeglin67@...]
>I tried the version 1.4.0beta82 and it works !

Hum.  What is the width that is going wrong?  I.e. exactly what value is
failing the test?  If we know that we will be able to make far more informed
guesses.

John Bowler <jbowler@...>



------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

Re: libng-1.4.0beta82 is available

by Arnaud BOEGLIN :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


On Sep 28, 2009, at 7:03 PM, John Bowler wrote:

> From: Arnaud BOEGLIN [mailto:a.boeglin67@...]
>> I tried the version 1.4.0beta82 and it works !
>
> Hum.  What is the width that is going wrong?  I.e. exactly what  
> value is
> failing the test?  If we know that we will be able to make far more  
> informed
> guesses.
>
> John Bowler <jbowler@...>

These following widths that are going wrong :

2362; 283; 1181; 38;

I think there's no special width which isn't correct.

Arnaud BOEGLIN.

> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry® Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart  
> your
> developing skills, take BlackBerry mobile applications to market and  
> stay
> ahead of the curve. Join us from November 9-12, 2009. Register  
> now!
> http://p.sf.net/sfu/devconf
> _______________________________________________
> png-mng-implement mailing list
> png-mng-implement@...
> https://lists.sourceforge.net/lists/listinfo/png-mng-implement


------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

Re: libng-1.4.0beta82 is available

by Glenn Randers-Pehrson :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Tue, Sep 29, 2009 at 9:10 AM, Arnaud BOEGLIN <a.boeglin67@...> wrote:

>
> On Sep 28, 2009, at 7:03 PM, John Bowler wrote:
>
>> From: Arnaud BOEGLIN [mailto:a.boeglin67@...]
>>> I tried the version 1.4.0beta82 and it works !
>>
>> Hum.  What is the width that is going wrong?  I.e. exactly what
>> value is
>> failing the test?  If we know that we will be able to make far more
>> informed
>> guesses.
>>
>> John Bowler <jbowler@...>
>
> These following widths that are going wrong :
>
> 2362; 283; 1181; 38;
>
> I think there's no special width which isn't correct.

It's very interesting that you did not get a warning from
libpng-1.2.41beta01 about the height also exceeding
the user limit.  An ENDIAN problem would affect both
width and height.

Note that width and height are the first two members
of the info struct.  If you would like to do a little
experiment, see what happens if you interchange
them and make "height" first:

In libpng-1.2.41beta01/png.h, change

   png_uint_32 width;       /* width of image in pixels (from IHDR) */
   png_uint_32 height;      /* height of image in pixels (from IHDR) */

to

   png_uint_32 height;      /* height of image in pixels (from IHDR) */
   png_uint_32 width;       /* width of image in pixels (from IHDR) */

and see if libpng then complains about height instead of about
width.

Glenn

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

Re: libng-1.4.0beta82 is available

by Arnaud BOEGLIN :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Ok, I do it and I send you the output !

Arnaud BOEGLIN.

On Sep 29, 2009, at 2:44 PM, Glenn Randers-Pehrson wrote:

> On Tue, Sep 29, 2009 at 9:10 AM, Arnaud BOEGLIN  
> <a.boeglin67@...> wrote:
>>
>> On Sep 28, 2009, at 7:03 PM, John Bowler wrote:
>>
>>> From: Arnaud BOEGLIN [mailto:a.boeglin67@...]
>>>> I tried the version 1.4.0beta82 and it works !
>>>
>>> Hum.  What is the width that is going wrong?  I.e. exactly what
>>> value is
>>> failing the test?  If we know that we will be able to make far more
>>> informed
>>> guesses.
>>>
>>> John Bowler <jbowler@...>
>>
>> These following widths that are going wrong :
>>
>> 2362; 283; 1181; 38;
>>
>> I think there's no special width which isn't correct.
>
> It's very interesting that you did not get a warning from
> libpng-1.2.41beta01 about the height also exceeding
> the user limit.  An ENDIAN problem would affect both
> width and height.
>
> Note that width and height are the first two members
> of the info struct.  If you would like to do a little
> experiment, see what happens if you interchange
> them and make "height" first:
>
> In libpng-1.2.41beta01/png.h, change
>
>   png_uint_32 width;       /* width of image in pixels (from IHDR) */
>   png_uint_32 height;      /* height of image in pixels (from IHDR) */
>
> to
>
>   png_uint_32 height;      /* height of image in pixels (from IHDR) */
>   png_uint_32 width;       /* width of image in pixels (from IHDR) */
>
> and see if libpng then complains about height instead of about
> width.
>
> Glenn
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry® Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart  
> your
> developing skills, take BlackBerry mobile applications to market and  
> stay
> ahead of the curve. Join us from November 9-12, 2009. Register  
> now!
> http://p.sf.net/sfu/devconf
> _______________________________________________
> png-mng-implement mailing list
> png-mng-implement@...
> https://lists.sourceforge.net/lists/listinfo/png-mng-implement


------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

Re: libng-1.4.0beta82 is available

by Arnaud BOEGLIN :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I've just done it, it's still the same output on stderr :

libpng warning: Image width exceeds user limit in IHDR
libpng error: Invalid IHDR data

Arnaud BOEGLIN.

On Sep 29, 2009, at 2:44 PM, Glenn Randers-Pehrson wrote:

> On Tue, Sep 29, 2009 at 9:10 AM, Arnaud BOEGLIN  
> <a.boeglin67@...> wrote:
>>
>> On Sep 28, 2009, at 7:03 PM, John Bowler wrote:
>>
>>> From: Arnaud BOEGLIN [mailto:a.boeglin67@...]
>>>> I tried the version 1.4.0beta82 and it works !
>>>
>>> Hum.  What is the width that is going wrong?  I.e. exactly what
>>> value is
>>> failing the test?  If we know that we will be able to make far more
>>> informed
>>> guesses.
>>>
>>> John Bowler <jbowler@...>
>>
>> These following widths that are going wrong :
>>
>> 2362; 283; 1181; 38;
>>
>> I think there's no special width which isn't correct.
>
> It's very interesting that you did not get a warning from
> libpng-1.2.41beta01 about the height also exceeding
> the user limit.  An ENDIAN problem would affect both
> width and height.
>
> Note that width and height are the first two members
> of the info struct.  If you would like to do a little
> experiment, see what happens if you interchange
> them and make "height" first:
>
> In libpng-1.2.41beta01/png.h, change
>
>   png_uint_32 width;       /* width of image in pixels (from IHDR) */
>   png_uint_32 height;      /* height of image in pixels (from IHDR) */
>
> to
>
>   png_uint_32 height;      /* height of image in pixels (from IHDR) */
>   png_uint_32 width;       /* width of image in pixels (from IHDR) */
>
> and see if libpng then complains about height instead of about
> width.
>
> Glenn
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry® Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart  
> your
> developing skills, take BlackBerry mobile applications to market and  
> stay
> ahead of the curve. Join us from November 9-12, 2009. Register  
> now!
> http://p.sf.net/sfu/devconf
> _______________________________________________
> png-mng-implement mailing list
> png-mng-implement@...
> https://lists.sourceforge.net/lists/listinfo/png-mng-implement


------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

Re: libng-1.4.0beta82 is available

by John Bowler-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

From: Arnaud BOEGLIN [mailto:a.boeglin67@...]
>> Hum.  What is the width that is going wrong?  I.e. exactly what  
>> value is failing the test
>These following widths that are going wrong :
>
>2362; 283; 1181; 38;
>
>I think there's no special width which isn't correct.

Well, they're all less than 16 bits (65536), but what I meant was what value
did the 'width' field of the *info_ptr structure have at the moment of
failure?  (It can't have had one of those values.)

The result of Glenn's suggested experiment hints that my original theory is
wrong, but can you print out the png_info_struct 'width' value immediately
before the call to png_get_IHDR that fails.  I.e. in your program something
like the following two lines:

        fprintf(stderr, "width is: %u\n", read_info_ptr->width);    /* add
this */
        fprintf(stderr, "private width is: %d\n", read_ptr->width); /* and
this before: */
        png_get_IHDR(read_ptr, read_info_ptr, &width, &height, &bit_depth,
&colortype,
                        ...etc...

Then report what the output is.

John Bowler <jbowler@...>



------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

Re: libng-1.4.0beta82 is available

by Glenn Randers-Pehrson :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Tue, Sep 29, 2009 at 12:04 PM, John Bowler
<john.cunningham.bowler@...> wrote:

> The result of Glenn's suggested experiment hints that my original theory is
> wrong, but can you print out the png_info_struct 'width' value immediately
> before the call to png_get_IHDR that fails.  I.e. in your program something
> like the following two lines:

Alternatively, if your program is open source, you could let us have a look
at it.

In particular, does your program make any direct reference to png_ptr->width ?
It seems to me that if you use png_ptr as an opaque structure, then the
warning would have changed to mention height instead of width.

Glenn

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

Re: libng-1.4.0beta82 is available

by glennrp-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I wrote:
> In particular, does your program make any direct reference to png_ptr->width ?

      I meant info_ptr not png_ptr.  Your program could of course have created
      it with another name.

      Glenn

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

Parent Message unknown Re: libng-1.4.0beta82 is available

by John Bowler-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

From: Arnaud BOEGLIN [mailto:a.boeglin67@...]

>On Sep 29, 2009, at 5:04 PM, John Bowler wrote:
>> in your program [add] something like the following two lines:
>>
>> fprintf(stderr, "width is: %u\n", read_info_ptr->width);  
>> fprintf(stderr, "private width is: %d\n", read_ptr->width);
>> png_get_IHDR(read_ptr, read_info_ptr, &width, &height, &bit_depth,
>> &colortype, ...etc...
>>
>> Then report what the output is.
>
>I get the following output :
>
>width is: 1181
>private width is: 1181
>libpng warning: Image width exceeds user limit in IHDR
>libpng error: Invalid IHDR data

Yurk.  Can you copy me the exact line of the png_get_IHDR call from your
program together with the declarations of the third ("width") and fourth
("height") parameters passed to the call?  It looks like the fourth (height)
parameter is only 16 bits in size and was declared immediately after the
width parameter on a big-endian machine with a descending stack.

If you are running on an x86 MacOS system I have to admit I'm mystified
about what is going on.

John Bowler <jbowler@...>



------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

Re: libng-1.4.0beta82 is available

by Glenn Randers-Pehrson :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

It would be helpful to also print out the values of
png_ptr->user_width_max and png_ptr->user_height_max
(they should both be 1 000 000).

Glenn

On Tue, Sep 29, 2009 at 9:04 PM, John Bowler
<john.cunningham.bowler@...> wrote:

> From: Arnaud BOEGLIN [mailto:a.boeglin67@...]
>>On Sep 29, 2009, at 5:04 PM, John Bowler wrote:
>>> in your program [add] something like the following two lines:
>>>
>>>      fprintf(stderr, "width is: %u\n", read_info_ptr->width);
>>>      fprintf(stderr, "private width is: %d\n", read_ptr->width);
>>>      png_get_IHDR(read_ptr, read_info_ptr, &width, &height, &bit_depth,
>>>                      &colortype,     ...etc...
>>>
>>> Then report what the output is.

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement
< Prev | 1 - 2 | Next >